)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1001036,"name":"Andreas Bolsch","email":"hyphen0break@gmail.com","username":"abmero"},"change_message_id":"fd6f54a3e2574d60e617852b5592e1a29548bba2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7cdc52fe_3f34d735","updated":"2022-12-29 16:08:11.000000000","message":"Apart from the problems with chip erase commands as indicated below, I\u0027m not sure whether these devices are still around. They\u0027re NRND for maybe a decade now? ST has long ago stopped manufacturing flash memories. However, I you still use one of these, adding them might be a good idea.","commit_id":"60b5ea1ac93ef8557aae0ce5405dc9288fb97e22"},{"author":{"_account_id":1001036,"name":"Andreas Bolsch","email":"hyphen0break@gmail.com","username":"abmero"},"change_message_id":"ea5695d792250aaf9c9cbc313d24c0b729ff2d47","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1c6ef71c_f0650d27","updated":"2022-12-29 19:08:52.000000000","message":"Seems to be fine, thanks.","commit_id":"504db9803fd4f8243318e81410fc7e5e95747f8c"},{"author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"change_message_id":"45997f8a6890fee42748f671e81492c53d987fab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d69b1ad8_4446f5fb","updated":"2022-12-29 20:02:53.000000000","message":"thanks for reviewing.","commit_id":"504db9803fd4f8243318e81410fc7e5e95747f8c"},{"author":{"_account_id":1001036,"name":"Andreas Bolsch","email":"hyphen0break@gmail.com","username":"abmero"},"change_message_id":"9ee5d68262f1c4bc76df17d77355414afdbbbcee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"23a622d9_611539e3","updated":"2023-02-15 13:07:12.000000000","message":"Again +1 ...","commit_id":"13594fea0f204837e31fb4f58b4773ef879ab25f"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"c68d64009047f37c4098650fdcca961df9cda37e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"38411bc0_5bdab910","updated":"2023-02-15 13:28:06.000000000","message":"thanks","commit_id":"13594fea0f204837e31fb4f58b4773ef879ab25f"}],"src/flash/nor/spi.c":[{"author":{"_account_id":1001036,"name":"Andreas Bolsch","email":"hyphen0break@gmail.com","username":"abmero"},"change_message_id":"fd6f54a3e2574d60e617852b5592e1a29548bba2","unresolved":true,"context_lines":[{"line_number":24,"context_line":"const struct flash_device flash_devices[] \u003d {"},{"line_number":25,"context_line":"\t/* name, read_cmd, qread_cmd, pprog_cmd, erase_cmd, chip_erase_cmd, device_id,"},{"line_number":26,"context_line":"\t * pagesize, sectorsize, size_in_bytes */"},{"line_number":27,"context_line":"\tFLASH_ID(\"st m25pe10\",          0x03, 0x00, 0x02, 0xd8, 0xdb, 0x00118020, 0x100, 0x10000, 0x20000),"},{"line_number":28,"context_line":"\tFLASH_ID(\"st m25pe20\",          0x03, 0x00, 0x02, 0xd8, 0xdb, 0x00128020, 0x100, 0x10000, 0x40000),"},{"line_number":29,"context_line":"\tFLASH_ID(\"st m25pe40\",          0x03, 0x00, 0x02, 0xd8, 0xdb, 0x00138020, 0x100, 0x10000, 0x80000),"},{"line_number":30,"context_line":"\tFLASH_ID(\"st m25pe80\",          0x03, 0x00, 0x02, 0xd8, 0xdb, 0x00148020, 0x100, 0x10000, 0x100000),"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"a7e32283_9c61f294","line":27,"updated":"2022-12-29 16:08:11.000000000","message":"According to datasheet as of 10/2005, there is no chip erase. 0xdb is page erase (i.e. 256 bytes erased), so 0xdb should be replaced by 0x00 (i.e. \"chip_erase_cmd\" not available).","commit_id":"60b5ea1ac93ef8557aae0ce5405dc9288fb97e22"},{"author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"change_message_id":"54e29539b1e17b17e16df30eca47e03326ebe0b0","unresolved":false,"context_lines":[{"line_number":24,"context_line":"const struct flash_device flash_devices[] \u003d {"},{"line_number":25,"context_line":"\t/* name, read_cmd, qread_cmd, pprog_cmd, erase_cmd, chip_erase_cmd, device_id,"},{"line_number":26,"context_line":"\t * pagesize, sectorsize, size_in_bytes */"},{"line_number":27,"context_line":"\tFLASH_ID(\"st m25pe10\",          0x03, 0x00, 0x02, 0xd8, 0xdb, 0x00118020, 0x100, 0x10000, 0x20000),"},{"line_number":28,"context_line":"\tFLASH_ID(\"st m25pe20\",          0x03, 0x00, 0x02, 0xd8, 0xdb, 0x00128020, 0x100, 0x10000, 0x40000),"},{"line_number":29,"context_line":"\tFLASH_ID(\"st m25pe40\",          0x03, 0x00, 0x02, 0xd8, 0xdb, 0x00138020, 0x100, 0x10000, 0x80000),"},{"line_number":30,"context_line":"\tFLASH_ID(\"st m25pe80\",          0x03, 0x00, 0x02, 0xd8, 0xdb, 0x00148020, 0x100, 0x10000, 0x100000),"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"a5a18b88_5b250d4f","line":27,"in_reply_to":"a7e32283_9c61f294","updated":"2022-12-29 18:56:26.000000000","message":"Done","commit_id":"60b5ea1ac93ef8557aae0ce5405dc9288fb97e22"},{"author":{"_account_id":1001036,"name":"Andreas Bolsch","email":"hyphen0break@gmail.com","username":"abmero"},"change_message_id":"fd6f54a3e2574d60e617852b5592e1a29548bba2","unresolved":true,"context_lines":[{"line_number":25,"context_line":"\t/* name, read_cmd, qread_cmd, pprog_cmd, erase_cmd, chip_erase_cmd, device_id,"},{"line_number":26,"context_line":"\t * pagesize, sectorsize, size_in_bytes */"},{"line_number":27,"context_line":"\tFLASH_ID(\"st m25pe10\",          0x03, 0x00, 0x02, 0xd8, 0xdb, 0x00118020, 0x100, 0x10000, 0x20000),"},{"line_number":28,"context_line":"\tFLASH_ID(\"st m25pe20\",          0x03, 0x00, 0x02, 0xd8, 0xdb, 0x00128020, 0x100, 0x10000, 0x40000),"},{"line_number":29,"context_line":"\tFLASH_ID(\"st m25pe40\",          0x03, 0x00, 0x02, 0xd8, 0xdb, 0x00138020, 0x100, 0x10000, 0x80000),"},{"line_number":30,"context_line":"\tFLASH_ID(\"st m25pe80\",          0x03, 0x00, 0x02, 0xd8, 0xdb, 0x00148020, 0x100, 0x10000, 0x100000),"},{"line_number":31,"context_line":"\tFLASH_ID(\"st m25pe16\",          0x03, 0x00, 0x02, 0xd8, 0xdb, 0x00158020, 0x100, 0x10000, 0x200000),"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"3bc6e22a_f06601a4","line":28,"updated":"2022-12-29 16:08:11.000000000","message":"Same as above.","commit_id":"60b5ea1ac93ef8557aae0ce5405dc9288fb97e22"},{"author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"change_message_id":"54e29539b1e17b17e16df30eca47e03326ebe0b0","unresolved":false,"context_lines":[{"line_number":25,"context_line":"\t/* name, read_cmd, qread_cmd, pprog_cmd, erase_cmd, chip_erase_cmd, device_id,"},{"line_number":26,"context_line":"\t * pagesize, sectorsize, size_in_bytes */"},{"line_number":27,"context_line":"\tFLASH_ID(\"st m25pe10\",          0x03, 0x00, 0x02, 0xd8, 0xdb, 0x00118020, 0x100, 0x10000, 0x20000),"},{"line_number":28,"context_line":"\tFLASH_ID(\"st m25pe20\",          0x03, 0x00, 0x02, 0xd8, 0xdb, 0x00128020, 0x100, 0x10000, 0x40000),"},{"line_number":29,"context_line":"\tFLASH_ID(\"st m25pe40\",          0x03, 0x00, 0x02, 0xd8, 0xdb, 0x00138020, 0x100, 0x10000, 0x80000),"},{"line_number":30,"context_line":"\tFLASH_ID(\"st m25pe80\",          0x03, 0x00, 0x02, 0xd8, 0xdb, 0x00148020, 0x100, 0x10000, 0x100000),"},{"line_number":31,"context_line":"\tFLASH_ID(\"st m25pe16\",          0x03, 0x00, 0x02, 0xd8, 0xdb, 0x00158020, 0x100, 0x10000, 0x200000),"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"83bd416e_f3099de5","line":28,"in_reply_to":"3bc6e22a_f06601a4","updated":"2022-12-29 18:56:26.000000000","message":"Done","commit_id":"60b5ea1ac93ef8557aae0ce5405dc9288fb97e22"},{"author":{"_account_id":1001036,"name":"Andreas Bolsch","email":"hyphen0break@gmail.com","username":"abmero"},"change_message_id":"fd6f54a3e2574d60e617852b5592e1a29548bba2","unresolved":true,"context_lines":[{"line_number":26,"context_line":"\t * pagesize, sectorsize, size_in_bytes */"},{"line_number":27,"context_line":"\tFLASH_ID(\"st m25pe10\",          0x03, 0x00, 0x02, 0xd8, 0xdb, 0x00118020, 0x100, 0x10000, 0x20000),"},{"line_number":28,"context_line":"\tFLASH_ID(\"st m25pe20\",          0x03, 0x00, 0x02, 0xd8, 0xdb, 0x00128020, 0x100, 0x10000, 0x40000),"},{"line_number":29,"context_line":"\tFLASH_ID(\"st m25pe40\",          0x03, 0x00, 0x02, 0xd8, 0xdb, 0x00138020, 0x100, 0x10000, 0x80000),"},{"line_number":30,"context_line":"\tFLASH_ID(\"st m25pe80\",          0x03, 0x00, 0x02, 0xd8, 0xdb, 0x00148020, 0x100, 0x10000, 0x100000),"},{"line_number":31,"context_line":"\tFLASH_ID(\"st m25pe16\",          0x03, 0x00, 0x02, 0xd8, 0xdb, 0x00158020, 0x100, 0x10000, 0x200000),"},{"line_number":32,"context_line":"\tFLASH_ID(\"st m25p05\",           0x03, 0x00, 0x02, 0xd8, 0xc7, 0x00102020, 0x80,  0x8000,  0x10000),"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"a89f31c4_30b65d53","line":29,"updated":"2022-12-29 16:08:11.000000000","message":"Some revisions do have chip erase 0xc7, but others don\u0027t. So it\u0027s better to disable chip_erase_cmd here as well.","commit_id":"60b5ea1ac93ef8557aae0ce5405dc9288fb97e22"},{"author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"change_message_id":"54e29539b1e17b17e16df30eca47e03326ebe0b0","unresolved":false,"context_lines":[{"line_number":26,"context_line":"\t * pagesize, sectorsize, size_in_bytes */"},{"line_number":27,"context_line":"\tFLASH_ID(\"st m25pe10\",          0x03, 0x00, 0x02, 0xd8, 0xdb, 0x00118020, 0x100, 0x10000, 0x20000),"},{"line_number":28,"context_line":"\tFLASH_ID(\"st m25pe20\",          0x03, 0x00, 0x02, 0xd8, 0xdb, 0x00128020, 0x100, 0x10000, 0x40000),"},{"line_number":29,"context_line":"\tFLASH_ID(\"st m25pe40\",          0x03, 0x00, 0x02, 0xd8, 0xdb, 0x00138020, 0x100, 0x10000, 0x80000),"},{"line_number":30,"context_line":"\tFLASH_ID(\"st m25pe80\",          0x03, 0x00, 0x02, 0xd8, 0xdb, 0x00148020, 0x100, 0x10000, 0x100000),"},{"line_number":31,"context_line":"\tFLASH_ID(\"st m25pe16\",          0x03, 0x00, 0x02, 0xd8, 0xdb, 0x00158020, 0x100, 0x10000, 0x200000),"},{"line_number":32,"context_line":"\tFLASH_ID(\"st m25p05\",           0x03, 0x00, 0x02, 0xd8, 0xc7, 0x00102020, 0x80,  0x8000,  0x10000),"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"ad7eb69c_f0553323","line":29,"in_reply_to":"a89f31c4_30b65d53","updated":"2022-12-29 18:56:26.000000000","message":"Done","commit_id":"60b5ea1ac93ef8557aae0ce5405dc9288fb97e22"},{"author":{"_account_id":1001036,"name":"Andreas Bolsch","email":"hyphen0break@gmail.com","username":"abmero"},"change_message_id":"fd6f54a3e2574d60e617852b5592e1a29548bba2","unresolved":true,"context_lines":[{"line_number":27,"context_line":"\tFLASH_ID(\"st m25pe10\",          0x03, 0x00, 0x02, 0xd8, 0xdb, 0x00118020, 0x100, 0x10000, 0x20000),"},{"line_number":28,"context_line":"\tFLASH_ID(\"st m25pe20\",          0x03, 0x00, 0x02, 0xd8, 0xdb, 0x00128020, 0x100, 0x10000, 0x40000),"},{"line_number":29,"context_line":"\tFLASH_ID(\"st m25pe40\",          0x03, 0x00, 0x02, 0xd8, 0xdb, 0x00138020, 0x100, 0x10000, 0x80000),"},{"line_number":30,"context_line":"\tFLASH_ID(\"st m25pe80\",          0x03, 0x00, 0x02, 0xd8, 0xdb, 0x00148020, 0x100, 0x10000, 0x100000),"},{"line_number":31,"context_line":"\tFLASH_ID(\"st m25pe16\",          0x03, 0x00, 0x02, 0xd8, 0xdb, 0x00158020, 0x100, 0x10000, 0x200000),"},{"line_number":32,"context_line":"\tFLASH_ID(\"st m25p05\",           0x03, 0x00, 0x02, 0xd8, 0xc7, 0x00102020, 0x80,  0x8000,  0x10000),"},{"line_number":33,"context_line":"\tFLASH_ID(\"st m25p10\",           0x03, 0x00, 0x02, 0xd8, 0xc7, 0x00112020, 0x80,  0x8000,  0x20000),"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"f38a1986_dc45bbf0","line":30,"updated":"2022-12-29 16:08:11.000000000","message":"This one does have chip erase, but that\u0027s 0xc7, not 0xdb.","commit_id":"60b5ea1ac93ef8557aae0ce5405dc9288fb97e22"},{"author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"change_message_id":"54e29539b1e17b17e16df30eca47e03326ebe0b0","unresolved":false,"context_lines":[{"line_number":27,"context_line":"\tFLASH_ID(\"st m25pe10\",          0x03, 0x00, 0x02, 0xd8, 0xdb, 0x00118020, 0x100, 0x10000, 0x20000),"},{"line_number":28,"context_line":"\tFLASH_ID(\"st m25pe20\",          0x03, 0x00, 0x02, 0xd8, 0xdb, 0x00128020, 0x100, 0x10000, 0x40000),"},{"line_number":29,"context_line":"\tFLASH_ID(\"st m25pe40\",          0x03, 0x00, 0x02, 0xd8, 0xdb, 0x00138020, 0x100, 0x10000, 0x80000),"},{"line_number":30,"context_line":"\tFLASH_ID(\"st m25pe80\",          0x03, 0x00, 0x02, 0xd8, 0xdb, 0x00148020, 0x100, 0x10000, 0x100000),"},{"line_number":31,"context_line":"\tFLASH_ID(\"st m25pe16\",          0x03, 0x00, 0x02, 0xd8, 0xdb, 0x00158020, 0x100, 0x10000, 0x200000),"},{"line_number":32,"context_line":"\tFLASH_ID(\"st m25p05\",           0x03, 0x00, 0x02, 0xd8, 0xc7, 0x00102020, 0x80,  0x8000,  0x10000),"},{"line_number":33,"context_line":"\tFLASH_ID(\"st m25p10\",           0x03, 0x00, 0x02, 0xd8, 0xc7, 0x00112020, 0x80,  0x8000,  0x20000),"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"ab14820a_4bdff976","line":30,"in_reply_to":"f38a1986_dc45bbf0","updated":"2022-12-29 18:56:26.000000000","message":"Done","commit_id":"60b5ea1ac93ef8557aae0ce5405dc9288fb97e22"},{"author":{"_account_id":1001036,"name":"Andreas Bolsch","email":"hyphen0break@gmail.com","username":"abmero"},"change_message_id":"fd6f54a3e2574d60e617852b5592e1a29548bba2","unresolved":true,"context_lines":[{"line_number":28,"context_line":"\tFLASH_ID(\"st m25pe20\",          0x03, 0x00, 0x02, 0xd8, 0xdb, 0x00128020, 0x100, 0x10000, 0x40000),"},{"line_number":29,"context_line":"\tFLASH_ID(\"st m25pe40\",          0x03, 0x00, 0x02, 0xd8, 0xdb, 0x00138020, 0x100, 0x10000, 0x80000),"},{"line_number":30,"context_line":"\tFLASH_ID(\"st m25pe80\",          0x03, 0x00, 0x02, 0xd8, 0xdb, 0x00148020, 0x100, 0x10000, 0x100000),"},{"line_number":31,"context_line":"\tFLASH_ID(\"st m25pe16\",          0x03, 0x00, 0x02, 0xd8, 0xdb, 0x00158020, 0x100, 0x10000, 0x200000),"},{"line_number":32,"context_line":"\tFLASH_ID(\"st m25p05\",           0x03, 0x00, 0x02, 0xd8, 0xc7, 0x00102020, 0x80,  0x8000,  0x10000),"},{"line_number":33,"context_line":"\tFLASH_ID(\"st m25p10\",           0x03, 0x00, 0x02, 0xd8, 0xc7, 0x00112020, 0x80,  0x8000,  0x20000),"},{"line_number":34,"context_line":"\tFLASH_ID(\"st m25p20\",           0x03, 0x00, 0x02, 0xd8, 0xc7, 0x00122020, 0x100, 0x10000, 0x40000),"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"b8b9d76d_5c3394da","line":31,"updated":"2022-12-29 16:08:11.000000000","message":"As above, chip erase is 0xc7, not 0xdb.","commit_id":"60b5ea1ac93ef8557aae0ce5405dc9288fb97e22"},{"author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"change_message_id":"54e29539b1e17b17e16df30eca47e03326ebe0b0","unresolved":false,"context_lines":[{"line_number":28,"context_line":"\tFLASH_ID(\"st m25pe20\",          0x03, 0x00, 0x02, 0xd8, 0xdb, 0x00128020, 0x100, 0x10000, 0x40000),"},{"line_number":29,"context_line":"\tFLASH_ID(\"st m25pe40\",          0x03, 0x00, 0x02, 0xd8, 0xdb, 0x00138020, 0x100, 0x10000, 0x80000),"},{"line_number":30,"context_line":"\tFLASH_ID(\"st m25pe80\",          0x03, 0x00, 0x02, 0xd8, 0xdb, 0x00148020, 0x100, 0x10000, 0x100000),"},{"line_number":31,"context_line":"\tFLASH_ID(\"st m25pe16\",          0x03, 0x00, 0x02, 0xd8, 0xdb, 0x00158020, 0x100, 0x10000, 0x200000),"},{"line_number":32,"context_line":"\tFLASH_ID(\"st m25p05\",           0x03, 0x00, 0x02, 0xd8, 0xc7, 0x00102020, 0x80,  0x8000,  0x10000),"},{"line_number":33,"context_line":"\tFLASH_ID(\"st m25p10\",           0x03, 0x00, 0x02, 0xd8, 0xc7, 0x00112020, 0x80,  0x8000,  0x20000),"},{"line_number":34,"context_line":"\tFLASH_ID(\"st m25p20\",           0x03, 0x00, 0x02, 0xd8, 0xc7, 0x00122020, 0x100, 0x10000, 0x40000),"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"208d3510_e092bb03","line":31,"in_reply_to":"b8b9d76d_5c3394da","updated":"2022-12-29 18:56:26.000000000","message":"Done","commit_id":"60b5ea1ac93ef8557aae0ce5405dc9288fb97e22"}]}