)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"7513a44106926eba70decf6d9747335727398c07","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"60aa955d_1b63ca70","updated":"2022-12-24 16:38:26.000000000","message":"The devices \"NUC123SD4AN\" and \"NUC123SD4AE\" share the same ID 0x10012315 and all other values are the same.\nAdding a new line in the table is not useful.\nMaybe changing the string with \"NUC123SD4Ax\" ?","commit_id":"105f51a9031e04a57781244c25f436b6dc6ccc32"}],"src/flash/nor/numicro.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"7513a44106926eba70decf6d9747335727398c07","unresolved":true,"context_lines":[{"line_number":1019,"context_line":"\t/* NUC103/NUC105/NUC123 */"},{"line_number":1020,"context_line":"\t{\"NUC123SC2AN\" , 0x00012305, NUMICRO_BANKS_NUC100(36*1024)},"},{"line_number":1021,"context_line":"\t{\"NUC123SD4AN\" , 0x00012315, NUMICRO_BANKS_NUC100(68*1024)},"},{"line_number":1022,"context_line":"\t{\"NUC123SD4AE\", 0x10012315, NUMICRO_BANKS_NUC100(68 * 1024)},"},{"line_number":1023,"context_line":"\t{\"NUC123LC2AN\" , 0x00012325, NUMICRO_BANKS_NUC100(36*1024)},"},{"line_number":1024,"context_line":"\t{\"NUC103LC2AN\" , 0x00010325, NUMICRO_BANKS_NUC100(36*1024)},"},{"line_number":1025,"context_line":"\t{\"NUC105LC2AN\" , 0x00010525, NUMICRO_BANKS_NUC100(36*1024)},"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"d603cf24_75f16cf2","line":1022,"updated":"2022-12-24 16:38:26.000000000","message":"the same partid 0x10012315 is already present in the line above.\nLet\u0027s continue below...","commit_id":"105f51a9031e04a57781244c25f436b6dc6ccc32"},{"author":{"_account_id":1002104,"name":"Giuseppe Iannello","email":"giuseppe.iannello@brokenloop.net","username":"giannello"},"change_message_id":"7da403c2b766d7683346eaf40844234c16630682","unresolved":false,"context_lines":[{"line_number":1019,"context_line":"\t/* NUC103/NUC105/NUC123 */"},{"line_number":1020,"context_line":"\t{\"NUC123SC2AN\" , 0x00012305, NUMICRO_BANKS_NUC100(36*1024)},"},{"line_number":1021,"context_line":"\t{\"NUC123SD4AN\" , 0x00012315, NUMICRO_BANKS_NUC100(68*1024)},"},{"line_number":1022,"context_line":"\t{\"NUC123SD4AE\", 0x10012315, NUMICRO_BANKS_NUC100(68 * 1024)},"},{"line_number":1023,"context_line":"\t{\"NUC123LC2AN\" , 0x00012325, NUMICRO_BANKS_NUC100(36*1024)},"},{"line_number":1024,"context_line":"\t{\"NUC103LC2AN\" , 0x00010325, NUMICRO_BANKS_NUC100(36*1024)},"},{"line_number":1025,"context_line":"\t{\"NUC105LC2AN\" , 0x00010525, NUMICRO_BANKS_NUC100(36*1024)},"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"24200a90_deeebded","line":1022,"in_reply_to":"1321d26a_a0ca955e","updated":"2022-12-29 01:38:07.000000000","message":"As long as the change is implemented, I won\u0027t mind if my patches are dropped in favor of #7339. Feel free.","commit_id":"105f51a9031e04a57781244c25f436b6dc6ccc32"},{"author":{"_account_id":1002104,"name":"Giuseppe Iannello","email":"giuseppe.iannello@brokenloop.net","username":"giannello"},"change_message_id":"fd686f4324fab2d6228f45c5a512b6c901d6339c","unresolved":false,"context_lines":[{"line_number":1019,"context_line":"\t/* NUC103/NUC105/NUC123 */"},{"line_number":1020,"context_line":"\t{\"NUC123SC2AN\" , 0x00012305, NUMICRO_BANKS_NUC100(36*1024)},"},{"line_number":1021,"context_line":"\t{\"NUC123SD4AN\" , 0x00012315, NUMICRO_BANKS_NUC100(68*1024)},"},{"line_number":1022,"context_line":"\t{\"NUC123SD4AE\", 0x10012315, NUMICRO_BANKS_NUC100(68 * 1024)},"},{"line_number":1023,"context_line":"\t{\"NUC123LC2AN\" , 0x00012325, NUMICRO_BANKS_NUC100(36*1024)},"},{"line_number":1024,"context_line":"\t{\"NUC103LC2AN\" , 0x00010325, NUMICRO_BANKS_NUC100(36*1024)},"},{"line_number":1025,"context_line":"\t{\"NUC105LC2AN\" , 0x00010525, NUMICRO_BANKS_NUC100(36*1024)},"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"6d071cf6_7ffb488e","line":1022,"in_reply_to":"5728fa6c_0b568a86","updated":"2022-12-27 14:54:27.000000000","message":"Jian-Hong is correct, the two parts have a different ID (even if they\u0027re effectively the same chip, just rated for different temperature ranges)","commit_id":"105f51a9031e04a57781244c25f436b6dc6ccc32"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"34b9326805621c904e3c8cda29503a4b1d1aa5df","unresolved":false,"context_lines":[{"line_number":1019,"context_line":"\t/* NUC103/NUC105/NUC123 */"},{"line_number":1020,"context_line":"\t{\"NUC123SC2AN\" , 0x00012305, NUMICRO_BANKS_NUC100(36*1024)},"},{"line_number":1021,"context_line":"\t{\"NUC123SD4AN\" , 0x00012315, NUMICRO_BANKS_NUC100(68*1024)},"},{"line_number":1022,"context_line":"\t{\"NUC123SD4AE\", 0x10012315, NUMICRO_BANKS_NUC100(68 * 1024)},"},{"line_number":1023,"context_line":"\t{\"NUC123LC2AN\" , 0x00012325, NUMICRO_BANKS_NUC100(36*1024)},"},{"line_number":1024,"context_line":"\t{\"NUC103LC2AN\" , 0x00010325, NUMICRO_BANKS_NUC100(36*1024)},"},{"line_number":1025,"context_line":"\t{\"NUC105LC2AN\" , 0x00010525, NUMICRO_BANKS_NUC100(36*1024)},"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"1321d26a_a0ca955e","line":1022,"in_reply_to":"6d071cf6_7ffb488e","updated":"2022-12-27 15:12:08.000000000","message":"Yes, Jian-Hong is right. I need to take better glasses!\nWhat about https://review.openocd.org/c/openocd/+/7339 ?\nI think that both patches from you are already covered by 7339. Should both be abandoned?","commit_id":"105f51a9031e04a57781244c25f436b6dc6ccc32"},{"author":{"_account_id":1001899,"name":"Jian-Hong Pan","email":"chienhung.pan@gmail.com","username":"starnight"},"change_message_id":"321c2e4c9bff45dc5021b06a2a63260a8494f250","unresolved":true,"context_lines":[{"line_number":1019,"context_line":"\t/* NUC103/NUC105/NUC123 */"},{"line_number":1020,"context_line":"\t{\"NUC123SC2AN\" , 0x00012305, NUMICRO_BANKS_NUC100(36*1024)},"},{"line_number":1021,"context_line":"\t{\"NUC123SD4AN\" , 0x00012315, NUMICRO_BANKS_NUC100(68*1024)},"},{"line_number":1022,"context_line":"\t{\"NUC123SD4AE\", 0x10012315, NUMICRO_BANKS_NUC100(68 * 1024)},"},{"line_number":1023,"context_line":"\t{\"NUC123LC2AN\" , 0x00012325, NUMICRO_BANKS_NUC100(36*1024)},"},{"line_number":1024,"context_line":"\t{\"NUC103LC2AN\" , 0x00010325, NUMICRO_BANKS_NUC100(36*1024)},"},{"line_number":1025,"context_line":"\t{\"NUC105LC2AN\" , 0x00010525, NUMICRO_BANKS_NUC100(36*1024)},"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"5728fa6c_0b568a86","line":1022,"in_reply_to":"d603cf24_75f16cf2","updated":"2022-12-25 10:30:01.000000000","message":"I think 0x10012315 is different from 0x00012315.\n\nHowever, this is already included in the request \"flash/nor/numicro: reorder the parts list\" https://review.openocd.org/c/openocd/+/7339","commit_id":"105f51a9031e04a57781244c25f436b6dc6ccc32"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"7513a44106926eba70decf6d9747335727398c07","unresolved":true,"context_lines":[{"line_number":1630,"context_line":"\tLOG_INFO(\"Device ID: 0x%08\" PRIx32 \"\", part_id);"},{"line_number":1631,"context_line":"\t/* search part numbers */"},{"line_number":1632,"context_line":"\tfor (size_t i \u003d 0; i \u003c ARRAY_SIZE(numicro_parts); i++) {"},{"line_number":1633,"context_line":"\t\tif (part_id \u003d\u003d numicro_parts[i].partid) {"},{"line_number":1634,"context_line":"\t\t\t*cpu \u003d \u0026numicro_parts[i];"},{"line_number":1635,"context_line":"\t\t\tLOG_INFO(\"Device Name: %s\", (*cpu)-\u003epartname);"},{"line_number":1636,"context_line":"\t\t\treturn ERROR_OK;"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"b59b6df3_89b0f7cb","line":1633,"updated":"2022-12-24 16:38:26.000000000","message":"the field partid is checked here and the loop is terminated at the first match.\nFor partid 0x10012315 it will end at the existing line, so it will never check the line added by this patch.","commit_id":"105f51a9031e04a57781244c25f436b6dc6ccc32"},{"author":{"_account_id":1002104,"name":"Giuseppe Iannello","email":"giuseppe.iannello@brokenloop.net","username":"giannello"},"change_message_id":"fd686f4324fab2d6228f45c5a512b6c901d6339c","unresolved":false,"context_lines":[{"line_number":1630,"context_line":"\tLOG_INFO(\"Device ID: 0x%08\" PRIx32 \"\", part_id);"},{"line_number":1631,"context_line":"\t/* search part numbers */"},{"line_number":1632,"context_line":"\tfor (size_t i \u003d 0; i \u003c ARRAY_SIZE(numicro_parts); i++) {"},{"line_number":1633,"context_line":"\t\tif (part_id \u003d\u003d numicro_parts[i].partid) {"},{"line_number":1634,"context_line":"\t\t\t*cpu \u003d \u0026numicro_parts[i];"},{"line_number":1635,"context_line":"\t\t\tLOG_INFO(\"Device Name: %s\", (*cpu)-\u003epartname);"},{"line_number":1636,"context_line":"\t\t\treturn ERROR_OK;"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"46d3eb71_4f7c1c2b","line":1633,"in_reply_to":"b59b6df3_89b0f7cb","updated":"2022-12-27 14:54:27.000000000","message":"I assume this is related to the previous comment. Not relevant, when there\u0027s no duplicated IDs in the list.","commit_id":"105f51a9031e04a57781244c25f436b6dc6ccc32"}]}