)]}'
{"id":"openocd~master~I9293e884bf3e9606d529756ae4483b844d3c39db","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000005":{"account":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"last_update":"2023-06-10 17:11:46.000000000","reason":"Change was submitted"},"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2023-06-04 16:57:17.000000000","reason":"\u003cGERRIT_ACCOUNT_1000021\u003e replied on the change","reason_account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}},"1002106":{"account":{"_account_id":1002106,"name":"Lorenz Brun","email":"lorenz@brun.one","username":"lorenz"},"last_update":"2023-06-10 17:11:46.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I9293e884bf3e9606d529756ae4483b844d3c39db","subject":"target/ti-cjtag: make switching to JTAG more reliable","status":"MERGED","created":"2022-12-26 21:10:49.000000000","updated":"2023-06-10 17:11:46.000000000","submitted":"2023-06-10 17:11:46.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":7,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7419","meta_rev_id":"b1128c0943b805173ecc2f3429e017d7809c4bf2","_number":7419,"owner":{"_account_id":1002106,"name":"Lorenz Brun","email":"lorenz@brun.one","username":"lorenz"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-06-10 17:11:46.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"value":0,"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-06-10 17:11:46.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-12-26 21:57:21.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-05-31 17:46:08.000000000","updated_by":{"_account_id":1002106,"name":"Lorenz Brun","email":"lorenz@brun.one","username":"lorenz"},"reviewer":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"state":"REVIEWER"},{"updated":"2023-06-03 12:41:43.000000000","updated_by":{"_account_id":1002106,"name":"Lorenz Brun","email":"lorenz@brun.one","username":"lorenz"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"67ff73159db2e681c168c348de7e5139d58a4d66","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002106,"name":"Lorenz Brun","email":"lorenz@brun.one","username":"lorenz"},"real_author":{"_account_id":1002106,"name":"Lorenz Brun","email":"lorenz@brun.one","username":"lorenz"},"date":"2022-12-26 21:10:49.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"782de39a08ad54b14386ee9b24df961e170317bb","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-12-26 21:57:21.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/17259/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/16461/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"f780ac8ae9be65e23394af93e5d5fd65f34797d4","author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"real_author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"date":"2023-06-04 11:28:49.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"bb0007f481e6bc4f26231b9ba2b4f34741e8171c","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-06-04 12:30:22.000000000","message":"Patch Set 1:\n\n(3 comments)","accounts_in_message":[],"_revision_number":1},{"id":"4a9af806d5d7eebf9b41e4c436dfe34afe4d611e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002106,"name":"Lorenz Brun","email":"lorenz@brun.one","username":"lorenz"},"real_author":{"_account_id":1002106,"name":"Lorenz Brun","email":"lorenz@brun.one","username":"lorenz"},"date":"2023-06-04 14:11:52.000000000","message":"Uploaded patch set 2: Commit message was updated.\n\nOutdated Votes:\n* Code-Review+1 (copy condition: \"changekind:NO_CHANGE OR is:MIN\")\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"b00cf048418939cf18eb03d26bd01b6b30f7888f","author":{"_account_id":1002106,"name":"Lorenz Brun","email":"lorenz@brun.one","username":"lorenz"},"real_author":{"_account_id":1002106,"name":"Lorenz Brun","email":"lorenz@brun.one","username":"lorenz"},"date":"2023-06-04 14:14:05.000000000","message":"Patch Set 2:\n\n(3 comments)","accounts_in_message":[],"_revision_number":2},{"id":"540b64585a106f4f218bc30f47f21470ac2da722","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-06-04 14:28:46.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/17772/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/16974/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"ef5fffbf5c5fa9d6aa29460f6fe4701afa29779d","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-06-04 16:57:17.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"06b70f502499aa9b8af98a360f1ddb59b74ef7d1","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-06-10 17:11:37.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"b1128c0943b805173ecc2f3429e017d7809c4bf2","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-06-10 17:11:46.000000000","message":"Change has been successfully cherry-picked as 63f4e7c72a27fb828fe1be3003be6a94519e1c12","accounts_in_message":[],"_revision_number":3}],"current_revision":"63f4e7c72a27fb828fe1be3003be6a94519e1c12","revisions":{"de4fe8e7d552e7b52091807a857b060cb0642ae9":{"kind":"REWORK","_number":1,"created":"2022-12-26 21:10:49.000000000","uploader":{"_account_id":1002106,"name":"Lorenz Brun","email":"lorenz@brun.one","username":"lorenz"},"ref":"refs/changes/19/7419/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/19/7419/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/19/7419/1 \u0026\u0026 git checkout -b change-7419 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/19/7419/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/19/7419/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/19/7419/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/19/7419/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/19/7419/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"dfe57baa16cdbc0dc2ae7182b5b3831028637223","subject":"Restore +dev suffix"}],"author":{"name":"Lorenz Brun","email":"lorenz@brun.one","date":"2022-12-24 02:56:22.000000000","tz":60},"committer":{"name":"Lorenz Brun","email":"lorenz@brun.one","date":"2022-12-26 21:10:16.000000000","tz":60},"subject":"target/ti-cjtag: make switching to JTAG more reliable","message":"target/ti-cjtag: make switching to JTAG more reliable\n\nThe current cJTAG to JTAG switching commands for TI chips are not\nparticularly reliable, especially on chips with accurate timing.\nOn a Raspberry Pi the existing sequence has (depending on cabling and\nchip) a ~50% chance of working, on a much better-behaved FT2232H\nit doesn\u0027t manage to enable full JTAG at all.\n\nThis change runs a bunch of test-idle cycles before actually attempting\nto switch to full JTAG. This makes the switch reliable even at high\nclock speeds (\u003e100kHz) and from precise sources like the FT2232H.\n\nThanks to Phil Wiggum in the issue tracker for the suggestion!\n\nChange-Id: I9293e884bf3e9606d529756ae4483b844d3c39db\nBug: 374\nSigned-off-by: Lorenz Brun \u003clorenz@brun.one\u003e\n"}},"b77d78e89fac36a1f9a24eaeb5d6b58844e14f51":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2023-06-04 14:11:52.000000000","uploader":{"_account_id":1002106,"name":"Lorenz Brun","email":"lorenz@brun.one","username":"lorenz"},"ref":"refs/changes/19/7419/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/19/7419/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/19/7419/2 \u0026\u0026 git checkout -b change-7419 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/19/7419/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/19/7419/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/19/7419/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/19/7419/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/19/7419/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"dfe57baa16cdbc0dc2ae7182b5b3831028637223","subject":"Restore +dev suffix"}],"author":{"name":"Lorenz Brun","email":"lorenz@brun.one","date":"2022-12-24 02:56:22.000000000","tz":60},"committer":{"name":"Lorenz Brun","email":"lorenz@brun.one","date":"2023-06-04 14:10:09.000000000","tz":120},"subject":"target/ti-cjtag: make switching to JTAG more reliable","message":"target/ti-cjtag: make switching to JTAG more reliable\n\nThe current cJTAG to JTAG switching commands for TI chips are not\nparticularly reliable, especially on chips with accurate timing.\nOn a Raspberry Pi the existing sequence has (depending on cabling and\nchip) a ~50% chance of working, on a much better-behaved FT2232H\nit doesn\u0027t manage to enable full JTAG at all.\n\nThis change runs a bunch of test-idle cycles before actually attempting\nto switch to full JTAG. This makes the switch reliable even at high\nclock speeds (\u003e100kHz) and from precise sources like the FT2232H.\n\nChange-Id: I9293e884bf3e9606d529756ae4483b844d3c39db\nReported-by: Phil Wiggum \u003cp1mail2015@mail.com\u003e\nFixes: https://sourceforge.net/p/openocd/tickets/375/\nSigned-off-by: Lorenz Brun \u003clorenz@brun.one\u003e\n"}},"63f4e7c72a27fb828fe1be3003be6a94519e1c12":{"kind":"REWORK","_number":3,"created":"2023-06-10 17:11:46.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/19/7419/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/19/7419/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/19/7419/3 \u0026\u0026 git checkout -b change-7419 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/19/7419/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/19/7419/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/19/7419/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/19/7419/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/19/7419/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d8c9f66d25cde09570e4f87e354216470b72de7e","subject":"jep106: update to revision JEP106BG May 2023"}],"author":{"name":"Lorenz Brun","email":"lorenz@brun.one","date":"2022-12-24 02:56:22.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-06-10 17:11:46.000000000","tz":0},"subject":"target/ti-cjtag: make switching to JTAG more reliable","message":"target/ti-cjtag: make switching to JTAG more reliable\n\nThe current cJTAG to JTAG switching commands for TI chips are not\nparticularly reliable, especially on chips with accurate timing.\nOn a Raspberry Pi the existing sequence has (depending on cabling and\nchip) a ~50% chance of working, on a much better-behaved FT2232H\nit doesn\u0027t manage to enable full JTAG at all.\n\nThis change runs a bunch of test-idle cycles before actually attempting\nto switch to full JTAG. This makes the switch reliable even at high\nclock speeds (\u003e100kHz) and from precise sources like the FT2232H.\n\nChange-Id: I9293e884bf3e9606d529756ae4483b844d3c39db\nReported-by: Phil Wiggum \u003cp1mail2015@mail.com\u003e\nFixes: https://sourceforge.net/p/openocd/tickets/375/\nSigned-off-by: Lorenz Brun \u003clorenz@brun.one\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7419\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}