)]}'
{"id":"openocd~master~I273448cf1f1484b10f6b6113ed7bb0fcf946482b","project":"openocd","branch":"master","topic":"after 0.12 release","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2023-02-20 09:59:37.000000000","reason":"Antonio Borneo replied on the change"},"1001674":{"account":{"_account_id":1001674,"name":"Evgeniy Didin","email":"didin@synopsys.com","username":"EvgeniiDidin"},"last_update":"2023-01-30 10:20:38.000000000","reason":"Evgeniy Didin replied on the change"}},"hashtags":[],"change_id":"I273448cf1f1484b10f6b6113ed7bb0fcf946482b","subject":"helper: nvp: add openocd nvp files","status":"MERGED","created":"2022-12-30 18:44:43.000000000","updated":"2023-02-20 17:18:53.000000000","submitted":"2023-02-03 22:47:40.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":5,"unresolved_comment_count":2,"has_review_started":true,"submission_id":"7423-after 0.12 release","meta_rev_id":"9b9a2a37bbe659a34b395150e04330d97e8e7efd","_number":7423,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1001674,"name":"Evgeniy Didin","email":"didin@synopsys.com","username":"EvgeniiDidin"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-02-03 22:47:40.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-02-03 22:47:40.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-02-03 22:47:40.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1001674,"name":"Evgeniy Didin","email":"didin@synopsys.com","username":"EvgeniiDidin"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}],"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1001674,"name":"Evgeniy Didin","email":"didin@synopsys.com","username":"EvgeniiDidin"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-12-30 18:44:43.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1001674,"name":"Evgeniy Didin","email":"didin@synopsys.com","username":"EvgeniiDidin"},"state":"REVIEWER"},{"updated":"2022-12-30 19:09:23.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-02-19 11:49:33.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"CC"}],"messages":[{"id":"e4302a977172b27eb414c30425b5b75ed56476bc","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-12-30 18:44:43.000000000","message":"Uploaded patch set 1: Code-Review+1.","accounts_in_message":[],"_revision_number":1},{"id":"efbe47be350de9d38417c71d8cc28840a3fe90f6","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-12-30 19:09:23.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit/17270/ : FAILURE\n\nhttps://build.openocd.org/job/openocd-gerrit-build/16471/ : FAILURE","accounts_in_message":[],"_revision_number":1},{"id":"4ddcf9a2d6ff4c8cb2ee2e15543e43bae622410d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-12-30 21:18:24.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"faf9d89870a526d786e251ebc466de75ee1114d1","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-12-30 22:04:05.000000000","message":"Topic set to after 0.12 release","accounts_in_message":[],"_revision_number":2},{"id":"0ae4da14a90a95e22bc93a32aeedc42aeb3864a7","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-12-30 22:04:17.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"03df19b9227bc9062f8198cd8c62f6c86d75a8fd","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-12-30 22:53:10.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/17273/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/16475/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"7d8cb9d52564fd2bb51ac720b4d867515e8bca44","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-01-01 17:00:22.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"6da0cd4bd4927c5430160a9fe0866b2b7c7fdea7","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-01-01 17:47:59.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/17276/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/16478/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"1fd380b4779a95a36359f5b68f13de2148b945d1","author":{"_account_id":1001674,"name":"Evgeniy Didin","email":"didin@synopsys.com","username":"EvgeniiDidin"},"real_author":{"_account_id":1001674,"name":"Evgeniy Didin","email":"didin@synopsys.com","username":"EvgeniiDidin"},"date":"2023-01-30 10:20:38.000000000","message":"Patch Set 3: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"f7f280de276cc25814632ee5a33be5d60cb925e9","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-02-03 22:47:37.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"51a47f73c7ec9275977c6bc41695031733abc12d","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-02-03 22:47:40.000000000","message":"Change has been successfully cherry-picked as ea6a99208e1bc41a878234f7220501e26ec4a7f1","accounts_in_message":[],"_revision_number":4},{"id":"e0ec12fc3da76d7a78f0186c4dd844185543b8a9","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-02-19 11:49:33.000000000","message":"Patch Set 4:\n\n(2 comments)","accounts_in_message":[],"_revision_number":4},{"id":"599e2da8aff876749bdcf6a03cf00ba2795b3fce","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-02-20 09:59:37.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"9b9a2a37bbe659a34b395150e04330d97e8e7efd","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-02-20 17:18:53.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4}],"current_revision":"ea6a99208e1bc41a878234f7220501e26ec4a7f1","revisions":{"ea6a99208e1bc41a878234f7220501e26ec4a7f1":{"kind":"REWORK","_number":4,"created":"2023-02-03 22:47:40.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/23/7423/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/23/7423/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/23/7423/4 \u0026\u0026 git checkout -b change-7423 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/23/7423/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/23/7423/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/23/7423/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/23/7423/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/23/7423/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"18bafdce615132311fd34f2e1bdf57c193d14097","subject":"target: arc: fix error handling in command \u0027arc set-reg-exists\u0027"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-12-26 20:59:56.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-02-03 22:47:40.000000000","tz":0},"subject":"helper: nvp: add openocd nvp files","message":"helper: nvp: add openocd nvp files\n\nLong ago jim_nvp was part of jimtcl. When jimtcl dropped it,\nOpenOCD kept copy of it in its code base. Current code of jim_nvp\nis still related with jimtcl data types and functions.\n\nWith the target of better isolating OpenOCD code from jimtcl,\ncreate a new file nvp.c that re-proposes only the core of the old\njim_nvp, dropping any link with jimtcl and removing the string\n\u0027jim\u0027 either from the filename and from the code.\nKeep the same license from the old code, as the new files are\nclearly derived from it.\n\nChange-Id: I273448cf1f1484b10f6b6113ed7bb0fcf946482b\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7423\nTested-by: jenkins\nReviewed-by: Evgeniy Didin \u003cdidin@synopsys.com\u003e\n"}},"162ca6b6e48c02e023e29a2281e6728927c70ab6":{"kind":"REWORK","_number":3,"created":"2023-01-01 17:00:22.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/23/7423/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/23/7423/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/23/7423/3 \u0026\u0026 git checkout -b change-7423 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/23/7423/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/23/7423/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/23/7423/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/23/7423/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/23/7423/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"68c85ffd379131e1c93e09d9b208e5127da2d7f8","subject":"target: arc: fix error handling in command \u0027arc set-reg-exists\u0027"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-12-26 20:59:56.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-12-31 22:47:56.000000000","tz":60},"subject":"helper: nvp: add openocd nvp files","message":"helper: nvp: add openocd nvp files\n\nLong ago jim_nvp was part of jimtcl. When jimtcl dropped it,\nOpenOCD kept copy of it in its code base. Current code of jim_nvp\nis still related with jimtcl data types and functions.\n\nWith the target of better isolating OpenOCD code from jimtcl,\ncreate a new file nvp.c that re-proposes only the core of the old\njim_nvp, dropping any link with jimtcl and removing the string\n\u0027jim\u0027 either from the filename and from the code.\nKeep the same license from the old code, as the new files are\nclearly derived from it.\n\nChange-Id: I273448cf1f1484b10f6b6113ed7bb0fcf946482b\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"9b59327bb28f55345bb120433f3401003be25606":{"kind":"REWORK","_number":2,"created":"2022-12-30 21:18:24.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/23/7423/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/23/7423/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/23/7423/2 \u0026\u0026 git checkout -b change-7423 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/23/7423/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/23/7423/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/23/7423/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/23/7423/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/23/7423/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"68c85ffd379131e1c93e09d9b208e5127da2d7f8","subject":"target: arc: fix error handling in command \u0027arc set-reg-exists\u0027"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-12-26 20:59:56.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-12-30 21:08:13.000000000","tz":60},"subject":"helper: nvp: add openocd nvp files","message":"helper: nvp: add openocd nvp files\n\nLong ago jim_nvp was part of jimtcl. When jimtcl dropped it,\nOpenOCD kept copy of it in its code base. Current code of jim_nvp\nis still related with jimtcl data types and functions.\n\nWith the target of better isolating OpenOCD code from jimtcl,\ncreate a new file nvp.c that re-proposes only the core of the old\njim_nvp, dropping any link with jimtcl and removing the string\n\u0027jim\u0027 either from the filename and from the code.\nKeep the same license from the old code, as the new files are\nclearly derived from it.\n\nChange-Id: I273448cf1f1484b10f6b6113ed7bb0fcf946482b\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"36d1604454cde6da0a4bf7b939db586a02e1d6b5":{"kind":"REWORK","_number":1,"created":"2022-12-30 18:44:43.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/23/7423/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/23/7423/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/23/7423/1 \u0026\u0026 git checkout -b change-7423 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/23/7423/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/23/7423/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/23/7423/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/23/7423/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/23/7423/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"68c85ffd379131e1c93e09d9b208e5127da2d7f8","subject":"target: arc: fix error handling in command \u0027arc set-reg-exists\u0027"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-12-26 20:59:56.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-12-30 18:38:52.000000000","tz":60},"subject":"helper: nvp: add openocd nvp files","message":"helper: nvp: add openocd nvp files\n\nLong ago jim_nvp was part of jimtcl. When jimtcl dropped it,\nOpenOCD kept copy of it in its code base. Current code of jim_nvp\nis still related with jimtcl data types and functions.\n\nWith the target of better isolating OpenOCD code from jimtcl,\ncreate a new file nvp.c that re-proposes only the core of the old\njim_nvp, dropping any link with jimtcl and removing the string\n\u0027jim\u0027 either from the filename and from the code.\nKeep the same license from the old code, as the new files are\nclearly derived from it.\n\nChange-Id: I273448cf1f1484b10f6b6113ed7bb0fcf946482b\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}