)]}'
{"id":"openocd~master~Ide4cbc829871a6a523026ccc0d3100dadc2afd06","project":"openocd","branch":"master","topic":"after 0.12 release","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2023-02-03 22:48:13.000000000","reason":"removed on reply"},"1001674":{"account":{"_account_id":1001674,"name":"Evgeniy Didin","email":"didin@synopsys.com","username":"EvgeniiDidin"},"last_update":"2023-01-30 10:47:40.000000000","reason":"Evgeniy Didin replied on the change"}},"hashtags":[],"change_id":"Ide4cbc829871a6a523026ccc0d3100dadc2afd06","subject":"target: arc: rewrite command \u0027arc add-reg-type-flags\u0027 as COMMAND_HANDLER","status":"MERGED","created":"2022-12-30 18:44:43.000000000","updated":"2023-02-03 22:48:15.000000000","submitted":"2023-02-03 22:48:15.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7424-after 0.12 release","meta_rev_id":"8ded9774d741d2bc07446ec69f4b2c8745000ee2","_number":7424,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1001674,"name":"Evgeniy Didin","email":"didin@synopsys.com","username":"EvgeniiDidin"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-02-03 22:48:15.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-02-03 22:48:15.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-02-03 22:48:15.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1001674,"name":"Evgeniy Didin","email":"didin@synopsys.com","username":"EvgeniiDidin"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1001674,"name":"Evgeniy Didin","email":"didin@synopsys.com","username":"EvgeniiDidin"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-12-30 18:44:43.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1001674,"name":"Evgeniy Didin","email":"didin@synopsys.com","username":"EvgeniiDidin"},"state":"REVIEWER"},{"updated":"2022-12-30 18:51:24.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"cb8cea4a87a235a70ebe5e64192401af4752aab9","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-12-30 18:44:43.000000000","message":"Uploaded patch set 1: Code-Review+1.","accounts_in_message":[],"_revision_number":1},{"id":"160ac383c9344a38f662dbc140df0b70ccd88cd5","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-12-30 18:51:24.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit/17268/ : FAILURE\n\nhttps://build.openocd.org/job/openocd-gerrit-build/16470/ : FAILURE","accounts_in_message":[],"_revision_number":1},{"id":"725a68fb27b3495253278e98f6a25ea4c9530e4f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-12-30 21:18:24.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"b9a80bf953c71f722d529122bf53a97fafc4d9fa","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-12-30 21:56:08.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/17272/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/16474/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"5d95c2ba11b3e5d2e3cab48ac50f615332ba6983","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-12-30 22:04:30.000000000","message":"Topic set to after 0.12 release","accounts_in_message":[],"_revision_number":2},{"id":"2efdbf088eedc9614b77ecabe2096318c3245ae5","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-12-30 22:10:43.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"d9748c40ae033fc8dbe855bbaa39227fbd0376fe","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-01-01 17:00:22.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"0ff412bfd4765ff634416eecabe0ff561620909b","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-01-01 18:43:39.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/17277/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/16479/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"53e2b086e2015cff9170903bdb5145e73a0e01c5","author":{"_account_id":1001674,"name":"Evgeniy Didin","email":"didin@synopsys.com","username":"EvgeniiDidin"},"real_author":{"_account_id":1001674,"name":"Evgeniy Didin","email":"didin@synopsys.com","username":"EvgeniiDidin"},"date":"2023-01-30 10:47:40.000000000","message":"Patch Set 3: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"77a309b7f3322c999f8a148fbcfbebb0296da6a1","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-02-03 22:48:13.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"8ded9774d741d2bc07446ec69f4b2c8745000ee2","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-02-03 22:48:15.000000000","message":"Change has been successfully cherry-picked as 92ef27494c510a2df7cbbee8b19d5c0d4d943d40","accounts_in_message":[],"_revision_number":4}],"current_revision":"92ef27494c510a2df7cbbee8b19d5c0d4d943d40","revisions":{"3ba582572e1266b9b12bce2d4cff94b46755fd61":{"kind":"REWORK","_number":1,"created":"2022-12-30 18:44:43.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/24/7424/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/24/7424/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/24/7424/1 \u0026\u0026 git checkout -b change-7424 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/24/7424/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/24/7424/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/24/7424/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/24/7424/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/24/7424/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"36d1604454cde6da0a4bf7b939db586a02e1d6b5","subject":"helper: nvp: add openocd nvp files"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-12-26 23:28:16.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-12-30 18:39:02.000000000","tz":60},"subject":"target: arc: rewrite command \u0027arc add-reg-type-flags\u0027 as COMMAND_HANDLER","message":"target: arc: rewrite command \u0027arc add-reg-type-flags\u0027 as COMMAND_HANDLER\n\nUse a COMMAND_HELPER() to avoid memory leaks when the helper\nCOMMAND_PARSE_NUMBER() returns due to an error.\n\nWhile there:\n- fix potential SIGSEGV due to dereference \u0027type\u0027 before checking\n  it\u0027s not NULL;\n- fix an incorrect NUL byte termination while copying to\n  type-\u003edata_type.id and to bitfields[cur_field].name;\n- fix some coding style error.\n\nChange-Id: Ide4cbc829871a6a523026ccc0d3100dadc2afd06\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"2f1e1a74d5c4cae7d30ab7f4f66e00dea2cd1200":{"kind":"REWORK","_number":3,"created":"2023-01-01 17:00:22.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/24/7424/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/24/7424/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/24/7424/3 \u0026\u0026 git checkout -b change-7424 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/24/7424/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/24/7424/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/24/7424/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/24/7424/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/24/7424/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"162ca6b6e48c02e023e29a2281e6728927c70ab6","subject":"helper: nvp: add openocd nvp files"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-12-26 23:28:16.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-12-31 22:47:56.000000000","tz":60},"subject":"target: arc: rewrite command \u0027arc add-reg-type-flags\u0027 as COMMAND_HANDLER","message":"target: arc: rewrite command \u0027arc add-reg-type-flags\u0027 as COMMAND_HANDLER\n\nUse a COMMAND_HELPER() to avoid memory leaks when the helper\nCOMMAND_PARSE_NUMBER() returns due to an error.\n\nWhile there:\n- fix potential SIGSEGV due to dereference \u0027type\u0027 before checking\n  it\u0027s not NULL;\n- fix an incorrect NUL byte termination while copying to\n  type-\u003edata_type.id and to bitfields[cur_field].name;\n- fix some coding style error.\n\nChange-Id: Ide4cbc829871a6a523026ccc0d3100dadc2afd06\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"0d983f6782ce48f8bd152420bf18131c2430902f":{"kind":"REWORK","_number":2,"created":"2022-12-30 21:18:24.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/24/7424/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/24/7424/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/24/7424/2 \u0026\u0026 git checkout -b change-7424 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/24/7424/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/24/7424/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/24/7424/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/24/7424/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/24/7424/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9b59327bb28f55345bb120433f3401003be25606","subject":"helper: nvp: add openocd nvp files"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-12-26 23:28:16.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-12-30 21:16:03.000000000","tz":60},"subject":"target: arc: rewrite command \u0027arc add-reg-type-flags\u0027 as COMMAND_HANDLER","message":"target: arc: rewrite command \u0027arc add-reg-type-flags\u0027 as COMMAND_HANDLER\n\nUse a COMMAND_HELPER() to avoid memory leaks when the helper\nCOMMAND_PARSE_NUMBER() returns due to an error.\n\nWhile there:\n- fix potential SIGSEGV due to dereference \u0027type\u0027 before checking\n  it\u0027s not NULL;\n- fix an incorrect NUL byte termination while copying to\n  type-\u003edata_type.id and to bitfields[cur_field].name;\n- fix some coding style error.\n\nChange-Id: Ide4cbc829871a6a523026ccc0d3100dadc2afd06\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"92ef27494c510a2df7cbbee8b19d5c0d4d943d40":{"kind":"REWORK","_number":4,"created":"2023-02-03 22:48:15.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/24/7424/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/24/7424/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/24/7424/4 \u0026\u0026 git checkout -b change-7424 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/24/7424/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/24/7424/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/24/7424/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/24/7424/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/24/7424/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ea6a99208e1bc41a878234f7220501e26ec4a7f1","subject":"helper: nvp: add openocd nvp files"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-12-26 23:28:16.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-02-03 22:48:15.000000000","tz":0},"subject":"target: arc: rewrite command \u0027arc add-reg-type-flags\u0027 as COMMAND_HANDLER","message":"target: arc: rewrite command \u0027arc add-reg-type-flags\u0027 as COMMAND_HANDLER\n\nUse a COMMAND_HELPER() to avoid memory leaks when the helper\nCOMMAND_PARSE_NUMBER() returns due to an error.\n\nWhile there:\n- fix potential SIGSEGV due to dereference \u0027type\u0027 before checking\n  it\u0027s not NULL;\n- fix an incorrect NUL byte termination while copying to\n  type-\u003edata_type.id and to bitfields[cur_field].name;\n- fix some coding style error.\n\nChange-Id: Ide4cbc829871a6a523026ccc0d3100dadc2afd06\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7424\nTested-by: jenkins\nReviewed-by: Evgeniy Didin \u003cdidin@synopsys.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}