)]}'
{"id":"openocd~master~I7158fd93b5d4742f11654b8ae4a7abd409ad06e2","project":"openocd","branch":"master","topic":"after 0.12 release","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2023-02-03 22:48:23.000000000","reason":"removed on reply"},"1001674":{"account":{"_account_id":1001674,"name":"Evgeniy Didin","email":"didin@synopsys.com","username":"EvgeniiDidin"},"last_update":"2023-01-30 10:57:04.000000000","reason":"Evgeniy Didin replied on the change"}},"hashtags":[],"change_id":"I7158fd93b5d4742f11654b8ae4a7abd409ad06e2","subject":"target: arc: rewrite command \u0027arc add-reg-type-struct\u0027 as COMMAND_HANDLER","status":"MERGED","created":"2022-12-30 18:44:43.000000000","updated":"2023-02-03 22:48:26.000000000","submitted":"2023-02-03 22:48:26.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7425-after 0.12 release","meta_rev_id":"c901325cae6060cf977f3a040bb8034640171293","_number":7425,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1001674,"name":"Evgeniy Didin","email":"didin@synopsys.com","username":"EvgeniiDidin"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-02-03 22:48:26.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-02-03 22:48:26.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-02-03 22:48:26.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1001674,"name":"Evgeniy Didin","email":"didin@synopsys.com","username":"EvgeniiDidin"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1001674,"name":"Evgeniy Didin","email":"didin@synopsys.com","username":"EvgeniiDidin"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-12-30 18:44:43.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1001674,"name":"Evgeniy Didin","email":"didin@synopsys.com","username":"EvgeniiDidin"},"state":"REVIEWER"},{"updated":"2022-12-30 19:48:25.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"596e8aefafb0783333cfb7815fc41ef7cd553271","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-12-30 18:44:43.000000000","message":"Uploaded patch set 1: Code-Review+1.","accounts_in_message":[],"_revision_number":1},{"id":"e5219bba1acba813452bb15b286c79167722f755","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-12-30 19:48:25.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit/17271/ : FAILURE\n\nhttps://build.openocd.org/job/openocd-gerrit-build/16472/ : FAILURE","accounts_in_message":[],"_revision_number":1},{"id":"54190efaaebaf2b53f40859f6845e5e04082ec2e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-12-30 22:01:28.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"0a8fe9239087749ad2235d1cba0022cfd0ffec1f","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-12-30 22:11:13.000000000","message":"Topic set to after 0.12 release","accounts_in_message":[],"_revision_number":2},{"id":"49763d3e2ce3694b467a16f401786c6566a0f2e7","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-12-30 23:46:41.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/17274/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/16476/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"2b17a047e3775b650b0b79d6affd431cad6cd370","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-01-01 17:00:22.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"3b4bc65e0161d8de710349ba35724b2993ae15eb","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-01-01 19:37:38.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/17278/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/16480/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"2c8ca8db8bc07e8d6773830e6266fe12e72777d0","author":{"_account_id":1001674,"name":"Evgeniy Didin","email":"didin@synopsys.com","username":"EvgeniiDidin"},"real_author":{"_account_id":1001674,"name":"Evgeniy Didin","email":"didin@synopsys.com","username":"EvgeniiDidin"},"date":"2023-01-30 10:57:04.000000000","message":"Patch Set 3: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"2416602833d7e99fc4c92effeec043040e124c36","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-02-03 22:48:23.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"c901325cae6060cf977f3a040bb8034640171293","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-02-03 22:48:26.000000000","message":"Change has been successfully cherry-picked as 85f3b10a6914fd44c8f32d345654bed371d0667d","accounts_in_message":[],"_revision_number":4}],"current_revision":"85f3b10a6914fd44c8f32d345654bed371d0667d","revisions":{"e3b175db2ff120bae3dc189a2f859133cf899b24":{"kind":"REWORK","_number":3,"created":"2023-01-01 17:00:22.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/25/7425/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/25/7425/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/25/7425/3 \u0026\u0026 git checkout -b change-7425 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/25/7425/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/25/7425/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/25/7425/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/25/7425/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/25/7425/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2f1e1a74d5c4cae7d30ab7f4f66e00dea2cd1200","subject":"target: arc: rewrite command \u0027arc add-reg-type-flags\u0027 as COMMAND_HANDLER"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-12-26 23:56:55.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-12-31 22:47:56.000000000","tz":60},"subject":"target: arc: rewrite command \u0027arc add-reg-type-struct\u0027 as COMMAND_HANDLER","message":"target: arc: rewrite command \u0027arc add-reg-type-struct\u0027 as COMMAND_HANDLER\n\nUse a COMMAND_HELPER() to avoid memory leaks when the helper\nCOMMAND_PARSE_NUMBER() returns due to an error.\n\nWhile there:\n- fix potential SIGSEGV due to dereference \u0027type\u0027 before checking\n  it\u0027s not NULL;\n- fix an incorrect NUL byte termination while copying to\n  type-\u003edata_type.id and to bitfields[cur_field].name;\n- fix some coding style error;\n- remove the now unused function jim_arc_read_reg_type_field().\n\nChange-Id: I7158fd93b5d4742f11654b8ae4a7abd409ad06e2\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"9c8e195dfc6904a4b49b86f1696940b1cbdfc1d7":{"kind":"REWORK","_number":2,"created":"2022-12-30 22:01:28.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/25/7425/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/25/7425/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/25/7425/2 \u0026\u0026 git checkout -b change-7425 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/25/7425/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/25/7425/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/25/7425/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/25/7425/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/25/7425/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"0d983f6782ce48f8bd152420bf18131c2430902f","subject":"target: arc: rewrite command \u0027arc add-reg-type-flags\u0027 as COMMAND_HANDLER"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-12-26 23:56:55.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-12-30 21:57:35.000000000","tz":60},"subject":"target: arc: rewrite command \u0027arc add-reg-type-struct\u0027 as COMMAND_HANDLER","message":"target: arc: rewrite command \u0027arc add-reg-type-struct\u0027 as COMMAND_HANDLER\n\nUse a COMMAND_HELPER() to avoid memory leaks when the helper\nCOMMAND_PARSE_NUMBER() returns due to an error.\n\nWhile there:\n- fix potential SIGSEGV due to dereference \u0027type\u0027 before checking\n  it\u0027s not NULL;\n- fix an incorrect NUL byte termination while copying to\n  type-\u003edata_type.id and to bitfields[cur_field].name;\n- fix some coding style error;\n- remove the now unused function jim_arc_read_reg_type_field().\n\nChange-Id: I7158fd93b5d4742f11654b8ae4a7abd409ad06e2\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"e1e877cb797226e156d754f14fd68cccb2163b28":{"kind":"REWORK","_number":1,"created":"2022-12-30 18:44:43.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/25/7425/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/25/7425/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/25/7425/1 \u0026\u0026 git checkout -b change-7425 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/25/7425/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/25/7425/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/25/7425/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/25/7425/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/25/7425/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3ba582572e1266b9b12bce2d4cff94b46755fd61","subject":"target: arc: rewrite command \u0027arc add-reg-type-flags\u0027 as COMMAND_HANDLER"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-12-26 23:56:55.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-12-30 18:39:10.000000000","tz":60},"subject":"target: arc: rewrite command \u0027arc add-reg-type-struct\u0027 as COMMAND_HANDLER","message":"target: arc: rewrite command \u0027arc add-reg-type-struct\u0027 as COMMAND_HANDLER\n\nUse a COMMAND_HELPER() to avoid memory leaks when the helper\nCOMMAND_PARSE_NUMBER() returns due to an error.\n\nWhile there:\n- fix potential SIGSEGV due to dereference \u0027type\u0027 before checking\n  it\u0027s not NULL;\n- fix an incorrect NUL byte termination while copying to\n  type-\u003edata_type.id and to bitfields[cur_field].name;\n- fix some coding style error;\n- remove the now unused function jim_arc_read_reg_type_field().\n\nChange-Id: I7158fd93b5d4742f11654b8ae4a7abd409ad06e2\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"85f3b10a6914fd44c8f32d345654bed371d0667d":{"kind":"REWORK","_number":4,"created":"2023-02-03 22:48:26.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/25/7425/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/25/7425/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/25/7425/4 \u0026\u0026 git checkout -b change-7425 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/25/7425/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/25/7425/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/25/7425/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/25/7425/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/25/7425/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"92ef27494c510a2df7cbbee8b19d5c0d4d943d40","subject":"target: arc: rewrite command \u0027arc add-reg-type-flags\u0027 as COMMAND_HANDLER"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-12-26 23:56:55.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-02-03 22:48:26.000000000","tz":0},"subject":"target: arc: rewrite command \u0027arc add-reg-type-struct\u0027 as COMMAND_HANDLER","message":"target: arc: rewrite command \u0027arc add-reg-type-struct\u0027 as COMMAND_HANDLER\n\nUse a COMMAND_HELPER() to avoid memory leaks when the helper\nCOMMAND_PARSE_NUMBER() returns due to an error.\n\nWhile there:\n- fix potential SIGSEGV due to dereference \u0027type\u0027 before checking\n  it\u0027s not NULL;\n- fix an incorrect NUL byte termination while copying to\n  type-\u003edata_type.id and to bitfields[cur_field].name;\n- fix some coding style error;\n- remove the now unused function jim_arc_read_reg_type_field().\n\nChange-Id: I7158fd93b5d4742f11654b8ae4a7abd409ad06e2\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7425\nTested-by: jenkins\nReviewed-by: Evgeniy Didin \u003cdidin@synopsys.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}