)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"c075f405c78421dd513e75fcb3e5d6a3b3c55eaa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c0b71e53_44ad1a9a","updated":"2023-01-02 14:57:25.000000000","message":"Tested with RP2040, SWD multidrop works","commit_id":"4b976315067e7c68b77243bb3492585b80dbd882"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"9e0b7c45ae249c83f0181706653a124fce9b5fff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c7ea125e_890bb46a","updated":"2023-01-01 21:41:06.000000000","message":"Tomas, would you mind testing this in SWD multi-drop? I still don\u0027t have such setup!","commit_id":"4b976315067e7c68b77243bb3492585b80dbd882"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"5115c545f406bfab5169eb017620f50c986140e9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"78131590_16920206","in_reply_to":"c0b71e53_44ad1a9a","updated":"2023-01-02 16:48:12.000000000","message":"Thanks for testing it","commit_id":"4b976315067e7c68b77243bb3492585b80dbd882"}],"src/jtag/tcl.c":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"c075f405c78421dd513e75fcb3e5d6a3b3c55eaa","unresolved":true,"context_lines":[{"line_number":610,"context_line":"\t/* default is enabled-after-reset */"},{"line_number":611,"context_line":"\ttap-\u003eenabled \u003d !tap-\u003edisabled_after_reset;"},{"line_number":612,"context_line":""},{"line_number":613,"context_line":"\t/* Did all the required option bits get cleared? */"},{"line_number":614,"context_line":"\tif (!transport_is_jtag() || tap-\u003eir_length !\u003d 0) {"},{"line_number":615,"context_line":"\t\tjtag_tap_init(tap);"},{"line_number":616,"context_line":"\t\treturn JIM_OK;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"3cf46626_632d3b83","line":613,"range":{"start_line":613,"start_character":4,"end_line":613,"end_character":49},"updated":"2023-01-02 14:57:25.000000000","message":"The comment is leftover from the ancient\nhttps://review.openocd.org/gitweb?p\u003dopenocd.git;a\u003dcommit;h\u003d0b476c9f4c0235f52f1a6c522f4835b5ca7e05c5\n\nCould you update it?\nAlso explain reasons for parsing in non-jtag setup (not necessarily here) and why IR length is checked for jtag only.\n\nOr improve code readability by changing the code flow to check IR length\nand return err if zero (and jtag is used) and move the final jtag_tap_init()\nto the end of jim_newtap_cmd() to follow the usual code flow pattern?","commit_id":"4b976315067e7c68b77243bb3492585b80dbd882"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"83bf03072d9fcbbc3d048c2f79ea70f67483d286","unresolved":false,"context_lines":[{"line_number":610,"context_line":"\t/* default is enabled-after-reset */"},{"line_number":611,"context_line":"\ttap-\u003eenabled \u003d !tap-\u003edisabled_after_reset;"},{"line_number":612,"context_line":""},{"line_number":613,"context_line":"\t/* Did all the required option bits get cleared? */"},{"line_number":614,"context_line":"\tif (!transport_is_jtag() || tap-\u003eir_length !\u003d 0) {"},{"line_number":615,"context_line":"\t\tjtag_tap_init(tap);"},{"line_number":616,"context_line":"\t\treturn JIM_OK;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"8783814c_056ae16c","line":613,"range":{"start_line":613,"start_character":4,"end_line":613,"end_character":49},"in_reply_to":"22b80373_eb39703a","updated":"2023-01-02 18:07:50.000000000","message":"Okay then","commit_id":"4b976315067e7c68b77243bb3492585b80dbd882"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"5115c545f406bfab5169eb017620f50c986140e9","unresolved":true,"context_lines":[{"line_number":610,"context_line":"\t/* default is enabled-after-reset */"},{"line_number":611,"context_line":"\ttap-\u003eenabled \u003d !tap-\u003edisabled_after_reset;"},{"line_number":612,"context_line":""},{"line_number":613,"context_line":"\t/* Did all the required option bits get cleared? */"},{"line_number":614,"context_line":"\tif (!transport_is_jtag() || tap-\u003eir_length !\u003d 0) {"},{"line_number":615,"context_line":"\t\tjtag_tap_init(tap);"},{"line_number":616,"context_line":"\t\treturn JIM_OK;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"bda61b2d_15cc5ec8","line":613,"range":{"start_line":613,"start_character":4,"end_line":613,"end_character":49},"in_reply_to":"3cf46626_632d3b83","updated":"2023-01-02 16:48:12.000000000","message":"Fully agree!\nThese comments have already be solved in a next patch that converts this code to COMMAND_HANDLER.\nI will send it on top of this series, but will not compile due to dependency from https://review.openocd.org/7423/ that I have send out for ARC. I was not planning to send it out alone, anyway here it is for your reference.\n\nI\u0027m reworking all the jim commands and the resulting series is giant!\nI have sent out these two patches because quite independent, and I need feedback from multi-drop.\nI have also sent out the part for ARC, that I cannot test.","commit_id":"4b976315067e7c68b77243bb3492585b80dbd882"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"d657e10363818d03d3355e04bd454697d40f8f8d","unresolved":false,"context_lines":[{"line_number":610,"context_line":"\t/* default is enabled-after-reset */"},{"line_number":611,"context_line":"\ttap-\u003eenabled \u003d !tap-\u003edisabled_after_reset;"},{"line_number":612,"context_line":""},{"line_number":613,"context_line":"\t/* Did all the required option bits get cleared? */"},{"line_number":614,"context_line":"\tif (!transport_is_jtag() || tap-\u003eir_length !\u003d 0) {"},{"line_number":615,"context_line":"\t\tjtag_tap_init(tap);"},{"line_number":616,"context_line":"\t\treturn JIM_OK;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"22b80373_eb39703a","line":613,"range":{"start_line":613,"start_character":4,"end_line":613,"end_character":49},"in_reply_to":"bda61b2d_15cc5ec8","updated":"2023-01-02 16:57:21.000000000","message":"Please see it in\nhttps://review.openocd.org/7431","commit_id":"4b976315067e7c68b77243bb3492585b80dbd882"}]}