)]}'
{"id":"openocd~master~I9dabbdc2a6f338f23b2fd3ed1a4dc3da0200c080","project":"openocd","branch":"master","topic":"after 0.12 release","hashtags":[],"change_id":"I9dabbdc2a6f338f23b2fd3ed1a4dc3da0200c080","subject":"jtag: hla: use generic helper for commands \u0027jtag newtap\u0027 \u0027swd newdap\u0027","status":"MERGED","created":"2023-01-01 18:32:05.000000000","updated":"2023-01-15 15:12:05.000000000","submitted":"2023-01-15 15:12:05.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7428-after 0.12 release","meta_rev_id":"95728557611c8ed988d9abb715da910e36f7bacf","_number":7428,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-01-15 15:12:05.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-01-15 15:12:05.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-01-01 21:46:14.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"f2468b6b424e67e787d0c7083ebc00bd498038ec","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-01-01 18:32:05.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"53bc5fe1d5a98ada874efaae47ec20df7918a0b5","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-01-01 21:41:22.000000000","message":"Topic set to after 0.12 release","accounts_in_message":[],"_revision_number":1},{"id":"e700b151d5c4fce518db69363a3a4cb23c242401","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-01-01 21:41:51.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"68f0177e7f164b76f6a7b88362e1259f494f118a","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-01-01 21:46:14.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/17281/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/16483/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"501088c5b8c62f639ffeb3679234f5567b0febad","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-01-15 14:42:29.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"95728557611c8ed988d9abb715da910e36f7bacf","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-01-15 15:12:05.000000000","message":"Change has been successfully cherry-picked as cda39f929e65316478f2f41f461b0cbb3338806c","accounts_in_message":[],"_revision_number":2}],"current_revision":"cda39f929e65316478f2f41f461b0cbb3338806c","revisions":{"cda39f929e65316478f2f41f461b0cbb3338806c":{"kind":"REWORK","_number":2,"created":"2023-01-15 15:12:05.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/28/7428/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/28/7428/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/28/7428/2 \u0026\u0026 git checkout -b change-7428 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/28/7428/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/28/7428/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/28/7428/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/28/7428/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/28/7428/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7a890a8f256f28b1c8b0dde3b62ab81c7c139d55","subject":"jtag: parse command options in \u0027swd newdap\u0027"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-01-01 18:17:18.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-01-15 15:12:05.000000000","tz":0},"subject":"jtag: hla: use generic helper for commands \u0027jtag newtap\u0027 \u0027swd newdap\u0027","message":"jtag: hla: use generic helper for commands \u0027jtag newtap\u0027 \u0027swd newdap\u0027\n\nThe commands \u0027jtag newtap\u0027 and \u0027swd newdap\u0027 have to work either on\nHLA transport and on standard JTAG/SWD. Having a dedicated\nimplementation for HLA is a non-sense.\n\nReuse the generic code jim_jtag_newtap() and drop the files\nhla_tcl.[ch] as they are now empty.\n\nChange-Id: I9dabbdc2a6f338f23b2fd3ed1a4dc3da0200c080\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7428\nTested-by: jenkins\n"}},"fad361f8f7b3678ab6511d03071ce579e8badcbc":{"kind":"REWORK","_number":1,"created":"2023-01-01 18:32:05.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/28/7428/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/28/7428/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/28/7428/1 \u0026\u0026 git checkout -b change-7428 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/28/7428/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/28/7428/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/28/7428/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/28/7428/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/28/7428/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4b976315067e7c68b77243bb3492585b80dbd882","subject":"jtag: parse command options in \u0027swd newdap\u0027"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-01-01 18:17:18.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-01-01 18:26:49.000000000","tz":60},"subject":"jtag: hla: use generic helper for commands \u0027jtag newtap\u0027 \u0027swd newdap\u0027","message":"jtag: hla: use generic helper for commands \u0027jtag newtap\u0027 \u0027swd newdap\u0027\n\nThe commands \u0027jtag newtap\u0027 and \u0027swd newdap\u0027 have to work either on\nHLA transport and on standard JTAG/SWD. Having a dedicated\nimplementation for HLA is a non-sense.\n\nReuse the generic code jim_jtag_newtap() and drop the files\nhla_tcl.[ch] as they are now empty.\n\nChange-Id: I9dabbdc2a6f338f23b2fd3ed1a4dc3da0200c080\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}