)]}'
{"id":"openocd~master~I1c8c3ffeb324e9eacb919c7e0d94fd72122c9a81","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2023-05-16 22:00:46.000000000","reason":"\u003cGERRIT_ACCOUNT_1000021\u003e replied on the change","reason_account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2023-05-27 06:42:01.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I1c8c3ffeb324e9eacb919c7e0d94fd72122c9a81","subject":"jtag: rewrite commands \u0027jtag newtap\u0027 and \u0027swd newdap\u0027 as COMMAND_HANDLER","status":"MERGED","created":"2023-01-02 16:54:52.000000000","updated":"2023-05-27 06:42:01.000000000","submitted":"2023-05-27 06:42:01.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":5,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7431","meta_rev_id":"7f5270e17c68820f42e7b22b101eac2ffbbabacf","_number":7431,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-05-27 06:42:01.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-05-27 06:42:01.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-01-02 17:53:00.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-03-28 14:19:58.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"}],"messages":[{"id":"7d823b89fb35b6c3a0cab895b41ba01b4592cb9e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-01-02 16:54:52.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"6fa43a46550588092cdd5227862c5805525e6a9a","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-01-02 16:56:06.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"8046ca063abd719622c4a00e3d0451362d489e06","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-01-02 16:56:13.000000000","message":"Topic set to after 0.12 release","accounts_in_message":[],"_revision_number":1},{"id":"7f3f29e84190762798f5b1758aca097bf1039929","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-01-02 17:53:00.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit/17286/ : FAILURE\n\nhttps://build.openocd.org/job/openocd-gerrit-build/16488/ : FAILURE","accounts_in_message":[],"_revision_number":1},{"id":"7000a7937e967c644484b828254001f75930c84a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-03-27 12:55:42.000000000","message":"Uploaded patch set 2: Code-Review+1.","accounts_in_message":[],"_revision_number":2},{"id":"db612c58e9c4efc2727d4b957ada3dca66a55974","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-03-27 12:56:33.000000000","message":"Topic after 0.12 release removed","accounts_in_message":[],"_revision_number":2},{"id":"91078c61a310a99b8752b5bc06a2762dd3469314","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-03-27 15:40:16.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16712/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/17506/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"fa1ed4b8b6cc380a4f149a28a5b3745df829c8c7","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-03-28 14:19:58.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"2691b868e104cb566664fedd68563ca4d65190dd","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-05-13 08:34:54.000000000","message":"Patch Set 2: Code-Review-1\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"38cbdd309090e950fc2b359882a1b3ebe4c1e99e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-05-13 13:20:26.000000000","message":"Uploaded patch set 3.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR is:MIN\")\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":3},{"id":"94b5afff942a6a3c30f278748b386d2c094cc662","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-05-13 23:24:09.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/17717/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/16919/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"4727926ac60c00adabe43937f149f4ca17488cfa","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-05-16 22:00:46.000000000","message":"Patch Set 3: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"e06b8b5e48d24e40e428153689f02065fe04c20c","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-05-27 06:41:54.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"7f5270e17c68820f42e7b22b101eac2ffbbabacf","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-05-27 06:42:01.000000000","message":"Change has been successfully cherry-picked as 5dd047fbbe6c550afe8491ade0eae0d61397e496","accounts_in_message":[],"_revision_number":4}],"current_revision":"5dd047fbbe6c550afe8491ade0eae0d61397e496","revisions":{"8f2294742ed1864b7de6ef021801597e6039de7b":{"kind":"REWORK","_number":1,"created":"2023-01-02 16:54:52.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/31/7431/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/31/7431/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/31/7431/1 \u0026\u0026 git checkout -b change-7431 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/31/7431/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/31/7431/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/31/7431/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/31/7431/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/31/7431/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"fad361f8f7b3678ab6511d03071ce579e8badcbc","subject":"jtag: hla: use generic helper for commands \u0027jtag newtap\u0027 \u0027swd newdap\u0027"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-01-02 00:11:44.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-01-02 16:37:02.000000000","tz":60},"subject":"jtag: rewrite commands \u0027jtag newtap\u0027 and \u0027swd newdap\u0027 as COMMAND_HANDLER","message":"jtag: rewrite commands \u0027jtag newtap\u0027 and \u0027swd newdap\u0027 as COMMAND_HANDLER\n\nWhile there:\n- fix memory leak in case of error on values tap-\u003echip,\n  tap-\u003etapname, tap-\u003eexpected_ids;\n- check for out of memory error;\n- fix minor coding style issue;\n- add missing .usage;\n- remove functions not in use anymore.\n\nChange-Id: I1c8c3ffeb324e9eacb919c7e0d94fd72122c9a81\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"592cdbc6c4ea9f733c713b300656291d46d258e9":{"kind":"REWORK","_number":3,"created":"2023-05-13 13:20:26.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/31/7431/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/31/7431/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/31/7431/3 \u0026\u0026 git checkout -b change-7431 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/31/7431/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/31/7431/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/31/7431/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/31/7431/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/31/7431/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"e48246064d1f6101943d100f2f9ba13107832d9b","subject":"target: use unsigned int for timeout_ms"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-01-02 00:11:44.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-05-13 12:58:37.000000000","tz":120},"subject":"jtag: rewrite commands \u0027jtag newtap\u0027 and \u0027swd newdap\u0027 as COMMAND_HANDLER","message":"jtag: rewrite commands \u0027jtag newtap\u0027 and \u0027swd newdap\u0027 as COMMAND_HANDLER\n\nWhile there:\n- fix memory leak in case of error on values tap-\u003echip,\n  tap-\u003etapname, tap-\u003eexpected_ids;\n- check for out of memory error;\n- fix minor coding style issue;\n- add the missing .usage field;\n- remove functions not in use anymore.\n\nChange-Id: I1c8c3ffeb324e9eacb919c7e0d94fd72122c9a81\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"7fbf0cad54d92c017f82bedec076295fcbab3de5":{"kind":"REWORK","_number":2,"created":"2023-03-27 12:55:42.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/31/7431/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/31/7431/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/31/7431/2 \u0026\u0026 git checkout -b change-7431 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/31/7431/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/31/7431/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/31/7431/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/31/7431/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/31/7431/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7e5c704a7f1348ad8f60d8e9904ae76b457320c6","subject":"openocd: trivial replace of jim-nvp with new nvp"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-01-02 00:11:44.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-03-25 18:21:34.000000000","tz":60},"subject":"jtag: rewrite commands \u0027jtag newtap\u0027 and \u0027swd newdap\u0027 as COMMAND_HANDLER","message":"jtag: rewrite commands \u0027jtag newtap\u0027 and \u0027swd newdap\u0027 as COMMAND_HANDLER\n\nWhile there:\n- fix memory leak in case of error on values tap-\u003echip,\n  tap-\u003etapname, tap-\u003eexpected_ids;\n- check for out of memory error;\n- fix minor coding style issue;\n- add the missing .usage field;\n- remove functions not in use anymore.\n\nChange-Id: I1c8c3ffeb324e9eacb919c7e0d94fd72122c9a81\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"5dd047fbbe6c550afe8491ade0eae0d61397e496":{"kind":"REWORK","_number":4,"created":"2023-05-27 06:42:01.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/31/7431/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/31/7431/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/31/7431/4 \u0026\u0026 git checkout -b change-7431 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/31/7431/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/31/7431/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/31/7431/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/31/7431/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/31/7431/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"da76f8f0b4b98c2b7f04b5fe94f721aed7b2cfab","subject":"target: use unsigned int for timeout_ms"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-01-02 00:11:44.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-05-27 06:42:01.000000000","tz":0},"subject":"jtag: rewrite commands \u0027jtag newtap\u0027 and \u0027swd newdap\u0027 as COMMAND_HANDLER","message":"jtag: rewrite commands \u0027jtag newtap\u0027 and \u0027swd newdap\u0027 as COMMAND_HANDLER\n\nWhile there:\n- fix memory leak in case of error on values tap-\u003echip,\n  tap-\u003etapname, tap-\u003eexpected_ids;\n- check for out of memory error;\n- fix minor coding style issue;\n- add the missing .usage field;\n- remove functions not in use anymore.\n\nChange-Id: I1c8c3ffeb324e9eacb919c7e0d94fd72122c9a81\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7431\nTested-by: jenkins\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}