)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"change_message_id":"2d3cc80cedb8e4e74c70044c5bd19fa4c23c3ba7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"db53a0e4_563f53ed","updated":"2023-01-05 12:22:53.000000000","message":"As we discussed in \"flash/jtagspi: handle error return values where needed\".\n\nI hope this is enough for the documentation. Let me know if you think we should also document the tcl scripts in \u0027openocd.texi\u0027.","commit_id":"9607eb8dfd504b7c6e98a013020f9ed585987e04"},{"author":{"_account_id":1001036,"name":"Andreas Bolsch","email":"hyphen0break@gmail.com","username":"abmero"},"change_message_id":"73387add404afe7b9e3c479c978817e3e0cfd8ed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"264e8bd9_6c96f37e","updated":"2023-01-08 14:46:40.000000000","message":"Seems good, thanks.","commit_id":"9607eb8dfd504b7c6e98a013020f9ed585987e04"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"f2d504892406d6db658646dab646320feef14fce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9a4acf79_e02530ad","updated":"2023-03-20 07:41:35.000000000","message":"Hmm, it will not work without merging the parent in the relation wait.\nLet\u0027s wait until the problem with sending cmd to a not-yet-probed bank is solved.","commit_id":"895c33a45efc49e85a9c062a82633da55dc7b506"},{"author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"change_message_id":"bb7a5a032a594e0a3720e15cbc1d5da31b762f35","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"563b12da_a7e070d2","updated":"2023-03-25 22:32:16.000000000","message":"After the proposed changes from Tomas Vanek I had to move the initialization of jtagspi_flash_bank::tap from jtagspi_probe() to jtagspi_flash_bank_command(), I think that\u0027s no problem.","commit_id":"7172a89e4f089c0899408d24d9ab1a5357496116"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"0e017c78ce9f52b5a1ddbee0a277833dcfa5a6de","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e035fd8e_2ef6b6c8","updated":"2023-05-11 12:03:55.000000000","message":"minor comment below","commit_id":"7172a89e4f089c0899408d24d9ab1a5357496116"},{"author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"change_message_id":"1c085fed224d8058ea799756f1d0100525533254","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9eb0bfb2_d1185812","updated":"2023-05-11 22:36:50.000000000","message":"thanks for reviewing","commit_id":"7172a89e4f089c0899408d24d9ab1a5357496116"}],"tcl/cpld/jtagspi.cfg":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"0e017c78ce9f52b5a1ddbee0a277833dcfa5a6de","unresolved":true,"context_lines":[{"line_number":28,"context_line":"# proxy_bit: file with bitstream connecting JTAG and SPI interface in the PLD."},{"line_number":29,"context_line":"# release_from_pwr_down_cmd: optional, command sent to spi flash before probing."},{"line_number":30,"context_line":"#                            ex: 0xAB to release from power-dowm."},{"line_number":31,"context_line":"#                            Juts omit to not send a command."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"proc jtagspi_init {chain_id proxy_bit {release_from_pwr_down_cmd 0}} {"},{"line_number":34,"context_line":"\t# load proxy bitstream $proxy_bit and probe spi flash"}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"1ab9f0df_e3a206c6","line":31,"updated":"2023-05-11 12:03:55.000000000","message":"typo: s/Juts/Just/","commit_id":"7172a89e4f089c0899408d24d9ab1a5357496116"},{"author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"change_message_id":"1c085fed224d8058ea799756f1d0100525533254","unresolved":false,"context_lines":[{"line_number":28,"context_line":"# proxy_bit: file with bitstream connecting JTAG and SPI interface in the PLD."},{"line_number":29,"context_line":"# release_from_pwr_down_cmd: optional, command sent to spi flash before probing."},{"line_number":30,"context_line":"#                            ex: 0xAB to release from power-dowm."},{"line_number":31,"context_line":"#                            Juts omit to not send a command."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"proc jtagspi_init {chain_id proxy_bit {release_from_pwr_down_cmd 0}} {"},{"line_number":34,"context_line":"\t# load proxy bitstream $proxy_bit and probe spi flash"}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"638f95ad_1ef4e34b","line":31,"in_reply_to":"1ab9f0df_e3a206c6","updated":"2023-05-11 22:36:50.000000000","message":"Done","commit_id":"7172a89e4f089c0899408d24d9ab1a5357496116"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"0e017c78ce9f52b5a1ddbee0a277833dcfa5a6de","unresolved":true,"context_lines":[{"line_number":30,"context_line":"#                            ex: 0xAB to release from power-dowm."},{"line_number":31,"context_line":"#                            Juts omit to not send a command."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"proc jtagspi_init {chain_id proxy_bit {release_from_pwr_down_cmd 0}} {"},{"line_number":34,"context_line":"\t# load proxy bitstream $proxy_bit and probe spi flash"},{"line_number":35,"context_line":"\tglobal _FLASHNAME"},{"line_number":36,"context_line":"\tpld load $chain_id $proxy_bit"}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"7e632db6_da2568b2","line":33,"updated":"2023-05-11 12:03:55.000000000","message":"Could ever exist the command \"0x00\" ?\nIn case yes, then here you can either default to \"-1\" or to a string, e.g. \"no\". TCL considers everything as a string and converts it, eventually, to a numeric value","commit_id":"7172a89e4f089c0899408d24d9ab1a5357496116"},{"author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"change_message_id":"11b3c9d588ed321ade52de9c28e949fa72d82136","unresolved":false,"context_lines":[{"line_number":30,"context_line":"#                            ex: 0xAB to release from power-dowm."},{"line_number":31,"context_line":"#                            Juts omit to not send a command."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"proc jtagspi_init {chain_id proxy_bit {release_from_pwr_down_cmd 0}} {"},{"line_number":34,"context_line":"\t# load proxy bitstream $proxy_bit and probe spi flash"},{"line_number":35,"context_line":"\tglobal _FLASHNAME"},{"line_number":36,"context_line":"\tpld load $chain_id $proxy_bit"}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"adc00bc4_4bafd73b","line":33,"in_reply_to":"02bf17dc_21d7375f","updated":"2023-05-17 08:27:02.000000000","message":"Ack","commit_id":"7172a89e4f089c0899408d24d9ab1a5357496116"},{"author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"change_message_id":"5b8b0f9065309936aa64120a08d41a1092ef3982","unresolved":true,"context_lines":[{"line_number":30,"context_line":"#                            ex: 0xAB to release from power-dowm."},{"line_number":31,"context_line":"#                            Juts omit to not send a command."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"proc jtagspi_init {chain_id proxy_bit {release_from_pwr_down_cmd 0}} {"},{"line_number":34,"context_line":"\t# load proxy bitstream $proxy_bit and probe spi flash"},{"line_number":35,"context_line":"\tglobal _FLASHNAME"},{"line_number":36,"context_line":"\tpld load $chain_id $proxy_bit"}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"1a9e8192_15fe8688","line":33,"in_reply_to":"19bccebd_e4b5e576","updated":"2023-05-14 19:40:01.000000000","message":"I\u0027m not sure about this one, because the coupling between the two is quite loose. If someone \"fixes\" spi.h based driver, this will be forgotten for sure. Also because this is in a tcl script not referencing spi.h.\nWith \u0027-1\u0027 it will continue to work afterwards.","commit_id":"7172a89e4f089c0899408d24d9ab1a5357496116"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"5db25cf93f93d56a00ab08bd07f526f5b3c53ff7","unresolved":true,"context_lines":[{"line_number":30,"context_line":"#                            ex: 0xAB to release from power-dowm."},{"line_number":31,"context_line":"#                            Juts omit to not send a command."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"proc jtagspi_init {chain_id proxy_bit {release_from_pwr_down_cmd 0}} {"},{"line_number":34,"context_line":"\t# load proxy bitstream $proxy_bit and probe spi flash"},{"line_number":35,"context_line":"\tglobal _FLASHNAME"},{"line_number":36,"context_line":"\tpld load $chain_id $proxy_bit"}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"02bf17dc_21d7375f","line":33,"in_reply_to":"1a9e8192_15fe8688","updated":"2023-05-17 08:05:58.000000000","message":"Thanks for the feedback, both relevant.\nIn any case \u0027-1\u0027 works fine, so I think this patch can go on.","commit_id":"7172a89e4f089c0899408d24d9ab1a5357496116"},{"author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"change_message_id":"1c085fed224d8058ea799756f1d0100525533254","unresolved":false,"context_lines":[{"line_number":30,"context_line":"#                            ex: 0xAB to release from power-dowm."},{"line_number":31,"context_line":"#                            Juts omit to not send a command."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"proc jtagspi_init {chain_id proxy_bit {release_from_pwr_down_cmd 0}} {"},{"line_number":34,"context_line":"\t# load proxy bitstream $proxy_bit and probe spi flash"},{"line_number":35,"context_line":"\tglobal _FLASHNAME"},{"line_number":36,"context_line":"\tpld load $chain_id $proxy_bit"}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"ae1c8268_274ec7b9","line":33,"in_reply_to":"7e632db6_da2568b2","updated":"2023-05-11 22:36:50.000000000","message":"Done","commit_id":"7172a89e4f089c0899408d24d9ab1a5357496116"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"cc7c81411917cdfc84d060709b18baa686fbce8d","unresolved":true,"context_lines":[{"line_number":30,"context_line":"#                            ex: 0xAB to release from power-dowm."},{"line_number":31,"context_line":"#                            Juts omit to not send a command."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"proc jtagspi_init {chain_id proxy_bit {release_from_pwr_down_cmd 0}} {"},{"line_number":34,"context_line":"\t# load proxy bitstream $proxy_bit and probe spi flash"},{"line_number":35,"context_line":"\tglobal _FLASHNAME"},{"line_number":36,"context_line":"\tpld load $chain_id $proxy_bit"}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"19bccebd_e4b5e576","line":33,"in_reply_to":"ae1c8268_274ec7b9","updated":"2023-05-12 04:57:05.000000000","message":"Antonio, just FYI: configurable commands in struct flash_device in spi.h have also zero value reserved as \"cmd not implemented\". So pure theoretically yes, there could be a device with \"0x00\" command but in practice we never seen any.\nI would prefer homogeneous use of 0, the same value both here and in spi.h based drivers.","commit_id":"7172a89e4f089c0899408d24d9ab1a5357496116"}]}