)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"e607d34301f43e2e4ef6454dd767b5b456d3c83d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"fd87a20b_6405da01","updated":"2023-01-07 23:13:04.000000000","message":"Thanks for your patch.\nI\u0027m not very comfortable at reviewing this svf code. I would wait for other maintainers to add their comments.\nIn mean time, some minor comment below","commit_id":"91e2c8a7bb80cff2d0c0f3f925f5e719e556fdb3"},{"author":{"_account_id":1002108,"name":"kaischmitzAdv","email":"kai.schmitz@advantest.com","username":"kaischmitzAdv"},"change_message_id":"139c48b199cf6ccb6de200c0e3faf9cbdee94533","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"8a4fe933_4c308321","updated":"2023-02-09 22:29:30.000000000","message":"Hi Antonio, have you been able to identify a maintainer to look at this change?","commit_id":"de4029898fe7a88fd400ee317c9e05d7016660ea"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3e32f1b371d81072ae4edcaa61e2589b1df4ef24","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ff5ca373_f67185a1","updated":"2023-03-10 09:11:55.000000000","message":"Sorry for taking so long time to return on this.\nIn mean time nobody else reviewed it, so it means there is no objections and can be merged.\nI only have some minor update to align the documentation to the code, then it would be ready.","commit_id":"de4029898fe7a88fd400ee317c9e05d7016660ea"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"1834a91c71fbd9b0f8e4a3f3e57fea9968623321","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"4b0be083_71c029b2","updated":"2023-03-10 11:53:36.000000000","message":"Thanks","commit_id":"b74c9d1787fa3b4c73852a73657f1e5d7443fc2d"},{"author":{"_account_id":1002108,"name":"kaischmitzAdv","email":"kai.schmitz@advantest.com","username":"kaischmitzAdv"},"change_message_id":"41202a9db2f1f06e31e7a3d5cc4273b891663d13","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"56cdbaef_ec96390c","in_reply_to":"4b0be083_71c029b2","updated":"2023-03-16 15:12:23.000000000","message":"\u003e Thanks\nCan you give a +2 for this change, I assume it won\u0027t merge otherwise?","commit_id":"b74c9d1787fa3b4c73852a73657f1e5d7443fc2d"}],"doc/openocd.texi":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"e607d34301f43e2e4ef6454dd767b5b456d3c83d","unresolved":true,"context_lines":[{"line_number":11427,"context_line":""},{"line_number":11428,"context_line":"@deffn {Command} {svf} @file{filename} [@option{-tap @var{tapname}}] [@option{[-]quiet}] @"},{"line_number":11429,"context_line":"                     [@option{[-]nil}] [@option{[-]progress}] [@option{[-]ignore_error}] @"},{"line_number":11430,"context_line":"                     [@option{[-]noreset}] [@option{-addcycles @var{cyclecount}}]"},{"line_number":11431,"context_line":"This issues a JTAG reset (Test-Logic-Reset) and then"},{"line_number":11432,"context_line":"runs the SVF script from @file{filename}."},{"line_number":11433,"context_line":""}],"source_content_type":"text/x-texinfo","patch_set":4,"id":"ee07fcbd_f4b640d1","line":11430,"updated":"2023-01-07 23:13:04.000000000","message":"odd! this is the only command that handles some of its options with and without the \u0027-\u0027!\nOne day this command has to be aligned with the rest of OpenOCD.\nWould you mind using only \u0027-noreset\u0027 in your patch?\n\u0027-addcycles\u0027 is already ok.","commit_id":"91e2c8a7bb80cff2d0c0f3f925f5e719e556fdb3"},{"author":{"_account_id":1002108,"name":"kaischmitzAdv","email":"kai.schmitz@advantest.com","username":"kaischmitzAdv"},"change_message_id":"26935fc4b460ef1bd5eb9dae39c0d33aa7ff617d","unresolved":false,"context_lines":[{"line_number":11427,"context_line":""},{"line_number":11428,"context_line":"@deffn {Command} {svf} @file{filename} [@option{-tap @var{tapname}}] [@option{[-]quiet}] @"},{"line_number":11429,"context_line":"                     [@option{[-]nil}] [@option{[-]progress}] [@option{[-]ignore_error}] @"},{"line_number":11430,"context_line":"                     [@option{[-]noreset}] [@option{-addcycles @var{cyclecount}}]"},{"line_number":11431,"context_line":"This issues a JTAG reset (Test-Logic-Reset) and then"},{"line_number":11432,"context_line":"runs the SVF script from @file{filename}."},{"line_number":11433,"context_line":""}],"source_content_type":"text/x-texinfo","patch_set":4,"id":"afde0170_e95e1fae","line":11430,"in_reply_to":"ee07fcbd_f4b640d1","updated":"2023-01-09 11:10:30.000000000","message":"Sure no problem. Tried to blend in as much as possible but also find this a bit odd.","commit_id":"91e2c8a7bb80cff2d0c0f3f925f5e719e556fdb3"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3e32f1b371d81072ae4edcaa61e2589b1df4ef24","unresolved":true,"context_lines":[{"line_number":11427,"context_line":""},{"line_number":11428,"context_line":"@deffn {Command} {svf} @file{filename} [@option{-tap @var{tapname}}] [@option{[-]quiet}] @"},{"line_number":11429,"context_line":"                     [@option{[-]nil}] [@option{[-]progress}] [@option{[-]ignore_error}] @"},{"line_number":11430,"context_line":"                     [@option{[-]noreset}] [@option{-addcycles @var{cyclecount}}]"},{"line_number":11431,"context_line":"This issues a JTAG reset (Test-Logic-Reset) and then"},{"line_number":11432,"context_line":"runs the SVF script from @file{filename}."},{"line_number":11433,"context_line":""}],"source_content_type":"text/x-texinfo","patch_set":5,"id":"6f863537_4aaeac49","line":11430,"updated":"2023-03-10 09:11:55.000000000","message":"please also remove the square brackets around \u0027-\u0027 before \u0027noreset\u0027, as now the only format of the flag is \u0027-noreset\u0027","commit_id":"de4029898fe7a88fd400ee317c9e05d7016660ea"},{"author":{"_account_id":1002108,"name":"kaischmitzAdv","email":"kai.schmitz@advantest.com","username":"kaischmitzAdv"},"change_message_id":"b06db0644fade34fc14a4a826aac1a28191d4477","unresolved":false,"context_lines":[{"line_number":11427,"context_line":""},{"line_number":11428,"context_line":"@deffn {Command} {svf} @file{filename} [@option{-tap @var{tapname}}] [@option{[-]quiet}] @"},{"line_number":11429,"context_line":"                     [@option{[-]nil}] [@option{[-]progress}] [@option{[-]ignore_error}] @"},{"line_number":11430,"context_line":"                     [@option{[-]noreset}] [@option{-addcycles @var{cyclecount}}]"},{"line_number":11431,"context_line":"This issues a JTAG reset (Test-Logic-Reset) and then"},{"line_number":11432,"context_line":"runs the SVF script from @file{filename}."},{"line_number":11433,"context_line":""}],"source_content_type":"text/x-texinfo","patch_set":5,"id":"6aee0015_17ffe851","line":11430,"in_reply_to":"6f863537_4aaeac49","updated":"2023-03-10 11:34:12.000000000","message":"Done","commit_id":"de4029898fe7a88fd400ee317c9e05d7016660ea"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3e32f1b371d81072ae4edcaa61e2589b1df4ef24","unresolved":true,"context_lines":[{"line_number":11446,"context_line":"@item @option{[-]progress} enable progress indication;"},{"line_number":11447,"context_line":"@item @option{[-]ignore_error} continue execution despite TDO check"},{"line_number":11448,"context_line":"errors."},{"line_number":11449,"context_line":"@item @option{[-]noreset} ommit JTAG reset (Test-Logic-Reset) before executing"},{"line_number":11450,"context_line":"content of the SVF file;"},{"line_number":11451,"context_line":"@item @option{-addcycles @var{cyclecount}} inject @var{cyclecount} number of"},{"line_number":11452,"context_line":"additional TCLK cycles after each SDR scan instruction;"}],"source_content_type":"text/x-texinfo","patch_set":5,"id":"26f8d7a6_8ffb0fc9","line":11449,"updated":"2023-03-10 09:11:55.000000000","message":"here too, remove the square brackets.\nI think the correct spelling is \u0027omit\u0027","commit_id":"de4029898fe7a88fd400ee317c9e05d7016660ea"},{"author":{"_account_id":1002108,"name":"kaischmitzAdv","email":"kai.schmitz@advantest.com","username":"kaischmitzAdv"},"change_message_id":"b06db0644fade34fc14a4a826aac1a28191d4477","unresolved":false,"context_lines":[{"line_number":11446,"context_line":"@item @option{[-]progress} enable progress indication;"},{"line_number":11447,"context_line":"@item @option{[-]ignore_error} continue execution despite TDO check"},{"line_number":11448,"context_line":"errors."},{"line_number":11449,"context_line":"@item @option{[-]noreset} ommit JTAG reset (Test-Logic-Reset) before executing"},{"line_number":11450,"context_line":"content of the SVF file;"},{"line_number":11451,"context_line":"@item @option{-addcycles @var{cyclecount}} inject @var{cyclecount} number of"},{"line_number":11452,"context_line":"additional TCLK cycles after each SDR scan instruction;"}],"source_content_type":"text/x-texinfo","patch_set":5,"id":"ee157f05_4a97b0c1","line":11449,"in_reply_to":"26f8d7a6_8ffb0fc9","updated":"2023-03-10 11:34:12.000000000","message":"Done","commit_id":"de4029898fe7a88fd400ee317c9e05d7016660ea"}],"src/svf/svf.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"e607d34301f43e2e4ef6454dd767b5b456d3c83d","unresolved":true,"context_lines":[{"line_number":223,"context_line":"static int svf_quiet;"},{"line_number":224,"context_line":"static int svf_nil;"},{"line_number":225,"context_line":"static int svf_ignore_error;"},{"line_number":226,"context_line":"static int svf_noreset;"},{"line_number":227,"context_line":"static int svf_addcycles;"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"/* Targeting particular tap */"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"f081b579_1f5c1de7","line":226,"updated":"2023-01-07 23:13:04.000000000","message":"what about type bool?\nOf course, adding \u003cstdbool.h\u003e on top","commit_id":"91e2c8a7bb80cff2d0c0f3f925f5e719e556fdb3"},{"author":{"_account_id":1002108,"name":"kaischmitzAdv","email":"kai.schmitz@advantest.com","username":"kaischmitzAdv"},"change_message_id":"26935fc4b460ef1bd5eb9dae39c0d33aa7ff617d","unresolved":false,"context_lines":[{"line_number":223,"context_line":"static int svf_quiet;"},{"line_number":224,"context_line":"static int svf_nil;"},{"line_number":225,"context_line":"static int svf_ignore_error;"},{"line_number":226,"context_line":"static int svf_noreset;"},{"line_number":227,"context_line":"static int svf_addcycles;"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"/* Targeting particular tap */"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"9be5afab_71a940c1","line":226,"in_reply_to":"f081b579_1f5c1de7","updated":"2023-01-09 11:10:30.000000000","message":"Ack","commit_id":"91e2c8a7bb80cff2d0c0f3f925f5e719e556fdb3"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"e607d34301f43e2e4ef6454dd767b5b456d3c83d","unresolved":true,"context_lines":[{"line_number":1566,"context_line":"\t\t.handler \u003d handle_svf_command,"},{"line_number":1567,"context_line":"\t\t.mode \u003d COMMAND_EXEC,"},{"line_number":1568,"context_line":"\t\t.help \u003d \"Runs a SVF file.\","},{"line_number":1569,"context_line":"\t\t.usage \u003d \"[-tap device.tap] \u003cfile\u003e [quiet] [nil] [progress] [ignore_error]\","},{"line_number":1570,"context_line":"\t},"},{"line_number":1571,"context_line":"\tCOMMAND_REGISTRATION_DONE"},{"line_number":1572,"context_line":"};"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"c592c1ea_ea707fc1","line":1569,"updated":"2023-01-07 23:13:04.000000000","message":"please update the usage.","commit_id":"91e2c8a7bb80cff2d0c0f3f925f5e719e556fdb3"},{"author":{"_account_id":1002108,"name":"kaischmitzAdv","email":"kai.schmitz@advantest.com","username":"kaischmitzAdv"},"change_message_id":"26935fc4b460ef1bd5eb9dae39c0d33aa7ff617d","unresolved":false,"context_lines":[{"line_number":1566,"context_line":"\t\t.handler \u003d handle_svf_command,"},{"line_number":1567,"context_line":"\t\t.mode \u003d COMMAND_EXEC,"},{"line_number":1568,"context_line":"\t\t.help \u003d \"Runs a SVF file.\","},{"line_number":1569,"context_line":"\t\t.usage \u003d \"[-tap device.tap] \u003cfile\u003e [quiet] [nil] [progress] [ignore_error]\","},{"line_number":1570,"context_line":"\t},"},{"line_number":1571,"context_line":"\tCOMMAND_REGISTRATION_DONE"},{"line_number":1572,"context_line":"};"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"fbb7bd42_1a81484a","line":1569,"in_reply_to":"c592c1ea_ea707fc1","updated":"2023-01-09 11:10:30.000000000","message":"Ack","commit_id":"91e2c8a7bb80cff2d0c0f3f925f5e719e556fdb3"}]}