)]}'
{"id":"openocd~master~I89ae943e77036206d40d4d54172cd4a73e76e5c5","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2023-01-11 17:02:38.000000000","reason":"removed on reply"},"1001964":{"account":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"last_update":"2023-01-07 10:34:37.000000000","reason":"Erhan Kurubas replied on the change"}},"hashtags":[],"change_id":"I89ae943e77036206d40d4d54172cd4a73e76e5c5","subject":"jtag: esp_usb_jtag: remove macro __packed","status":"MERGED","created":"2023-01-06 22:51:12.000000000","updated":"2023-01-11 17:02:44.000000000","submitted":"2023-01-11 17:02:44.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7435","meta_rev_id":"3349d1a72807e0e425b9a77dbb1d0a1683116a83","_number":7435,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-01-11 17:02:44.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"value":0,"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-01-11 17:02:44.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-01-11 17:02:44.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-01-06 22:51:12.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"state":"REVIEWER"},{"updated":"2023-01-06 23:41:57.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"4316340d397e0e5d45e41bda1a97431782c2a0b7","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-01-06 22:51:12.000000000","message":"Uploaded patch set 1: Code-Review+1.","accounts_in_message":[],"_revision_number":1},{"id":"cc7ab1f0b05c86283e7da53c8261dcfbde45eecc","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-01-06 23:41:57.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/17296/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/16498/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"e9947cabb78ccf6f70dd062b10796254474ec307","author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"real_author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"date":"2023-01-07 10:34:37.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"c976f9740dbda1b3f07db7906928cc7b196dede8","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-01-11 17:02:38.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"3349d1a72807e0e425b9a77dbb1d0a1683116a83","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-01-11 17:02:44.000000000","message":"Change has been successfully cherry-picked as d92ebb5ab43f6c6a900c6beb0bc426573058c359","accounts_in_message":[],"_revision_number":2}],"current_revision":"d92ebb5ab43f6c6a900c6beb0bc426573058c359","revisions":{"33e0bf1ed814d806a75b141775bbfe5d9887846a":{"kind":"REWORK","_number":1,"created":"2023-01-06 22:51:12.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/35/7435/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/35/7435/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/35/7435/1 \u0026\u0026 git checkout -b change-7435 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/35/7435/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/35/7435/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/35/7435/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/35/7435/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/35/7435/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"dfe57baa16cdbc0dc2ae7182b5b3831028637223","subject":"Restore +dev suffix"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-01-06 11:40:01.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-01-06 22:43:04.000000000","tz":60},"subject":"jtag: esp_usb_jtag: remove macro __packed","message":"jtag: esp_usb_jtag: remove macro __packed\n\nIn FreeBSB 13.0 the build fails due to redefined macro __packed.\n\n\tsrc/jtag/drivers/esp_usb_jtag.c:19:9: error: \u0027__packed\u0027 macro\n\t    redefined [-Werror,-Wmacro-redefined]\n\t#define __packed __attribute__((packed))\n\t        ^\n\t/usr/include/sys/cdefs.h:223:9: note: previous definition is here\n\t#define __packed        __attribute__((__packed__))\n\t        ^\n\t1 error generated.\n\nDrop the macro and align the code with the other files in OpenOCD\nproject, where the attribute is directly applied without using a\nmacro.\n\nChange-Id: I89ae943e77036206d40d4d54172cd4a73e76e5c5\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReported-by: Wojciech Puchar \u003cwojtek@puchar.net\u003e\n"}},"d92ebb5ab43f6c6a900c6beb0bc426573058c359":{"kind":"REWORK","_number":2,"created":"2023-01-11 17:02:44.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/35/7435/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/35/7435/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/35/7435/2 \u0026\u0026 git checkout -b change-7435 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/35/7435/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/35/7435/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/35/7435/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/35/7435/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/35/7435/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7dd5b6a4645cf0ce9c635a7fc8b140575385c827","subject":"rtt: fix corner-cases of finding control block"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-01-06 11:40:01.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-01-11 17:02:44.000000000","tz":0},"subject":"jtag: esp_usb_jtag: remove macro __packed","message":"jtag: esp_usb_jtag: remove macro __packed\n\nIn FreeBSB 13.0 the build fails due to redefined macro __packed.\n\n\tsrc/jtag/drivers/esp_usb_jtag.c:19:9: error: \u0027__packed\u0027 macro\n\t    redefined [-Werror,-Wmacro-redefined]\n\t#define __packed __attribute__((packed))\n\t        ^\n\t/usr/include/sys/cdefs.h:223:9: note: previous definition is here\n\t#define __packed        __attribute__((__packed__))\n\t        ^\n\t1 error generated.\n\nDrop the macro and align the code with the other files in OpenOCD\nproject, where the attribute is directly applied without using a\nmacro.\n\nChange-Id: I89ae943e77036206d40d4d54172cd4a73e76e5c5\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReported-by: Wojciech Puchar \u003cwojtek@puchar.net\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7435\nTested-by: jenkins\nReviewed-by: Erhan Kurubas \u003cerhan.kurubas@espressif.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}