)]}'
{"id":"openocd~master~I705f72d83e374c8dd700baaa0c0bbe041f153605","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000160":{"account":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"last_update":"2023-01-14 20:05:57.000000000","reason":"removed on reply"},"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2023-01-14 20:06:11.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I705f72d83e374c8dd700baaa0c0bbe041f153605","subject":"configure.ac: fix check for jimtcl submodule","status":"MERGED","created":"2023-01-14 14:35:55.000000000","updated":"2023-01-14 20:06:11.000000000","submitted":"2023-01-14 20:06:11.000000000","submitter":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7437","meta_rev_id":"474709746b45c5c7f2786bb8cb56b3a7a91d54c0","_number":7437,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-01-14 20:06:11.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-01-14 20:06:11.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-01-14 14:35:55.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"state":"REVIEWER"},{"updated":"2023-01-14 15:31:37.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"4d3b47442613f77ae22eb8efdb33f4795b387f35","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-01-14 14:35:55.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ea4c4d73be7eeb941837d85ccb7616281eccf4c8","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-01-14 15:31:37.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16513/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/17311/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"dedb97642299144862a04721dc17ed158eeb1e1f","author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"real_author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"date":"2023-01-14 20:05:57.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"474709746b45c5c7f2786bb8cb56b3a7a91d54c0","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"real_author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"date":"2023-01-14 20:06:11.000000000","message":"Change has been successfully cherry-picked as f71b5f5a37fde4b22cd8eb379c2bc8454c636145","accounts_in_message":[],"_revision_number":2}],"current_revision":"f71b5f5a37fde4b22cd8eb379c2bc8454c636145","revisions":{"1ecc7e89e5136e7344d5cf49ccd20c0cf82cdbd3":{"kind":"REWORK","_number":1,"created":"2023-01-14 14:35:55.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/37/7437/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/37/7437/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/37/7437/1 \u0026\u0026 git checkout -b change-7437 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/37/7437/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/37/7437/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/37/7437/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/37/7437/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/37/7437/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d92ebb5ab43f6c6a900c6beb0bc426573058c359","subject":"jtag: esp_usb_jtag: remove macro __packed"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-01-14 14:18:02.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-01-14 14:34:21.000000000","tz":60},"subject":"configure.ac: fix check for jimtcl submodule","message":"configure.ac: fix check for jimtcl submodule\n\nThe file configure.ac checks if jimtcl submodule is present by\nlooking for the file jimtcl/configure.ac .\nBut jimtcl has switched to its own build system in 2011 and thus\ndropped configure.ac . This cause a build issue on OpenOCD that\nwas incorrectly fixed by adding a dummy configure.ac in jimtcl.\n\nFix OpenOCD configure.ac to look for the correct file\njimtcl/configure .\nAfter this fix, another fix would be proposed to jimtcl to drop\nits useless dummy file configure.ac .\n\nChange-Id: I705f72d83e374c8dd700baaa0c0bbe041f153605\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReported-by: Paul Fertser \u003cfercerpav@gmail.com\u003e\n"}},"f71b5f5a37fde4b22cd8eb379c2bc8454c636145":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2023-01-14 20:06:11.000000000","uploader":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"ref":"refs/changes/37/7437/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/37/7437/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/37/7437/2 \u0026\u0026 git checkout -b change-7437 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/37/7437/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/37/7437/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/37/7437/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/37/7437/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/37/7437/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d92ebb5ab43f6c6a900c6beb0bc426573058c359","subject":"jtag: esp_usb_jtag: remove macro __packed"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-01-14 14:18:02.000000000","tz":60},"committer":{"name":"Paul Fertser","email":"fercerpav@gmail.com","date":"2023-01-14 20:06:11.000000000","tz":0},"subject":"configure.ac: fix check for jimtcl submodule","message":"configure.ac: fix check for jimtcl submodule\n\nThe file configure.ac checks if jimtcl submodule is present by\nlooking for the file jimtcl/configure.ac .\nBut jimtcl has switched to its own build system in 2011 and thus\ndropped configure.ac . This cause a build issue on OpenOCD that\nwas incorrectly fixed by adding a dummy configure.ac in jimtcl.\n\nFix OpenOCD configure.ac to look for the correct file\njimtcl/configure .\nAfter this fix, another fix would be proposed to jimtcl to drop\nits useless dummy file configure.ac .\n\nChange-Id: I705f72d83e374c8dd700baaa0c0bbe041f153605\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReported-by: Paul Fertser \u003cfercerpav@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7437\nTested-by: jenkins\nReviewed-by: Paul Fertser \u003cfercerpav@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}