)]}'
{"id":"openocd~master~Ib2482a671cc98cddec8eff7f1cb2720d93fa0910","project":"openocd","branch":"master","attention_set":{"1000160":{"account":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"last_update":"2023-01-28 23:51:45.000000000","reason":"Antonio Borneo replied on the change"},"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2023-01-29 05:29:18.000000000","reason":"Xiaofan Chen replied on the change"},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2023-01-28 23:51:45.000000000","reason":"Antonio Borneo replied on the change"}},"removed_from_attention_set":{"1000019":{"account":{"_account_id":1000019,"name":"Xiaofan Chen","email":"xiaofanc@gmail.com","username":"xiaofan"},"last_update":"2023-01-29 05:29:18.000000000","reason":"Xiaofan Chen replied on the change"}},"hashtags":[],"change_id":"Ib2482a671cc98cddec8eff7f1cb2720d93fa0910","subject":"jtag: drivers: fix for libusb API change","status":"NEW","created":"2023-01-28 22:14:12.000000000","updated":"2023-03-12 14:09:50.000000000","submit_type":"CHERRY_PICK","submittable":false,"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"34bf2b542d7f43de373ef7c0bbc215c82fb4650c","_number":7467,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"_account_id":1000019,"name":"Xiaofan Chen","email":"xiaofanc@gmail.com","username":"xiaofan"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":1,"date":"2023-01-28 23:51:48.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"recommended":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"disliked":{"_account_id":1000019,"name":"Xiaofan Chen","email":"xiaofanc@gmail.com","username":"xiaofan"},"all":[{"value":-1,"date":"2023-03-12 14:09:50.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1000019,"name":"Xiaofan Chen","email":"xiaofanc@gmail.com","username":"xiaofan"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},{"value":1,"date":"2023-01-28 23:51:45.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","value":-1,"default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000019,"name":"Xiaofan Chen","email":"xiaofanc@gmail.com","username":"xiaofan"},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-01-28 22:19:17.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-01-28 23:51:45.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"},{"updated":"2023-01-28 23:51:45.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"state":"REVIEWER"},{"updated":"2023-01-28 23:51:45.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000019,"name":"Xiaofan Chen","email":"xiaofanc@gmail.com","username":"xiaofan"},"state":"REVIEWER"}],"messages":[{"id":"cb0a1b98c072b50c175851c8023a10cfe0e49b19","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-01-28 22:14:12.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"5f924bab39a0a39d396d88a2462291aeded61065","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-01-28 22:19:17.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16552/ : FAILURE\n\nhttps://build.openocd.org/job/openocd-gerrit/17350/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"8aca0eba64ed45be381ed9770f66550ed0422894","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-01-28 23:23:51.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"3398d391ab78977f2a72b4594be31fd0e2cc4a60","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-01-28 23:51:45.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"967b451a5831d2cd98f6e2581ea0e6c97df12c12","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-01-28 23:51:48.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16553/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/17351/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"ae2ce12f66efe6a5ee0273bcf47f45dfeed40b58","author":{"_account_id":1000019,"name":"Xiaofan Chen","email":"xiaofanc@gmail.com","username":"xiaofan"},"real_author":{"_account_id":1000019,"name":"Xiaofan Chen","email":"xiaofanc@gmail.com","username":"xiaofan"},"date":"2023-01-29 05:29:18.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"9ad1f743c64ac5335d30ef7965a68dbd146a1e60","author":{"_account_id":1000019,"name":"Xiaofan Chen","email":"xiaofanc@gmail.com","username":"xiaofan"},"real_author":{"_account_id":1000019,"name":"Xiaofan Chen","email":"xiaofanc@gmail.com","username":"xiaofan"},"date":"2023-01-29 05:32:45.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"34bf2b542d7f43de373ef7c0bbc215c82fb4650c","author":{"_account_id":1000019,"name":"Xiaofan Chen","email":"xiaofanc@gmail.com","username":"xiaofan"},"real_author":{"_account_id":1000019,"name":"Xiaofan Chen","email":"xiaofanc@gmail.com","username":"xiaofan"},"date":"2023-03-12 14:09:50.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2}],"current_revision":"e309eccb6ea799513b2bdfd66adaf531b8afe8d8","revisions":{"e89afee044c43b2a3de09f91a6c86261341b9354":{"kind":"REWORK","_number":1,"created":"2023-01-28 22:14:12.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/67/7467/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/67/7467/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/67/7467/1 \u0026\u0026 git checkout -b change-7467 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/67/7467/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/67/7467/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/67/7467/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/67/7467/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/67/7467/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"0b6f53e94cd81ee9c85ddc122004fa403b9cc454","subject":"tcl/target: add rescue mode to RP2040 config"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-01-28 21:28:51.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-01-28 21:28:51.000000000","tz":60},"subject":"jtag: drivers: fix for libusb API change","message":"jtag: drivers: fix for libusb API change\n\nDuring the development phase for next libusb v1.0.27, some API of\nlibusb has changed, marking as deprecated the obsoleted API.\nDue to such libusb change, OpenOCD build fails with a warning on\nthe deprecated API.\n\nUse the new API in the code, detect the API change through the\nmacro LIBUSB_API_VERSION and provide a safe fallback for old\nlibusb versions.\n\nChange-Id: Ib2482a671cc98cddec8eff7f1cb2720d93fa0910\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReported-by: Xiaofan Chen \u003cxiaofanc@gmail.com\u003e\nFixes: https://github.com/libusb/libusb/issues/1236\n"}},"e309eccb6ea799513b2bdfd66adaf531b8afe8d8":{"kind":"REWORK","_number":2,"created":"2023-01-28 23:23:51.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/67/7467/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/67/7467/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/67/7467/2 \u0026\u0026 git checkout -b change-7467 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/67/7467/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/67/7467/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/67/7467/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/67/7467/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/67/7467/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"0b6f53e94cd81ee9c85ddc122004fa403b9cc454","subject":"tcl/target: add rescue mode to RP2040 config"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-01-28 21:28:51.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-01-28 23:23:12.000000000","tz":60},"subject":"jtag: drivers: fix for libusb API change","message":"jtag: drivers: fix for libusb API change\n\nDuring the development phase for next libusb v1.0.27, some API of\nlibusb has changed, marking as deprecated the obsoleted API.\nDue to such libusb change, OpenOCD build fails with a warning on\nthe deprecated API.\n\nUse the new API in the code, detect the API change through the\nmacro LIBUSB_API_VERSION and provide a safe fallback for old\nlibusb versions.\n\nChange-Id: Ib2482a671cc98cddec8eff7f1cb2720d93fa0910\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReported-by: Xiaofan Chen \u003cxiaofanc@gmail.com\u003e\nFixes: https://github.com/libusb/libusb/issues/1236\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"NOT_READY","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"NEED"}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"UNSATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"]}}]}