)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b6a24ea18e0bd714d50eebe3c935be10fdc4ed6e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ce4e4162_45eff795","updated":"2023-02-07 22:37:03.000000000","message":"Andreas, I\u0027m unable to really review this patch, but I have two questions below","commit_id":"0ac80b51109a835110347fce5c9d466dad8d3af1"},{"author":{"_account_id":1001036,"name":"Andreas Bolsch","email":"hyphen0break@gmail.com","username":"abmero"},"change_message_id":"b3ac7594221c655b11aadeddb87ef118f5229ae2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"98803fd4_e7a97f08","updated":"2023-02-15 14:16:18.000000000","message":"Thanks for the remarks, Antonio. These new octal device families are still not that widespread, so it\u0027s clear that there is little chance for finding reviewers (and testers) soon. Maybe the patch could simply sit there as is until some demand pops up ...","commit_id":"0ac80b51109a835110347fce5c9d466dad8d3af1"}],"doc/openocd.texi":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b6a24ea18e0bd714d50eebe3c935be10fdc4ed6e","unresolved":true,"context_lines":[{"line_number":6053,"context_line":"In OPI mode the one/two byte command format is handled automatically."},{"line_number":6054,"context_line":""},{"line_number":6055,"context_line":"@deffn Command {stmqspi always_4byte} bank_id [ on | off ]"},{"line_number":6056,"context_line":"Some devices use 4-byte addresses for all commands except the legacy 0x03 read"},{"line_number":6057,"context_line":"regardless of device size. This command controls the corresponding hack,"},{"line_number":6058,"context_line":"defaults to \u0027off\u0027."},{"line_number":6059,"context_line":"@end deffn"}],"source_content_type":"text/x-texinfo","patch_set":2,"id":"5c104115_c60f2eb4","line":6056,"updated":"2023-02-07 22:37:03.000000000","message":"If this is specific for some device, could it be addressed by adding a flag in table struct flash_device flash_devices[] ?\nAdding a uint32_t flags as last field, we don\u0027t need to change the whole table but just add a bitfield to the device that need it\n  struct flash_device {\n    ...\n    uint32_t size_in_bytes;\n +  uint32_t flags;\n  };\n +#define ALWAYS_4BYTE BIT(0)\n +#define ANOTHER_CRAP BIT(1)\n\nthen, supposing this is the ugly device\n -  FLASH_ID(\"win w25q32fv\", ..., 0x400000),\n +  FLASH_ID(\"win w25q32fv\", ..., 0x400000, ALWAYS_4BYTE),","commit_id":"0ac80b51109a835110347fce5c9d466dad8d3af1"},{"author":{"_account_id":1001036,"name":"Andreas Bolsch","email":"hyphen0break@gmail.com","username":"abmero"},"change_message_id":"b3ac7594221c655b11aadeddb87ef118f5229ae2","unresolved":false,"context_lines":[{"line_number":6053,"context_line":"In OPI mode the one/two byte command format is handled automatically."},{"line_number":6054,"context_line":""},{"line_number":6055,"context_line":"@deffn Command {stmqspi always_4byte} bank_id [ on | off ]"},{"line_number":6056,"context_line":"Some devices use 4-byte addresses for all commands except the legacy 0x03 read"},{"line_number":6057,"context_line":"regardless of device size. This command controls the corresponding hack,"},{"line_number":6058,"context_line":"defaults to \u0027off\u0027."},{"line_number":6059,"context_line":"@end deffn"}],"source_content_type":"text/x-texinfo","patch_set":2,"id":"51035822_300dbbc9","line":6056,"in_reply_to":"5c104115_c60f2eb4","updated":"2023-02-15 14:16:18.000000000","message":"This particular \"defect\" could be handled that way, but anyway there should be a possibilty to override the setting: If the device is already in octal mode, it doesn\u0027t reply to Read ID at all ... So in this case all settings must be done manually (or one must switch to spi mode first).","commit_id":"0ac80b51109a835110347fce5c9d466dad8d3af1"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b6a24ea18e0bd714d50eebe3c935be10fdc4ed6e","unresolved":true,"context_lines":[{"line_number":6081,"context_line":"e.g. Read Status Reg. (0x05) and Read SPDP Data (0x5A) require varying address size"},{"line_number":6082,"context_line":"and dummy clocks, the drivers attempts to detect those automatically. The one/two byte"},{"line_number":6083,"context_line":"command format is handled automatically by @var{cmd}, however, (dummy) address bytes"},{"line_number":6084,"context_line":"are not. E.g. for MX25LM51245G in OPI mode Read Status Reg. must be done that way:"},{"line_number":6085,"context_line":"@example"},{"line_number":6086,"context_line":"stmqspi cmd bank_id 1 0x05 0x00 0x00 0x00 0x00"},{"line_number":6087,"context_line":"@end example"}],"source_content_type":"text/x-texinfo","patch_set":2,"id":"e3b93254_027a7fa2","line":6084,"updated":"2023-02-07 22:37:03.000000000","message":"also for this dummy address, can be handled automatically by adding a flag in struct flash_device?","commit_id":"0ac80b51109a835110347fce5c9d466dad8d3af1"},{"author":{"_account_id":1001036,"name":"Andreas Bolsch","email":"hyphen0break@gmail.com","username":"abmero"},"change_message_id":"b3ac7594221c655b11aadeddb87ef118f5229ae2","unresolved":false,"context_lines":[{"line_number":6081,"context_line":"e.g. Read Status Reg. (0x05) and Read SPDP Data (0x5A) require varying address size"},{"line_number":6082,"context_line":"and dummy clocks, the drivers attempts to detect those automatically. The one/two byte"},{"line_number":6083,"context_line":"command format is handled automatically by @var{cmd}, however, (dummy) address bytes"},{"line_number":6084,"context_line":"are not. E.g. for MX25LM51245G in OPI mode Read Status Reg. must be done that way:"},{"line_number":6085,"context_line":"@example"},{"line_number":6086,"context_line":"stmqspi cmd bank_id 1 0x05 0x00 0x00 0x00 0x00"},{"line_number":6087,"context_line":"@end example"}],"source_content_type":"text/x-texinfo","patch_set":2,"id":"c662c4d3_accf4e22","line":6084,"in_reply_to":"e3b93254_027a7fa2","updated":"2023-02-15 14:16:18.000000000","message":"Point is, according to datasheet the Read ID command needs 0x00000000 address and dummy clocks (In fact, the dummy address *seems* to be don\u0027t care, but ...). So we have to know these parameters in advance to identify the device. Moreover, the fancy S28HS devices allow separate adjustment of dummy clocks for this case (not to be confused with dummy clocks for ordinary memory reads). The heuristics built in works for the device families listed in commit msg., but of course there is no guarantee beyond that.","commit_id":"0ac80b51109a835110347fce5c9d466dad8d3af1"}]}