)]}'
{"id":"openocd~master~I6757c20fbfce923dd393083146e8d5a1f3b790b4","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2023-02-26 10:00:52.000000000","reason":"Change was submitted"},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2023-02-19 12:29:36.000000000","reason":"Tomas Vanek replied on the change"}},"hashtags":[],"change_id":"I6757c20fbfce923dd393083146e8d5a1f3b790b4","subject":"helper: command: drop last LF (\u0027\\n\u0027) from sequence of command_print()","status":"MERGED","created":"2023-02-03 23:35:48.000000000","updated":"2023-02-26 10:00:52.000000000","submitted":"2023-02-26 10:00:52.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7471","meta_rev_id":"dcc3ba0a601c11e1efa3110dd679f9d31e5b5bb9","_number":7471,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-02-26 10:00:52.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-02-26 10:00:52.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-02-26 10:00:52.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-02-04 00:19:22.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-02-18 18:17:11.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"}],"messages":[{"id":"43d864ec3dcb1255e4dae157a55e117ef024a614","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-02-03 23:35:48.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"84c166d31aa6341c124bc22e7836bf3f4c446328","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-02-04 00:19:22.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16564/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/17359/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"6a064a50e79922913d9b0c0130616fec4598169e","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-02-18 18:17:11.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"d2ce7ea5208d95cc13f83ead8d4060177fd3f64b","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-02-19 12:29:36.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"cb3f576b271d11223d4dfd9d75b6244ac21da2db","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-02-20 12:19:49.000000000","message":"Patch Set 1: -Code-Review\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"c85fc0fa556fd2d26a3d77b844222a6315a35f74","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-02-20 12:44:05.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"af22e8aeddd692609fb048ee09e85688af9dce4d","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-02-20 14:06:32.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16588/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/17384/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"ffcb5b8cd9ffa0ebc0f49a276cd7dd8b1f0097d7","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-02-20 14:28:01.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"652026a33247a9df95fbb518e9df9cd24f2b87b2","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-02-20 17:22:06.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"dcc3ba0a601c11e1efa3110dd679f9d31e5b5bb9","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-02-26 10:00:52.000000000","message":"Change has been successfully cherry-picked as c99c043f3f6e79e391debee29371360b0965b2d6","accounts_in_message":[],"_revision_number":3}],"current_revision":"c99c043f3f6e79e391debee29371360b0965b2d6","revisions":{"c99c043f3f6e79e391debee29371360b0965b2d6":{"kind":"REWORK","_number":3,"created":"2023-02-26 10:00:52.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/71/7471/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/71/7471/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/71/7471/3 \u0026\u0026 git checkout -b change-7471 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/71/7471/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/71/7471/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/71/7471/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/71/7471/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/71/7471/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"79caea8745284ac1d2e8931335b58c679cd11882","subject":"flash/nor/spi: add 25pe{10/20/40/80/16}"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-12-19 18:41:46.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-02-26 10:00:52.000000000","tz":0},"subject":"helper: command: drop last LF (\u0027\\n\u0027) from sequence of command_print()","message":"helper: command: drop last LF (\u0027\\n\u0027) from sequence of command_print()\n\nThe OpenOCD commands produce their TCL text result through the\npair command_print() and command_print_sameline().\nThe latter is used to concatenate output in a single line.\n\nAt the end of a sequence of command_print(), the last LF is taken\nas part of the command result, while it is not always needed, and\nit is even annoying when the output of two commands needs to be\nconcatenate in a single line.\n\nUsing command_print_sameline() in place of the last call to\ncommand_print() would solve the problem but it\u0027s quite expensive\nin term of coding to fix all the existing commands.\n\nDrop the last LF, if present.\nCommands that would specifically need a LF as last char, can add\nan extra LF at the end of the output.\nDocument this behavior in command.h.\n\nChange-Id: I6757c20fbfce923dd393083146e8d5a1f3b790b4\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7471\nTested-by: jenkins\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"b007414624f95b226bbd2c751fe7ea2ba67e02e6":{"kind":"REWORK","_number":2,"created":"2023-02-20 12:44:05.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/71/7471/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/71/7471/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/71/7471/2 \u0026\u0026 git checkout -b change-7471 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/71/7471/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/71/7471/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/71/7471/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/71/7471/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/71/7471/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1998b1e5a89e57b2d1109bc36d6af916106103ff","subject":"README: Remove statement about libjaylink Git submodule"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-12-19 18:41:46.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-02-20 12:43:05.000000000","tz":60},"subject":"helper: command: drop last LF (\u0027\\n\u0027) from sequence of command_print()","message":"helper: command: drop last LF (\u0027\\n\u0027) from sequence of command_print()\n\nThe OpenOCD commands produce their TCL text result through the\npair command_print() and command_print_sameline().\nThe latter is used to concatenate output in a single line.\n\nAt the end of a sequence of command_print(), the last LF is taken\nas part of the command result, while it is not always needed, and\nit is even annoying when the output of two commands needs to be\nconcatenate in a single line.\n\nUsing command_print_sameline() in place of the last call to\ncommand_print() would solve the problem but it\u0027s quite expensive\nin term of coding to fix all the existing commands.\n\nDrop the last LF, if present.\nCommands that would specifically need a LF as last char, can add\nan extra LF at the end of the output.\nDocument this behavior in command.h.\n\nChange-Id: I6757c20fbfce923dd393083146e8d5a1f3b790b4\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"5a42af73b4d60e6f76fd57de5a4d029c3f281f60":{"kind":"REWORK","_number":1,"created":"2023-02-03 23:35:48.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/71/7471/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/71/7471/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/71/7471/1 \u0026\u0026 git checkout -b change-7471 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/71/7471/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/71/7471/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/71/7471/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/71/7471/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/71/7471/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1998b1e5a89e57b2d1109bc36d6af916106103ff","subject":"README: Remove statement about libjaylink Git submodule"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-12-19 18:41:46.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-02-03 23:34:35.000000000","tz":60},"subject":"helper: command: drop last LF (\u0027\\n\u0027) from sequence of command_print()","message":"helper: command: drop last LF (\u0027\\n\u0027) from sequence of command_print()\n\nThe OpenOCD commands produce their TCL text result through the\npair command_print() and command_print_sameline().\nThe latter is used to concatenate output in a single line.\n\nAt the end of a sequence of command_print(), the last LF is taken\nas part of the command result, while it is not always needed, and\nit is even annoying when the output of two commands needs to be\nconcatenate in a single line.\n\nUsing command_print_sameline() in place of the last call to\ncommand_print() would solve the problem but it\u0027s quite expensive\nin term of coding to fix all the existing commands.\n\nDrop the last LF, if present.\nCommands that would specifically need a LF as last char, can add a\nsecond LF at the end of the output.\n\nChange-Id: I6757c20fbfce923dd393083146e8d5a1f3b790b4\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}