)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"change_message_id":"542f7858bf99a746b31a1007877376f6f4655d7b","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Jeremy Herbert \u003cjeremy.006@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-02-07 12:18:27 +1000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"bugfix/enhancement: add use_remote_sleep option to remote_bitbang"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If the remote_bitbang host does not execute requests immediately,"},{"line_number":10,"context_line":"delays performed inside OpenOCD can be lost. This option allows"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"6c90505e_cbbd6a48","line":7,"updated":"2023-02-15 14:09:43.000000000","message":"Detail: The typical convention for the commit messges is:\n\nremote_bitbang: \u003cdescribe what changed\u003e","commit_id":"0a92c514240e242d8c515cb75cfc03b6b73c3cd8"},{"author":{"_account_id":1002115,"name":"Jeremy Herbert","email":"jeremy.006@gmail.com","username":"jeremyherbert"},"change_message_id":"6c64990b38427ad06492180a74f92616193018ef","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Jeremy Herbert \u003cjeremy.006@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-02-07 12:18:27 +1000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"bugfix/enhancement: add use_remote_sleep option to remote_bitbang"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If the remote_bitbang host does not execute requests immediately,"},{"line_number":10,"context_line":"delays performed inside OpenOCD can be lost. This option allows"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"538565a1_d081dddd","line":7,"in_reply_to":"6c90505e_cbbd6a48","updated":"2023-02-16 02:20:10.000000000","message":"Done","commit_id":"0a92c514240e242d8c515cb75cfc03b6b73c3cd8"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"change_message_id":"542f7858bf99a746b31a1007877376f6f4655d7b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"dfdea635_d4ad9974","updated":"2023-02-15 14:09:43.000000000","message":"I like the idea of being able to communicate the delays to the remote host using remote_bitbang.\n\nI have checked the code visually and it looks all right.\n\nThank you.","commit_id":"0a92c514240e242d8c515cb75cfc03b6b73c3cd8"},{"author":{"_account_id":1002115,"name":"Jeremy Herbert","email":"jeremy.006@gmail.com","username":"jeremyherbert"},"change_message_id":"6c1b197060b70d145cd8c617e610f774beb6c75f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4dba19f1_a9da75c7","updated":"2023-02-07 02:27:49.000000000","message":"Just to add a little more explanation: \n\nI have a remote_bitbang host which accepts data faster than it can actually bitbang. When playing back an SVF file (to program an FPGA), this is a problem because the local openocd instance delays correctly, but since the host cannot execute the queued requests quick enough, the delay disappears. This causes a TDO check error while the device is restarting after being flashed.\n\nWith this option enabled, the flash is successful and no more TDO errors are present.\n\nIf it helps, I am flashing an ECP5 FPGA using the Glasgow interface explorer tool.\n\nThis is my first OpenOCD patch so please let me know if I have done anything silly - I will be happy to fix it.","commit_id":"0a92c514240e242d8c515cb75cfc03b6b73c3cd8"},{"author":{"_account_id":1002115,"name":"Jeremy Herbert","email":"jeremy.006@gmail.com","username":"jeremyherbert"},"change_message_id":"6c64990b38427ad06492180a74f92616193018ef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2b6414ad_1e97856e","in_reply_to":"4dba19f1_a9da75c7","updated":"2023-02-16 02:20:10.000000000","message":"Done","commit_id":"0a92c514240e242d8c515cb75cfc03b6b73c3cd8"},{"author":{"_account_id":1002115,"name":"Jeremy Herbert","email":"jeremy.006@gmail.com","username":"jeremyherbert"},"change_message_id":"6c64990b38427ad06492180a74f92616193018ef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"94db6d95_d93ba1bf","updated":"2023-02-16 02:20:10.000000000","message":"Thank you for the review and feedback. I have adjusted the patch as suggested. Please let me know if you see any other issues.","commit_id":"c5f5ea8a09992a0457bbf0f6b3913b60075b314a"},{"author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"change_message_id":"d606f52dbf85828129ca121f5a0442f598081759","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"0d2a034e_01c4799e","updated":"2023-02-16 06:59:23.000000000","message":"This looks fine (visual check).\n\nI have just one last cosmetic suggestion.","commit_id":"107511dfd66f537802bf45fd5dac37b5e6d55c7c"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"208059828f1e13ec5006ea025427178a2ba8a928","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"dedfa633_8519addc","updated":"2023-11-26 20:22:05.000000000","message":"Another point. For long delays we need to periodically call keep_alive() to prevent GDB to timeout.\nWhere to put the keep_alive()?\nIt doesn\u0027t make sense to put it inside remote_bitbang_sleep(), because this function just sends out a sequence of \u0027D\u0027 and \u0027d\u0027; the sequence is buffered by the network layer of the OS and dispatched later.\nI think the keep_alive() should go where the driver waits for a reply with socket_read(), but will not work in case of BLOCK. So some extra code rework is required.\nWould you please consider this in an additional patch, after this one is merged?","commit_id":"0b12c23b3d62972019084bc175fd04f01005c1fd"},{"author":{"_account_id":1002115,"name":"Jeremy Herbert","email":"jeremy.006@gmail.com","username":"jeremyherbert"},"change_message_id":"98dad0459fd6d63347826b7df3cdc7138dfb7fed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"8df20ff4_3b9a0f0b","updated":"2023-02-16 23:53:59.000000000","message":"Changed as requested.","commit_id":"0b12c23b3d62972019084bc175fd04f01005c1fd"},{"author":{"_account_id":1002167,"name":"Catherine","email":"whitequark@whitequark.org","username":"whitequark"},"change_message_id":"3be55c0f92509c86503d7041dd0c50deb7f4b3d6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"4b61bc50_63a281df","updated":"2023-10-21 17:48:22.000000000","message":"Is there anything preventing this patch from being merged still?","commit_id":"0b12c23b3d62972019084bc175fd04f01005c1fd"},{"author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"change_message_id":"bf2bc59c9f47726e69efac3125aa9a90690ddc98","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"c0826c9c_17a73a79","updated":"2023-02-17 06:50:59.000000000","message":"Looks all right.","commit_id":"0b12c23b3d62972019084bc175fd04f01005c1fd"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"90aeef6c6ec4588413f0c78d85da4bc55b07ef4d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"8598ced8_170e768d","updated":"2023-11-26 17:42:15.000000000","message":"The patch looks ok, thanks, but should be rebased after 6044 get merged.\nPlus it misses support for the remote sleep in\ncontrib/remote_bitbang/remote_bitbang_sysfsgpio.c:process_remote_protocol()\n\nI don\u0027t see a way to \"autodetect\" if remote sleep is supported by the server, since there is no reply for these new commands. Or did I missed something?","commit_id":"0b12c23b3d62972019084bc175fd04f01005c1fd"},{"author":{"_account_id":1002167,"name":"Catherine","email":"whitequark@whitequark.org","username":"whitequark"},"change_message_id":"d2b1af17a34d6431cf7511c1add395b02ff9b204","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"cfadde9d_2d06c54f","in_reply_to":"c0826c9c_17a73a79","updated":"2023-07-24 01:59:00.000000000","message":"Hi Jan,\n\nJust checking in--is there anything that prevents this patch from being merged?\n\nCheers","commit_id":"0b12c23b3d62972019084bc175fd04f01005c1fd"},{"author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"change_message_id":"076a7107d0f58b2245e4a5fc5f987d5d4ef77e5d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"273e38d1_3edf34b8","in_reply_to":"cfadde9d_2d06c54f","updated":"2023-07-24 05:03:23.000000000","message":"Hi Catherine,\nI don\u0027t believe there is anything preventing the merge. This chas has probably just escaped the attention of the maintainers.","commit_id":"0b12c23b3d62972019084bc175fd04f01005c1fd"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"503ccb9818da84db27eb3cafc0fd5ed8b5514708","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"20083bd7_a61b60d0","updated":"2023-12-10 22:34:28.000000000","message":"Thanks","commit_id":"a3b6a77e4a4e8efac3a9875a39e7c83a5bbb9baa"}],"doc/openocd.texi":[{"author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"change_message_id":"542f7858bf99a746b31a1007877376f6f4655d7b","unresolved":true,"context_lines":[{"line_number":2816,"context_line":"forwarded to the remote host. This is useful if the remote host performs its"},{"line_number":2817,"context_line":"own request queuing rather than executing requests immediately."},{"line_number":2818,"context_line":""},{"line_number":2819,"context_line":"This is disabled by default."},{"line_number":2820,"context_line":"@end deffn"},{"line_number":2821,"context_line":""},{"line_number":2822,"context_line":"For example, to connect remotely via TCP to the host foobar you might have"}],"source_content_type":"text/x-texinfo","patch_set":1,"id":"b14915c1_ca1bf5f4","line":2819,"updated":"2023-02-15 14:09:43.000000000","message":"I\u0027d recommend to mention:\n\n\"This option should only be enabled if the given remote_bitbang host supports receiving the delay information.\"\n\n(or similar wording)","commit_id":"0a92c514240e242d8c515cb75cfc03b6b73c3cd8"},{"author":{"_account_id":1002115,"name":"Jeremy Herbert","email":"jeremy.006@gmail.com","username":"jeremyherbert"},"change_message_id":"6c64990b38427ad06492180a74f92616193018ef","unresolved":false,"context_lines":[{"line_number":2816,"context_line":"forwarded to the remote host. This is useful if the remote host performs its"},{"line_number":2817,"context_line":"own request queuing rather than executing requests immediately."},{"line_number":2818,"context_line":""},{"line_number":2819,"context_line":"This is disabled by default."},{"line_number":2820,"context_line":"@end deffn"},{"line_number":2821,"context_line":""},{"line_number":2822,"context_line":"For example, to connect remotely via TCP to the host foobar you might have"}],"source_content_type":"text/x-texinfo","patch_set":1,"id":"582d71bd_94385fa0","line":2819,"in_reply_to":"b14915c1_ca1bf5f4","updated":"2023-02-16 02:20:10.000000000","message":"Done","commit_id":"0a92c514240e242d8c515cb75cfc03b6b73c3cd8"}],"src/jtag/drivers/remote_bitbang.c":[{"author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"change_message_id":"d606f52dbf85828129ca121f5a0442f598081759","unresolved":true,"context_lines":[{"line_number":411,"context_line":"\t\t.mode \u003d COMMAND_CONFIG,"},{"line_number":412,"context_line":"\t\t.help \u003d \"Rather than executing sleep locally, include delays in the \""},{"line_number":413,"context_line":"\t\t\t\"instruction stream for the remote host.\","},{"line_number":414,"context_line":"\t\t.usage \u003d \"(yes|no)\","},{"line_number":415,"context_line":"\t},"},{"line_number":416,"context_line":"\tCOMMAND_REGISTRATION_DONE"},{"line_number":417,"context_line":"};"}],"source_content_type":"text/x-csrc","patch_set":6,"id":"a409d148_8f3f2650","line":414,"updated":"2023-02-16 06:59:23.000000000","message":"For consistency, I\u0027d recommend to stick with \n\n.usage \u003d \"(on|off)\"\n\n... in the help message, for consistency with the rest of the OpenOCD commands.","commit_id":"107511dfd66f537802bf45fd5dac37b5e6d55c7c"},{"author":{"_account_id":1002115,"name":"Jeremy Herbert","email":"jeremy.006@gmail.com","username":"jeremyherbert"},"change_message_id":"98dad0459fd6d63347826b7df3cdc7138dfb7fed","unresolved":false,"context_lines":[{"line_number":411,"context_line":"\t\t.mode \u003d COMMAND_CONFIG,"},{"line_number":412,"context_line":"\t\t.help \u003d \"Rather than executing sleep locally, include delays in the \""},{"line_number":413,"context_line":"\t\t\t\"instruction stream for the remote host.\","},{"line_number":414,"context_line":"\t\t.usage \u003d \"(yes|no)\","},{"line_number":415,"context_line":"\t},"},{"line_number":416,"context_line":"\tCOMMAND_REGISTRATION_DONE"},{"line_number":417,"context_line":"};"}],"source_content_type":"text/x-csrc","patch_set":6,"id":"bcc08bbb_17af2519","line":414,"in_reply_to":"a409d148_8f3f2650","updated":"2023-02-16 23:53:59.000000000","message":"changed in the docs and source as requested.","commit_id":"107511dfd66f537802bf45fd5dac37b5e6d55c7c"}]}