)]}'
{"id":"openocd~master~Ia9e01e3af5ad035f2cf2a32292c9d66e57eafae9","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2023-02-26 10:03:42.000000000","reason":"Change was submitted"},"1001992":{"account":{"_account_id":1001992,"name":"Peter Collingbourne","email":"pcc@google.com","username":"pcc"},"last_update":"2023-02-26 10:03:42.000000000","reason":"Change was submitted"},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2023-02-22 07:25:06.000000000","reason":"Tomas Vanek replied on the change"}},"hashtags":[],"change_id":"Ia9e01e3af5ad035f2cf2a32292c9d66e57eafae9","subject":"jtag/drivers/cmsis_dap: run queue on reaching transaction limit","status":"MERGED","created":"2023-02-18 02:33:51.000000000","updated":"2023-02-26 10:03:42.000000000","submitted":"2023-02-26 10:03:42.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":7,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7483","meta_rev_id":"9d1db43b3452b3a033d3c13b762eadd2d09429e1","_number":7483,"owner":{"_account_id":1001992,"name":"Peter Collingbourne","email":"pcc@google.com","username":"pcc"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-02-26 10:03:42.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-02-26 10:03:42.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-02-18 02:38:19.000000000","updated_by":{"_account_id":1001992,"name":"Peter Collingbourne","email":"pcc@google.com","username":"pcc"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"},{"updated":"2023-02-18 02:38:19.000000000","updated_by":{"_account_id":1001992,"name":"Peter Collingbourne","email":"pcc@google.com","username":"pcc"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"},{"updated":"2023-02-18 04:12:02.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"5a2a144a6cddf7ac63094a0896a43ee852ca24d0","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001992,"name":"Peter Collingbourne","email":"pcc@google.com","username":"pcc"},"real_author":{"_account_id":1001992,"name":"Peter Collingbourne","email":"pcc@google.com","username":"pcc"},"date":"2023-02-18 02:33:51.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c80504efffc4e13eeca6ba9d77eefe659a828a27","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-02-18 04:12:02.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16587/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/17383/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"5d66987763125ae01cde371383682ec8a5e61e19","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-02-18 06:30:05.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"a023f6f6e00331a9c5e2059669212174d71b9056","author":{"_account_id":1001992,"name":"Peter Collingbourne","email":"pcc@google.com","username":"pcc"},"real_author":{"_account_id":1001992,"name":"Peter Collingbourne","email":"pcc@google.com","username":"pcc"},"date":"2023-02-22 07:05:21.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"88e1f885fd71ca72fb1b1e3615e8a5c86abe05bc","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-02-22 07:25:06.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"cda90c067b6237b2b531494ceae5a86cd7f936a4","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-02-22 08:28:56.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"6a960ff7b5a8c8d99f4c604d64f893039268ea3a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001992,"name":"Peter Collingbourne","email":"pcc@google.com","username":"pcc"},"real_author":{"_account_id":1001992,"name":"Peter Collingbourne","email":"pcc@google.com","username":"pcc"},"date":"2023-02-24 19:27:05.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"0b277f4cb99b97da47d90a71ed60e2ca65e7944f","author":{"_account_id":1001992,"name":"Peter Collingbourne","email":"pcc@google.com","username":"pcc"},"real_author":{"_account_id":1001992,"name":"Peter Collingbourne","email":"pcc@google.com","username":"pcc"},"date":"2023-02-24 19:27:29.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"a9f1703f4941839817ad0ec59337276a134d1ed1","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-02-24 20:06:26.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16594/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/17390/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"253586318aef5d533c5d057ed772e77510d1c382","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-02-24 21:18:32.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"9d1db43b3452b3a033d3c13b762eadd2d09429e1","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-02-26 10:03:42.000000000","message":"Change has been successfully cherry-picked as 0a20e78b759efa86a676b4a9fed4027fdd84e90c","accounts_in_message":[],"_revision_number":3}],"current_revision":"0a20e78b759efa86a676b4a9fed4027fdd84e90c","revisions":{"9e4ec6eef8f4d8ef18209c620859d733eeab7378":{"kind":"REWORK","_number":1,"created":"2023-02-18 02:33:51.000000000","uploader":{"_account_id":1001992,"name":"Peter Collingbourne","email":"pcc@google.com","username":"pcc"},"ref":"refs/changes/83/7483/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/83/7483/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/83/7483/1 \u0026\u0026 git checkout -b change-7483 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/83/7483/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/83/7483/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/83/7483/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/83/7483/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/83/7483/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"85ae73de03ebcc723842b7978a6c94b73166f027","subject":"new SPI memory devices, continuation code for manufacturer id"}],"author":{"name":"Peter Collingbourne","email":"pcc@google.com","date":"2023-02-18 02:26:05.000000000","tz":-480},"committer":{"name":"Peter Collingbourne","email":"pcc@google.com","date":"2023-02-18 02:33:44.000000000","tz":-480},"subject":"jtag/drivers/cmsis_dap: run queue on reaching transaction limit","message":"jtag/drivers/cmsis_dap: run queue on reaching transaction limit\n\nWe currently fail the transfer when issuing more than 255 transactions\nat once, e.g.\n\n\u003e read_memory 0x10000000 32 256\nCMSIS-DAP transfer count mismatch: expected 257, got 1\n\nThis is because the protocol only supports 255 transactions per packet\n(65535 for block transactions), and as a result we truncate the\ntransaction count when assembling the packet. Fix it by running the\nqueue when we hit the limit.\n\nChange-Id: Ia9e01e3af5ad035f2cf2a32292c9d66e57eafae9\nSigned-off-by: Peter Collingbourne \u003cpcc@google.com\u003e\n"}},"fc42dcbb199da6c953e3bed1fcf2022ebb5654ec":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2023-02-24 19:27:05.000000000","uploader":{"_account_id":1001992,"name":"Peter Collingbourne","email":"pcc@google.com","username":"pcc"},"ref":"refs/changes/83/7483/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/83/7483/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/83/7483/2 \u0026\u0026 git checkout -b change-7483 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/83/7483/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/83/7483/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/83/7483/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/83/7483/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/83/7483/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"85ae73de03ebcc723842b7978a6c94b73166f027","subject":"new SPI memory devices, continuation code for manufacturer id"}],"author":{"name":"Peter Collingbourne","email":"pcc@google.com","date":"2023-02-18 02:26:05.000000000","tz":-480},"committer":{"name":"Peter Collingbourne","email":"pcc@google.com","date":"2023-02-24 19:23:23.000000000","tz":-480},"subject":"jtag/drivers/cmsis_dap: run queue on reaching transaction limit","message":"jtag/drivers/cmsis_dap: run queue on reaching transaction limit\n\nWe currently fail the transfer when issuing more than 255 transactions\nat once, e.g.\n\n\u003e read_memory 0x10000000 32 256\nCMSIS-DAP transfer count mismatch: expected 257, got 1\n\nThis is because the protocol only supports 255 transactions per packet\n(65535 for block transactions), and as a result we truncate the\ntransaction count when assembling the packet. Fix it by running the\nqueue when we hit the limit.\n\nChange-Id: Ia9e01e3af5ad035f2cf2a32292c9d66e57eafae9\nSigned-off-by: Peter Collingbourne \u003cpcc@google.com\u003e\nFixes: 40bac8e8c4e5 (\"jtag/drivers/cmsis_dap: improve USB packets filling\")\n"}},"0a20e78b759efa86a676b4a9fed4027fdd84e90c":{"kind":"REWORK","_number":3,"created":"2023-02-26 10:03:42.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/83/7483/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/83/7483/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/83/7483/3 \u0026\u0026 git checkout -b change-7483 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/83/7483/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/83/7483/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/83/7483/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/83/7483/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/83/7483/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c99c043f3f6e79e391debee29371360b0965b2d6","subject":"helper: command: drop last LF (\u0027\\n\u0027) from sequence of command_print()"}],"author":{"name":"Peter Collingbourne","email":"pcc@google.com","date":"2023-02-18 02:26:05.000000000","tz":-480},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-02-26 10:03:42.000000000","tz":0},"subject":"jtag/drivers/cmsis_dap: run queue on reaching transaction limit","message":"jtag/drivers/cmsis_dap: run queue on reaching transaction limit\n\nWe currently fail the transfer when issuing more than 255 transactions\nat once, e.g.\n\n\u003e read_memory 0x10000000 32 256\nCMSIS-DAP transfer count mismatch: expected 257, got 1\n\nThis is because the protocol only supports 255 transactions per packet\n(65535 for block transactions), and as a result we truncate the\ntransaction count when assembling the packet. Fix it by running the\nqueue when we hit the limit.\n\nChange-Id: Ia9e01e3af5ad035f2cf2a32292c9d66e57eafae9\nSigned-off-by: Peter Collingbourne \u003cpcc@google.com\u003e\nFixes: 40bac8e8c4e5 (\"jtag/drivers/cmsis_dap: improve USB packets filling\")\nReviewed-on: https://review.openocd.org/c/openocd/+/7483\nTested-by: jenkins\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}