)]}'
{"id":"openocd~master~I9f3e8394c1a0cc0312b414c58275e1220217bbed","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2023-03-25 18:09:47.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I9f3e8394c1a0cc0312b414c58275e1220217bbed","subject":"transport: rewrite command \u0027transport select\u0027 as COMMAND_HANDLER","status":"MERGED","created":"2023-02-26 21:04:47.000000000","updated":"2023-03-25 18:09:47.000000000","submitted":"2023-03-25 18:09:47.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7485","meta_rev_id":"88add67bca9ef6c7f604ebc8032f0cbc0f61b085","_number":7485,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-03-25 18:09:47.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-03-25 18:09:47.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-03-25 18:09:47.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-02-27 21:25:34.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-03-13 11:35:26.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"}],"messages":[{"id":"6ed6740316936fe90a490e3f2fceb17c6873b1bd","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-02-26 21:04:47.000000000","message":"Uploaded patch set 1: Code-Review+1.","accounts_in_message":[],"_revision_number":1},{"id":"e4c57aea961fe7f0f6274864c79c41f0a476424e","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-02-27 21:25:34.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16623/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/17418/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"5f4df1a7611e299f4d4857d44dee8029220e641a","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-03-13 11:35:26.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"88add67bca9ef6c7f604ebc8032f0cbc0f61b085","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-03-25 18:09:47.000000000","message":"Change has been successfully cherry-picked as d05c68667129705ecfd42c6029a60e849518d50c","accounts_in_message":[],"_revision_number":2}],"current_revision":"d05c68667129705ecfd42c6029a60e849518d50c","revisions":{"d05c68667129705ecfd42c6029a60e849518d50c":{"kind":"REWORK","_number":2,"created":"2023-03-25 18:09:47.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/85/7485/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/85/7485/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/85/7485/2 \u0026\u0026 git checkout -b change-7485 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/85/7485/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/85/7485/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/85/7485/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/85/7485/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/85/7485/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1ec8b83cbdb407536966b4e455dbb39d1cb42b3a","subject":"helper: command: rewrite command \u0027ocd_find\u0027 as COMMAND_HANDLER"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-12-18 14:26:56.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-03-25 18:09:47.000000000","tz":0},"subject":"transport: rewrite command \u0027transport select\u0027 as COMMAND_HANDLER","message":"transport: rewrite command \u0027transport select\u0027 as COMMAND_HANDLER\n\nThe mixed use of jim commands and OpenOCD commands is error prone\ndue to handling of errors through JIM_xx and ERROR_yy.\n\nRewrite the jim command \u0027transport select\u0027 as OpenOCD command.\nThis fixes and incorrect check for the return value of function\ntransport_select(); it returns ERROR_yy but the check is on JIM_xx.\nWhile there, fix the coding style.\n\nChange-Id: I9f3e8394c1a0cc0312b414c58275e1220217bbed\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7485\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nTested-by: jenkins\n"}},"aa2e631ffb73543a05f153afb5fc28d1c8481f22":{"kind":"REWORK","_number":1,"created":"2023-02-26 21:04:47.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/85/7485/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/85/7485/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/85/7485/1 \u0026\u0026 git checkout -b change-7485 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/85/7485/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/85/7485/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/85/7485/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/85/7485/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/85/7485/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"20d2d44afea3cf47395577c2fc475ddcdf74fded","subject":"helper: command: rewrite command \u0027ocd_find\u0027 as COMMAND_HANDLER"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-12-18 14:26:56.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-02-26 10:13:05.000000000","tz":60},"subject":"transport: rewrite command \u0027transport select\u0027 as COMMAND_HANDLER","message":"transport: rewrite command \u0027transport select\u0027 as COMMAND_HANDLER\n\nThe mixed use of jim commands and OpenOCD commands is error prone\ndue to handling of errors through JIM_xx and ERROR_yy.\n\nRewrite the jim command \u0027transport select\u0027 as OpenOCD command.\nThis fixes and incorrect check for the return value of function\ntransport_select(); it returns ERROR_yy but the check is on JIM_xx.\nWhile there, fix the coding style.\n\nChange-Id: I9f3e8394c1a0cc0312b414c58275e1220217bbed\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}