)]}'
{"id":"openocd~master~I1ee69870d3ab3c1cfc46cd2b8ec03de6b2300bd6","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2023-03-25 18:10:02.000000000","reason":"Change was submitted"},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2023-03-13 11:43:42.000000000","reason":"Tomas Vanek replied on the change"}},"hashtags":[],"change_id":"I1ee69870d3ab3c1cfc46cd2b8ec03de6b2300bd6","subject":"flash: nor: rewrite command \u0027flash list\u0027 as COMMAND_HANDLER","status":"MERGED","created":"2023-02-26 21:04:47.000000000","updated":"2023-03-25 18:10:02.000000000","submitted":"2023-03-25 18:10:02.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7486","meta_rev_id":"fd78b81088999e0b71493375426ba4f3e9b38815","_number":7486,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-03-25 18:10:02.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-03-25 18:10:02.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-03-25 18:10:02.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-02-26 21:23:19.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"},{"updated":"2023-02-27 00:18:28.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"ea4dbbd9dabb1568429cdd0c235376b1a973e478","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-02-26 21:04:47.000000000","message":"Uploaded patch set 1: Code-Review+1.","accounts_in_message":[],"_revision_number":1},{"id":"6707eed24c3f16662635feb4a91b7f098819b7ea","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-02-26 21:23:19.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"409a5cb4e0739399f10db7c3ad4fd839d031e24d","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-02-27 00:18:28.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16597/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/17392/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"143d4a0155b17c199eecda6a5bcc25bb7874f17b","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-03-13 11:43:42.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"fd78b81088999e0b71493375426ba4f3e9b38815","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-03-25 18:10:02.000000000","message":"Change has been successfully cherry-picked as 80fc9fabc66a0bc767467fa14c703e5a9f340cd3","accounts_in_message":[],"_revision_number":2}],"current_revision":"80fc9fabc66a0bc767467fa14c703e5a9f340cd3","revisions":{"eca69ee75f609f4442287b32e601c1d81d436087":{"kind":"REWORK","_number":1,"created":"2023-02-26 21:04:47.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/86/7486/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/86/7486/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/86/7486/1 \u0026\u0026 git checkout -b change-7486 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/86/7486/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/86/7486/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/86/7486/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/86/7486/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/86/7486/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"aa2e631ffb73543a05f153afb5fc28d1c8481f22","subject":"transport: rewrite command \u0027transport select\u0027 as COMMAND_HANDLER"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-12-18 15:09:02.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-02-26 10:22:54.000000000","tz":60},"subject":"flash: nor: rewrite command \u0027flash list\u0027 as COMMAND_HANDLER","message":"flash: nor: rewrite command \u0027flash list\u0027 as COMMAND_HANDLER\n\nThe mixed use of jim commands and OpenOCD commands is error prone\ndue to handling of errors through JIM_xx and ERROR_yy.\n\nRewrite the jim command \u0027flash list\u0027 as OpenOCD command.\nWhile there:\n- format in a human readable way the output dictionary list, while\n  preserving the structure of its TCL data;\n- add the mandatory \u0027usage\u0027 field.\n\nChange-Id: I1ee69870d3ab3c1cfc46cd2b8ec03de6b2300bd6\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"80fc9fabc66a0bc767467fa14c703e5a9f340cd3":{"kind":"REWORK","_number":2,"created":"2023-03-25 18:10:02.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/86/7486/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/86/7486/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/86/7486/2 \u0026\u0026 git checkout -b change-7486 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/86/7486/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/86/7486/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/86/7486/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/86/7486/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/86/7486/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d05c68667129705ecfd42c6029a60e849518d50c","subject":"transport: rewrite command \u0027transport select\u0027 as COMMAND_HANDLER"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-12-18 15:09:02.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-03-25 18:10:02.000000000","tz":0},"subject":"flash: nor: rewrite command \u0027flash list\u0027 as COMMAND_HANDLER","message":"flash: nor: rewrite command \u0027flash list\u0027 as COMMAND_HANDLER\n\nThe mixed use of jim commands and OpenOCD commands is error prone\ndue to handling of errors through JIM_xx and ERROR_yy.\n\nRewrite the jim command \u0027flash list\u0027 as OpenOCD command.\nWhile there:\n- format in a human readable way the output dictionary list, while\n  preserving the structure of its TCL data;\n- add the mandatory \u0027usage\u0027 field.\n\nChange-Id: I1ee69870d3ab3c1cfc46cd2b8ec03de6b2300bd6\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7486\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nTested-by: jenkins\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}