)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"change_message_id":"f5a02016f8628e164bbe41b2966e8eb7b5510b52","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"05633f45_9a20707d","updated":"2023-03-04 08:36:29.000000000","message":"Hi!\nThank you for the patch. Few comments inline.","commit_id":"1858d63a78913e83421965d4cfdc8bb2771d3395"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"263bcd10a7999f7ade2d31f15aa089d4eb6c418f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2a14a5da_f92f8e52","updated":"2023-03-03 22:56:47.000000000","message":"Thanks for the patch.\nOnly a minor comment from my side, as I\u0027m not expert on this flash driver","commit_id":"1858d63a78913e83421965d4cfdc8bb2771d3395"},{"author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"change_message_id":"3fddc0f0abb167dff2f7fb8eb82fce883a387d13","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"472800be_0ebc961d","updated":"2023-03-14 14:32:52.000000000","message":"The new patchset doesn\u0027t really answer my questions :/","commit_id":"7915eeb861896046b8f12512e280f83a5ab97b94"}],"src/flash/nor/stm32l4x.c":[{"author":{"_account_id":1001036,"name":"Andreas Bolsch","email":"hyphen0break@gmail.com","username":"abmero"},"change_message_id":"73d2849aa83f092b76a6f65a77fff525e02b3cdb","unresolved":true,"context_lines":[{"line_number":348,"context_line":""},{"line_number":349,"context_line":"static const struct stm32l4_rev stm32u535_u545_revs[] \u003d {"},{"line_number":350,"context_line":"\t{ 0x1000, \"A\" },"},{"line_number":351,"context_line":"};"},{"line_number":352,"context_line":""},{"line_number":353,"context_line":"static const struct stm32l4_part_info stm32l4_parts[] \u003d {"},{"line_number":354,"context_line":"\t{"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"62751484_20dc4de7","line":351,"updated":"2023-03-06 09:58:28.000000000","message":"RM0456 rev. 4 says \"For STM32U535/545 0x1001: revision Z\", no revision \"A\" at all. Hence \"A\" probably refers to samples, and \"Z\" to production items?","commit_id":"1858d63a78913e83421965d4cfdc8bb2771d3395"},{"author":{"_account_id":1002119,"name":"Fedi Bouzazi","email":"fedi.bouzazi@st.com","username":"FBOSTM"},"change_message_id":"b78b9e43e60e1344b28363517addd6bf95d01e27","unresolved":false,"context_lines":[{"line_number":348,"context_line":""},{"line_number":349,"context_line":"static const struct stm32l4_rev stm32u535_u545_revs[] \u003d {"},{"line_number":350,"context_line":"\t{ 0x1000, \"A\" },"},{"line_number":351,"context_line":"};"},{"line_number":352,"context_line":""},{"line_number":353,"context_line":"static const struct stm32l4_part_info stm32l4_parts[] \u003d {"},{"line_number":354,"context_line":"\t{"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"7599eefd_17c59e18","line":351,"in_reply_to":"62751484_20dc4de7","updated":"2023-04-28 15:36:02.000000000","message":"Done","commit_id":"1858d63a78913e83421965d4cfdc8bb2771d3395"},{"author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"change_message_id":"b4c1ef58379f7b40a57752f495b7316cfc7cac58","unresolved":true,"context_lines":[{"line_number":364,"context_line":"\t  .otp_size              \u003d 1024,"},{"line_number":365,"context_line":"\t},"},{"line_number":366,"context_line":"\t{"},{"line_number":367,"context_line":"\t\t  .id                    \u003d DEVID_STM32U535_U545,"},{"line_number":368,"context_line":"\t\t  .revs                  \u003d stm32u535_u545_revs,"},{"line_number":369,"context_line":"\t\t  .num_revs              \u003d ARRAY_SIZE(stm32u535_u545_revs),"},{"line_number":370,"context_line":"\t\t  .device_str            \u003d \"STM32U535/U545\","},{"line_number":371,"context_line":"\t\t  .max_flash_size_kb     \u003d 512,"},{"line_number":372,"context_line":"\t\t  .flags                 \u003d F_HAS_DUAL_BANK | F_QUAD_WORD_PROG | F_HAS_TZ | F_HAS_L5_FLASH_REGS,"},{"line_number":373,"context_line":"\t\t  .flash_regs_base       \u003d 0x40022000,"},{"line_number":374,"context_line":"\t\t  .fsize_addr            \u003d 0x0BFA07A0,"},{"line_number":375,"context_line":"\t\t  .otp_base              \u003d 0x0BFA0000,"},{"line_number":376,"context_line":"\t\t  .otp_size              \u003d 512,"},{"line_number":377,"context_line":"\t},"},{"line_number":378,"context_line":"\t{"},{"line_number":379,"context_line":"\t  .id                    \u003d DEVID_STM32L43_L44XX,"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"b3727d2c_392a193e","line":376,"range":{"start_line":367,"start_character":0,"end_line":376,"end_character":33},"updated":"2023-03-03 14:07:05.000000000","message":"please use the same style","commit_id":"1858d63a78913e83421965d4cfdc8bb2771d3395"},{"author":{"_account_id":1002119,"name":"Fedi Bouzazi","email":"fedi.bouzazi@st.com","username":"FBOSTM"},"change_message_id":"b78b9e43e60e1344b28363517addd6bf95d01e27","unresolved":false,"context_lines":[{"line_number":364,"context_line":"\t  .otp_size              \u003d 1024,"},{"line_number":365,"context_line":"\t},"},{"line_number":366,"context_line":"\t{"},{"line_number":367,"context_line":"\t\t  .id                    \u003d DEVID_STM32U535_U545,"},{"line_number":368,"context_line":"\t\t  .revs                  \u003d stm32u535_u545_revs,"},{"line_number":369,"context_line":"\t\t  .num_revs              \u003d ARRAY_SIZE(stm32u535_u545_revs),"},{"line_number":370,"context_line":"\t\t  .device_str            \u003d \"STM32U535/U545\","},{"line_number":371,"context_line":"\t\t  .max_flash_size_kb     \u003d 512,"},{"line_number":372,"context_line":"\t\t  .flags                 \u003d F_HAS_DUAL_BANK | F_QUAD_WORD_PROG | F_HAS_TZ | F_HAS_L5_FLASH_REGS,"},{"line_number":373,"context_line":"\t\t  .flash_regs_base       \u003d 0x40022000,"},{"line_number":374,"context_line":"\t\t  .fsize_addr            \u003d 0x0BFA07A0,"},{"line_number":375,"context_line":"\t\t  .otp_base              \u003d 0x0BFA0000,"},{"line_number":376,"context_line":"\t\t  .otp_size              \u003d 512,"},{"line_number":377,"context_line":"\t},"},{"line_number":378,"context_line":"\t{"},{"line_number":379,"context_line":"\t  .id                    \u003d DEVID_STM32L43_L44XX,"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"5035e422_b1f00fee","line":376,"range":{"start_line":367,"start_character":0,"end_line":376,"end_character":33},"in_reply_to":"b3727d2c_392a193e","updated":"2023-04-28 15:36:02.000000000","message":"Done","commit_id":"1858d63a78913e83421965d4cfdc8bb2771d3395"},{"author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"change_message_id":"f5a02016f8628e164bbe41b2966e8eb7b5510b52","unresolved":true,"context_lines":[{"line_number":1957,"context_line":"\t\tbreak;"},{"line_number":1958,"context_line":"\tcase DEVID_STM32U57_U58XX:"},{"line_number":1959,"context_line":"\tcase DEVID_STM32U535_U545:"},{"line_number":1960,"context_line":"\t\t/* if flash size is max (2M) the device is always dual bank"},{"line_number":1961,"context_line":"\t\t * otherwise check DUALBANK"},{"line_number":1962,"context_line":"\t\t */"},{"line_number":1963,"context_line":"\t\tpage_size_kb \u003d 8;"},{"line_number":1964,"context_line":"\t\tnum_pages \u003d flash_size_kb / page_size_kb;"},{"line_number":1965,"context_line":"\t\tstm32l4_info-\u003ebank1_sectors \u003d num_pages;"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"fc377785_b12bf39a","line":1962,"range":{"start_line":1960,"start_character":2,"end_line":1962,"end_character":5},"updated":"2023-03-04 08:36:29.000000000","message":"Is this comment incorrect?","commit_id":"1858d63a78913e83421965d4cfdc8bb2771d3395"},{"author":{"_account_id":1002119,"name":"Fedi Bouzazi","email":"fedi.bouzazi@st.com","username":"FBOSTM"},"change_message_id":"b78b9e43e60e1344b28363517addd6bf95d01e27","unresolved":false,"context_lines":[{"line_number":1957,"context_line":"\t\tbreak;"},{"line_number":1958,"context_line":"\tcase DEVID_STM32U57_U58XX:"},{"line_number":1959,"context_line":"\tcase DEVID_STM32U535_U545:"},{"line_number":1960,"context_line":"\t\t/* if flash size is max (2M) the device is always dual bank"},{"line_number":1961,"context_line":"\t\t * otherwise check DUALBANK"},{"line_number":1962,"context_line":"\t\t */"},{"line_number":1963,"context_line":"\t\tpage_size_kb \u003d 8;"},{"line_number":1964,"context_line":"\t\tnum_pages \u003d flash_size_kb / page_size_kb;"},{"line_number":1965,"context_line":"\t\tstm32l4_info-\u003ebank1_sectors \u003d num_pages;"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"19183212_aa4bcac2","line":1962,"range":{"start_line":1960,"start_character":2,"end_line":1962,"end_character":5},"in_reply_to":"fc377785_b12bf39a","updated":"2023-04-28 15:36:02.000000000","message":"Done","commit_id":"1858d63a78913e83421965d4cfdc8bb2771d3395"},{"author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"change_message_id":"f5a02016f8628e164bbe41b2966e8eb7b5510b52","unresolved":true,"context_lines":[{"line_number":1963,"context_line":"\t\tpage_size_kb \u003d 8;"},{"line_number":1964,"context_line":"\t\tnum_pages \u003d flash_size_kb / page_size_kb;"},{"line_number":1965,"context_line":"\t\tstm32l4_info-\u003ebank1_sectors \u003d num_pages;"},{"line_number":1966,"context_line":"\t\tif (flash_size_kb \u003e 1024 || (stm32l4_info-\u003eoptr \u0026 FLASH_U5_DUALBANK)) {"},{"line_number":1967,"context_line":"\t\t\tstm32l4_info-\u003edual_bank_mode \u003d true;"},{"line_number":1968,"context_line":"\t\t\tstm32l4_info-\u003ebank1_sectors \u003d num_pages / 2;"},{"line_number":1969,"context_line":"\t\t}"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"e08f521c_d5ad32f1","line":1966,"range":{"start_line":1966,"start_character":7,"end_line":1966,"end_character":26},"updated":"2023-03-04 08:36:29.000000000","message":"So you\u0027re changing this not only for the part you\u0027re adding but also for U58XX. And the code diverges from the other similar parts where is_max_flash_size is used. Is there some specific reference to the datasheets which explain why these U* parts should be different?","commit_id":"1858d63a78913e83421965d4cfdc8bb2771d3395"},{"author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"change_message_id":"b4c1ef58379f7b40a57752f495b7316cfc7cac58","unresolved":true,"context_lines":[{"line_number":1963,"context_line":"\t\tpage_size_kb \u003d 8;"},{"line_number":1964,"context_line":"\t\tnum_pages \u003d flash_size_kb / page_size_kb;"},{"line_number":1965,"context_line":"\t\tstm32l4_info-\u003ebank1_sectors \u003d num_pages;"},{"line_number":1966,"context_line":"\t\tif (flash_size_kb \u003e 1024 || (stm32l4_info-\u003eoptr \u0026 FLASH_U5_DUALBANK)) {"},{"line_number":1967,"context_line":"\t\t\tstm32l4_info-\u003edual_bank_mode \u003d true;"},{"line_number":1968,"context_line":"\t\t\tstm32l4_info-\u003ebank1_sectors \u003d num_pages / 2;"},{"line_number":1969,"context_line":"\t\t}"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"d8b70b39_bfda78b6","line":1966,"range":{"start_line":1966,"start_character":6,"end_line":1966,"end_character":26},"updated":"2023-03-03 14:07:05.000000000","message":"this seem not to be true, according to Line 372","commit_id":"1858d63a78913e83421965d4cfdc8bb2771d3395"},{"author":{"_account_id":1002119,"name":"Fedi Bouzazi","email":"fedi.bouzazi@st.com","username":"FBOSTM"},"change_message_id":"b78b9e43e60e1344b28363517addd6bf95d01e27","unresolved":false,"context_lines":[{"line_number":1963,"context_line":"\t\tpage_size_kb \u003d 8;"},{"line_number":1964,"context_line":"\t\tnum_pages \u003d flash_size_kb / page_size_kb;"},{"line_number":1965,"context_line":"\t\tstm32l4_info-\u003ebank1_sectors \u003d num_pages;"},{"line_number":1966,"context_line":"\t\tif (flash_size_kb \u003e 1024 || (stm32l4_info-\u003eoptr \u0026 FLASH_U5_DUALBANK)) {"},{"line_number":1967,"context_line":"\t\t\tstm32l4_info-\u003edual_bank_mode \u003d true;"},{"line_number":1968,"context_line":"\t\t\tstm32l4_info-\u003ebank1_sectors \u003d num_pages / 2;"},{"line_number":1969,"context_line":"\t\t}"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"8da9ba19_5c8d338d","line":1966,"range":{"start_line":1966,"start_character":6,"end_line":1966,"end_character":26},"in_reply_to":"d8b70b39_bfda78b6","updated":"2023-04-28 15:36:02.000000000","message":"Done","commit_id":"1858d63a78913e83421965d4cfdc8bb2771d3395"},{"author":{"_account_id":1002119,"name":"Fedi Bouzazi","email":"fedi.bouzazi@st.com","username":"FBOSTM"},"change_message_id":"b78b9e43e60e1344b28363517addd6bf95d01e27","unresolved":false,"context_lines":[{"line_number":1963,"context_line":"\t\tpage_size_kb \u003d 8;"},{"line_number":1964,"context_line":"\t\tnum_pages \u003d flash_size_kb / page_size_kb;"},{"line_number":1965,"context_line":"\t\tstm32l4_info-\u003ebank1_sectors \u003d num_pages;"},{"line_number":1966,"context_line":"\t\tif (flash_size_kb \u003e 1024 || (stm32l4_info-\u003eoptr \u0026 FLASH_U5_DUALBANK)) {"},{"line_number":1967,"context_line":"\t\t\tstm32l4_info-\u003edual_bank_mode \u003d true;"},{"line_number":1968,"context_line":"\t\t\tstm32l4_info-\u003ebank1_sectors \u003d num_pages / 2;"},{"line_number":1969,"context_line":"\t\t}"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"314ad21c_b526d330","line":1966,"range":{"start_line":1966,"start_character":7,"end_line":1966,"end_character":26},"in_reply_to":"e08f521c_d5ad32f1","updated":"2023-04-28 15:36:02.000000000","message":"Thank you Paul for the review, you can check the RM under st.com, check \u0027https://www.st.com/content/ccc/resource/technical/document/reference_manual/group0/f3/60/ca/d2/98/c8/47/88/DM00477635/files/DM00477635.pdf/jcr:content/translations/en.DM00477635.pdf\u0027. You can examine \u00277.3.1 Flash memory organization\u0027.","commit_id":"1858d63a78913e83421965d4cfdc8bb2771d3395"}],"src/flash/nor/stm32l4x.h":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"263bcd10a7999f7ade2d31f15aa089d4eb6c418f","unresolved":true,"context_lines":[{"line_number":105,"context_line":"#define DEVID_STM32WB5XX\t\t0x495"},{"line_number":106,"context_line":"#define DEVID_STM32WB3XX\t\t0x496"},{"line_number":107,"context_line":"#define DEVID_STM32WLE_WL5XX\t0x497"},{"line_number":108,"context_line":"#define DEVID_STM32U535_U545\t0x455"},{"line_number":109,"context_line":"/* known Flash base addresses */"},{"line_number":110,"context_line":"#define STM32_FLASH_BANK_BASE\t0x08000000"},{"line_number":111,"context_line":"#define STM32_FLASH_S_BANK_BASE\t0x0C000000"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"7eeccf6c_2bb0652d","line":108,"updated":"2023-03-03 22:56:47.000000000","message":"the list above is sorted by numeric ID.\nCan you please move this between 0x435 and 0x456 ?","commit_id":"1858d63a78913e83421965d4cfdc8bb2771d3395"},{"author":{"_account_id":1002119,"name":"Fedi Bouzazi","email":"fedi.bouzazi@st.com","username":"FBOSTM"},"change_message_id":"b78b9e43e60e1344b28363517addd6bf95d01e27","unresolved":false,"context_lines":[{"line_number":105,"context_line":"#define DEVID_STM32WB5XX\t\t0x495"},{"line_number":106,"context_line":"#define DEVID_STM32WB3XX\t\t0x496"},{"line_number":107,"context_line":"#define DEVID_STM32WLE_WL5XX\t0x497"},{"line_number":108,"context_line":"#define DEVID_STM32U535_U545\t0x455"},{"line_number":109,"context_line":"/* known Flash base addresses */"},{"line_number":110,"context_line":"#define STM32_FLASH_BANK_BASE\t0x08000000"},{"line_number":111,"context_line":"#define STM32_FLASH_S_BANK_BASE\t0x0C000000"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"8fd4c42a_7f74966b","line":108,"in_reply_to":"7eeccf6c_2bb0652d","updated":"2023-04-28 15:36:02.000000000","message":"Done","commit_id":"1858d63a78913e83421965d4cfdc8bb2771d3395"}]}