)]}'
{"id":"openocd~master~I0879891dbd083bfbff1e904daf6cd549c3329bbf","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2023-03-06 09:05:27.000000000","reason":"Antonio Borneo replied on the change"}},"hashtags":[],"change_id":"I0879891dbd083bfbff1e904daf6cd549c3329bbf","subject":"jimtcl: update to version 0.82","status":"MERGED","created":"2023-03-04 17:39:50.000000000","updated":"2023-03-18 21:59:19.000000000","submitted":"2023-03-18 21:59:19.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7517","meta_rev_id":"dcc5bb3079f9ba4885d63e144ed148f68f8b4753","_number":7517,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-03-18 21:59:19.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-03-18 21:59:19.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-03-04 19:10:28.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"0e46b0ba1f9c765de9625885f384e822481dfa57","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-03-04 17:39:50.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f77f4466b3dce6940da67cb2a4bef1e57dfb1089","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-03-04 19:10:28.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16633/ : FAILURE\n\nhttps://build.openocd.org/job/openocd-gerrit/17428/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"b30fcfdeddb770798e76020fd7dc693887055885","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-03-04 21:29:56.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"8fb4b8222f23b0a0bdca6978eef339048926cbba","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-03-04 22:22:03.000000000","message":"Patch Set 2: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16635/ : FAILURE\n\nhttps://build.openocd.org/job/openocd-gerrit/17431/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"2c12e248fecfecb4a95ccaeb6ca53a30f5e7d38a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-03-06 00:06:41.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.","accounts_in_message":[],"_revision_number":3},{"id":"22754199204bd7eb4f74e4e8197689e41320637d","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-03-06 04:40:41.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16647/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/17442/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"9657df76fc5db98a6b4aae93864e9e7d0aec3297","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-03-06 09:05:27.000000000","message":"Patch Set 3: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"86ea04e83e0116b212fcd2902cfd4c260281ac56","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-03-18 21:59:15.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"dcc5bb3079f9ba4885d63e144ed148f68f8b4753","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-03-18 21:59:19.000000000","message":"Change has been successfully cherry-picked as dccf323c1f78d015f75db4cef8cdc33523e1abd6","accounts_in_message":[],"_revision_number":4}],"current_revision":"dccf323c1f78d015f75db4cef8cdc33523e1abd6","revisions":{"dabf8f7bb9d09b2d1c628a0ae2b288086d3c4b93":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2023-03-06 00:06:41.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/17/7517/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/17/7517/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/17/7517/3 \u0026\u0026 git checkout -b change-7517 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/17/7517/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/17/7517/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/17/7517/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/17/7517/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/17/7517/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1303982a865c8a24ebc8f1879d3c8b90a2000cec","subject":"build: fix distcheck for jimtcl"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-03-04 11:08:58.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-03-05 23:57:57.000000000","tz":60},"subject":"jimtcl: update to version 0.82","message":"jimtcl: update to version 0.82\n\nThe new version modifies it\u0027s auto configure in change\n\thttps://github.com/msteveb/jimtcl/commit/ccd47be13019\nstating:\n\tconfigure: Default to --full\n\tNow use --minimal and/or --without-ext to disable things.\n\nWith such change jimtcl doesn\u0027t build anymore as OpenOCD submodule\nbecause of errors linking with new dependencies openssl and zlib.\n\nUse option --minimal to keep the same build configuration as with\nformer jimtcl 0.81.\nAdd option --disable-ssl to avoid a build error on system with no\nssl libraries installed. This is already fixed in jimtcl upstream\nbut not part of 0.82. Note that ssl is not currently used by\nOpenOCD.\n\nChange-Id: I0879891dbd083bfbff1e904daf6cd549c3329bbf\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"b98fa1f2c4d76fbcfdc7d39995bf3fedc26a31b9":{"kind":"REWORK","_number":2,"created":"2023-03-04 21:29:56.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/17/7517/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/17/7517/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/17/7517/2 \u0026\u0026 git checkout -b change-7517 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/17/7517/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/17/7517/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/17/7517/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/17/7517/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/17/7517/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"50d7d5fc77fc6dfe7c3844e7f13abf4f0d9f5681","subject":"openocd: drop JIM_EMBEDDED macro"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-03-04 11:08:58.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-03-04 21:27:02.000000000","tz":60},"subject":"jimtcl: update to version 0.82","message":"jimtcl: update to version 0.82\n\nThe new version modifies it\u0027s auto configure in change\n\thttps://github.com/msteveb/jimtcl/commit/ccd47be13019\nstating:\n\tconfigure: Default to --full\n\tNow use --minimal and/or --without-ext to disable things.\n\nWith such change jimtcl doesn\u0027t build anymore as OpenOCD submodule\nbecause of errors linking with new dependencies openssl and zlib.\n\nUse option --minimal to keep the same build configuration as with\nformer jimtcl 0.81.\nAdd option --disable-ssl to avoid a build error on system with no\nssl libraries installed. This is already fixed in jimtcl upstream\nbut not part of 0.82. Note that ssl is not currently used by\nOpenOCD.\n\nChange-Id: I0879891dbd083bfbff1e904daf6cd549c3329bbf\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"06cd205d517039964a6a8c8cccf96f34ef158247":{"kind":"REWORK","_number":1,"created":"2023-03-04 17:39:50.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/17/7517/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/17/7517/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/17/7517/1 \u0026\u0026 git checkout -b change-7517 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/17/7517/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/17/7517/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/17/7517/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/17/7517/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/17/7517/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"fc30feb51a76e893646e2794c99a78dbdc0d251f","subject":"tlc/interface: does fix source of raspberrypi-gpio-connector.cfg in raspberrypi-native.cfg"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-03-04 11:08:58.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-03-04 17:38:29.000000000","tz":60},"subject":"jimtcl: update to version 0.82","message":"jimtcl: update to version 0.82\n\nThe new version modifies it\u0027s auto configure in change\n\thttps://github.com/msteveb/jimtcl/commit/ccd47be13019\nstating:\n\tconfigure: Default to --full\n\tNow use --minimal and/or --without-ext to disable things.\n\nWith such change jimtcl doesn\u0027t build anymore as OpenOCD submodule\nbecause of errors linking with new dependencies openssl and zlib.\n\nUse option --minimal to keep the same build configuration as with\nformer jimtcl 0.81.\n\nChange-Id: I0879891dbd083bfbff1e904daf6cd549c3329bbf\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"dccf323c1f78d015f75db4cef8cdc33523e1abd6":{"kind":"REWORK","_number":4,"created":"2023-03-18 21:59:19.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/17/7517/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/17/7517/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/17/7517/4 \u0026\u0026 git checkout -b change-7517 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/17/7517/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/17/7517/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/17/7517/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/17/7517/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/17/7517/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"45eeeab3080991168a07854af5dded926a22253c","subject":"build: fix distcheck for jimtcl"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-03-04 11:08:58.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-03-18 21:59:19.000000000","tz":0},"subject":"jimtcl: update to version 0.82","message":"jimtcl: update to version 0.82\n\nThe new version modifies it\u0027s auto configure in change\n\thttps://github.com/msteveb/jimtcl/commit/ccd47be13019\nstating:\n\tconfigure: Default to --full\n\tNow use --minimal and/or --without-ext to disable things.\n\nWith such change jimtcl doesn\u0027t build anymore as OpenOCD submodule\nbecause of errors linking with new dependencies openssl and zlib.\n\nUse option --minimal to keep the same build configuration as with\nformer jimtcl 0.81.\nAdd option --disable-ssl to avoid a build error on system with no\nssl libraries installed. This is already fixed in jimtcl upstream\nbut not part of 0.82. Note that ssl is not currently used by\nOpenOCD.\n\nChange-Id: I0879891dbd083bfbff1e904daf6cd549c3329bbf\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7517\nTested-by: jenkins\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}
