)]}'
{"id":"openocd~master~I36883f60f25bb25839e4ebf908159569659764dd","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2023-03-04 23:16:05.000000000","reason":"Antonio Borneo replied on the change"}},"hashtags":[],"change_id":"I36883f60f25bb25839e4ebf908159569659764dd","subject":"openocd: drop JIM_EMBEDDED macro","status":"MERGED","created":"2023-03-04 18:34:30.000000000","updated":"2023-03-18 21:58:01.000000000","submitted":"2023-03-18 21:58:01.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7518","meta_rev_id":"a69766826e2ff331b70e2cdca4e395a3387e5a0c","_number":7518,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-03-18 21:58:01.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-03-18 21:58:01.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-03-04 20:01:22.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"5d23471560cd4aeadd326d9dd9a27e09f66bc56c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-03-04 18:34:30.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b0290f6fe329ee77b1e0963f229d68f02e255d44","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-03-04 20:01:22.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16634/ : FAILURE\n\nhttps://build.openocd.org/job/openocd-gerrit/17429/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"ce209a9bc1416b0c35421c720deb00832b4b80aa","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-03-04 21:29:56.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"73719db9760a43b61bf96e8c241dce16f9b35908","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-03-04 23:13:12.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16636/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/17430/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"57af894a9db3ef48d7f8c8bca7a0b00ddf79665e","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-03-04 23:16:05.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"845b1f8fe430854563c2294afda007e168faf949","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-03-18 21:57:56.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"a69766826e2ff331b70e2cdca4e395a3387e5a0c","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-03-18 21:58:01.000000000","message":"Change has been successfully cherry-picked as 642735449a3a7297126a3dd9b76ffaaca74a1752","accounts_in_message":[],"_revision_number":3}],"current_revision":"642735449a3a7297126a3dd9b76ffaaca74a1752","revisions":{"cd23232ba0828bf04c29de84adf5d27a312eb8cc":{"kind":"REWORK","_number":1,"created":"2023-03-04 18:34:30.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/18/7518/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/18/7518/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/18/7518/1 \u0026\u0026 git checkout -b change-7518 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/18/7518/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/18/7518/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/18/7518/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/18/7518/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/18/7518/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"06cd205d517039964a6a8c8cccf96f34ef158247","subject":"jimtcl: update to version 0.82"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-03-04 18:19:16.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-03-04 18:19:16.000000000","tz":60},"subject":"openocd: drop JIM_EMBEDDED macro","message":"openocd: drop JIM_EMBEDDED macro\n\nThe macro JIM_EMBEDDED was required to be defined before including\njim.h in applications that embed jimtcl.\nThis requirement has been dropped in 2010 by removing the file\ndos/Embedder-HOWTO.txt from jimtcl in\nhttps://github.com/msteveb/jimtcl/commit/2d8564100c86#diff-3e93fa55e666\n\nDrop the macro definition and the comment that mandates it.\n\nChange-Id: I36883f60f25bb25839e4ebf908159569659764dd\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"642735449a3a7297126a3dd9b76ffaaca74a1752":{"kind":"REWORK","_number":3,"created":"2023-03-18 21:58:01.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/18/7518/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/18/7518/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/18/7518/3 \u0026\u0026 git checkout -b change-7518 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/18/7518/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/18/7518/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/18/7518/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/18/7518/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/18/7518/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"e8f376e3c1874ccd14e148164d9695a93c575def","subject":"helper: add compiler.h to handle compiler specific workarounds"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-03-04 18:19:16.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-03-18 21:58:01.000000000","tz":0},"subject":"openocd: drop JIM_EMBEDDED macro","message":"openocd: drop JIM_EMBEDDED macro\n\nThe macro JIM_EMBEDDED was required to be defined before including\njim.h in applications that embed jimtcl.\nThis requirement has been dropped in 2010 by removing the file\ndos/Embedder-HOWTO.txt from jimtcl in\nhttps://github.com/msteveb/jimtcl/commit/2d8564100c86#diff-3e93fa55e666\n\nDrop the macro definition and the comment that mandates it.\n\nChange-Id: I36883f60f25bb25839e4ebf908159569659764dd\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7518\nTested-by: jenkins\n"}},"50d7d5fc77fc6dfe7c3844e7f13abf4f0d9f5681":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2023-03-04 21:29:56.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/18/7518/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/18/7518/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/18/7518/2 \u0026\u0026 git checkout -b change-7518 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/18/7518/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/18/7518/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/18/7518/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/18/7518/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/18/7518/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"fc30feb51a76e893646e2794c99a78dbdc0d251f","subject":"tlc/interface: does fix source of raspberrypi-gpio-connector.cfg in raspberrypi-native.cfg"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-03-04 18:19:16.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-03-04 21:19:25.000000000","tz":60},"subject":"openocd: drop JIM_EMBEDDED macro","message":"openocd: drop JIM_EMBEDDED macro\n\nThe macro JIM_EMBEDDED was required to be defined before including\njim.h in applications that embed jimtcl.\nThis requirement has been dropped in 2010 by removing the file\ndos/Embedder-HOWTO.txt from jimtcl in\nhttps://github.com/msteveb/jimtcl/commit/2d8564100c86#diff-3e93fa55e666\n\nDrop the macro definition and the comment that mandates it.\n\nChange-Id: I36883f60f25bb25839e4ebf908159569659764dd\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}