)]}'
{"id":"openocd~master~I92d871337281169134ce8e40b2064591518be71f","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2023-03-05 21:42:09.000000000","reason":"Antonio Borneo replied on the change"}},"hashtags":[],"change_id":"I92d871337281169134ce8e40b2064591518be71f","subject":"helper: add compiler.h to handle compiler specific workarounds","status":"MERGED","created":"2023-03-04 23:07:46.000000000","updated":"2023-03-18 21:57:27.000000000","submitted":"2023-03-18 21:57:27.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7519","meta_rev_id":"cea400e01da9458f7e441a4b63c8f370d65519f0","_number":7519,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-03-18 21:57:27.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-03-18 21:57:27.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-03-18 21:57:27.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-03-04 23:22:41.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-03-05 12:02:11.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"CC"},{"updated":"2023-03-05 15:35:13.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"}],"messages":[{"id":"f5a0b7c0bb26c403d197b7eb66da0302c9f7b1ba","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-03-04 23:07:46.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1329026ab788444dba1c8f8f37b7dccc2090557f","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-03-04 23:22:41.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16637/ : FAILURE\n\nhttps://build.openocd.org/job/openocd-gerrit/17432/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"13a56e160f27532d6e58b7bd201af1c07b283fb1","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-03-05 12:02:11.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"7b315c4a4478ae99ac41e0d4927c744798756e5e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-03-05 14:20:37.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"f107b6ac730c8e497a3c80722d18795af0b1d1d3","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-03-05 15:14:19.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16638/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/17433/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"efa476537710f78cdb7e36ebed66d18b4fbc6e4c","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-03-05 15:35:13.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"686b2fab0937f42965f22e350735ab222b638579","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-03-05 21:42:09.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"cea400e01da9458f7e441a4b63c8f370d65519f0","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-03-18 21:57:27.000000000","message":"Change has been successfully cherry-picked as e8f376e3c1874ccd14e148164d9695a93c575def","accounts_in_message":[],"_revision_number":3}],"current_revision":"e8f376e3c1874ccd14e148164d9695a93c575def","revisions":{"00b057d213231be08e28ce002aa06c92123bad7b":{"kind":"REWORK","_number":2,"created":"2023-03-05 14:20:37.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/19/7519/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/19/7519/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/19/7519/2 \u0026\u0026 git checkout -b change-7519 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/19/7519/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/19/7519/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/19/7519/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/19/7519/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/19/7519/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"fc30feb51a76e893646e2794c99a78dbdc0d251f","subject":"tlc/interface: does fix source of raspberrypi-gpio-connector.cfg in raspberrypi-native.cfg"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-03-04 22:56:35.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-03-05 14:19:20.000000000","tz":60},"subject":"helper: add compiler.h to handle compiler specific workarounds","message":"helper: add compiler.h to handle compiler specific workarounds\n\nNot all compilers nor compiler versions supports the attributes\nused in OpenOCD code.\nCollect in a single file the workaround to handle them.\n\nChange-Id: I92d871337281169134ce8e40b2064591518be71f\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"e8f376e3c1874ccd14e148164d9695a93c575def":{"kind":"REWORK","_number":3,"created":"2023-03-18 21:57:27.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/19/7519/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/19/7519/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/19/7519/3 \u0026\u0026 git checkout -b change-7519 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/19/7519/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/19/7519/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/19/7519/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/19/7519/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/19/7519/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"904d58c208ab03f09f8d8e7184d49f42f6e16533","subject":"target/xtensa: add NX support"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-03-04 22:56:35.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-03-18 21:57:27.000000000","tz":0},"subject":"helper: add compiler.h to handle compiler specific workarounds","message":"helper: add compiler.h to handle compiler specific workarounds\n\nNot all compilers nor compiler versions supports the attributes\nused in OpenOCD code.\nCollect in a single file the workaround to handle them.\n\nChange-Id: I92d871337281169134ce8e40b2064591518be71f\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7519\nTested-by: jenkins\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"289e0c538176fd8ce27931fe28d5e75bdc82d43f":{"kind":"REWORK","_number":1,"created":"2023-03-04 23:07:46.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/19/7519/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/19/7519/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/19/7519/1 \u0026\u0026 git checkout -b change-7519 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/19/7519/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/19/7519/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/19/7519/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/19/7519/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/19/7519/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"fc30feb51a76e893646e2794c99a78dbdc0d251f","subject":"tlc/interface: does fix source of raspberrypi-gpio-connector.cfg in raspberrypi-native.cfg"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-03-04 22:56:35.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-03-04 23:05:31.000000000","tz":60},"subject":"helper: add compiler.h to handle compiler specific workarounds","message":"helper: add compiler.h to handle compiler specific workarounds\n\nNot all compilers nor compiler versions supports the attributes\nused in OpenOCD code.\nCollect in a single file the workaround to handle them.\n\nChange-Id: I92d871337281169134ce8e40b2064591518be71f\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}