)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"114e7375558475c5bd1bf5827a783f8ce3738986","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"70309009_6500fd9b","updated":"2023-03-06 06:46:35.000000000","message":"Wolfram,\nthanks for fixing this old stuff.\n\nUnfortunately the structure of the config files is quite broken too.\nThe adapter configuration (interface/ftdi/calao-usb-...) should never include the target configuration (target/at91sam9260.cfg). Nowadays a board config (in tcl/board directory) is required to include the target and an on-board adapter configuration if there is one.\n\nThe include file tcl/interface/calao-usb-a9260.cfg is IMO screwed too.\nBoth \u0027adapter srst delay\u0027 and \u0027jtag_ntrst_delay\u0027 are relevant to a board or a target, not to the adapter. I think these values should go directly to board config file, the include is nonsense in this case.\n\nCould you please address the structure refactoring?","commit_id":"46c51d80c9ff16a8b5e17b8b8726d664a2b3f481"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"a9f316d3a09a7e95fd6d2e104e5c04c663a9703f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4d218ac6_ca251c41","in_reply_to":"4bfa9ab5_dbf7de52","updated":"2023-03-06 13:07:18.000000000","message":"Done","commit_id":"46c51d80c9ff16a8b5e17b8b8726d664a2b3f481"},{"author":{"_account_id":1002122,"name":"Wolfram Sang","email":"wsa@kernel.org","username":"wsakernel"},"change_message_id":"456dd0d72460d8d15e18f20c86e6712b25d1c88a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4bfa9ab5_dbf7de52","in_reply_to":"70309009_6500fd9b","updated":"2023-03-06 09:03:33.000000000","message":"Yes, I think I understand what you mean. I\u0027ll update accordingly. Actually, I was confused what was the difference between \"board\" and \"interface\" but didn\u0027t investigate further. Now, it seems clear.","commit_id":"46c51d80c9ff16a8b5e17b8b8726d664a2b3f481"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"1ff4963a275362ff65458456ac8befcc46c3a500","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"bf2bff3d_fdf679c9","updated":"2023-03-06 21:47:37.000000000","message":"Thanks for the cleanup","commit_id":"1d7d880f87c3039b52c127e8930594aa2223d13d"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"45553b6fde6b8b98bc3c74087809ee1523f83b7d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"163307ba_bd010fdb","updated":"2023-03-10 06:51:28.000000000","message":"Looks good, just a minor problem from the original config.","commit_id":"a2073d2d4564876c25886daaa270a0c68d18fcec"},{"author":{"_account_id":1002122,"name":"Wolfram Sang","email":"wsa@kernel.org","username":"wsakernel"},"change_message_id":"0a7c19dcbb725447ef32fac7d291ea9bd5109bab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a966345a_15571e36","updated":"2023-03-17 18:07:02.000000000","message":"Ouch, fixed it right away, then forgot to push :/ Here it is now.","commit_id":"06b650517e0db080b9c2db0cac0221db76c20496"}],"src/helper/startup.tcl":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"929136590744ee69f27e0553702861401ab577d2","unresolved":true,"context_lines":[{"line_number":23,"context_line":"add_usage_text find \"\u003cfile\u003e\""},{"line_number":24,"context_line":"add_help_text find \"print full path to file according to OpenOCD search rules\""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# Find and run a script"},{"line_number":27,"context_line":"proc script {filename} {"},{"line_number":28,"context_line":"\tuplevel #0 [list source [find $filename]]"},{"line_number":29,"context_line":"}"},{"line_number":30,"context_line":"add_help_text script \"filename of OpenOCD script (tcl) to run\""},{"line_number":31,"context_line":"add_usage_text script \"\u003cfile\u003e\""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"# Run a list of post-init commands"},{"line_number":34,"context_line":"# Each command should be added with \u0027lappend post_init_commands command\u0027"}],"source_content_type":"text/x-tcl","patch_set":2,"id":"5c9f407a_da09503e","line":31,"range":{"start_line":26,"start_character":0,"end_line":31,"end_character":30},"updated":"2023-03-07 05:55:08.000000000","message":"...see definition here","commit_id":"1d7d880f87c3039b52c127e8930594aa2223d13d"},{"author":{"_account_id":1002122,"name":"Wolfram Sang","email":"wsa@kernel.org","username":"wsakernel"},"change_message_id":"0a7c19dcbb725447ef32fac7d291ea9bd5109bab","unresolved":false,"context_lines":[{"line_number":23,"context_line":"add_usage_text find \"\u003cfile\u003e\""},{"line_number":24,"context_line":"add_help_text find \"print full path to file according to OpenOCD search rules\""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# Find and run a script"},{"line_number":27,"context_line":"proc script {filename} {"},{"line_number":28,"context_line":"\tuplevel #0 [list source [find $filename]]"},{"line_number":29,"context_line":"}"},{"line_number":30,"context_line":"add_help_text script \"filename of OpenOCD script (tcl) to run\""},{"line_number":31,"context_line":"add_usage_text script \"\u003cfile\u003e\""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"# Run a list of post-init commands"},{"line_number":34,"context_line":"# Each command should be added with \u0027lappend post_init_commands command\u0027"}],"source_content_type":"text/x-tcl","patch_set":2,"id":"da4bb9a7_5a60cc45","line":31,"range":{"start_line":26,"start_character":0,"end_line":31,"end_character":30},"in_reply_to":"5c9f407a_da09503e","updated":"2023-03-17 18:07:02.000000000","message":"Ack","commit_id":"1d7d880f87c3039b52c127e8930594aa2223d13d"}],"tcl/board/calao-usb-a9260.cfg":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"a9f316d3a09a7e95fd6d2e104e5c04c663a9703f","unresolved":true,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# CALAO Systems USB-A9260 (C01 and C02)"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"adapter driver ftdi"},{"line_number":6,"context_line":"ftdi device_desc \"USB-A9260\""},{"line_number":7,"context_line":"ftdi vid_pid 0x0403 0x6001 0x0403 0x6010"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"ftdi layout_init 0x0c08 0x0f1b"},{"line_number":10,"context_line":"ftdi layout_signal nTRST -data 0x0100 -noe 0x0400"},{"line_number":11,"context_line":"ftdi layout_signal nSRST -data 0x0200 -noe 0x0800"},{"line_number":12,"context_line":"transport select jtag"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"adapter srst delay 200"},{"line_number":15,"context_line":"jtag_ntrst_delay 200"}],"source_content_type":"text/x-ttcn-cfg","patch_set":2,"id":"26607ac2_c33d8811","line":12,"range":{"start_line":5,"start_character":0,"end_line":12,"end_character":21},"updated":"2023-03-06 13:07:18.000000000","message":"Originally I mentioned this part would go to e.g. interface/ftdi/calao-usb-xx.cfg\nand will included from here.\nThe on-board adapter defined directly in a board file is simpler and have been used several times in OpenOCD - so should be ok - let\u0027s ask Antonio to be sure.","commit_id":"1d7d880f87c3039b52c127e8930594aa2223d13d"},{"author":{"_account_id":1002122,"name":"Wolfram Sang","email":"wsa@kernel.org","username":"wsakernel"},"change_message_id":"a07971985c05eaf49a24799f11a2d38afeea96ec","unresolved":true,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# CALAO Systems USB-A9260 (C01 and C02)"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"adapter driver ftdi"},{"line_number":6,"context_line":"ftdi device_desc \"USB-A9260\""},{"line_number":7,"context_line":"ftdi vid_pid 0x0403 0x6001 0x0403 0x6010"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"ftdi layout_init 0x0c08 0x0f1b"},{"line_number":10,"context_line":"ftdi layout_signal nTRST -data 0x0100 -noe 0x0400"},{"line_number":11,"context_line":"ftdi layout_signal nSRST -data 0x0200 -noe 0x0800"},{"line_number":12,"context_line":"transport select jtag"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"adapter srst delay 200"},{"line_number":15,"context_line":"jtag_ntrst_delay 200"}],"source_content_type":"text/x-ttcn-cfg","patch_set":2,"id":"32057fec_82b07bda","line":12,"range":{"start_line":5,"start_character":0,"end_line":12,"end_character":21},"in_reply_to":"26607ac2_c33d8811","updated":"2023-03-06 14:18:56.000000000","message":"I see. The first three lines could only be shared with A9260. So we\u0027d need another interface file for the A9G20. Because \u0027device_desc\u0027 differs. I\u0027d prefer the current solution but can change to the other, of course, if this is favored.","commit_id":"1d7d880f87c3039b52c127e8930594aa2223d13d"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"1ff4963a275362ff65458456ac8befcc46c3a500","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# CALAO Systems USB-A9260 (C01 and C02)"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"adapter driver ftdi"},{"line_number":6,"context_line":"ftdi device_desc \"USB-A9260\""},{"line_number":7,"context_line":"ftdi vid_pid 0x0403 0x6001 0x0403 0x6010"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"ftdi layout_init 0x0c08 0x0f1b"},{"line_number":10,"context_line":"ftdi layout_signal nTRST -data 0x0100 -noe 0x0400"},{"line_number":11,"context_line":"ftdi layout_signal nSRST -data 0x0200 -noe 0x0800"},{"line_number":12,"context_line":"transport select jtag"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"adapter srst delay 200"},{"line_number":15,"context_line":"jtag_ntrst_delay 200"}],"source_content_type":"text/x-ttcn-cfg","patch_set":2,"id":"5b2bd5fb_a4517e23","line":12,"range":{"start_line":5,"start_character":0,"end_line":12,"end_character":21},"in_reply_to":"32057fec_82b07bda","updated":"2023-03-06 21:47:37.000000000","message":"I think it\u0027s ok. This is a dedicated on-board FTDI adapter\n.","commit_id":"1d7d880f87c3039b52c127e8930594aa2223d13d"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"1b05123b52b697f12063e7dd6b41d2e7c9e8e302","unresolved":true,"context_lines":[{"line_number":14,"context_line":"adapter srst delay 200"},{"line_number":15,"context_line":"jtag_ntrst_delay 200"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"script target/at91sam9260.cfg"}],"source_content_type":"text/x-ttcn-cfg","patch_set":2,"id":"b52bb7cc_0bfde916","line":17,"updated":"2023-03-06 22:03:25.000000000","message":"oops, missed this. It should be\n script [find target/at91sam9260.cfg]","commit_id":"1d7d880f87c3039b52c127e8930594aa2223d13d"},{"author":{"_account_id":1002122,"name":"Wolfram Sang","email":"wsa@kernel.org","username":"wsakernel"},"change_message_id":"063753f9b583cba02d07be8c1a741afa9bbe96ad","unresolved":true,"context_lines":[{"line_number":14,"context_line":"adapter srst delay 200"},{"line_number":15,"context_line":"jtag_ntrst_delay 200"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"script target/at91sam9260.cfg"}],"source_content_type":"text/x-ttcn-cfg","patch_set":2,"id":"79211b42_23639059","line":17,"in_reply_to":"5ce69343_79d55628","updated":"2023-03-07 22:18:09.000000000","message":"Okay, I\u0027ll fix accordingly. The question why we can\u0027t use \u0027script\u0027is interesting, though.","commit_id":"1d7d880f87c3039b52c127e8930594aa2223d13d"},{"author":{"_account_id":1002122,"name":"Wolfram Sang","email":"wsa@kernel.org","username":"wsakernel"},"change_message_id":"0a7c19dcbb725447ef32fac7d291ea9bd5109bab","unresolved":false,"context_lines":[{"line_number":14,"context_line":"adapter srst delay 200"},{"line_number":15,"context_line":"jtag_ntrst_delay 200"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"script target/at91sam9260.cfg"}],"source_content_type":"text/x-ttcn-cfg","patch_set":2,"id":"e250d90d_3005a4af","line":17,"in_reply_to":"79211b42_23639059","updated":"2023-03-17 18:07:02.000000000","message":"Ack","commit_id":"1d7d880f87c3039b52c127e8930594aa2223d13d"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"929136590744ee69f27e0553702861401ab577d2","unresolved":true,"context_lines":[{"line_number":14,"context_line":"adapter srst delay 200"},{"line_number":15,"context_line":"jtag_ntrst_delay 200"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"script target/at91sam9260.cfg"}],"source_content_type":"text/x-ttcn-cfg","patch_set":2,"id":"5ce69343_79d55628","line":17,"in_reply_to":"b52bb7cc_0bfde916","updated":"2023-03-07 05:55:08.000000000","message":"You probably mean\n\n source [find target/at91sam9260.cfg]\n\nAnother question arises. What is the \u0027script\u0027 command for if it cannot be used? Shouldn\u0027t we drop it?","commit_id":"1d7d880f87c3039b52c127e8930594aa2223d13d"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"45553b6fde6b8b98bc3c74087809ee1523f83b7d","unresolved":true,"context_lines":[{"line_number":10,"context_line":"ftdi layout_signal nSRST -data 0x0200 -noe 0x0800"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"transport select jtag"},{"line_number":13,"context_line":"adapter srst delay 200"},{"line_number":14,"context_line":"jtag_ntrst_delay 200"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"source [find target/at91sam9260.cfg]"}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"bf1403f2_d36b6222","line":14,"range":{"start_line":13,"start_character":0,"end_line":14,"end_character":20},"updated":"2023-03-10 06:51:28.000000000","message":"I checked the included target config and it rewrites both values.\n\nTo prevent unwanted surprises when somebody changes any of the values here I propose to remove them. Alternatively move them after source ...at91sam9260.cfg","commit_id":"a2073d2d4564876c25886daaa270a0c68d18fcec"},{"author":{"_account_id":1002122,"name":"Wolfram Sang","email":"wsa@kernel.org","username":"wsakernel"},"change_message_id":"0a7c19dcbb725447ef32fac7d291ea9bd5109bab","unresolved":false,"context_lines":[{"line_number":10,"context_line":"ftdi layout_signal nSRST -data 0x0200 -noe 0x0800"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"transport select jtag"},{"line_number":13,"context_line":"adapter srst delay 200"},{"line_number":14,"context_line":"jtag_ntrst_delay 200"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"source [find target/at91sam9260.cfg]"}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"015e9ace_3a5f3c85","line":14,"range":{"start_line":13,"start_character":0,"end_line":14,"end_character":20},"in_reply_to":"bf1403f2_d36b6222","updated":"2023-03-17 18:07:02.000000000","message":"Ack","commit_id":"a2073d2d4564876c25886daaa270a0c68d18fcec"}],"tcl/target/at91sam9.cfg":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"45553b6fde6b8b98bc3c74087809ee1523f83b7d","unresolved":true,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"jtag newtap $_CHIPNAME cpu -irlen 4 -ircapture 0x1 -irmask 0xf -expected-id $_CPUTAPID"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"adapter srst delay 300"},{"line_number":30,"context_line":"jtag_ntrst_delay 200"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"adapter speed 3"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"9ac88a53_5580eb4c","side":"PARENT","line":30,"range":{"start_line":29,"start_character":0,"end_line":30,"end_character":20},"updated":"2023-03-10 06:51:28.000000000","message":"...both gets rewritten here.","commit_id":"fc30feb51a76e893646e2794c99a78dbdc0d251f"},{"author":{"_account_id":1002122,"name":"Wolfram Sang","email":"wsa@kernel.org","username":"wsakernel"},"change_message_id":"0a7c19dcbb725447ef32fac7d291ea9bd5109bab","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"jtag newtap $_CHIPNAME cpu -irlen 4 -ircapture 0x1 -irmask 0xf -expected-id $_CPUTAPID"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"adapter srst delay 300"},{"line_number":30,"context_line":"jtag_ntrst_delay 200"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"adapter speed 3"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"431107f6_c52acc2d","side":"PARENT","line":30,"range":{"start_line":29,"start_character":0,"end_line":30,"end_character":20},"in_reply_to":"9ac88a53_5580eb4c","updated":"2023-03-17 18:07:02.000000000","message":"Ack","commit_id":"fc30feb51a76e893646e2794c99a78dbdc0d251f"}]}