)]}'
{"id":"openocd~master~I2f9153c5a41ba66b989b27c7bc57b38d1744cc29","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000160":{"account":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"last_update":"2023-03-18 21:58:20.000000000","reason":"Change was submitted"},"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2023-03-18 21:58:14.000000000","reason":"removed on reply"},"1000853":{"account":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"last_update":"2023-03-08 20:47:13.000000000","reason":"Marc Schink replied on the change"}},"hashtags":[],"change_id":"I2f9153c5a41ba66b989b27c7bc57b38d1744cc29","subject":"build: fix distcheck for jimtcl","status":"MERGED","created":"2023-03-06 00:06:41.000000000","updated":"2023-03-18 21:58:20.000000000","submitted":"2023-03-18 21:58:20.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7527","meta_rev_id":"c6d1cbf40efa0eeaad681d270d5450047b0af77d","_number":7527,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-03-18 21:58:20.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-03-18 21:58:20.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-03-18 21:58:20.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"}],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-03-06 05:31:41.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-03-06 09:03:12.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"state":"REVIEWER"},{"updated":"2023-03-06 09:03:12.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"state":"REVIEWER"}],"messages":[{"id":"bd8eb213c1e449fb466c1d7f42a7f2f882e9b38c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-03-06 00:06:41.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"957afe963df0cedc02887fea028026d6b61c055a","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-03-06 05:31:41.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16648/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/17443/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"fac77d01a426137ab905f3278fa1b0e84a64788e","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-03-06 09:03:12.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"6e9c28349631992d5426f7f94e8048889f9e7457","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2023-03-08 20:47:13.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"ffe976abdf9fa7c84a202a123c68565c7923f795","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-03-18 21:58:14.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"c6d1cbf40efa0eeaad681d270d5450047b0af77d","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-03-18 21:58:20.000000000","message":"Change has been successfully cherry-picked as 45eeeab3080991168a07854af5dded926a22253c","accounts_in_message":[],"_revision_number":2}],"current_revision":"45eeeab3080991168a07854af5dded926a22253c","revisions":{"1303982a865c8a24ebc8f1879d3c8b90a2000cec":{"kind":"REWORK","_number":1,"created":"2023-03-06 00:06:41.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/27/7527/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/27/7527/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/27/7527/1 \u0026\u0026 git checkout -b change-7527 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/27/7527/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/27/7527/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/27/7527/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/27/7527/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/27/7527/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"50d7d5fc77fc6dfe7c3844e7f13abf4f0d9f5681","subject":"openocd: drop JIM_EMBEDDED macro"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-03-05 23:27:58.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-03-05 23:57:57.000000000","tz":60},"subject":"build: fix distcheck for jimtcl","message":"build: fix distcheck for jimtcl\n\nThe issues have been highlighted while integrated jimtcl 0.82,\nbut were already present.\n\nWhile building jimtcl as submodule, OpenOCD generates the file\njimtcl/configure.gnu to pass specific configure flags.\nIssue 1: this file is not included in the distribution.\nThis causes the rebuild from the distribution to have a jimtcl\nbuilt with different (the default) configure flags.\nWith jimtcl 0.82 the new default is to enable all the features,\nbut a bug causes the build to fail when openssl is not installed\nin the build system (the bug is already fixed but after 0.82 [1]).\nAll these together cause OpenOCD Jenkins to fail the build for\ntarget \u0027distcheck\u0027 with jimtcl 0.82.\n\nAdd jimtcl/configure.gnu to OpenOCD distribution\u0027s file list.\n\nThe build system considers jimtcl/configure.gnu as a temporarily\nfile that should be removed during \u0027distclean\u0027.\nIssue 2: \u0027distcheck\u0027 set read-only permission to the source files,\nincluding jimtcl/configure.gnu, so \u0027distclean\u0027 fails removing it.\n\nAdd a leading \u0027-\u0027 to ignore errors while trying to remove the\nfile.\n\nIssue 3: Now that \u0027distcheck\u0027 properly configures and builds\njimtcl, \u0027distcheck\u0027 still fails because we have enabled jimtcl\njson support in [2] and jimtcl \u0027distclean\u0027 fails to properly\nremove one object file (fixed after 0.82 [3]).\n\nMake OpenOCD removing the file jimtcl/jsmn/jsmn.o to complete\nthe execution of \u0027distcheck\u0027. Add a comment specifying which of\nthe jimtcl versions are affected.\n\nChange-Id: I2f9153c5a41ba66b989b27c7bc57b38d1744cc29\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nLink: [1] https://github.com/msteveb/jimtcl/commit/22277943a19c\nLink: [2] 0a36acbf6ac6 (\"configure: build jimtcl with json extension\")\nLink: [3] https://github.com/msteveb/jimtcl/commit/32a488587a3e\n"}},"45eeeab3080991168a07854af5dded926a22253c":{"kind":"REWORK","_number":2,"created":"2023-03-18 21:58:20.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/27/7527/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/27/7527/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/27/7527/2 \u0026\u0026 git checkout -b change-7527 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/27/7527/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/27/7527/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/27/7527/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/27/7527/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/27/7527/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"642735449a3a7297126a3dd9b76ffaaca74a1752","subject":"openocd: drop JIM_EMBEDDED macro"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-03-05 23:27:58.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-03-18 21:58:20.000000000","tz":0},"subject":"build: fix distcheck for jimtcl","message":"build: fix distcheck for jimtcl\n\nThe issues have been highlighted while integrated jimtcl 0.82,\nbut were already present.\n\nWhile building jimtcl as submodule, OpenOCD generates the file\njimtcl/configure.gnu to pass specific configure flags.\nIssue 1: this file is not included in the distribution.\nThis causes the rebuild from the distribution to have a jimtcl\nbuilt with different (the default) configure flags.\nWith jimtcl 0.82 the new default is to enable all the features,\nbut a bug causes the build to fail when openssl is not installed\nin the build system (the bug is already fixed but after 0.82 [1]).\nAll these together cause OpenOCD Jenkins to fail the build for\ntarget \u0027distcheck\u0027 with jimtcl 0.82.\n\nAdd jimtcl/configure.gnu to OpenOCD distribution\u0027s file list.\n\nThe build system considers jimtcl/configure.gnu as a temporarily\nfile that should be removed during \u0027distclean\u0027.\nIssue 2: \u0027distcheck\u0027 set read-only permission to the source files,\nincluding jimtcl/configure.gnu, so \u0027distclean\u0027 fails removing it.\n\nAdd a leading \u0027-\u0027 to ignore errors while trying to remove the\nfile.\n\nIssue 3: Now that \u0027distcheck\u0027 properly configures and builds\njimtcl, \u0027distcheck\u0027 still fails because we have enabled jimtcl\njson support in [2] and jimtcl \u0027distclean\u0027 fails to properly\nremove one object file (fixed after 0.82 [3]).\n\nMake OpenOCD removing the file jimtcl/jsmn/jsmn.o to complete\nthe execution of \u0027distcheck\u0027. Add a comment specifying which of\nthe jimtcl versions are affected.\n\nChange-Id: I2f9153c5a41ba66b989b27c7bc57b38d1744cc29\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nLink: [1] https://github.com/msteveb/jimtcl/commit/22277943a19c\nLink: [2] 0a36acbf6ac6 (\"configure: build jimtcl with json extension\")\nLink: [3] https://github.com/msteveb/jimtcl/commit/32a488587a3e\nReviewed-on: https://review.openocd.org/c/openocd/+/7527\nTested-by: jenkins\nReviewed-by: zapb \u003cdev@zapb.de\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}