)]}'
{"id":"openocd~master~I5efe9ce576a3a50588b30000222665e26161dfdc","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2023-03-25 18:08:15.000000000","reason":"removed on reply"},"1002108":{"account":{"_account_id":1002108,"name":"kaischmitzAdv","email":"kai.schmitz@advantest.com","username":"kaischmitzAdv"},"last_update":"2023-03-20 08:51:04.000000000","reason":"kaischmitzAdv replied on the change"}},"hashtags":[],"change_id":"I5efe9ce576a3a50588b30000222665e26161dfdc","subject":"svf: fix leaking file descriptor","status":"MERGED","created":"2023-03-10 12:05:10.000000000","updated":"2023-03-25 18:08:18.000000000","submitted":"2023-03-25 18:08:18.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7532","meta_rev_id":"e1705475412d8d5996d692a73c71e7ea5a555493","_number":7532,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-03-25 18:08:18.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"value":0,"_account_id":1002108,"name":"kaischmitzAdv","email":"kai.schmitz@advantest.com","username":"kaischmitzAdv"}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-03-25 18:08:18.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-03-25 18:08:18.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-03-25 18:08:18.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1002108,"name":"kaischmitzAdv","email":"kai.schmitz@advantest.com","username":"kaischmitzAdv"}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"_account_id":1002108,"name":"kaischmitzAdv","email":"kai.schmitz@advantest.com","username":"kaischmitzAdv"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-03-10 12:05:10.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1002108,"name":"kaischmitzAdv","email":"kai.schmitz@advantest.com","username":"kaischmitzAdv"},"state":"REVIEWER"},{"updated":"2023-03-10 15:14:15.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-03-11 05:33:26.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"}],"messages":[{"id":"a8d5c2ec6ceac3388e73e1941c4e96d892a050f8","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-03-10 12:05:10.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a9819ac2675ce5fd9c80ff1a2d7257fa82b08daf","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-03-10 12:07:24.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"21afa48f09b1ef6fedcf8389382a503be64a9fb7","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-03-10 15:14:15.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16666/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/17461/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"3cfc466b4ffb4f720009eb8b651bf5dbd6d55f73","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-03-11 05:33:26.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"6edcf66895c36eb63d13ebd947476f61df5ca164","author":{"_account_id":1002108,"name":"kaischmitzAdv","email":"kai.schmitz@advantest.com","username":"kaischmitzAdv"},"real_author":{"_account_id":1002108,"name":"kaischmitzAdv","email":"kai.schmitz@advantest.com","username":"kaischmitzAdv"},"date":"2023-03-20 08:51:04.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"b011c90da375862f6dd7cbacd81c101e0cafd6aa","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-03-25 18:08:15.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"e1705475412d8d5996d692a73c71e7ea5a555493","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-03-25 18:08:18.000000000","message":"Change has been successfully cherry-picked as 86827a961a22815ebd5fa367468ca7444f0ee2e1","accounts_in_message":[],"_revision_number":2}],"current_revision":"86827a961a22815ebd5fa367468ca7444f0ee2e1","revisions":{"75a9dec49e11191c77efeadaa054e1b989567025":{"kind":"REWORK","_number":1,"created":"2023-03-10 12:05:10.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/32/7532/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/32/7532/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/32/7532/1 \u0026\u0026 git checkout -b change-7532 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/32/7532/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/32/7532/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/32/7532/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/32/7532/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/32/7532/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b74c9d1787fa3b4c73852a73657f1e5d7443fc2d","subject":"svf: new command line options -noreset and -addcycles"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-03-10 10:50:08.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-03-10 11:55:47.000000000","tz":60},"subject":"svf: fix leaking file descriptor","message":"svf: fix leaking file descriptor\n\nThe file descriptor svf_fd is not closed on command error, thus\nleaking memory.\n\nClose svf_fd on errors.\nWhile there, properly initialize svf_fd using NULL instead of 0.\n\nChange-Id: I5efe9ce576a3a50588b30000222665e26161dfdc\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"86827a961a22815ebd5fa367468ca7444f0ee2e1":{"kind":"REWORK","_number":2,"created":"2023-03-25 18:08:18.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/32/7532/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/32/7532/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/32/7532/2 \u0026\u0026 git checkout -b change-7532 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/32/7532/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/32/7532/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/32/7532/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/32/7532/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/32/7532/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"415715d91a11ea4ed6db3a1fd760741a22b6e098","subject":"target/adi_v5_jtag: fix endianness error in transaction replay"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-03-10 10:50:08.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-03-25 18:08:18.000000000","tz":0},"subject":"svf: fix leaking file descriptor","message":"svf: fix leaking file descriptor\n\nThe file descriptor svf_fd is not closed on command error, thus\nleaking memory.\n\nClose svf_fd on errors.\nWhile there, properly initialize svf_fd using NULL instead of 0.\n\nChange-Id: I5efe9ce576a3a50588b30000222665e26161dfdc\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7532\nTested-by: jenkins\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nReviewed-by: \u003ckai.schmitz@advantest.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}