)]}'
{"id":"openocd~master~I61fd89cad10652f2f9ef1f9d48a040e35253c3d4","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2023-03-25 18:08:41.000000000","reason":"removed on reply"},"1002108":{"account":{"_account_id":1002108,"name":"kaischmitzAdv","email":"kai.schmitz@advantest.com","username":"kaischmitzAdv"},"last_update":"2023-03-25 18:08:45.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I61fd89cad10652f2f9ef1f9d48a040e35253c3d4","subject":"svf: fix memory leak on error during command execution","status":"MERGED","created":"2023-03-10 12:05:10.000000000","updated":"2023-03-25 18:08:45.000000000","submitted":"2023-03-25 18:08:45.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7533","meta_rev_id":"f96c119b07d46adc96a930d6cd48c218395a2cb5","_number":7533,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-03-25 18:08:45.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-03-25 18:08:45.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-03-25 18:08:45.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1002108,"name":"kaischmitzAdv","email":"kai.schmitz@advantest.com","username":"kaischmitzAdv"}],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"_account_id":1002108,"name":"kaischmitzAdv","email":"kai.schmitz@advantest.com","username":"kaischmitzAdv"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-03-10 12:05:10.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1002108,"name":"kaischmitzAdv","email":"kai.schmitz@advantest.com","username":"kaischmitzAdv"},"state":"REVIEWER"},{"updated":"2023-03-10 16:07:59.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-03-11 05:30:41.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"}],"messages":[{"id":"3444142b18806003a4357da8cd285b19810f7422","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-03-10 12:05:10.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c35056774d0240d46d2b440a965c8e1a72cad12f","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-03-10 16:07:59.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16667/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/17462/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"9a5e193d2920a322becf351fcae272fd8df90d0e","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-03-10 22:55:16.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"31c2e8336ebe8941698da50cf046e5f0cca13a86","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-03-11 05:30:41.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"63a58686ae2ccdd85e87824295eefc10614bab6f","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-03-25 18:08:41.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"f96c119b07d46adc96a930d6cd48c218395a2cb5","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-03-25 18:08:45.000000000","message":"Change has been successfully cherry-picked as f8631c3650c0e3a3c3e16726f1ca3748d163cc69","accounts_in_message":[],"_revision_number":2}],"current_revision":"f8631c3650c0e3a3c3e16726f1ca3748d163cc69","revisions":{"f8631c3650c0e3a3c3e16726f1ca3748d163cc69":{"kind":"REWORK","_number":2,"created":"2023-03-25 18:08:45.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/33/7533/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/33/7533/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/33/7533/2 \u0026\u0026 git checkout -b change-7533 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/33/7533/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/33/7533/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/33/7533/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/33/7533/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/33/7533/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"86827a961a22815ebd5fa367468ca7444f0ee2e1","subject":"svf: fix leaking file descriptor"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-03-10 11:01:03.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-03-25 18:08:45.000000000","tz":0},"subject":"svf: fix memory leak on error during command execution","message":"svf: fix memory leak on error during command execution\n\nIf svf_set_padding() returns error, jump to free_all label to\nprevent any memory leak.\nPropagate the error reported by svf_set_padding() instead of\noverwriting it.\nUse command_print() instead of LOG_ERROR() for command output.\n\nChange-Id: I61fd89cad10652f2f9ef1f9d48a040e35253c3d4\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7533\nTested-by: jenkins\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"3f953929733378d79ec78282830673806d3e2e6a":{"kind":"REWORK","_number":1,"created":"2023-03-10 12:05:10.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/33/7533/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/33/7533/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/33/7533/1 \u0026\u0026 git checkout -b change-7533 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/33/7533/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/33/7533/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/33/7533/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/33/7533/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/33/7533/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"75a9dec49e11191c77efeadaa054e1b989567025","subject":"svf: fix leaking file descriptor"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-03-10 11:01:03.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-03-10 11:55:47.000000000","tz":60},"subject":"svf: fix memory leak on error during command execution","message":"svf: fix memory leak on error during command execution\n\nIf svf_set_padding() returns error, jump to free_all label to\nprevent any memory leak.\nPropagate the error reported by svf_set_padding() instead of\noverwriting it.\nUse command_print() instead of LOG_ERROR() for command output.\n\nChange-Id: I61fd89cad10652f2f9ef1f9d48a040e35253c3d4\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}