)]}'
{"id":"openocd~master~I5b944403d92a3fa1e12d5faafc1d2a139bc16a7d","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1002108":{"account":{"_account_id":1002108,"name":"kaischmitzAdv","email":"kai.schmitz@advantest.com","username":"kaischmitzAdv"},"last_update":"2023-03-25 18:09:06.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I5b944403d92a3fa1e12d5faafc1d2a139bc16a7d","subject":"svf: make command \u0027svf\u0027 syntax consistent","status":"MERGED","created":"2023-03-10 12:05:10.000000000","updated":"2023-03-25 18:09:06.000000000","submitted":"2023-03-25 18:09:06.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7534","meta_rev_id":"61cedb5970a4f246b303d61b3f2a8cb028823303","_number":7534,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-03-25 18:09:06.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-03-25 18:09:06.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1002108,"name":"kaischmitzAdv","email":"kai.schmitz@advantest.com","username":"kaischmitzAdv"}],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1002108,"name":"kaischmitzAdv","email":"kai.schmitz@advantest.com","username":"kaischmitzAdv"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-03-10 12:05:10.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1002108,"name":"kaischmitzAdv","email":"kai.schmitz@advantest.com","username":"kaischmitzAdv"},"state":"REVIEWER"},{"updated":"2023-03-10 16:57:39.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"6388a352635cfc1edf0f3dd0ac63ecc9321ff4b2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-03-10 12:05:10.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7f3f9786315d950c96cbe3c3846df2825bcb8e45","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-03-10 16:57:39.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16668/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/17463/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"6f5f468bdef4930c08278927773e57a3d84af60c","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-03-10 22:55:21.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"370ce39539777130acf64c83f0c5061f4e7eef1e","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-03-25 18:09:00.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"61cedb5970a4f246b303d61b3f2a8cb028823303","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-03-25 18:09:06.000000000","message":"Change has been successfully cherry-picked as 5f6ceebbba3a34fc4bfcf56e963739dd2e9cf056","accounts_in_message":[],"_revision_number":2}],"current_revision":"5f6ceebbba3a34fc4bfcf56e963739dd2e9cf056","revisions":{"5f6ceebbba3a34fc4bfcf56e963739dd2e9cf056":{"kind":"REWORK","_number":2,"created":"2023-03-25 18:09:06.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/34/7534/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/34/7534/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/34/7534/2 \u0026\u0026 git checkout -b change-7534 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/34/7534/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/34/7534/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/34/7534/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/34/7534/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/34/7534/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f8631c3650c0e3a3c3e16726f1ca3748d163cc69","subject":"svf: fix memory leak on error during command execution"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-03-10 10:41:54.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-03-25 18:09:06.000000000","tz":0},"subject":"svf: make command \u0027svf\u0027 syntax consistent","message":"svf: make command \u0027svf\u0027 syntax consistent\n\nThe command \u0027svf\u0027 is the only command in OpenOCD that accepts\noptions in both forms \u0027option\u0027 and \u0027-option\u0027.\n\nDeprecate the option format without the leading \u0027-\u0027.\nUpdate the documentation and fix the on-line help.\nWhile there:\n- switch to use the new nvp.h helper;\n- return ERROR_COMMAND_ARGUMENT_INVALID on invalid command args;\n- fix some minor coding style rule.\n\nChange-Id: I5b944403d92a3fa1e12d5faafc1d2a139bc16a7d\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7534\nTested-by: jenkins\n"}},"5aa584cc326e22eb56b963564bdee8064c00759c":{"kind":"REWORK","_number":1,"created":"2023-03-10 12:05:10.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/34/7534/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/34/7534/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/34/7534/1 \u0026\u0026 git checkout -b change-7534 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/34/7534/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/34/7534/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/34/7534/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/34/7534/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/34/7534/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3f953929733378d79ec78282830673806d3e2e6a","subject":"svf: fix memory leak on error during command execution"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-03-10 10:41:54.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-03-10 11:55:47.000000000","tz":60},"subject":"svf: make command \u0027svf\u0027 syntax consistent","message":"svf: make command \u0027svf\u0027 syntax consistent\n\nThe command \u0027svf\u0027 is the only command in OpenOCD that accepts\noptions in both forms \u0027option\u0027 and \u0027-option\u0027.\n\nDeprecate the option format without the leading \u0027-\u0027.\nUpdate the documentation and fix the on-line help.\nWhile there:\n- switch to use the new nvp.h helper;\n- return ERROR_COMMAND_ARGUMENT_INVALID on invalid command args;\n- fix some minor coding style rule.\n\nChange-Id: I5b944403d92a3fa1e12d5faafc1d2a139bc16a7d\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}