)]}'
{"id":"openocd~master~I20f3fdced176c3b9ab00f889743161ecad7280f9","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2023-03-15 09:37:28.000000000","reason":"Antonio Borneo replied on the change"},"1001964":{"account":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"last_update":"2023-03-25 18:06:36.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I20f3fdced176c3b9ab00f889743161ecad7280f9","subject":"target/espressif: check common_magic instead of gdb_arch string","status":"MERGED","created":"2023-03-14 22:27:08.000000000","updated":"2023-03-25 18:06:36.000000000","submitted":"2023-03-25 18:06:36.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7536","meta_rev_id":"132c9d24f961709fefefa06752b513608b0251a5","_number":7536,"owner":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-03-25 18:06:36.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-03-25 18:06:36.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-03-14 22:28:58.000000000","updated_by":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"},{"updated":"2023-03-15 00:06:02.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"f9be9a072fd72d49baf41f32c57b42b01f9f3f4b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"real_author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"date":"2023-03-14 22:27:08.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7583cf40c28e722025879162bb0ba065bff35e98","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-03-15 00:06:02.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16674/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/17469/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"dfcaf952f0b4133659d30a507ebb6a812327b721","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-03-15 09:37:28.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"132c9d24f961709fefefa06752b513608b0251a5","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-03-25 18:06:36.000000000","message":"Change has been successfully cherry-picked as faeae51d7f497d83ab166329abb1f06aa5903774","accounts_in_message":[],"_revision_number":2}],"current_revision":"faeae51d7f497d83ab166329abb1f06aa5903774","revisions":{"faeae51d7f497d83ab166329abb1f06aa5903774":{"kind":"REWORK","_number":2,"created":"2023-03-25 18:06:36.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/36/7536/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/36/7536/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/36/7536/2 \u0026\u0026 git checkout -b change-7536 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/36/7536/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/36/7536/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/36/7536/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/36/7536/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/36/7536/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ee31f1578a333a75737bc5b183cd4ae98cdaf798","subject":"rtos/nuttx: add Espressif target support and refactoring"}],"author":{"name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","date":"2023-03-14 22:22:10.000000000","tz":180},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-03-25 18:06:36.000000000","tz":0},"subject":"target/espressif: check common_magic instead of gdb_arch string","message":"target/espressif: check common_magic instead of gdb_arch string\n\nThe value returned by target_get_gdb_arch() is something specific for GDB.\nThere could be several variants of the same CPU.\nIf we start implementing all the variants, checking the string value,\ncould become incorrect.\nIt\u0027s better to check for xtensa-\u003ecommon_magic \u003d\u003d XTENSA_COMMON_MAGIC\n\nSigned-off-by: Erhan Kurubas \u003cerhan.kurubas@espressif.com\u003e\nChange-Id: I20f3fdced176c3b9ab00f889743161ecad7280f9\nReviewed-on: https://review.openocd.org/c/openocd/+/7536\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"5d9b9d2dde809ef7ed39c70dc7d59af8f5163cdd":{"kind":"REWORK","_number":1,"created":"2023-03-14 22:27:08.000000000","uploader":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"ref":"refs/changes/36/7536/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/36/7536/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/36/7536/1 \u0026\u0026 git checkout -b change-7536 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/36/7536/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/36/7536/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/36/7536/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/36/7536/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/36/7536/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"fc30feb51a76e893646e2794c99a78dbdc0d251f","subject":"tlc/interface: does fix source of raspberrypi-gpio-connector.cfg in raspberrypi-native.cfg"}],"author":{"name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","date":"2023-03-14 22:22:10.000000000","tz":180},"committer":{"name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","date":"2023-03-14 22:25:13.000000000","tz":180},"subject":"target/espressif: check common_magic instead of gdb_arch string","message":"target/espressif: check common_magic instead of gdb_arch string\n\nThe value returned by target_get_gdb_arch() is something specific for GDB.\nThere could be several variants of the same CPU.\nIf we start implementing all the variants, checking the string value,\ncould become incorrect.\nIt\u0027s better to check for xtensa-\u003ecommon_magic \u003d\u003d XTENSA_COMMON_MAGIC\n\nSigned-off-by: Erhan Kurubas \u003cerhan.kurubas@espressif.com\u003e\nChange-Id: I20f3fdced176c3b9ab00f889743161ecad7280f9\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}