)]}'
{"id":"openocd~master~Ibbb0b06cb592be072571218b666566a13d8dff0e","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2023-12-29 13:10:59.000000000","reason":"\u003cGERRIT_ACCOUNT_1000021\u003e replied on the change","reason_account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2023-12-29 14:33:55.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ibbb0b06cb592be072571218b666566a13d8dff0e","subject":"target/arm_adi_v5: fix DP SELECT logic","status":"MERGED","created":"2023-03-15 16:51:19.000000000","updated":"2023-12-29 14:33:55.000000000","submitted":"2023-12-29 14:33:55.000000000","submitter":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"total_comment_count":29,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7541","meta_rev_id":"3fef7944dc7b1a456af3c2a5c76c8c002f02b333","_number":7541,"owner":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-12-29 14:33:55.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-12-29 14:33:55.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-12-29 14:33:55.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-03-15 22:42:29.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-04-06 22:11:12.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"CC"},{"updated":"2023-12-29 13:10:59.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"513ebb48bf93eb04f24cdc1f9f76f55e03b46c98","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-03-15 16:51:19.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c2342949cc3d60c4e94c9baecbb2ae07e14b52c0","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-03-15 22:42:29.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16680/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/17476/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"f86ce159c8277a8ddf4540c149c99c97db3cb1cb","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-03-31 06:08:59.000000000","message":"Patch Set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"b8e2201700e5775dd918e9b7dd159f43187da589","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-03-31 06:45:43.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16733/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/17528/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"673070df86ed22a28002ca30c8c1e6cf7cf4a380","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-04-02 20:21:13.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.","accounts_in_message":[],"_revision_number":3},{"id":"5f7177edad90c507992d59b8c05943a53feb9c57","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-04-03 00:40:58.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16757/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/17551/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"47af21c7c34401cddf3e1f98ab2c8609efd30f43","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-04-06 22:11:12.000000000","message":"Patch Set 3:\n\n(8 comments)","accounts_in_message":[],"_revision_number":3},{"id":"36c41ce2f5b1ab55182af5861b0e89194d48a0b1","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-05-28 06:34:34.000000000","message":"Patch Set 3:\n\n(2 comments)","accounts_in_message":[],"_revision_number":3},{"id":"e1f57e77c3bca7a50a5c464cac0a914e78d44018","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-09-05 15:11:36.000000000","message":"Uploaded patch set 4: Patch Set 3 was rebased.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":4},{"id":"5591bf34e0f6d82180433db9173d6f644c73f989","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-09-05 15:59:26.000000000","message":"Patch Set 4: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/18307/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/17498/ : SUCCESS","accounts_in_message":[],"_revision_number":4},{"id":"5e748c68a0060bfd111ca2aa9832373117ec1cf0","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-09-10 15:04:54.000000000","message":"Patch Set 4:\n\n(7 comments)","accounts_in_message":[],"_revision_number":4},{"id":"6df545db6b97f8ac71987dca0e07eba226044452","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-09-11 13:50:51.000000000","message":"Uploaded patch set 5.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":5},{"id":"c30a3458ba927f0735fd1cf20e38cc674d52e36f","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-09-11 13:56:57.000000000","message":"Patch Set 5:\n\n(4 comments)","accounts_in_message":[],"_revision_number":5},{"id":"61f22928074310b9c44b58a5a15f47571d410332","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-09-11 14:34:01.000000000","message":"Patch Set 5: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/18362/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/17551/ : SUCCESS","accounts_in_message":[],"_revision_number":5},{"id":"25cc27f1e2c0cc7f2f934ccbdb60a6c1b82ba956","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-09-17 15:10:08.000000000","message":"Patch Set 5:\n\n(4 comments)","accounts_in_message":[],"_revision_number":5},{"id":"f487cca05330926cad63d4974ac510aa210eb521","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-09-19 05:03:21.000000000","message":"Uploaded patch set 6.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":6},{"id":"bb681fb6a34ebed183806ae6992ad7eb9dadf54a","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-09-19 05:04:54.000000000","message":"Patch Set 6:\n\n(1 comment)","accounts_in_message":[],"_revision_number":6},{"id":"57514e61382d65d78e9cbb8791a691d9daa803f8","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-09-19 05:21:08.000000000","message":"Patch Set 6: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/18400/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/17589/ : SUCCESS","accounts_in_message":[],"_revision_number":6},{"id":"5e11a86fd5079c6e4e69239d231915da45103f99","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-10-04 15:31:14.000000000","message":"Patch Set 6:\n\n(1 comment)","accounts_in_message":[],"_revision_number":6},{"id":"02ba193fcf699cb9d8b5c39c4e09a49413e52055","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-11-07 12:01:19.000000000","message":"Patch Set 6:\n\n(1 comment)","accounts_in_message":[],"_revision_number":6},{"id":"f745c86c3e15ec3b98b091a5ea872ef9fe40bd15","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-11-30 06:52:18.000000000","message":"Patch Set 6: Code-Review+2","accounts_in_message":[],"_revision_number":6},{"id":"8a642fe0221d18f9f29c94a52ac24ee7add470b0","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-12-29 13:10:59.000000000","message":"Patch Set 6: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":6},{"id":"3fef7944dc7b1a456af3c2a5c76c8c002f02b333","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-12-29 14:33:55.000000000","message":"Change has been successfully cherry-picked as ee3fb5a0eacb42e8e881239194485d79d128d246","accounts_in_message":[],"_revision_number":7}],"current_revision":"ee3fb5a0eacb42e8e881239194485d79d128d246","revisions":{"cf315b3f675f1747cb7a56419a5b96a13c27de43":{"kind":"REWORK","_number":5,"created":"2023-09-11 13:50:51.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/41/7541/5","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/41/7541/5","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/41/7541/5 \u0026\u0026 git checkout -b change-7541 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/41/7541/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/41/7541/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/41/7541/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/41/7541/5","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/41/7541/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"65b1006339623674ce9be481ef1d52730e50c2a4","subject":"target/adi_v5_xxx: use ADIV5_DP_SELECT_APBANK"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2023-03-14 17:40:25.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2023-09-11 11:08:03.000000000","tz":120},"subject":"target/arm_adi_v5: fix DP SELECT logic","message":"target/arm_adi_v5: fix DP SELECT logic\n\nThe original code supported ADIv5 only, just one SELECT register\nwith some reserved bits - the pseudo value DP_SELECT_INVALID was\njust fine to indicate the DP SELECT register is in an unknown state.\n\nAdded ADIv6 support required DP SELECT and SELECT1 registers\nwithout reserved bits. Therefore DP_SELECT_INVALID value became\nreachable as a (fortunately not really used) ADIv6 AP ADDR.\n\nJTAG DPBANKSEL setting support introduced with ADIv6 does not\nhonor DP_SELECT_INVALID correctly: required select value\ngets compared to DP_SELECT_INVALID value and the most common zero\nbank does not trigger DP SELECT write.\n\nDP banked registers need just to set DP SELECT. ADIv6 AP register\naddressing scheme may use both DP SELECT and SELECT1. This further\ncomplicates using a single invalid value.\n\nMoreover the difference how the SWD line reset influences\nDPBANKSEL field between ADIv5 and ADIv6 deserves better handling\nthan setting select cache to zero and then to DP_SELECT_INVALID\nin a very specific code positions.\n\nIntroduce bool flags indicating the validity of each SELECT\nregister and one SWD specific for DPBANKSEL field.\nUse the latter to prevent selecting DP BANK before taking\nthe connection out of reset by reading DPIDR.\n\nTreat DP SELECT and SELECT1 individually in ADIv6 64-bit mode.\n\nUpdate comments to reflect the difference between ADIv5 and ADIv6\nin SWD line reset.\n\nChange-Id: Ibbb0b06cb592be072571218b666566a13d8dff0e\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"3f86181f747ca33350b74953c26825d635965ebf":{"kind":"TRIVIAL_REBASE","_number":4,"created":"2023-09-05 15:11:36.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/41/7541/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/41/7541/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/41/7541/4 \u0026\u0026 git checkout -b change-7541 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/41/7541/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/41/7541/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/41/7541/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/41/7541/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/41/7541/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"65b1006339623674ce9be481ef1d52730e50c2a4","subject":"target/adi_v5_xxx: use ADIV5_DP_SELECT_APBANK"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2023-03-14 17:40:25.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2023-09-05 14:31:03.000000000","tz":120},"subject":"target/arm_adi_v5: fix DP SELECT logic","message":"target/arm_adi_v5: fix DP SELECT logic\n\nThe original code supported ADIv5 only, just one SELECT register\nwith some reserved bits - the pseudo value DP_SELECT_INVALID was\njust fine to indicate the DP SELECT register is in an unknown state.\n\nAdded ADIv6 support required DP SELECT and SELECT1 registers\nwithout reserved bits. Therefore DP_SELECT_INVALID value became\nreachable as a (fortunately not really used) ADIv6 AP ADDR.\n\nJTAG DPBANKSEL setting support introduced with ADIv6 does not\nhonor DP_SELECT_INVALID correctly: required select value\ngets compared to DP_SELECT_INVALID value and the most common zero\nbank does not trigger DP SELECT write.\n\nDP banked registers need just to set DP SELECT. ADIv6 AP register\naddressing scheme may use both DP SELECT and SELECT1. This further\ncomplicates using a single invalid value.\n\nMoreover the difference how the SWD line reset influences\nDPBANKSEL field between ADIv5 and ADIv6 deserves better handling\nthan setting select cache to zero and then to DP_SELECT_INVALID\nin a very specific code positions.\n\nIntroduce bool flags indicating the validity of each SELECT\nregister and one SWD specific for DPBANKSEL field.\nUse the latter to prevent selecting DP BANK before taking\nthe connection out of reset by reading DPIDR.\n\nTreat DP SELECT and SELECT1 individually in ADIv6 64-bit mode.\n\nUpdate comments to reflect the difference between ADIv5 and ADIv6\nin SWD line reset.\n\nChange-Id: Ibbb0b06cb592be072571218b666566a13d8dff0e\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"ee3fb5a0eacb42e8e881239194485d79d128d246":{"kind":"REWORK","_number":7,"created":"2023-12-29 14:33:55.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/41/7541/7","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/41/7541/7","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/41/7541/7 \u0026\u0026 git checkout -b change-7541 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/41/7541/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/41/7541/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/41/7541/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/41/7541/7","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/41/7541/7 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"492dc7c537d5685e5e6d41757b73eea2365b96ee","subject":"helper/bin2char: drop trailing empty line"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2023-03-14 17:40:25.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2023-12-29 14:33:55.000000000","tz":0},"subject":"target/arm_adi_v5: fix DP SELECT logic","message":"target/arm_adi_v5: fix DP SELECT logic\n\nThe original code supported ADIv5 only, just one SELECT register\nwith some reserved bits - the pseudo value DP_SELECT_INVALID was\njust fine to indicate the DP SELECT register is in an unknown state.\n\nAdded ADIv6 support required DP SELECT and SELECT1 registers\nwithout reserved bits. Therefore DP_SELECT_INVALID value became\nreachable as a (fortunately not really used) ADIv6 AP ADDR.\n\nJTAG DPBANKSEL setting support introduced with ADIv6 does not\nhonor DP_SELECT_INVALID correctly: required select value\ngets compared to DP_SELECT_INVALID value and the most common zero\nbank does not trigger DP SELECT write.\n\nDP banked registers need just to set DP SELECT. ADIv6 AP register\naddressing scheme may use both DP SELECT and SELECT1. This further\ncomplicates using a single invalid value.\n\nMoreover the difference how the SWD line reset influences\nDPBANKSEL field between ADIv5 and ADIv6 deserves better handling\nthan setting select cache to zero and then to DP_SELECT_INVALID\nin a very specific code positions.\n\nIntroduce bool flags indicating the validity of each SELECT\nregister and one SWD specific for DPBANKSEL field.\nUse the latter to prevent selecting DP BANK before taking\nthe connection out of reset by reading DPIDR.\n\nTreat DP SELECT and SELECT1 individually in ADIv6 64-bit mode.\n\nUpdate comments to reflect the difference between ADIv5 and ADIv6\nin SWD line reset.\n\nChange-Id: Ibbb0b06cb592be072571218b666566a13d8dff0e\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7541\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"74895aa24da7c5c0c8af662c8d11be5c8693a42c":{"kind":"REWORK","_number":6,"created":"2023-09-19 05:03:21.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/41/7541/6","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/41/7541/6","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/41/7541/6 \u0026\u0026 git checkout -b change-7541 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/41/7541/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/41/7541/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/41/7541/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/41/7541/6","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/41/7541/6 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"65b1006339623674ce9be481ef1d52730e50c2a4","subject":"target/adi_v5_xxx: use ADIV5_DP_SELECT_APBANK"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2023-03-14 17:40:25.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2023-09-19 04:54:31.000000000","tz":120},"subject":"target/arm_adi_v5: fix DP SELECT logic","message":"target/arm_adi_v5: fix DP SELECT logic\n\nThe original code supported ADIv5 only, just one SELECT register\nwith some reserved bits - the pseudo value DP_SELECT_INVALID was\njust fine to indicate the DP SELECT register is in an unknown state.\n\nAdded ADIv6 support required DP SELECT and SELECT1 registers\nwithout reserved bits. Therefore DP_SELECT_INVALID value became\nreachable as a (fortunately not really used) ADIv6 AP ADDR.\n\nJTAG DPBANKSEL setting support introduced with ADIv6 does not\nhonor DP_SELECT_INVALID correctly: required select value\ngets compared to DP_SELECT_INVALID value and the most common zero\nbank does not trigger DP SELECT write.\n\nDP banked registers need just to set DP SELECT. ADIv6 AP register\naddressing scheme may use both DP SELECT and SELECT1. This further\ncomplicates using a single invalid value.\n\nMoreover the difference how the SWD line reset influences\nDPBANKSEL field between ADIv5 and ADIv6 deserves better handling\nthan setting select cache to zero and then to DP_SELECT_INVALID\nin a very specific code positions.\n\nIntroduce bool flags indicating the validity of each SELECT\nregister and one SWD specific for DPBANKSEL field.\nUse the latter to prevent selecting DP BANK before taking\nthe connection out of reset by reading DPIDR.\n\nTreat DP SELECT and SELECT1 individually in ADIv6 64-bit mode.\n\nUpdate comments to reflect the difference between ADIv5 and ADIv6\nin SWD line reset.\n\nChange-Id: Ibbb0b06cb592be072571218b666566a13d8dff0e\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"c39529170c5ac4a65e9efdfd0c322517587e698b":{"kind":"REWORK","_number":1,"created":"2023-03-15 16:51:19.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/41/7541/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/41/7541/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/41/7541/1 \u0026\u0026 git checkout -b change-7541 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/41/7541/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/41/7541/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/41/7541/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/41/7541/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/41/7541/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ab3e23fcac59882f694275fc922ca1f5c12165e7","subject":"target/adi_v5_jtag: fix endianess error in transaction replay"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2023-03-14 17:40:25.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2023-03-15 16:48:34.000000000","tz":60},"subject":"target/arm_adi_v5: fix DP SELECT logic","message":"target/arm_adi_v5: fix DP SELECT logic\n\nThe original code supported ADIv5 only, just one SELECT register\nwith some reserved bits - the pseudo value DP_SELECT_INVALID was\njust fine to indicate the DP SELECT register is in an unknown state.\n\nAdded ADIv6 support required DP SELECT and SELECT1 registers\nwithout reserved bits. Therefore DP_SELECT_INVALID value became\nreachable as a valid ADIv6 AP ADDR.\n\nJTAG DPBANKSEL setting support introduced with ADIv6 does not\nhonor DP_SELECT_INVALID correctly: required select value\ngets compared to DP_SELECT_INVALID value and the most common zero\nbank does not trigger DP SELECT write.\n\nDP banked registers need just to set DP SELECT. ADIv6 AP register\naddressing scheme may use both DP SELECT and SELECT1. This further\ncomplicates using a single invalid value.\n\nMoreover the difference how the SWD line reset influences\nDPBANKSEL field between ADIv5 and ADIv6 deserves better handling\nthan setting select cache to zero and then to DP_SELECT_INVALID\nin a very specific code positions.\n\nIntroduce bool flags indicating the validity of each SELECT\nregister and one SWD specific for DPBANKSEL field.\nUse the latter to prevent selecting DP BANK before taking\nthe connection out of reset by reading DPIDR.\n\nTreat DP SELECT and SELECT1 individually in ADIv6 64-bit mode.\n\nUpdate comments to reflect the difference between ADIv5 and ADIv6\nin SWD line reset.\n\nChange-Id: Ibbb0b06cb592be072571218b666566a13d8dff0e\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"90c146f6bf3eeb543632ce1cad6fac7d75397355":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2023-04-02 20:21:13.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/41/7541/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/41/7541/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/41/7541/3 \u0026\u0026 git checkout -b change-7541 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/41/7541/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/41/7541/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/41/7541/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/41/7541/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/41/7541/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2a53efe03be78f6ff4582a470507bb50e8c1ae89","subject":"target/adi_v5_xxx: use ADIV5_DP_SELECT_APBANK"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2023-03-14 17:40:25.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2023-04-02 08:45:19.000000000","tz":120},"subject":"target/arm_adi_v5: fix DP SELECT logic","message":"target/arm_adi_v5: fix DP SELECT logic\n\nThe original code supported ADIv5 only, just one SELECT register\nwith some reserved bits - the pseudo value DP_SELECT_INVALID was\njust fine to indicate the DP SELECT register is in an unknown state.\n\nAdded ADIv6 support required DP SELECT and SELECT1 registers\nwithout reserved bits. Therefore DP_SELECT_INVALID value became\nreachable as a (fortunately not really used) ADIv6 AP ADDR.\n\nJTAG DPBANKSEL setting support introduced with ADIv6 does not\nhonor DP_SELECT_INVALID correctly: required select value\ngets compared to DP_SELECT_INVALID value and the most common zero\nbank does not trigger DP SELECT write.\n\nDP banked registers need just to set DP SELECT. ADIv6 AP register\naddressing scheme may use both DP SELECT and SELECT1. This further\ncomplicates using a single invalid value.\n\nMoreover the difference how the SWD line reset influences\nDPBANKSEL field between ADIv5 and ADIv6 deserves better handling\nthan setting select cache to zero and then to DP_SELECT_INVALID\nin a very specific code positions.\n\nIntroduce bool flags indicating the validity of each SELECT\nregister and one SWD specific for DPBANKSEL field.\nUse the latter to prevent selecting DP BANK before taking\nthe connection out of reset by reading DPIDR.\n\nTreat DP SELECT and SELECT1 individually in ADIv6 64-bit mode.\n\nUpdate comments to reflect the difference between ADIv5 and ADIv6\nin SWD line reset.\n\nChange-Id: Ibbb0b06cb592be072571218b666566a13d8dff0e\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"1559f607024b0bd7cb5552ce6701eea882064671":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2023-03-31 06:08:59.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/41/7541/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/41/7541/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/41/7541/2 \u0026\u0026 git checkout -b change-7541 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/41/7541/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/41/7541/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/41/7541/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/41/7541/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/41/7541/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ab3e23fcac59882f694275fc922ca1f5c12165e7","subject":"target/adi_v5_jtag: fix endianess error in transaction replay"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2023-03-14 17:40:25.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2023-03-31 06:08:59.000000000","tz":0},"subject":"target/arm_adi_v5: fix DP SELECT logic","message":"target/arm_adi_v5: fix DP SELECT logic\n\nThe original code supported ADIv5 only, just one SELECT register\nwith some reserved bits - the pseudo value DP_SELECT_INVALID was\njust fine to indicate the DP SELECT register is in an unknown state.\n\nAdded ADIv6 support required DP SELECT and SELECT1 registers\nwithout reserved bits. Therefore DP_SELECT_INVALID value became\nreachable as a (fortunately not really used) ADIv6 AP ADDR.\n\nJTAG DPBANKSEL setting support introduced with ADIv6 does not\nhonor DP_SELECT_INVALID correctly: required select value\ngets compared to DP_SELECT_INVALID value and the most common zero\nbank does not trigger DP SELECT write.\n\nDP banked registers need just to set DP SELECT. ADIv6 AP register\naddressing scheme may use both DP SELECT and SELECT1. This further\ncomplicates using a single invalid value.\n\nMoreover the difference how the SWD line reset influences\nDPBANKSEL field between ADIv5 and ADIv6 deserves better handling\nthan setting select cache to zero and then to DP_SELECT_INVALID\nin a very specific code positions.\n\nIntroduce bool flags indicating the validity of each SELECT\nregister and one SWD specific for DPBANKSEL field.\nUse the latter to prevent selecting DP BANK before taking\nthe connection out of reset by reading DPIDR.\n\nTreat DP SELECT and SELECT1 individually in ADIv6 64-bit mode.\n\nUpdate comments to reflect the difference between ADIv5 and ADIv6\nin SWD line reset.\n\nChange-Id: Ibbb0b06cb592be072571218b666566a13d8dff0e\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"},"description":"Edit commit message"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}