)]}'
{"id":"openocd~master~I64fcf51b102ea91c196e657debd8c267943a2b08","project":"openocd","branch":"master","hashtags":[],"change_id":"I64fcf51b102ea91c196e657debd8c267943a2b08","subject":"helper/compiler: fix build on MacOS","status":"MERGED","created":"2023-03-19 22:33:33.000000000","updated":"2023-03-25 18:00:28.000000000","submitted":"2023-03-25 18:00:28.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7544","meta_rev_id":"ce444cd7b78f8c8d176a2b238c7afee7f431a5b9","_number":7544,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-03-25 18:00:28.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-03-25 18:00:28.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-03-19 23:25:43.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"e8c6b9ac020c8d38c28c608a28226a32d4878311","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-03-19 22:33:33.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"6eb843aff79855d4c04334301526ab888b6529a2","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-03-19 23:25:43.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16691/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/17486/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"3a7719d1b1a7caefeb5f71fe8de7c6bf3a98e695","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-03-19 23:39:09.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"bc7684553c2e4d8ff6fb354d48178d81034811c1","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-03-25 17:59:50.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"ce444cd7b78f8c8d176a2b238c7afee7f431a5b9","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-03-25 18:00:28.000000000","message":"Change has been successfully cherry-picked as 9ce6b0898e5c0b2d6b6928b93b18137fecd6a32d","accounts_in_message":[],"_revision_number":2}],"current_revision":"9ce6b0898e5c0b2d6b6928b93b18137fecd6a32d","revisions":{"40f9f9f668bedf97a8a76805b3e3d285a65c6c13":{"kind":"REWORK","_number":1,"created":"2023-03-19 22:33:33.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/44/7544/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/44/7544/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/44/7544/1 \u0026\u0026 git checkout -b change-7544 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/44/7544/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/44/7544/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/44/7544/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/44/7544/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/44/7544/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b6b4f9d46a48aadc1de6bb5152ff4913661c9059","subject":"svf: new command line options -noreset and -addcycles"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-03-19 09:57:04.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-03-19 22:32:48.000000000","tz":60},"subject":"helper/compiler: fix build on MacOS","message":"helper/compiler: fix build on MacOS\n\nOn MacOS, clang defines [1]:\n\t#define __nonnull _Nonnull\nthat creates incompatibility with GCC and with the macro __nonnull\ndefined in some libc.\n\nDetect clang on MacOS and undefine __nonnull.\n\nChange-Id: I64fcf51b102ea91c196e657debd8c267943a2b08\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nLinks: [1] https://github.com/llvm/llvm-project/blob/llvmorg-16.0.0/clang/lib/Frontend/InitPreprocessor.cpp#L1226\n"}},"9ce6b0898e5c0b2d6b6928b93b18137fecd6a32d":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2023-03-25 18:00:28.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/44/7544/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/44/7544/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/44/7544/2 \u0026\u0026 git checkout -b change-7544 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/44/7544/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/44/7544/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/44/7544/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/44/7544/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/44/7544/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b6b4f9d46a48aadc1de6bb5152ff4913661c9059","subject":"svf: new command line options -noreset and -addcycles"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-03-19 09:57:04.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-03-25 18:00:28.000000000","tz":0},"subject":"helper/compiler: fix build on MacOS","message":"helper/compiler: fix build on MacOS\n\nOn MacOS, clang defines [1]:\n\t#define __nonnull _Nonnull\nthat creates incompatibility with GCC and with the macro __nonnull\ndefined in some libc.\n\nDetect clang on MacOS and undefine __nonnull.\n\nChange-Id: I64fcf51b102ea91c196e657debd8c267943a2b08\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nLinks: [1] https://github.com/llvm/llvm-project/blob/llvmorg-16.0.0/clang/lib/Frontend/InitPreprocessor.cpp#L1226\nReviewed-on: https://review.openocd.org/c/openocd/+/7544\nTested-by: jenkins\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}