)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"bddc5a6f35a6d246782a3f247810572b9f5ab69c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a346243e_13434e45","updated":"2023-04-10 18:36:04.000000000","message":"@erhan - Any issues with this patch when running Espressif regressions?\n\n@antonio - Any schedule on when you might be able to review? \n\nThanks both in advance.","commit_id":"ef4fa4efb032d42a557d1d0f854cdfc3cdb9ddbe"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"c3e968505f14067e5edee4a1e0aebfe0ffb6e152","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"76159b2d_6f200ba6","updated":"2023-03-24 00:44:16.000000000","message":"Adding GDB File-IO RSP extension support for Xtensa targets.  Please review as time permits.\n\nThis patch is fully functional and was validated on Xtensa applications linked with the \"gdbio\" LSPs.  Please review as time permits.\n\nSeparately, this patch is noticeably slower than on our Xtensa fork due to the 100ms TARGET_DEFAULT_POLLING_INTERVAL in target.h.  I see improved performance when reducing this to 10ms, but of course don\u0027t want to make that a blanket change.  I am considering a separate patch to make \"polling_interval\" in target.c configurable.\n\n@antonio would you be supportive of such a patch?  If not, do you have a recommendation for how best to poll more frequently, or to force a target state change from the xtensa target layer?  Thanks in advance.","commit_id":"ef4fa4efb032d42a557d1d0f854cdfc3cdb9ddbe"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"2319acf81390c7a2723c9b6908e0330a48022abd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7c01c058_4865c5cf","updated":"2023-05-08 20:18:02.000000000","message":"Thanks for the feedback.  Issues addressed, as well as made an improvement to Xtensa-specific Ctrl-C handling","commit_id":"ef4fa4efb032d42a557d1d0f854cdfc3cdb9ddbe"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"dc9b0565142dfba0605c3fe464c5b672945941c8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e522b95c_b8b78735","updated":"2023-05-08 10:12:12.000000000","message":"Thanks for the patch.\nI\u0027m almost ok with this, only few comment below","commit_id":"ef4fa4efb032d42a557d1d0f854cdfc3cdb9ddbe"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"348bdd5e579be6299dc4e8aef25ad5fbaaba0605","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d9b57181_b9568832","updated":"2023-05-09 00:52:10.000000000","message":"Minor comment update to retrigger Jenkins","commit_id":"3f8b8d259aae4fcb49c9e7f80bab2715cb807542"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"98a29429f319f4b40be6614b9a87db92a96b8a6d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9ec883c1_c243237c","updated":"2023-05-16 22:07:25.000000000","message":"Thanks!","commit_id":"52666a78a34a8b2e191e38309ee94a26fb7873e0"}],"src/target/xtensa/xtensa.c":[{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"073c2ccc0659dd118b688265c3b1d5c6813f60b8","unresolved":false,"context_lines":[{"line_number":1544,"context_line":"\t\tLOG_TARGET_WARNING(target, \"target not halted\");"},{"line_number":1545,"context_line":"\t\treturn ERROR_TARGET_NOT_HALTED;"},{"line_number":1546,"context_line":"\t}"},{"line_number":1547,"context_line":"\txtensa-\u003ehalt_request \u003d false;"},{"line_number":1548,"context_line":""},{"line_number":1549,"context_line":"\tif (address \u0026\u0026 !current) {"},{"line_number":1550,"context_line":"\t\txtensa_reg_set(target, XT_REG_IDX_PC, address);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"47dc229a_08e72de1","line":1547,"updated":"2023-04-14 19:55:47.000000000","message":"@Ian, This is the only change that could affect us, but no issues. That\u0027s fine.","commit_id":"ef4fa4efb032d42a557d1d0f854cdfc3cdb9ddbe"}],"src/target/xtensa/xtensa_fileio.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"dc9b0565142dfba0605c3fe464c5b672945941c8","unresolved":true,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"int xtensa_fileio_init(struct target *target)"},{"line_number":22,"context_line":"{"},{"line_number":23,"context_line":"\ttarget-\u003efileio_info \u003d malloc(sizeof(struct gdb_fileio_info));"},{"line_number":24,"context_line":"\ttarget-\u003efileio_info-\u003eidentifier \u003d malloc(XTENSA_SYSCALL_LEN_MAX + 1);"},{"line_number":25,"context_line":"\treturn ERROR_OK;"},{"line_number":26,"context_line":"}"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"44a4e31c_d02b1e73","line":24,"range":{"start_line":23,"start_character":1,"end_line":24,"end_character":4},"updated":"2023-05-08 10:12:12.000000000","message":"please check for any of the malloc() to fail, LOG_ERROR(\"Out of memory\"), free() both and return ERROR_FAIL","commit_id":"ef4fa4efb032d42a557d1d0f854cdfc3cdb9ddbe"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"2319acf81390c7a2723c9b6908e0330a48022abd","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"int xtensa_fileio_init(struct target *target)"},{"line_number":22,"context_line":"{"},{"line_number":23,"context_line":"\ttarget-\u003efileio_info \u003d malloc(sizeof(struct gdb_fileio_info));"},{"line_number":24,"context_line":"\ttarget-\u003efileio_info-\u003eidentifier \u003d malloc(XTENSA_SYSCALL_LEN_MAX + 1);"},{"line_number":25,"context_line":"\treturn ERROR_OK;"},{"line_number":26,"context_line":"}"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"a1c2d6ca_5f6d647e","line":24,"range":{"start_line":23,"start_character":1,"end_line":24,"end_character":4},"in_reply_to":"44a4e31c_d02b1e73","updated":"2023-05-08 20:18:02.000000000","message":"Good catch!  Fixed.  Thank you!","commit_id":"ef4fa4efb032d42a557d1d0f854cdfc3cdb9ddbe"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"dc9b0565142dfba0605c3fe464c5b672945941c8","unresolved":true,"context_lines":[{"line_number":170,"context_line":"\tLOG_TARGET_DEBUG(target, \"File-I/O: syscall return code: 0x%x, errno: 0x%x , ctrl_c: %s\","},{"line_number":171,"context_line":"\t\tretcode, fileio_errno, ctrl_c ? \"true\" : \"false\");"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"\t// If interrupt was requested before FIO completion (ERRNO\u003d\u003d4), halt and repeat syscall"},{"line_number":174,"context_line":"\t// Otherwise, set File-I/O Ax and underlying ARx registers, increment PC"},{"line_number":175,"context_line":"\t// NOTE: sporadic cases of ((ERRNO\u003d\u003d4) \u0026\u0026 !ctrl_c) were observed, although most have ctrl_c"},{"line_number":176,"context_line":"\tif (fileio_errno !\u003d 4) {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"5e2153bb_9bdfad17","line":173,"updated":"2023-05-08 10:12:12.000000000","message":"please use /**/ for multi line comments","commit_id":"ef4fa4efb032d42a557d1d0f854cdfc3cdb9ddbe"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"2319acf81390c7a2723c9b6908e0330a48022abd","unresolved":false,"context_lines":[{"line_number":170,"context_line":"\tLOG_TARGET_DEBUG(target, \"File-I/O: syscall return code: 0x%x, errno: 0x%x , ctrl_c: %s\","},{"line_number":171,"context_line":"\t\tretcode, fileio_errno, ctrl_c ? \"true\" : \"false\");"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"\t// If interrupt was requested before FIO completion (ERRNO\u003d\u003d4), halt and repeat syscall"},{"line_number":174,"context_line":"\t// Otherwise, set File-I/O Ax and underlying ARx registers, increment PC"},{"line_number":175,"context_line":"\t// NOTE: sporadic cases of ((ERRNO\u003d\u003d4) \u0026\u0026 !ctrl_c) were observed, although most have ctrl_c"},{"line_number":176,"context_line":"\tif (fileio_errno !\u003d 4) {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"88c017a1_6acb35c9","line":173,"in_reply_to":"5e2153bb_9bdfad17","updated":"2023-05-08 20:18:02.000000000","message":"Done","commit_id":"ef4fa4efb032d42a557d1d0f854cdfc3cdb9ddbe"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"dc9b0565142dfba0605c3fe464c5b672945941c8","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"95e40c0b_fb40152e","line":188,"updated":"2023-05-08 10:12:12.000000000","message":"please remove extra empty line at end-of-file","commit_id":"ef4fa4efb032d42a557d1d0f854cdfc3cdb9ddbe"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"2319acf81390c7a2723c9b6908e0330a48022abd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f0b02831_a85219e2","line":188,"in_reply_to":"95e40c0b_fb40152e","updated":"2023-05-08 20:18:02.000000000","message":"Done","commit_id":"ef4fa4efb032d42a557d1d0f854cdfc3cdb9ddbe"}]}