)]}'
{".github/workflows/snapshot.yml":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"ffd3a25c726fc7524ce48e9d8acae86365397b06","unresolved":true,"context_lines":[{"line_number":82,"context_line":"          # add missing dlls"},{"line_number":83,"context_line":"          cd $HOST-root/usr"},{"line_number":84,"context_line":"          cp `$HOST-gcc --print-file-name\u003dlibwinpthread-1.dll` ./bin/"},{"line_number":85,"context_line":"          cp `$HOST-gcc --print-file-name\u003dlibgcc_s_dw2-1.dll` ./bin/"},{"line_number":86,"context_line":"          # prepare the artifact"},{"line_number":87,"context_line":"          ARTIFACT\u003d\"openocd-${OPENOCD_TAG}-${HOST}.tar.gz\""},{"line_number":88,"context_line":"          tar -czf $ARTIFACT *"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"934f110f_d1a76637","line":85,"updated":"2023-03-29 08:07:00.000000000","message":"Why did you had to change this? Does it have different name between ubuntu-18.04 and ubuntu-latest? Would we need to change it again and again every time github updates the version pointed by ubuntu-latest?","commit_id":"9296b455b8c22921cb8d59448024c2c3866357ef"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"6f4345b67f3319647b1fe9c999375cd43c3ac5d3","unresolved":false,"context_lines":[{"line_number":82,"context_line":"          # add missing dlls"},{"line_number":83,"context_line":"          cd $HOST-root/usr"},{"line_number":84,"context_line":"          cp `$HOST-gcc --print-file-name\u003dlibwinpthread-1.dll` ./bin/"},{"line_number":85,"context_line":"          cp `$HOST-gcc --print-file-name\u003dlibgcc_s_dw2-1.dll` ./bin/"},{"line_number":86,"context_line":"          # prepare the artifact"},{"line_number":87,"context_line":"          ARTIFACT\u003d\"openocd-${OPENOCD_TAG}-${HOST}.tar.gz\""},{"line_number":88,"context_line":"          tar -czf $ARTIFACT *"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"4a573c68_60572e40","line":85,"in_reply_to":"934f110f_d1a76637","updated":"2023-03-29 10:36:17.000000000","message":"According to dependencywalker utility, FTDI lib depends on the libgcc_xxx.dll\n\nlibgcc_xxx.dll \u003d gcc-mingw-version \u003e\u003d 10.3.x ? libgcc_s_dw2-1.dll : libgcc_s_sjlj-1.dll\n\nThis can be changed again after gcc 10.3.x.\n\nSince openocd is distrubuted in one package, we can consider to build and link libraries as a static library. If you look at the artifact folder, you will see other dlls. https://github.com/erhankur/openocd-esp32/suites/11873447975/artifacts/620971261\n\nAnyways, I have re-tested with ubuntu 20.04. It is fine and dll update doesn\u0027t require.","commit_id":"9296b455b8c22921cb8d59448024c2c3866357ef"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"f5b238d457be066968e23fa4eb8e7601a3eccc0c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"38420e9a_b92a7bcf","updated":"2023-03-25 11:26:16.000000000","message":"I have no idea what this patch is fixing. Can you explain more, maybe in the commit message? Can you report the complete error message.\nAnyway, I put -1 because you are incorrectly reverting the jimtcl submodule to 0.81, while we have just updated it to 0.82. Can you please fix it?","commit_id":"8a3269f7c19946c1b8bbe2518969b0a9281c60d2"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"e2f495c85ae7044195590785d6406d62645aad19","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5166e0b2_95861535","in_reply_to":"38420e9a_b92a7bcf","updated":"2023-03-25 13:03:48.000000000","message":"jimtcl version is fixed. \n\nexample log for the GH action failure; \n\nhttps://github.com/openocd-org/openocd/actions/runs/4457500925/jobs/7828620305#step:1:35","commit_id":"8a3269f7c19946c1b8bbe2518969b0a9281c60d2"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"03136257206bc869686d7867f54bce7f8560d370","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"82cdb69a_7f8cc6b4","updated":"2023-03-25 18:48:36.000000000","message":"Thanks, looks reasonable to me.\nTarek? Any comment?\n\nI also see in the failure message:\nThe ubuntu-18.04 environment is deprecated, consider switching to ubuntu-20.04(ubuntu-latest), or ubuntu-22.04 instead. For more details see https://github.com/actions/virtual-environments/issues/6002\n\nAnd following the link:\nDeprecation will begin on 2022/08/08 and the image will be fully unsupported by 2023/04/01\n\nShould we switch to new Ubuntu VM?\n\nAlso:\n- libusb 1.0.26 \u003d\u003e OK\n- hidapi 0.11.2 \u003d\u003e exists 0.13.1\n- libftdi 1.5 \u003d\u003e OK\n- capstone 4.0.2 \u003d\u003e OK\nMove to new hihapi?","commit_id":"5dc370c848455a6144a2e931a34d49e5fcc53742"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"42cd32f61749f15d16ed624744e747b80391f7ea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2f3dc894_337f089f","in_reply_to":"82cdb69a_7f8cc6b4","updated":"2023-03-28 22:26:29.000000000","message":"In the PS4, I have fixed the warnings (ubuntu and nodejs) and updated the hidapi version to the 0.13.1.\nTested at my Espressif fork. Logs are here; https://github.com/erhankur/openocd-esp32/actions/runs/4547926795\n\nAlso I have tested the windows binary, no issue in terms of dependencies.","commit_id":"5dc370c848455a6144a2e931a34d49e5fcc53742"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"ffd3a25c726fc7524ce48e9d8acae86365397b06","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"439960ce_d30a87c0","updated":"2023-03-29 08:07:00.000000000","message":"I\u0027m ok with this. Can you please answer to my question below?\n\nTarek? Any feedback?","commit_id":"9296b455b8c22921cb8d59448024c2c3866357ef"}]}