)]}'
{".github/workflows/snapshot.yml":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"e71d9f9522856324b0e96d30d5c3604e0a353d58","unresolved":false,"context_lines":[{"line_number":20,"context_line":"      - name: Checkout Code"},{"line_number":21,"context_line":"        uses: actions/checkout@v1"},{"line_number":22,"context_line":"      - run: ./bootstrap"},{"line_number":23,"context_line":"      - name: Prepare libusb1"},{"line_number":24,"context_line":"        env:"},{"line_number":25,"context_line":"          LIBUSB1_VER: 1.0.26"},{"line_number":26,"context_line":"        run: |"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"09402d05_728582dd","line":23,"updated":"2023-03-25 11:21:54.000000000","message":"here we build \"libusb1\" before building OpenOCD.\nI think we build it instead of installing it (as done for \"autotools\" above) because we need the cross-built version.","commit_id":"d3cab5f37f9cc417f37b2da74982d18abeff6dd7"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"63dff9d893af8a6f8544ba69d52bc48304abcdee","unresolved":true,"context_lines":[{"line_number":20,"context_line":"      - name: Checkout Code"},{"line_number":21,"context_line":"        uses: actions/checkout@v1"},{"line_number":22,"context_line":"      - run: ./bootstrap"},{"line_number":23,"context_line":"      - name: Prepare libusb1"},{"line_number":24,"context_line":"        env:"},{"line_number":25,"context_line":"          LIBUSB1_VER: 1.0.26"},{"line_number":26,"context_line":"        run: |"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ae2a1bb5_69e85473","line":23,"in_reply_to":"09402d05_728582dd","updated":"2023-03-25 13:17:06.000000000","message":"Here we don\u0027t build it. We just download the source code and exporting the variables. Build process is done inside `cross-build.sh`\n\nInstallation is done to the common folder so OpenOCD build scripts can search the libraries from known location.\n\nI don\u0027t think this approach is bad.","commit_id":"d3cab5f37f9cc417f37b2da74982d18abeff6dd7"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"d782a21d841aaa43babd9981026cf2422b640a95","unresolved":false,"context_lines":[{"line_number":20,"context_line":"      - name: Checkout Code"},{"line_number":21,"context_line":"        uses: actions/checkout@v1"},{"line_number":22,"context_line":"      - run: ./bootstrap"},{"line_number":23,"context_line":"      - name: Prepare libusb1"},{"line_number":24,"context_line":"        env:"},{"line_number":25,"context_line":"          LIBUSB1_VER: 1.0.26"},{"line_number":26,"context_line":"        run: |"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"0b3108a9_0a9e0ef7","line":23,"in_reply_to":"ae2a1bb5_69e85473","updated":"2023-03-29 21:16:30.000000000","message":"Done","commit_id":"d3cab5f37f9cc417f37b2da74982d18abeff6dd7"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"e71d9f9522856324b0e96d30d5c3604e0a353d58","unresolved":false,"context_lines":[{"line_number":28,"context_line":"          wget \"https://github.com/libusb/libusb/releases/download/v${LIBUSB1_VER}/libusb-${LIBUSB1_VER}.tar.bz2\""},{"line_number":29,"context_line":"          tar -xjf libusb-${LIBUSB1_VER}.tar.bz2"},{"line_number":30,"context_line":"          echo \"LIBUSB1_SRC\u003d$PWD/libusb-${LIBUSB1_VER}\" \u003e\u003e $GITHUB_ENV"},{"line_number":31,"context_line":"      - name: Prepare hidapi"},{"line_number":32,"context_line":"        env:"},{"line_number":33,"context_line":"          HIDAPI_VER: 0.11.2"},{"line_number":34,"context_line":"        run: |"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"f381fa4a_bc113f7f","line":31,"updated":"2023-03-25 11:21:54.000000000","message":"here we build \"hidapi\"","commit_id":"d3cab5f37f9cc417f37b2da74982d18abeff6dd7"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"63dff9d893af8a6f8544ba69d52bc48304abcdee","unresolved":false,"context_lines":[{"line_number":28,"context_line":"          wget \"https://github.com/libusb/libusb/releases/download/v${LIBUSB1_VER}/libusb-${LIBUSB1_VER}.tar.bz2\""},{"line_number":29,"context_line":"          tar -xjf libusb-${LIBUSB1_VER}.tar.bz2"},{"line_number":30,"context_line":"          echo \"LIBUSB1_SRC\u003d$PWD/libusb-${LIBUSB1_VER}\" \u003e\u003e $GITHUB_ENV"},{"line_number":31,"context_line":"      - name: Prepare hidapi"},{"line_number":32,"context_line":"        env:"},{"line_number":33,"context_line":"          HIDAPI_VER: 0.11.2"},{"line_number":34,"context_line":"        run: |"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"69698513_79e2773c","line":31,"in_reply_to":"f381fa4a_bc113f7f","updated":"2023-03-25 13:17:06.000000000","message":"Same as libusb comment","commit_id":"d3cab5f37f9cc417f37b2da74982d18abeff6dd7"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"e71d9f9522856324b0e96d30d5c3604e0a353d58","unresolved":false,"context_lines":[{"line_number":38,"context_line":"          cd hidapi-hidapi-${HIDAPI_VER}"},{"line_number":39,"context_line":"          ./bootstrap"},{"line_number":40,"context_line":"          echo \"HIDAPI_SRC\u003d$PWD\" \u003e\u003e $GITHUB_ENV"},{"line_number":41,"context_line":"      - name: Prepare libftdi"},{"line_number":42,"context_line":"        env:"},{"line_number":43,"context_line":"          LIBFTDI_VER: 1.5"},{"line_number":44,"context_line":"        run: |"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"052d0f53_6ba76b36","line":41,"updated":"2023-03-25 11:21:54.000000000","message":"here \"libftdi\", and so on","commit_id":"d3cab5f37f9cc417f37b2da74982d18abeff6dd7"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"63dff9d893af8a6f8544ba69d52bc48304abcdee","unresolved":false,"context_lines":[{"line_number":38,"context_line":"          cd hidapi-hidapi-${HIDAPI_VER}"},{"line_number":39,"context_line":"          ./bootstrap"},{"line_number":40,"context_line":"          echo \"HIDAPI_SRC\u003d$PWD\" \u003e\u003e $GITHUB_ENV"},{"line_number":41,"context_line":"      - name: Prepare libftdi"},{"line_number":42,"context_line":"        env:"},{"line_number":43,"context_line":"          LIBFTDI_VER: 1.5"},{"line_number":44,"context_line":"        run: |"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"2522d41b_0eb33027","line":41,"in_reply_to":"052d0f53_6ba76b36","updated":"2023-03-25 13:17:06.000000000","message":"Same as libusb comment","commit_id":"d3cab5f37f9cc417f37b2da74982d18abeff6dd7"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"e71d9f9522856324b0e96d30d5c3604e0a353d58","unresolved":true,"context_lines":[{"line_number":76,"context_line":"          # set env and call cross-build.sh"},{"line_number":77,"context_line":"          export OPENOCD_TAG\u003d$OPENOCD_TAG"},{"line_number":78,"context_line":"          export OPENOCD_SRC\u003d$PWD"},{"line_number":79,"context_line":"          export OPENOCD_CONFIG\u003d\"--enable-internal-libjaylink\""},{"line_number":80,"context_line":"          mkdir -p $BUILD_DIR \u0026\u0026  cd $BUILD_DIR"},{"line_number":81,"context_line":"          bash $OPENOCD_SRC/contrib/cross-build.sh $HOST"},{"line_number":82,"context_line":"          # add missing dlls"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"0fe88099_ea058ae9","line":79,"updated":"2023-03-25 11:21:54.000000000","message":"Why, instead, \"libjaylink\" has to be built internally?\nCannot be built as \"libusb1\" and the others?\nThe idea behind disabling it, is to drop the internal build of \"libjaylink\" and rely on the binary package distributed by the OS.\nAnd \"jimtcl\" could face the same trend soon.","commit_id":"d3cab5f37f9cc417f37b2da74982d18abeff6dd7"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"63dff9d893af8a6f8544ba69d52bc48304abcdee","unresolved":true,"context_lines":[{"line_number":76,"context_line":"          # set env and call cross-build.sh"},{"line_number":77,"context_line":"          export OPENOCD_TAG\u003d$OPENOCD_TAG"},{"line_number":78,"context_line":"          export OPENOCD_SRC\u003d$PWD"},{"line_number":79,"context_line":"          export OPENOCD_CONFIG\u003d\"--enable-internal-libjaylink\""},{"line_number":80,"context_line":"          mkdir -p $BUILD_DIR \u0026\u0026  cd $BUILD_DIR"},{"line_number":81,"context_line":"          bash $OPENOCD_SRC/contrib/cross-build.sh $HOST"},{"line_number":82,"context_line":"          # add missing dlls"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"f2b7441c_91f45202","line":79,"in_reply_to":"0fe88099_ea058ae9","updated":"2023-03-25 13:17:06.000000000","message":"Ok. libjaylink is also can be built as libusb and the others. I will make the changes.","commit_id":"d3cab5f37f9cc417f37b2da74982d18abeff6dd7"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"84390f63b0f5c48b959906a4e1c4c29dacccb923","unresolved":false,"context_lines":[{"line_number":76,"context_line":"          # set env and call cross-build.sh"},{"line_number":77,"context_line":"          export OPENOCD_TAG\u003d$OPENOCD_TAG"},{"line_number":78,"context_line":"          export OPENOCD_SRC\u003d$PWD"},{"line_number":79,"context_line":"          export OPENOCD_CONFIG\u003d\"--enable-internal-libjaylink\""},{"line_number":80,"context_line":"          mkdir -p $BUILD_DIR \u0026\u0026  cd $BUILD_DIR"},{"line_number":81,"context_line":"          bash $OPENOCD_SRC/contrib/cross-build.sh $HOST"},{"line_number":82,"context_line":"          # add missing dlls"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"6be090ec_266aab70","line":79,"in_reply_to":"f17ca947_41ca12ea","updated":"2023-03-29 21:19:33.000000000","message":"Antonio, Marc, \nYou can find the example output and artifact files here. https://github.com/erhankur/openocd-esp32/actions/runs/4557811551","commit_id":"d3cab5f37f9cc417f37b2da74982d18abeff6dd7"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"d782a21d841aaa43babd9981026cf2422b640a95","unresolved":false,"context_lines":[{"line_number":76,"context_line":"          # set env and call cross-build.sh"},{"line_number":77,"context_line":"          export OPENOCD_TAG\u003d$OPENOCD_TAG"},{"line_number":78,"context_line":"          export OPENOCD_SRC\u003d$PWD"},{"line_number":79,"context_line":"          export OPENOCD_CONFIG\u003d\"--enable-internal-libjaylink\""},{"line_number":80,"context_line":"          mkdir -p $BUILD_DIR \u0026\u0026  cd $BUILD_DIR"},{"line_number":81,"context_line":"          bash $OPENOCD_SRC/contrib/cross-build.sh $HOST"},{"line_number":82,"context_line":"          # add missing dlls"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"f17ca947_41ca12ea","line":79,"in_reply_to":"f2b7441c_91f45202","updated":"2023-03-29 21:16:30.000000000","message":"Done","commit_id":"d3cab5f37f9cc417f37b2da74982d18abeff6dd7"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"e71d9f9522856324b0e96d30d5c3604e0a353d58","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3501ca6a_b33ea293","updated":"2023-03-25 11:21:54.000000000","message":"Hi Erhan, thanks for spotting this. We have already fixed it for Jenkins build, while missed it for github.\nBut I think this patch is not the right solution.\nI\u0027m not familiar with github actions, so I don\u0027t have a proper patch to propose. Would you mind having a look to my comments?","commit_id":"d3cab5f37f9cc417f37b2da74982d18abeff6dd7"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"222eba989422b8fe9f72e119855c9b58e456b6e9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2569377d_bc43ca0d","updated":"2023-03-25 18:51:46.000000000","message":"I agree with Antonio on all points","commit_id":"d3cab5f37f9cc417f37b2da74982d18abeff6dd7"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"63dff9d893af8a6f8544ba69d52bc48304abcdee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"50f85da8_813258c3","in_reply_to":"3501ca6a_b33ea293","updated":"2023-03-25 13:17:06.000000000","message":"Hi Antonio, commented above.","commit_id":"d3cab5f37f9cc417f37b2da74982d18abeff6dd7"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"2fc733f54f6f1f5c75df2ee640fe51c0c4b4fc80","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"62a97261_6290d197","updated":"2023-03-30 07:16:18.000000000","message":"Looks good to me, thanks Erhan!","commit_id":"9a2358a1163b6d1338e348eed7c4ef6b7ef559d0"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"a68222a2311afe347958fa7e66736f3454e1edf1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"75c33a10_1489db04","updated":"2023-03-30 16:10:45.000000000","message":"Thanks!","commit_id":"9a2358a1163b6d1338e348eed7c4ef6b7ef559d0"}]}