)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"a5f5dcd56bcb5262fd1f2a5ba66b7dc127e308f8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c5798a0c_8918f55f","updated":"2023-03-28 10:57:24.000000000","message":"Some questions not much related to the rewrite...","commit_id":"4b495df9a52f0f6043bcff4cce03c80984a6b954"}],"src/jtag/hla/hla_transport.c":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"a5f5dcd56bcb5262fd1f2a5ba66b7dc127e308f8","unresolved":true,"context_lines":[{"line_number":113,"context_line":"\t{"},{"line_number":114,"context_line":"\t .name \u003d \"tapdisable\","},{"line_number":115,"context_line":"\t .mode \u003d COMMAND_EXEC,"},{"line_number":116,"context_line":"\t .handler \u003d hl_transport_jtag_command,"},{"line_number":117,"context_line":"\t .usage \u003d \"\","},{"line_number":118,"context_line":"\t },"},{"line_number":119,"context_line":"\t{"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"1681c526_43daec90","line":116,"range":{"start_line":116,"start_character":13,"end_line":116,"end_character":38},"updated":"2023-03-28 10:57:24.000000000","message":"Is explained anywhere why tapdisable is dummy for HLA and dapdirect?","commit_id":"4b495df9a52f0f6043bcff4cce03c80984a6b954"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"cfaac87773426d1736e01c9b17209830113b4639","unresolved":true,"context_lines":[{"line_number":113,"context_line":"\t{"},{"line_number":114,"context_line":"\t .name \u003d \"tapdisable\","},{"line_number":115,"context_line":"\t .mode \u003d COMMAND_EXEC,"},{"line_number":116,"context_line":"\t .handler \u003d hl_transport_jtag_command,"},{"line_number":117,"context_line":"\t .usage \u003d \"\","},{"line_number":118,"context_line":"\t },"},{"line_number":119,"context_line":"\t{"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"88e731d8_6dcff53e","line":116,"range":{"start_line":116,"start_character":13,"end_line":116,"end_character":38},"in_reply_to":"1681c526_43daec90","updated":"2023-05-13 13:09:28.000000000","message":"Humm, no, probably only in the commit msg of\nhttps://review.openocd.org/1664/","commit_id":"4b495df9a52f0f6043bcff4cce03c80984a6b954"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"5c67cde69e07d763c24e19228ff3cfea0d9d74b7","unresolved":false,"context_lines":[{"line_number":113,"context_line":"\t{"},{"line_number":114,"context_line":"\t .name \u003d \"tapdisable\","},{"line_number":115,"context_line":"\t .mode \u003d COMMAND_EXEC,"},{"line_number":116,"context_line":"\t .handler \u003d hl_transport_jtag_command,"},{"line_number":117,"context_line":"\t .usage \u003d \"\","},{"line_number":118,"context_line":"\t },"},{"line_number":119,"context_line":"\t{"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"65b73c90_3b11539c","line":116,"range":{"start_line":116,"start_character":13,"end_line":116,"end_character":38},"in_reply_to":"88e731d8_6dcff53e","updated":"2023-05-16 22:02:01.000000000","message":"Ack","commit_id":"4b495df9a52f0f6043bcff4cce03c80984a6b954"}],"src/jtag/tcl.c":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"a5f5dcd56bcb5262fd1f2a5ba66b7dc127e308f8","unresolved":true,"context_lines":[{"line_number":651,"context_line":"static bool jtag_tap_enable(struct jtag_tap *t)"},{"line_number":652,"context_line":"{"},{"line_number":653,"context_line":"\tif (t-\u003eenabled)"},{"line_number":654,"context_line":"\t\treturn false;"},{"line_number":655,"context_line":"\tjtag_tap_handle_event(t, JTAG_TAP_EVENT_ENABLE);"},{"line_number":656,"context_line":"\tif (!t-\u003eenabled)"},{"line_number":657,"context_line":"\t\treturn false;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"7444cb29_18b041de","line":654,"range":{"start_line":654,"start_character":9,"end_line":654,"end_character":14},"updated":"2023-03-28 10:57:24.000000000","message":"Strange.","commit_id":"4b495df9a52f0f6043bcff4cce03c80984a6b954"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"5c67cde69e07d763c24e19228ff3cfea0d9d74b7","unresolved":false,"context_lines":[{"line_number":651,"context_line":"static bool jtag_tap_enable(struct jtag_tap *t)"},{"line_number":652,"context_line":"{"},{"line_number":653,"context_line":"\tif (t-\u003eenabled)"},{"line_number":654,"context_line":"\t\treturn false;"},{"line_number":655,"context_line":"\tjtag_tap_handle_event(t, JTAG_TAP_EVENT_ENABLE);"},{"line_number":656,"context_line":"\tif (!t-\u003eenabled)"},{"line_number":657,"context_line":"\t\treturn false;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"e1d4c0b8_1a8fdc45","line":654,"range":{"start_line":654,"start_character":9,"end_line":654,"end_character":14},"in_reply_to":"7444cb29_18b041de","updated":"2023-05-16 22:02:01.000000000","message":"Done","commit_id":"4b495df9a52f0f6043bcff4cce03c80984a6b954"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"a5f5dcd56bcb5262fd1f2a5ba66b7dc127e308f8","unresolved":true,"context_lines":[{"line_number":666,"context_line":"static bool jtag_tap_disable(struct jtag_tap *t)"},{"line_number":667,"context_line":"{"},{"line_number":668,"context_line":"\tif (!t-\u003eenabled)"},{"line_number":669,"context_line":"\t\treturn false;"},{"line_number":670,"context_line":"\tjtag_tap_handle_event(t, JTAG_TAP_EVENT_DISABLE);"},{"line_number":671,"context_line":"\tif (t-\u003eenabled)"},{"line_number":672,"context_line":"\t\treturn false;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"2e1babf8_7e9dcd7c","line":669,"range":{"start_line":669,"start_character":9,"end_line":669,"end_character":14},"updated":"2023-03-28 10:57:24.000000000","message":"Same as above","commit_id":"4b495df9a52f0f6043bcff4cce03c80984a6b954"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"5c67cde69e07d763c24e19228ff3cfea0d9d74b7","unresolved":false,"context_lines":[{"line_number":666,"context_line":"static bool jtag_tap_disable(struct jtag_tap *t)"},{"line_number":667,"context_line":"{"},{"line_number":668,"context_line":"\tif (!t-\u003eenabled)"},{"line_number":669,"context_line":"\t\treturn false;"},{"line_number":670,"context_line":"\tjtag_tap_handle_event(t, JTAG_TAP_EVENT_DISABLE);"},{"line_number":671,"context_line":"\tif (t-\u003eenabled)"},{"line_number":672,"context_line":"\t\treturn false;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"8892edfb_1e0ad83b","line":669,"range":{"start_line":669,"start_character":9,"end_line":669,"end_character":14},"in_reply_to":"2e1babf8_7e9dcd7c","updated":"2023-05-16 22:02:01.000000000","message":"Done","commit_id":"4b495df9a52f0f6043bcff4cce03c80984a6b954"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"a5f5dcd56bcb5262fd1f2a5ba66b7dc127e308f8","unresolved":true,"context_lines":[{"line_number":692,"context_line":""},{"line_number":693,"context_line":"\tif (strcmp(CMD_NAME, \"tapisenabled\") \u003d\u003d 0) {"},{"line_number":694,"context_line":"\t\t/* do nothing, just return the value */"},{"line_number":695,"context_line":"\t} else if (strcmp(CMD_NAME, \"tapenable\") \u003d\u003d 0) {"},{"line_number":696,"context_line":"\t\tif (!jtag_tap_enable(t)) {"},{"line_number":697,"context_line":"\t\t\tcommand_print(CMD, \"failed to enable tap %s\", t-\u003edotted_name);"},{"line_number":698,"context_line":"\t\t\treturn ERROR_FAIL;"},{"line_number":699,"context_line":"\t\t}"},{"line_number":700,"context_line":"\t} else if (strcmp(CMD_NAME, \"tapdisable\") \u003d\u003d 0) {"},{"line_number":701,"context_line":"\t\tif (!jtag_tap_disable(t)) {"},{"line_number":702,"context_line":"\t\t\tcommand_print(CMD, \"failed to disable tap %s\", t-\u003edotted_name);"},{"line_number":703,"context_line":"\t\t\treturn ERROR_FAIL;"},{"line_number":704,"context_line":"\t\t}"},{"line_number":705,"context_line":"\t} else {"},{"line_number":706,"context_line":"\t\tcommand_print(CMD, \"command \u0027%s\u0027 unknown\", CMD_NAME);"},{"line_number":707,"context_line":"\t\treturn ERROR_FAIL;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"81204f45_95df50de","line":704,"range":{"start_line":695,"start_character":1,"end_line":704,"end_character":3},"updated":"2023-03-28 10:57:24.000000000","message":"Both old and rewritten code do not comply to the doc:\n\n Command: jtag tapenable dotted.name\n\n If necessary, enables the tap by sending it a tap-enable event.\n Returns the string \"1\" if the tap specified by dotted.name is enabled, and \"0\" if it is disabled.\n\nIn fact the code returns error if the tap was in desired state before enable/disable command.\n\n  \u003e jtag tapisenabled stm32h7x.cpu\n  1\n  \u003e jtag tapenable stm32h7x.cpu\n  failed to enable tap stm32h7x.cpu\n\nOr am I wrong?","commit_id":"4b495df9a52f0f6043bcff4cce03c80984a6b954"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"cfaac87773426d1736e01c9b17209830113b4639","unresolved":true,"context_lines":[{"line_number":692,"context_line":""},{"line_number":693,"context_line":"\tif (strcmp(CMD_NAME, \"tapisenabled\") \u003d\u003d 0) {"},{"line_number":694,"context_line":"\t\t/* do nothing, just return the value */"},{"line_number":695,"context_line":"\t} else if (strcmp(CMD_NAME, \"tapenable\") \u003d\u003d 0) {"},{"line_number":696,"context_line":"\t\tif (!jtag_tap_enable(t)) {"},{"line_number":697,"context_line":"\t\t\tcommand_print(CMD, \"failed to enable tap %s\", t-\u003edotted_name);"},{"line_number":698,"context_line":"\t\t\treturn ERROR_FAIL;"},{"line_number":699,"context_line":"\t\t}"},{"line_number":700,"context_line":"\t} else if (strcmp(CMD_NAME, \"tapdisable\") \u003d\u003d 0) {"},{"line_number":701,"context_line":"\t\tif (!jtag_tap_disable(t)) {"},{"line_number":702,"context_line":"\t\t\tcommand_print(CMD, \"failed to disable tap %s\", t-\u003edotted_name);"},{"line_number":703,"context_line":"\t\t\treturn ERROR_FAIL;"},{"line_number":704,"context_line":"\t\t}"},{"line_number":705,"context_line":"\t} else {"},{"line_number":706,"context_line":"\t\tcommand_print(CMD, \"command \u0027%s\u0027 unknown\", CMD_NAME);"},{"line_number":707,"context_line":"\t\treturn ERROR_FAIL;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"cc01d900_1f053aa1","line":704,"range":{"start_line":695,"start_character":1,"end_line":704,"end_character":3},"in_reply_to":"81204f45_95df50de","updated":"2023-05-13 13:09:28.000000000","message":"Agree, implementation is incorrect. I will change it in this same patch.","commit_id":"4b495df9a52f0f6043bcff4cce03c80984a6b954"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"5c67cde69e07d763c24e19228ff3cfea0d9d74b7","unresolved":false,"context_lines":[{"line_number":692,"context_line":""},{"line_number":693,"context_line":"\tif (strcmp(CMD_NAME, \"tapisenabled\") \u003d\u003d 0) {"},{"line_number":694,"context_line":"\t\t/* do nothing, just return the value */"},{"line_number":695,"context_line":"\t} else if (strcmp(CMD_NAME, \"tapenable\") \u003d\u003d 0) {"},{"line_number":696,"context_line":"\t\tif (!jtag_tap_enable(t)) {"},{"line_number":697,"context_line":"\t\t\tcommand_print(CMD, \"failed to enable tap %s\", t-\u003edotted_name);"},{"line_number":698,"context_line":"\t\t\treturn ERROR_FAIL;"},{"line_number":699,"context_line":"\t\t}"},{"line_number":700,"context_line":"\t} else if (strcmp(CMD_NAME, \"tapdisable\") \u003d\u003d 0) {"},{"line_number":701,"context_line":"\t\tif (!jtag_tap_disable(t)) {"},{"line_number":702,"context_line":"\t\t\tcommand_print(CMD, \"failed to disable tap %s\", t-\u003edotted_name);"},{"line_number":703,"context_line":"\t\t\treturn ERROR_FAIL;"},{"line_number":704,"context_line":"\t\t}"},{"line_number":705,"context_line":"\t} else {"},{"line_number":706,"context_line":"\t\tcommand_print(CMD, \"command \u0027%s\u0027 unknown\", CMD_NAME);"},{"line_number":707,"context_line":"\t\treturn ERROR_FAIL;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"9b151105_56312e74","line":704,"range":{"start_line":695,"start_character":1,"end_line":704,"end_character":3},"in_reply_to":"cc01d900_1f053aa1","updated":"2023-05-16 22:02:01.000000000","message":"Done","commit_id":"4b495df9a52f0f6043bcff4cce03c80984a6b954"}]}