)]}'
{"id":"openocd~master~Ic68424b7f42d44e550433a120093db5e7980fd56","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1002132":{"account":{"_account_id":1002132,"name":"boblegal31","email":"devel@thom.fr.eu.org","username":"boblegal31"},"last_update":"2023-04-01 13:33:28.000000000","reason":"boblegal31 replied on the change"}},"hashtags":[],"change_id":"Ic68424b7f42d44e550433a120093db5e7980fd56","subject":"src/target/mips_m4k : fix condition on overlapping workspace data area","status":"MERGED","created":"2023-03-29 14:36:00.000000000","updated":"2023-04-07 21:45:18.000000000","submitted":"2023-04-07 21:45:18.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7563","meta_rev_id":"0d5d79431da811899c0ef9c3381d918ac083ae9e","_number":7563,"owner":{"_account_id":1002132,"name":"boblegal31","email":"devel@thom.fr.eu.org","username":"boblegal31"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-04-07 21:45:18.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-04-07 21:45:18.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-03-29 15:36:13.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-03-31 05:41:20.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"},{"updated":"2023-04-07 21:45:18.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"4bef5919a5714a78284fb93a5accc14184f7abc9","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002132,"name":"boblegal31","email":"devel@thom.fr.eu.org","username":"boblegal31"},"real_author":{"_account_id":1002132,"name":"boblegal31","email":"devel@thom.fr.eu.org","username":"boblegal31"},"date":"2023-03-29 14:36:00.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3d289c538f85510df7b18cca39f92d686efdd99e","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-03-29 15:36:13.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16725/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/17520/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"7b2f7e60bc26c4aeddd6fe3ce884d2f4cbc36258","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-03-31 05:41:20.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"5c7b30de189f96d4691192baf43a0706e09e863a","author":{"_account_id":1002132,"name":"boblegal31","email":"devel@thom.fr.eu.org","username":"boblegal31"},"real_author":{"_account_id":1002132,"name":"boblegal31","email":"devel@thom.fr.eu.org","username":"boblegal31"},"date":"2023-03-31 13:30:27.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"512f7437733943314be40905fd652c9fb2be8c64","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-03-31 15:14:56.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"5c7609ea0bdff3981460372a2767c890f43d421f","author":{"_account_id":1002132,"name":"boblegal31","email":"devel@thom.fr.eu.org","username":"boblegal31"},"real_author":{"_account_id":1002132,"name":"boblegal31","email":"devel@thom.fr.eu.org","username":"boblegal31"},"date":"2023-04-01 13:33:28.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"0d5d79431da811899c0ef9c3381d918ac083ae9e","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-04-07 21:45:18.000000000","message":"Change has been successfully cherry-picked as 18aacc8bf3ff7c7481673cbbfe82f0104e4dccf9","accounts_in_message":[],"_revision_number":2}],"current_revision":"18aacc8bf3ff7c7481673cbbfe82f0104e4dccf9","revisions":{"18aacc8bf3ff7c7481673cbbfe82f0104e4dccf9":{"kind":"REWORK","_number":2,"created":"2023-04-07 21:45:18.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/63/7563/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/63/7563/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/63/7563/2 \u0026\u0026 git checkout -b change-7563 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/63/7563/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/63/7563/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/63/7563/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/63/7563/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/63/7563/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"41037eb26585114209c3c8f1d63f7788a421df07","subject":"rtos/FreeRTOS: some optimization of freertos_update_threads()"}],"author":{"name":"François LEGAL","email":"devel@thom.fr.eu.org","date":"2023-03-29 12:19:48.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-04-07 21:45:18.000000000","tz":0},"subject":"src/target/mips_m4k : fix condition on overlapping workspace data area","message":"src/target/mips_m4k : fix condition on overlapping workspace data area\n\nThe condition to check if the workspace area (used by actual MIPS code\nexecuted on target) and data area (sandbox to put data to be read/written\nto/from flash) is wrong, thus preventing the use of FAST_* commands to\nprogram/verify FLASH.\n\nSigned-off-by: François LEGAL \u003cdevel@thom.fr.eu.org\u003e\nChange-Id: Ic68424b7f42d44e550433a120093db5e7980fd56\nReviewed-on: https://review.openocd.org/c/openocd/+/7563\nTested-by: jenkins\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"d795777639917cbb70f60cd0161710017b1998ad":{"kind":"REWORK","_number":1,"created":"2023-03-29 14:36:00.000000000","uploader":{"_account_id":1002132,"name":"boblegal31","email":"devel@thom.fr.eu.org","username":"boblegal31"},"ref":"refs/changes/63/7563/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/63/7563/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/63/7563/1 \u0026\u0026 git checkout -b change-7563 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/63/7563/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/63/7563/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/63/7563/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/63/7563/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/63/7563/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c1b14d678fd77095ef5c076c0e927aeed6a753c7","subject":"flash/nor: missing fileio_close."}],"author":{"name":"François LEGAL","email":"devel@thom.fr.eu.org","date":"2023-03-29 12:19:48.000000000","tz":120},"committer":{"name":"François LEGAL","email":"devel@thom.fr.eu.org","date":"2023-03-29 12:29:03.000000000","tz":120},"subject":"src/target/mips_m4k : fix condition on overlapping workspace data area","message":"src/target/mips_m4k : fix condition on overlapping workspace data area\n\nThe condition to check if the workspace area (used by actual MIPS code\nexecuted on target) and data area (sandbox to put data to be read/written\nto/from flash) is wrong, thus preventing the use of FAST_* commands to\nprogram/verify FLASH.\n\nSigned-off-by: François LEGAL \u003cdevel@thom.fr.eu.org\u003e\nChange-Id: Ic68424b7f42d44e550433a120093db5e7980fd56\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}