)]}'
{"id":"openocd~master~I420e5de38ab755fdfbeb2115538c61818308ec2b","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2023-04-07 21:47:09.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I420e5de38ab755fdfbeb2115538c61818308ec2b","subject":"helper/list: remove unused hlist_*","status":"MERGED","created":"2023-04-01 21:50:00.000000000","updated":"2023-04-07 21:47:13.000000000","submitted":"2023-04-07 21:47:13.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7567","meta_rev_id":"c176a2d7f0a374bf00ff10c16e2224068fec4a4f","_number":7567,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-04-07 21:47:13.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-04-07 21:47:13.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-04-07 21:47:13.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-04-02 01:15:27.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-04-02 07:35:24.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"}],"messages":[{"id":"5578c2c2b3d1f1ec3046f8be84815bc8e052761b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-04-01 21:50:00.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"189bd4a4203d0c2217021124db9d35a87f1790ca","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-04-02 01:15:27.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16748/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/17542/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"d8e303f1a5db2bd17e938c50dd19c6e9909a029a","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-04-02 07:35:24.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"81bb93abd91ece747d14758b563c1b42ef52bfa2","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-04-07 21:47:09.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"c176a2d7f0a374bf00ff10c16e2224068fec4a4f","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-04-07 21:47:13.000000000","message":"Change has been successfully cherry-picked as 90ce9da644d751466d8dc451d7d2a043cdbf7d72","accounts_in_message":[],"_revision_number":2}],"current_revision":"90ce9da644d751466d8dc451d7d2a043cdbf7d72","revisions":{"90ce9da644d751466d8dc451d7d2a043cdbf7d72":{"kind":"REWORK","_number":2,"created":"2023-04-07 21:47:13.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/67/7567/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/67/7567/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/67/7567/2 \u0026\u0026 git checkout -b change-7567 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/67/7567/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/67/7567/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/67/7567/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/67/7567/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/67/7567/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"55e04e3157cd4d817cfd39c6f1384f96d61a0951","subject":"src/target/mips_m4k : add fast read method"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-03-14 14:01:18.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-04-07 21:47:13.000000000","tz":0},"subject":"helper/list: remove unused hlist_*","message":"helper/list: remove unused hlist_*\n\nThe file list.h is taken from Linux and includes two similar\nimplementation of double linked lists:\n- with single linked list\u0027s head (hlist_*), and\n- with double linked list\u0027s head (list_*).\nWhile the former offers a minor memory footprint improvement,\nkeeping two implementations makes harder for newbie developers\nto approach them.\n\nSo far only the latter implementation has been used and no new\npatches in gerrit is going to change that.\n\nDrop the support for lists with single linked head.\nIt can be easily taken back from git history, if needed.\n\nChange-Id: I420e5de38ab755fdfbeb2115538c61818308ec2b\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7567\nTested-by: jenkins\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"8a33e64b6087d3c59401a91a0ca82be4eb9f785d":{"kind":"REWORK","_number":1,"created":"2023-04-01 21:50:00.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/67/7567/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/67/7567/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/67/7567/1 \u0026\u0026 git checkout -b change-7567 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/67/7567/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/67/7567/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/67/7567/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/67/7567/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/67/7567/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"99ec5760961d264599a9c9fb1a4d5d6042bc3ba8","subject":"github/workflow: build libjaylink from source"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-03-14 14:01:18.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-04-01 21:15:15.000000000","tz":120},"subject":"helper/list: remove unused hlist_*","message":"helper/list: remove unused hlist_*\n\nThe file list.h is taken from Linux and includes two similar\nimplementation of double linked lists:\n- with single linked list\u0027s head (hlist_*), and\n- with double linked list\u0027s head (list_*).\nWhile the former offers a minor memory footprint improvement,\nkeeping two implementations makes harder for newbie developers\nto approach them.\n\nSo far only the latter implementation has been used and no new\npatches in gerrit is going to change that.\n\nDrop the support for lists with single linked head.\nIt can be easily taken back from git history, if needed.\n\nChange-Id: I420e5de38ab755fdfbeb2115538c61818308ec2b\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}