)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"10e47e6548fb40249fa76e8e45979256e081810d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e83aa979_cff20632","updated":"2023-04-01 22:34:51.000000000","message":"Related section about the changes.\n\nhttps://releases.llvm.org/15.0.0/tools/clang/docs/ReleaseNotes.html#improvements-to-clang-s-diagnostics","commit_id":"97cf9b227883978e159498a3caaa3f605e942c5a"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"9a032d16243d151e64539b710359473919c595e0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"28dbabbd_be132b65","updated":"2023-04-15 12:52:08.000000000","message":"I remember there were some concern in Linux mailing list about where to add the attribute:\n- type varname attribute;\n- type attribute varname;\n- varname type attribute;\nSo far jenkins is happy, so let\u0027s merge it as is. If we find any issue, it could be fixed later.\nThanks","commit_id":"eab0f3447e0ee1904d5df15fd62818b309b9c790"}],"src/server/gdb_server.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"d9df9cf4aa0ae19af4914d0883f0a2252075b765","unresolved":true,"context_lines":[{"line_number":2976,"context_line":"\treturn ERROR_OK;"},{"line_number":2977,"context_line":"}"},{"line_number":2978,"context_line":""},{"line_number":2979,"context_line":"static bool gdb_handle_vcont_packet(struct connection *connection, const char *packet, int packet_size)"},{"line_number":2980,"context_line":"{"},{"line_number":2981,"context_line":"\tstruct gdb_connection *gdb_connection \u003d connection-\u003epriv;"},{"line_number":2982,"context_line":"\tstruct target *target \u003d get_target_from_connection(connection);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"3e3705be_29d1886d","line":2979,"updated":"2023-04-14 21:43:33.000000000","message":"with this patch, \u0027packet_size\u0027 becomes unused.\nIt could be removed from the function prototype, but I prefer keeping it to have every function that receives \u0027packet\u0027 to also receive \u0027packet_size\u0027.\nPlease add __attribute__ ((unused)) to \u0027packet_size\u0027.","commit_id":"97cf9b227883978e159498a3caaa3f605e942c5a"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"07115cf0b02d67f05f4468adbd3aefbde0b55f3c","unresolved":false,"context_lines":[{"line_number":2976,"context_line":"\treturn ERROR_OK;"},{"line_number":2977,"context_line":"}"},{"line_number":2978,"context_line":""},{"line_number":2979,"context_line":"static bool gdb_handle_vcont_packet(struct connection *connection, const char *packet, int packet_size)"},{"line_number":2980,"context_line":"{"},{"line_number":2981,"context_line":"\tstruct gdb_connection *gdb_connection \u003d connection-\u003epriv;"},{"line_number":2982,"context_line":"\tstruct target *target \u003d get_target_from_connection(connection);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"0ed45816_19172368","line":2979,"in_reply_to":"3e3705be_29d1886d","updated":"2023-04-14 22:22:17.000000000","message":"Done","commit_id":"97cf9b227883978e159498a3caaa3f605e942c5a"}]}
