)]}'
{"id":"openocd~master~Ic99de78348c6aa86561212a3aded9342e5d32e02","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2023-04-07 22:56:13.000000000","reason":"removed on reply"},"1001964":{"account":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"last_update":"2023-04-02 13:47:37.000000000","reason":"Erhan Kurubas replied on the change"}},"hashtags":[],"change_id":"Ic99de78348c6aa86561212a3aded9342e5d32e02","subject":"helper/compiler fix build with gcc on MacOS","status":"MERGED","created":"2023-04-02 12:29:18.000000000","updated":"2023-04-07 22:56:27.000000000","submitted":"2023-04-07 22:56:27.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7571","meta_rev_id":"9e4abe406aeb6c068917df4bd88f7a22ccd775e8","_number":7571,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-04-07 22:56:27.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"value":0,"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-04-07 22:56:27.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-04-07 22:56:27.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-04-02 12:29:18.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"state":"REVIEWER"},{"updated":"2023-04-07 22:46:57.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"cba002842ccb60c2f9a5ca7de5bcfbe97d77e421","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-04-02 12:29:18.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"81b78478314677e440fdd6b4638be3e1ee0aac0c","author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"real_author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"date":"2023-04-02 13:47:37.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"73cea92af3652c2fbed014ac78bc2c61d9133d69","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-04-07 22:46:57.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16782/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/17577/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"60860c974a02fd91bdbcc416817ca17daae3370f","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-04-07 22:56:13.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"9e4abe406aeb6c068917df4bd88f7a22ccd775e8","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-04-07 22:56:27.000000000","message":"Change has been successfully cherry-picked as 561f27fde9dc51f014b672c227dc7c8ca2530fcf","accounts_in_message":[],"_revision_number":2}],"current_revision":"561f27fde9dc51f014b672c227dc7c8ca2530fcf","revisions":{"ebf7dda8c66b88400c4fa4d70267988246965e20":{"kind":"REWORK","_number":1,"created":"2023-04-02 12:29:18.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/71/7571/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/71/7571/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/71/7571/1 \u0026\u0026 git checkout -b change-7571 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/71/7571/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/71/7571/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/71/7571/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/71/7571/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/71/7571/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"99ec5760961d264599a9c9fb1a4d5d6042bc3ba8","subject":"github/workflow: build libjaylink from source"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-04-02 12:24:23.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-04-02 12:24:23.000000000","tz":120},"subject":"helper/compiler fix build with gcc on MacOS","message":"helper/compiler fix build with gcc on MacOS\n\nOn MacOS libc includes files from MacOSX.sdk that define the macro\n\t#define __nonnull\nwithout arguments, causing compile error.\n\nExtend the existing check for clang on MacOS and undefine the\nmacro for gcc too.\n\nChange-Id: Ic99de78348c6aa86561212a3aded9342e5d32e02\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReported-by: Erhan Kurubas \u003cerhan.kurubas@espressif.com\u003e\n"}},"561f27fde9dc51f014b672c227dc7c8ca2530fcf":{"kind":"REWORK","_number":2,"created":"2023-04-07 22:56:27.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/71/7571/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/71/7571/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/71/7571/2 \u0026\u0026 git checkout -b change-7571 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/71/7571/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/71/7571/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/71/7571/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/71/7571/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/71/7571/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7e0797d19ac1837e3001df9d45030b5eb97ca36d","subject":"ipdbg: whitespaces"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-04-02 12:24:23.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-04-07 22:56:27.000000000","tz":0},"subject":"helper/compiler fix build with gcc on MacOS","message":"helper/compiler fix build with gcc on MacOS\n\nOn MacOS libc includes files from MacOSX.sdk that define the macro\n\t#define __nonnull\nwithout arguments, causing compile error.\n\nExtend the existing check for clang on MacOS and undefine the\nmacro for gcc too.\n\nChange-Id: Ic99de78348c6aa86561212a3aded9342e5d32e02\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReported-by: Erhan Kurubas \u003cerhan.kurubas@espressif.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7571\nReviewed-by: Erhan Kurubas \u003cerhan.kurubas@espressif.com\u003e\nTested-by: jenkins\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}