)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"eb9030a4efcab231e48544dda7b90cb012fd0e7b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7303de06_ab156696","updated":"2023-09-05 15:17:49.000000000","message":"Philip, could you please test the reworked version of TI big-endian workaround on TMS570LC43xx?","commit_id":"7b42d22df0179848cdd6e99bf91157c65af26c1e"},{"author":{"_account_id":1002140,"name":"Philip Kirkpatrick","display_name":"Philip Kirkpatrick","email":"p.kirkpatrick@reflexaerospace.com","username":"RA-Phil-K","status":"Reflex Aerospace"},"change_message_id":"5eea05b950492b6737a3cbb2e64fc634858ba294","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"14620e3e_c57b6de6","in_reply_to":"7303de06_ab156696","updated":"2023-09-06 08:13:14.000000000","message":"I did a quick check and it appears to be working fine on my TMS570LC4357.","commit_id":"7b42d22df0179848cdd6e99bf91157c65af26c1e"}],"src/target/arm_adi_v5.c":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"f266908e095ce02df2dc7e05866cab2fd9ada354","unresolved":true,"context_lines":[{"line_number":385,"context_line":"\t\tif (retval !\u003d ERROR_OK)"},{"line_number":386,"context_line":"\t\t\tbreak;"},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"\t\tretval \u003d mem_ap_setup_tar(ap, address ^ addr_xor);"},{"line_number":389,"context_line":"\t\tif (retval !\u003d ERROR_OK)"},{"line_number":390,"context_line":"\t\t\treturn retval;"},{"line_number":391,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"15e89b00_c3dad826","side":"PARENT","line":388,"range":{"start_line":388,"start_character":40,"end_line":388,"end_character":50},"updated":"2023-04-04 18:59:40.000000000","message":"Note that address must be xored also here - therefore it seems me cleaner to use similar workaround on both places.","commit_id":"1f9fd668affba2acc308479b95952c515d471d5e"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"282cd5329fa7b234d12d037e5dcd4f354f97ddf0","unresolved":true,"context_lines":[{"line_number":385,"context_line":"\t\tif (retval !\u003d ERROR_OK)"},{"line_number":386,"context_line":"\t\t\tbreak;"},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"\t\tretval \u003d mem_ap_setup_tar(ap, address ^ addr_xor);"},{"line_number":389,"context_line":"\t\tif (retval !\u003d ERROR_OK)"},{"line_number":390,"context_line":"\t\t\treturn retval;"},{"line_number":391,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"24faf574_47ced713","side":"PARENT","line":388,"range":{"start_line":388,"start_character":40,"end_line":388,"end_character":50},"in_reply_to":"15e89b00_c3dad826","updated":"2023-04-06 22:38:10.000000000","message":"It\u0027s olny one line, and with the rename ti_be_addr_xor it\u0027s easy to mentally sort it out while reading the code.","commit_id":"1f9fd668affba2acc308479b95952c515d471d5e"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"df6382462f3bd6863567cba306a5976c0305a848","unresolved":false,"context_lines":[{"line_number":385,"context_line":"\t\tif (retval !\u003d ERROR_OK)"},{"line_number":386,"context_line":"\t\t\tbreak;"},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"\t\tretval \u003d mem_ap_setup_tar(ap, address ^ addr_xor);"},{"line_number":389,"context_line":"\t\tif (retval !\u003d ERROR_OK)"},{"line_number":390,"context_line":"\t\t\treturn retval;"},{"line_number":391,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"0335e58e_a45297a5","side":"PARENT","line":388,"range":{"start_line":388,"start_character":40,"end_line":388,"end_character":50},"in_reply_to":"24faf574_47ced713","updated":"2023-12-29 17:16:50.000000000","message":"Done","commit_id":"1f9fd668affba2acc308479b95952c515d471d5e"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"c17e4b4ec30b89282110af338d22066c412e3dd4","unresolved":true,"context_lines":[{"line_number":417,"context_line":"\t\t} else {"},{"line_number":418,"context_line":"\t\t\tswitch (this_size) {"},{"line_number":419,"context_line":"\t\t\tcase 4:"},{"line_number":420,"context_line":"\t\t\t\toutvalue |\u003d (uint32_t)*buffer++ \u003c\u003c 8 * ((drw_byte_idx++ \u0026 3) ^ ti_be_lane_xor);"},{"line_number":421,"context_line":"\t\t\t\toutvalue |\u003d (uint32_t)*buffer++ \u003c\u003c 8 * ((drw_byte_idx++ \u0026 3) ^ ti_be_lane_xor);"},{"line_number":422,"context_line":"\t\t\t\t/* fallthrough */"},{"line_number":423,"context_line":"\t\t\tcase 2:"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"e278b79a_b8604dca","line":420,"updated":"2023-04-04 16:44:55.000000000","message":"I understand it looks redundant, but I think it\u0027s better to keep in one of the if/the/else branches the \"clean\" solution, separate from the quirks.\nIt helps reading this code, ignoring the quirk and avoid wasting time understanding the specific quirk.\nApart from this, yes, a simplification on TI BE quirk is welcome, but in its own branch.","commit_id":"a0de90b6cfaeefd1b895f0d1780420ebc62fa960"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"282cd5329fa7b234d12d037e5dcd4f354f97ddf0","unresolved":true,"context_lines":[{"line_number":417,"context_line":"\t\t} else {"},{"line_number":418,"context_line":"\t\t\tswitch (this_size) {"},{"line_number":419,"context_line":"\t\t\tcase 4:"},{"line_number":420,"context_line":"\t\t\t\toutvalue |\u003d (uint32_t)*buffer++ \u003c\u003c 8 * ((drw_byte_idx++ \u0026 3) ^ ti_be_lane_xor);"},{"line_number":421,"context_line":"\t\t\t\toutvalue |\u003d (uint32_t)*buffer++ \u003c\u003c 8 * ((drw_byte_idx++ \u0026 3) ^ ti_be_lane_xor);"},{"line_number":422,"context_line":"\t\t\t\t/* fallthrough */"},{"line_number":423,"context_line":"\t\t\tcase 2:"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"65418d0e_198ef544","line":420,"in_reply_to":"35bd3c07_b4df0eb6","updated":"2023-04-06 22:38:10.000000000","message":"I don\u0027t know it TI quirks is still needed, it was introduced in 2014. The TMS570 are still in production.\nBut the Nuvoton quirks is quite recent Oct 2021, should be kept still for a while.\nAgree that the TI code is ugly and can be written better, but still I prefer reading this code skipping the quirks part and going to the clean one.\nAnd when, one day, we will drop them, it would be straightforward","commit_id":"a0de90b6cfaeefd1b895f0d1780420ebc62fa960"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"df6382462f3bd6863567cba306a5976c0305a848","unresolved":false,"context_lines":[{"line_number":417,"context_line":"\t\t} else {"},{"line_number":418,"context_line":"\t\t\tswitch (this_size) {"},{"line_number":419,"context_line":"\t\t\tcase 4:"},{"line_number":420,"context_line":"\t\t\t\toutvalue |\u003d (uint32_t)*buffer++ \u003c\u003c 8 * ((drw_byte_idx++ \u0026 3) ^ ti_be_lane_xor);"},{"line_number":421,"context_line":"\t\t\t\toutvalue |\u003d (uint32_t)*buffer++ \u003c\u003c 8 * ((drw_byte_idx++ \u0026 3) ^ ti_be_lane_xor);"},{"line_number":422,"context_line":"\t\t\t\t/* fallthrough */"},{"line_number":423,"context_line":"\t\t\tcase 2:"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"96052255_0adfd508","line":420,"in_reply_to":"65418d0e_198ef544","updated":"2023-12-29 17:16:50.000000000","message":"Let\u0027s move forward with this. I also see some code improvement later in this series.\nI will eventually add more comments in the code once this series is merged.","commit_id":"a0de90b6cfaeefd1b895f0d1780420ebc62fa960"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"f266908e095ce02df2dc7e05866cab2fd9ada354","unresolved":true,"context_lines":[{"line_number":417,"context_line":"\t\t} else {"},{"line_number":418,"context_line":"\t\t\tswitch (this_size) {"},{"line_number":419,"context_line":"\t\t\tcase 4:"},{"line_number":420,"context_line":"\t\t\t\toutvalue |\u003d (uint32_t)*buffer++ \u003c\u003c 8 * ((drw_byte_idx++ \u0026 3) ^ ti_be_lane_xor);"},{"line_number":421,"context_line":"\t\t\t\toutvalue |\u003d (uint32_t)*buffer++ \u003c\u003c 8 * ((drw_byte_idx++ \u0026 3) ^ ti_be_lane_xor);"},{"line_number":422,"context_line":"\t\t\t\t/* fallthrough */"},{"line_number":423,"context_line":"\t\t\tcase 2:"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"35bd3c07_b4df0eb6","line":420,"in_reply_to":"e278b79a_b8604dca","updated":"2023-04-04 18:59:40.000000000","message":"Don\u0027t think so.\n\nThe original code\n (3 ^ (drw_byte_idx++ \u0026 3) ^ addr_xor)\n\nor\n (1 ^ (drw_byte_idx \u0026 3) ^ addr_xor)\n\ntotally obfuscates what is wrong with byte lane addressing. It\u0027s funny that\nmagic num ^ addr_xor is always 3 (for size 1, 2, 4)!\n\nMoreover this awkward code complicates implementation of new features, like large data extension. Take this change as preparatory for \n7576: target/adiv5: probe MEM-AP supported transfer sizes including large data | https://review.openocd.org/c/openocd/+/7576\nPlease consider the patch in the context of changes in 7576.\n\nIf you prefer, we can remove these quirk workarounds at all.","commit_id":"a0de90b6cfaeefd1b895f0d1780420ebc62fa960"}]}