)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"d9bacf64e02958a22d8f02fc06429ab6c9d7c3c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3a40c7ef_697d7d49","updated":"2023-12-29 17:19:46.000000000","message":"Please notice that this doesn\u0027t merge anymore after current\nhttps://review.openocd.org/c/7574/4","commit_id":"adeefb4ad385f9794fe0d6d603800275b02fca27"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"17dddc0f782c0e9766a92ab9ed9fbb520add63d4","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d655da6c_144c3b9c","in_reply_to":"3a40c7ef_697d7d49","updated":"2023-12-29 20:13:11.000000000","message":"Doesn\u0027t it? It merged and compiled okay here, but the next\n7576: target/adiv5: probe MEM-AP supported transfer sizes including large data | https://review.openocd.org/c/openocd/+/7576\nfails to merge","commit_id":"adeefb4ad385f9794fe0d6d603800275b02fca27"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"8404049f5a7965a3d46f1fafa08934c626989a95","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c6a1f133_6afdf0af","in_reply_to":"d655da6c_144c3b9c","updated":"2023-12-29 21:23:24.000000000","message":"true, no idea why it failed before","commit_id":"adeefb4ad385f9794fe0d6d603800275b02fca27"}],"src/target/arm_adi_v5.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"c6b0ade70d91fa0ac635537ba4dda4141208c8a7","unresolved":false,"context_lines":[{"line_number":376,"context_line":""},{"line_number":377,"context_line":"\t\t/* Select packed transfer if possible */"},{"line_number":378,"context_line":"\t\tif (addrinc \u0026\u0026 ap-\u003epacked_transfers \u0026\u0026 nbytes \u003e\u003d 4"},{"line_number":379,"context_line":"\t\t\t\t\u0026\u0026 !dap-\u003enu_npcx_quirks"},{"line_number":380,"context_line":"\t\t\t\t\u0026\u0026 max_tar_block_size(ap-\u003etar_autoincr_block, address) \u003e\u003d 4) {"},{"line_number":381,"context_line":"\t\t\tthis_size \u003d 4;"},{"line_number":382,"context_line":"\t\t\tretval \u003d mem_ap_setup_csw(ap, csw_size | CSW_ADDRINC_PACKED);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"a9f5cc5e_230f67f7","line":379,"updated":"2023-04-06 22:42:19.000000000","message":"agree on this","commit_id":"adeefb4ad385f9794fe0d6d603800275b02fca27"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"c6b0ade70d91fa0ac635537ba4dda4141208c8a7","unresolved":true,"context_lines":[{"line_number":395,"context_line":"\t\t * depends on the type of transfer and alignment. See ARM document IHI0031C. */"},{"line_number":396,"context_line":"\t\tuint32_t outvalue \u003d 0;"},{"line_number":397,"context_line":"\t\tuint32_t drw_byte_idx \u003d address;"},{"line_number":398,"context_line":"\t\tif (dap-\u003enu_npcx_quirks \u0026\u0026 this_size \u003c\u003d 2) {"},{"line_number":399,"context_line":"\t\t\tswitch (this_size) {"},{"line_number":400,"context_line":"\t\t\tcase 2:"},{"line_number":401,"context_line":"\t\t\t\t{"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"7dd19c10_93d4a92e","line":398,"updated":"2023-04-06 22:42:19.000000000","message":"why to mix quirk with default path?\nI don\u0027t see any improvement, it just makes it more difficult to read.","commit_id":"adeefb4ad385f9794fe0d6d603800275b02fca27"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"d9bacf64e02958a22d8f02fc06429ab6c9d7c3c5","unresolved":false,"context_lines":[{"line_number":395,"context_line":"\t\t * depends on the type of transfer and alignment. See ARM document IHI0031C. */"},{"line_number":396,"context_line":"\t\tuint32_t outvalue \u003d 0;"},{"line_number":397,"context_line":"\t\tuint32_t drw_byte_idx \u003d address;"},{"line_number":398,"context_line":"\t\tif (dap-\u003enu_npcx_quirks \u0026\u0026 this_size \u003c\u003d 2) {"},{"line_number":399,"context_line":"\t\t\tswitch (this_size) {"},{"line_number":400,"context_line":"\t\t\tcase 2:"},{"line_number":401,"context_line":"\t\t\t\t{"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"33848b69_529a4ad4","line":398,"in_reply_to":"36fdfbb7_48701554","updated":"2023-12-29 17:19:46.000000000","message":"Ack","commit_id":"adeefb4ad385f9794fe0d6d603800275b02fca27"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"c3b656289fd8a9e38cb1a7501e5964b20eb08b96","unresolved":true,"context_lines":[{"line_number":395,"context_line":"\t\t * depends on the type of transfer and alignment. See ARM document IHI0031C. */"},{"line_number":396,"context_line":"\t\tuint32_t outvalue \u003d 0;"},{"line_number":397,"context_line":"\t\tuint32_t drw_byte_idx \u003d address;"},{"line_number":398,"context_line":"\t\tif (dap-\u003enu_npcx_quirks \u0026\u0026 this_size \u003c\u003d 2) {"},{"line_number":399,"context_line":"\t\t\tswitch (this_size) {"},{"line_number":400,"context_line":"\t\t\tcase 2:"},{"line_number":401,"context_line":"\t\t\t\t{"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"36fdfbb7_48701554","line":398,"in_reply_to":"7dd19c10_93d4a92e","updated":"2023-09-05 15:48:38.000000000","message":"Why? Because there is **NO** quirk in the case of 4 byte word access! Did you spot it from the original code? It was again obfuscated by an identical copy of the base code - but difficult to recognise the code is equal because the copy was not divided by \u0027case\u0027 labels.\n\nBTW I added comments, introduced descriptive temporary variables to avoid hard to read combinations of \\*buffer, \\*(buffer+1) and *buffer++.\nI made it to fully understand the quirk and the way it\u0027s worked around.\n\nAntonio, please stop inventing your \u0027why not\u0027s or this series never gets finished.","commit_id":"adeefb4ad385f9794fe0d6d603800275b02fca27"}]}