)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"f45a8a69298341dfc16a40a45b025d0599d3b679","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"34cdde33_e9f50f84","updated":"2023-04-03 08:54:58.000000000","message":"Tested on\nRP2040/Cortex-M0+: byte, halfword transfers, no packing, no LD\nSTM32H745/Cortex-M7: byte, halfword transfers, packing, no LD\nBCM2711/Cortex-A72: mem ap supports word transfers only, no LD\n\nUnfortunately I don\u0027t have any device with large data support.","commit_id":"2b4eada9a812e02f110620fafb348b32e268d8be"},{"author":{"_account_id":1001992,"name":"Peter Collingbourne","email":"pcc@google.com","username":"pcc"},"change_message_id":"2a03fe3e5929d94d2bf769c1aaa3b94eb8987160","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"afaf2600_8737daf7","in_reply_to":"34cdde33_e9f50f84","updated":"2023-04-26 04:33:39.000000000","message":"Thanks! Verified that this series works on my target with large data support.","commit_id":"2b4eada9a812e02f110620fafb348b32e268d8be"}],"src/target/arm_adi_v5.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"c3a1851cf833c9312b62c3b0425bd45955a4f4c6","unresolved":true,"context_lines":[{"line_number":403,"context_line":"\t\tif (size_supported) {"},{"line_number":404,"context_line":"\t\t\tap-\u003ecsw_size_supported |\u003d size;"},{"line_number":405,"context_line":"\t\t\tif (pack) {"},{"line_number":406,"context_line":"\t\t\t\tap-\u003epacked_transfers_probed \u003d true;"},{"line_number":407,"context_line":"\t\t\t\tap-\u003epacked_transfers_supported \u003d"},{"line_number":408,"context_line":"\t\t\t\t\t((csw_readback \u0026 CSW_ADDRINC_MASK) \u003d\u003d csw_addrinc);"},{"line_number":409,"context_line":"\t\t\t\tLOG_DEBUG(\"probed packing: %s\","}],"source_content_type":"text/x-csrc","patch_set":2,"id":"bc29e813_cffa03a7","line":406,"updated":"2023-12-29 18:10:50.000000000","message":"is it correct to enter here every time we probe a new size, even if ap-\u003epacked_transfers_probed is already true for a previous size?\nWe would get the LOG_DEBUG below repeated.\nShould the check above be changed as:\nif (pack \u0026\u0026 !ap-\u003epacked_transfers_probed) {","commit_id":"2b4eada9a812e02f110620fafb348b32e268d8be"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"c60bf5fae95c38e296ce3c77403934c48ae58543","unresolved":false,"context_lines":[{"line_number":403,"context_line":"\t\tif (size_supported) {"},{"line_number":404,"context_line":"\t\t\tap-\u003ecsw_size_supported |\u003d size;"},{"line_number":405,"context_line":"\t\t\tif (pack) {"},{"line_number":406,"context_line":"\t\t\t\tap-\u003epacked_transfers_probed \u003d true;"},{"line_number":407,"context_line":"\t\t\t\tap-\u003epacked_transfers_supported \u003d"},{"line_number":408,"context_line":"\t\t\t\t\t((csw_readback \u0026 CSW_ADDRINC_MASK) \u003d\u003d csw_addrinc);"},{"line_number":409,"context_line":"\t\t\t\tLOG_DEBUG(\"probed packing: %s\","}],"source_content_type":"text/x-csrc","patch_set":2,"id":"9aa95540_92f1020b","line":406,"in_reply_to":"bc29e813_cffa03a7","updated":"2023-12-29 22:50:14.000000000","message":"Good catch!\n\nDone","commit_id":"2b4eada9a812e02f110620fafb348b32e268d8be"}],"src/target/arm_adi_v5.h":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"c3a1851cf833c9312b62c3b0425bd45955a4f4c6","unresolved":true,"context_lines":[{"line_number":273,"context_line":"\tuint32_t csw_value;"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"\t/**"},{"line_number":276,"context_line":"\t * Save the supported CSW.Size data types for the MEM-AP."},{"line_number":277,"context_line":"\t * Each bit corresponds to a data type."},{"line_number":278,"context_line":"\t * 0b1 \u003d Supported data type. 0b0 \u003d Not supported."},{"line_number":279,"context_line":"\t * Bit 0 \u003d Byte (8-bits)"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"8357387e_41bc945a","line":276,"updated":"2023-12-29 18:10:50.000000000","message":"please extend the comment to say that this applies to both fields csw_size_supported and csw_size_probed; I always return on this patch and ask myself why csw_size_probed is not of type bool.\nI\u0027m not sure it could help renaming them s/size/sizes/ as we have below packed_transfers_probed.\nWhat about a longer name as\ncsw_sizemask_supported and csw_sizemask_probed\nor probably better\ncsw_size_supported_mask and csw_size_probed_mask ?","commit_id":"2b4eada9a812e02f110620fafb348b32e268d8be"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"c60bf5fae95c38e296ce3c77403934c48ae58543","unresolved":false,"context_lines":[{"line_number":273,"context_line":"\tuint32_t csw_value;"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"\t/**"},{"line_number":276,"context_line":"\t * Save the supported CSW.Size data types for the MEM-AP."},{"line_number":277,"context_line":"\t * Each bit corresponds to a data type."},{"line_number":278,"context_line":"\t * 0b1 \u003d Supported data type. 0b0 \u003d Not supported."},{"line_number":279,"context_line":"\t * Bit 0 \u003d Byte (8-bits)"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"5d14dd26_27232287","line":276,"in_reply_to":"8357387e_41bc945a","updated":"2023-12-29 22:50:14.000000000","message":"Both the comment and variable names was copied from\nhttps://review.openocd.org/c/openocd/+/7191/5/src/target/arm_adi_v5.h\n\nYou\u0027re right, I extended the comment and added _mask to var names.","commit_id":"2b4eada9a812e02f110620fafb348b32e268d8be"}]}