)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"dff2285ec244059863a799ee80dc40d5fba75c88","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2023-04-10 11:26:30 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"openocd: fix some coding style"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Signed-off-by: Mark Zhuang \u003cmark.zhuang@spacemit.com\u003e"},{"line_number":10,"context_line":"Change-Id: I50fce3da283a78ba02bf70b6a752f7bf778d79f5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"502ddb2f_b055762b","line":8,"updated":"2023-04-10 09:25:07.000000000","message":"chackpatch script complains that the commit message is empty.\nIt requires some description of what the patch does, after the title.\nBut I\u0027m surprised that the other patch from you didn\u0027t have the same error.\nSo I have checked checkpatch and it wrongly takes the line Change-Id: as a valid message. Here Change-Id is after Signed-off-by and it detect the error. In 7584, instead, the Change-Id is before Signed-off-by and checkpatch fails to detect...\nI will send a patch to fix checkpatch in Linux.\nIn mean time, would you mind resending this patch after add some short description like:\n Add space around math operators.","commit_id":"b908edf123769aa1008ad80f53cf2a95abbe4063"},{"author":{"_account_id":1002135,"name":"Mark Zhuang","email":"mark.zhuang@spacemit.com","username":"zqb-all"},"change_message_id":"dea155f96a69c635258f42c9cdb215f4b54fec64","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2023-04-10 11:26:30 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"openocd: fix some coding style"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Signed-off-by: Mark Zhuang \u003cmark.zhuang@spacemit.com\u003e"},{"line_number":10,"context_line":"Change-Id: I50fce3da283a78ba02bf70b6a752f7bf778d79f5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"b9a1301a_e65fa182","line":8,"in_reply_to":"22907936_5cf64103","updated":"2024-06-19 02:20:14.000000000","message":"Done","commit_id":"b908edf123769aa1008ad80f53cf2a95abbe4063"},{"author":{"_account_id":1002135,"name":"Mark Zhuang","email":"mark.zhuang@spacemit.com","username":"zqb-all"},"change_message_id":"6ef6e31ffe4f484e43319cca984ce46a3b3d9edf","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2023-04-10 11:26:30 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"openocd: fix some coding style"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Signed-off-by: Mark Zhuang \u003cmark.zhuang@spacemit.com\u003e"},{"line_number":10,"context_line":"Change-Id: I50fce3da283a78ba02bf70b6a752f7bf778d79f5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"22907936_5cf64103","line":8,"in_reply_to":"502ddb2f_b055762b","updated":"2023-04-10 10:33:32.000000000","message":"I will do that later","commit_id":"b908edf123769aa1008ad80f53cf2a95abbe4063"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"dff2285ec244059863a799ee80dc40d5fba75c88","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"83f4cf31_098a7629","updated":"2023-04-10 09:25:07.000000000","message":"Thanks for this patch","commit_id":"b908edf123769aa1008ad80f53cf2a95abbe4063"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"2b0cc551ad693a5429a71f210e1bac881bfa751b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"86cfb34a_5f000687","updated":"2024-06-08 08:40:51.000000000","message":"This patch does not merge anymore after the modifications on file arm_adi_v5.c\nCan you please rebase and resend it?","commit_id":"619054633c5cd6e425ff790d62ebfa54d544fade"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"7b439cd096f6421de075a3b40734af61a97d5c4b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"97fed66b_ea293965","updated":"2024-06-20 16:08:27.000000000","message":"Thanks!","commit_id":"c17fad24b93ab9afec554f09c59b4d8ecedc9420"}],"src/target/arm_adi_v5.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"dff2285ec244059863a799ee80dc40d5fba75c88","unresolved":true,"context_lines":[{"line_number":419,"context_line":"\t\t\t\tbreak;"},{"line_number":420,"context_line":"\t\t\tcase 2:"},{"line_number":421,"context_line":"\t\t\t\toutvalue |\u003d (uint32_t)*buffer \u003c\u003c 8 * (drw_byte_idx++ \u0026 3);"},{"line_number":422,"context_line":"\t\t\t\toutvalue |\u003d (uint32_t)*(buffer + 1) \u003c\u003c 8 * (drw_byte_idx++ \u0026 3);"},{"line_number":423,"context_line":"\t\t\t\toutvalue |\u003d (uint32_t)*buffer++ \u003c\u003c 8 * (drw_byte_idx++ \u0026 3);"},{"line_number":424,"context_line":"\t\t\t\toutvalue |\u003d (uint32_t)*buffer++ \u003c\u003c 8 * (drw_byte_idx \u0026 3);"},{"line_number":425,"context_line":"\t\t\t\tbreak;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"3ee26255_9381b2aa","line":422,"updated":"2023-04-10 09:25:07.000000000","message":"This change is correct, but there is some other patch in gerrit that is modifying this part of code.\nI would prefer giving priority to the code change and delay merging this coding style violation.\nIf you don\u0027t mind, I will keep this on hold.","commit_id":"b908edf123769aa1008ad80f53cf2a95abbe4063"},{"author":{"_account_id":1002135,"name":"Mark Zhuang","email":"mark.zhuang@spacemit.com","username":"zqb-all"},"change_message_id":"6ef6e31ffe4f484e43319cca984ce46a3b3d9edf","unresolved":true,"context_lines":[{"line_number":419,"context_line":"\t\t\t\tbreak;"},{"line_number":420,"context_line":"\t\t\tcase 2:"},{"line_number":421,"context_line":"\t\t\t\toutvalue |\u003d (uint32_t)*buffer \u003c\u003c 8 * (drw_byte_idx++ \u0026 3);"},{"line_number":422,"context_line":"\t\t\t\toutvalue |\u003d (uint32_t)*(buffer + 1) \u003c\u003c 8 * (drw_byte_idx++ \u0026 3);"},{"line_number":423,"context_line":"\t\t\t\toutvalue |\u003d (uint32_t)*buffer++ \u003c\u003c 8 * (drw_byte_idx++ \u0026 3);"},{"line_number":424,"context_line":"\t\t\t\toutvalue |\u003d (uint32_t)*buffer++ \u003c\u003c 8 * (drw_byte_idx \u0026 3);"},{"line_number":425,"context_line":"\t\t\t\tbreak;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"5e0afcbf_1cc85b24","line":422,"in_reply_to":"3ee26255_9381b2aa","updated":"2023-04-10 10:33:32.000000000","message":"Okay, just deal with the other patches first","commit_id":"b908edf123769aa1008ad80f53cf2a95abbe4063"},{"author":{"_account_id":1002135,"name":"Mark Zhuang","email":"mark.zhuang@spacemit.com","username":"zqb-all"},"change_message_id":"dea155f96a69c635258f42c9cdb215f4b54fec64","unresolved":false,"context_lines":[{"line_number":419,"context_line":"\t\t\t\tbreak;"},{"line_number":420,"context_line":"\t\t\tcase 2:"},{"line_number":421,"context_line":"\t\t\t\toutvalue |\u003d (uint32_t)*buffer \u003c\u003c 8 * (drw_byte_idx++ \u0026 3);"},{"line_number":422,"context_line":"\t\t\t\toutvalue |\u003d (uint32_t)*(buffer + 1) \u003c\u003c 8 * (drw_byte_idx++ \u0026 3);"},{"line_number":423,"context_line":"\t\t\t\toutvalue |\u003d (uint32_t)*buffer++ \u003c\u003c 8 * (drw_byte_idx++ \u0026 3);"},{"line_number":424,"context_line":"\t\t\t\toutvalue |\u003d (uint32_t)*buffer++ \u003c\u003c 8 * (drw_byte_idx \u0026 3);"},{"line_number":425,"context_line":"\t\t\t\tbreak;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"6368fc77_187c4fbc","line":422,"in_reply_to":"5e0afcbf_1cc85b24","updated":"2024-06-19 02:20:14.000000000","message":"Done","commit_id":"b908edf123769aa1008ad80f53cf2a95abbe4063"}]}