)]}'
{"id":"openocd~master~I50fce3da283a78ba02bf70b6a752f7bf778d79f5","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1002135":{"account":{"_account_id":1002135,"name":"Mark Zhuang","email":"mark.zhuang@spacemit.com","username":"zqb-all"},"last_update":"2024-07-13 16:47:44.000000000","reason":"Change was submitted"},"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2024-06-20 16:08:27.000000000","reason":"\u003cGERRIT_ACCOUNT_1000021\u003e replied on the change","reason_account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}},"hashtags":[],"change_id":"I50fce3da283a78ba02bf70b6a752f7bf778d79f5","subject":"openocd: fix some coding style","status":"MERGED","created":"2023-04-10 03:27:18.000000000","updated":"2024-07-13 16:47:44.000000000","submitted":"2024-07-13 16:47:44.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":9,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7585","meta_rev_id":"729b89e37c7da1d5eab7ef3125c0533f526dc03a","_number":7585,"owner":{"_account_id":1002135,"name":"Mark Zhuang","email":"mark.zhuang@spacemit.com","username":"zqb-all"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-07-13 16:47:44.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-07-13 16:47:44.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-04-10 04:23:09.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-04-10 09:25:07.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"CC"},{"updated":"2023-04-10 17:15:23.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"84514aaf73f3d4a510d5e1305da8757a7602baad","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002135,"name":"Mark Zhuang","email":"mark.zhuang@spacemit.com","username":"zqb-all"},"real_author":{"_account_id":1002135,"name":"Mark Zhuang","email":"mark.zhuang@spacemit.com","username":"zqb-all"},"date":"2023-04-10 03:27:18.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b926ccc2c63c5cdf3fe9d6b2ef4d23deb701f9c5","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-04-10 04:23:09.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16798/ : FAILURE\n\nhttps://build.openocd.org/job/openocd-gerrit/17595/ : FAILURE","accounts_in_message":[],"_revision_number":1},{"id":"dff2285ec244059863a799ee80dc40d5fba75c88","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-04-10 09:25:07.000000000","message":"Patch Set 1:\n\n(3 comments)","accounts_in_message":[],"_revision_number":1},{"id":"6ef6e31ffe4f484e43319cca984ce46a3b3d9edf","author":{"_account_id":1002135,"name":"Mark Zhuang","email":"mark.zhuang@spacemit.com","username":"zqb-all"},"real_author":{"_account_id":1002135,"name":"Mark Zhuang","email":"mark.zhuang@spacemit.com","username":"zqb-all"},"date":"2023-04-10 10:33:32.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"2d14f5a80011db5afcf98034571d1b5fd29d857d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002135,"name":"Mark Zhuang","email":"mark.zhuang@spacemit.com","username":"zqb-all"},"real_author":{"_account_id":1002135,"name":"Mark Zhuang","email":"mark.zhuang@spacemit.com","username":"zqb-all"},"date":"2023-04-10 14:15:53.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"777106b38f917726c94b41fb8c553b42f4aab760","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-04-10 15:45:44.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16804/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/17602/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"178675499fe1c036a6930354d181fec5217e9102","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-04-10 17:15:23.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"2b0cc551ad693a5429a71f210e1bac881bfa751b","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-06-08 08:40:51.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"41a27c6fd642b9e21b4a0aecc2511f9d33e1b7b2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002135,"name":"Mark Zhuang","email":"mark.zhuang@spacemit.com","username":"zqb-all"},"real_author":{"_account_id":1002135,"name":"Mark Zhuang","email":"mark.zhuang@spacemit.com","username":"zqb-all"},"date":"2024-06-19 02:16:52.000000000","message":"Uploaded patch set 3.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR is:MIN\")\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":3},{"id":"dea155f96a69c635258f42c9cdb215f4b54fec64","author":{"_account_id":1002135,"name":"Mark Zhuang","email":"mark.zhuang@spacemit.com","username":"zqb-all"},"real_author":{"_account_id":1002135,"name":"Mark Zhuang","email":"mark.zhuang@spacemit.com","username":"zqb-all"},"date":"2024-06-19 02:20:14.000000000","message":"Patch Set 3:\n\n(2 comments)","accounts_in_message":[],"_revision_number":3},{"id":"0bcd5d59bf79b9bad4fb45ae5fcc667ef2b2cc6a","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-06-19 02:29:59.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19723/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18879/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"7b439cd096f6421de075a3b40734af61a97d5c4b","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-06-20 16:08:27.000000000","message":"Patch Set 3: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"729b89e37c7da1d5eab7ef3125c0533f526dc03a","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-07-13 16:47:44.000000000","message":"Change has been successfully cherry-picked as 7957208cf6c50ddbbc4b6d687f8aa278604a363b","accounts_in_message":[],"_revision_number":4}],"current_revision":"7957208cf6c50ddbbc4b6d687f8aa278604a363b","revisions":{"b908edf123769aa1008ad80f53cf2a95abbe4063":{"kind":"REWORK","_number":1,"created":"2023-04-10 03:27:18.000000000","uploader":{"_account_id":1002135,"name":"Mark Zhuang","email":"mark.zhuang@spacemit.com","username":"zqb-all"},"ref":"refs/changes/85/7585/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/85/7585/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/85/7585/1 \u0026\u0026 git checkout -b change-7585 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/85/7585/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/85/7585/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/85/7585/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/85/7585/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/85/7585/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"561f27fde9dc51f014b672c227dc7c8ca2530fcf","subject":"helper/compiler fix build with gcc on MacOS"}],"author":{"name":"Mark Zhuang","email":"mark.zhuang@spacemit.com","date":"2023-04-10 03:17:17.000000000","tz":480},"committer":{"name":"Mark Zhuang","email":"mark.zhuang@spacemit.com","date":"2023-04-10 03:26:30.000000000","tz":480},"subject":"openocd: fix some coding style","message":"openocd: fix some coding style\n\nSigned-off-by: Mark Zhuang \u003cmark.zhuang@spacemit.com\u003e\nChange-Id: I50fce3da283a78ba02bf70b6a752f7bf778d79f5\n"}},"c17fad24b93ab9afec554f09c59b4d8ecedc9420":{"kind":"REWORK","_number":3,"created":"2024-06-19 02:16:52.000000000","uploader":{"_account_id":1002135,"name":"Mark Zhuang","email":"mark.zhuang@spacemit.com","username":"zqb-all"},"ref":"refs/changes/85/7585/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/85/7585/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/85/7585/3 \u0026\u0026 git checkout -b change-7585 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/85/7585/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/85/7585/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/85/7585/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/85/7585/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/85/7585/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c5358c84ad0d3e7497498e0457cec7785f72910a","subject":"target: Do not use LOG_USER() for error messages"}],"author":{"name":"Mark Zhuang","email":"mark.zhuang@spacemit.com","date":"2023-04-10 03:17:17.000000000","tz":480},"committer":{"name":"Mark Zhuang","email":"mark.zhuang@spacemit.com","date":"2024-06-19 02:13:53.000000000","tz":480},"subject":"openocd: fix some coding style","message":"openocd: fix some coding style\n\nAdd space around math operators.\n\nChange-Id: I50fce3da283a78ba02bf70b6a752f7bf778d79f5\nSigned-off-by: Mark Zhuang \u003cmark.zhuang@spacemit.com\u003e\n"}},"619054633c5cd6e425ff790d62ebfa54d544fade":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2023-04-10 14:15:53.000000000","uploader":{"_account_id":1002135,"name":"Mark Zhuang","email":"mark.zhuang@spacemit.com","username":"zqb-all"},"ref":"refs/changes/85/7585/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/85/7585/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/85/7585/2 \u0026\u0026 git checkout -b change-7585 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/85/7585/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/85/7585/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/85/7585/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/85/7585/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/85/7585/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"561f27fde9dc51f014b672c227dc7c8ca2530fcf","subject":"helper/compiler fix build with gcc on MacOS"}],"author":{"name":"Mark Zhuang","email":"mark.zhuang@spacemit.com","date":"2023-04-10 03:17:17.000000000","tz":480},"committer":{"name":"Mark Zhuang","email":"mark.zhuang@spacemit.com","date":"2023-04-10 14:15:00.000000000","tz":480},"subject":"openocd: fix some coding style","message":"openocd: fix some coding style\n\nAdd space around math operators.\n\nChange-Id: I50fce3da283a78ba02bf70b6a752f7bf778d79f5\nSigned-off-by: Mark Zhuang \u003cmark.zhuang@spacemit.com\u003e\n"}},"7957208cf6c50ddbbc4b6d687f8aa278604a363b":{"kind":"REWORK","_number":4,"created":"2024-07-13 16:47:44.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/85/7585/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/85/7585/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/85/7585/4 \u0026\u0026 git checkout -b change-7585 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/85/7585/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/85/7585/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/85/7585/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/85/7585/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/85/7585/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"990869f7ec8dbb91f14f9edde6f02dc30fd18b8e","subject":"openocd: build: prevent old clone to fail on git submodules"}],"author":{"name":"Mark Zhuang","email":"mark.zhuang@spacemit.com","date":"2023-04-10 03:17:17.000000000","tz":480},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-07-13 16:47:44.000000000","tz":0},"subject":"openocd: fix some coding style","message":"openocd: fix some coding style\n\nAdd space around math operators.\n\nChange-Id: I50fce3da283a78ba02bf70b6a752f7bf778d79f5\nSigned-off-by: Mark Zhuang \u003cmark.zhuang@spacemit.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7585\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}