)]}'
{"id":"openocd~master~Iae42e28357da54061122fe56e4cd8e041df5255c","project":"openocd","branch":"master","attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2023-04-10 16:10:27.000000000","reason":"Weijie Gao replied on the change"}},"removed_from_attention_set":{"1001853":{"account":{"_account_id":1001853,"name":"Weijie Gao","email":"hackpascal@gmail.com","username":"hackpascal"},"last_update":"2023-04-10 16:10:27.000000000","reason":"Weijie Gao replied on the change"}},"hashtags":[],"change_id":"Iae42e28357da54061122fe56e4cd8e041df5255c","subject":"jtag/drivers/ftdi: add support for using FTDI D2XX driver on Windows","status":"NEW","created":"2023-04-10 08:51:43.000000000","updated":"2023-04-10 16:10:27.000000000","submit_type":"CHERRY_PICK","mergeable":false,"submittable":false,"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"fb01ada6ab5aa2c9cba3baec764eaf0b5a87175d","_number":7589,"owner":{"_account_id":1001853,"name":"Weijie Gao","email":"hackpascal@gmail.com","username":"hackpascal"},"actions":{},"labels":{"Verified":{"rejected":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":-1,"date":"2023-04-10 10:29:32.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0,"blocking":true},"Code-Review":{"rejected":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"value":-2,"date":"2023-04-10 13:24:13.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0,"blocking":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-04-10 10:29:32.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-04-10 13:24:13.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"91727d3cdcbf1f3a4426833eaae55fcb58cad491","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001853,"name":"Weijie Gao","email":"hackpascal@gmail.com","username":"hackpascal"},"real_author":{"_account_id":1001853,"name":"Weijie Gao","email":"hackpascal@gmail.com","username":"hackpascal"},"date":"2023-04-10 08:51:43.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"83b7b8d78bd4a6732c371e1325bf6e6c08bc1aa3","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-04-10 10:29:32.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16802/ : FAILURE\n\nhttps://build.openocd.org/job/openocd-gerrit/17599/ : FAILURE","accounts_in_message":[],"_revision_number":1},{"id":"733e97e8a1c7510e96a38ae17d4544a2eb911fc2","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-04-10 13:24:13.000000000","message":"Patch Set 1: Code-Review-2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"368cb0cf12696f712be0505440c60f1cba920cb6","author":{"_account_id":1001853,"name":"Weijie Gao","email":"hackpascal@gmail.com","username":"hackpascal"},"real_author":{"_account_id":1001853,"name":"Weijie Gao","email":"hackpascal@gmail.com","username":"hackpascal"},"date":"2023-04-10 14:36:52.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"f80762886f4026bdf0aac6e574c725a7630980f7","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-04-10 15:31:16.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"fb01ada6ab5aa2c9cba3baec764eaf0b5a87175d","author":{"_account_id":1001853,"name":"Weijie Gao","email":"hackpascal@gmail.com","username":"hackpascal"},"real_author":{"_account_id":1001853,"name":"Weijie Gao","email":"hackpascal@gmail.com","username":"hackpascal"},"date":"2023-04-10 16:10:27.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1}],"current_revision":"d5e2eb80571ae23b0de68fd40a5f79c1c9632011","revisions":{"d5e2eb80571ae23b0de68fd40a5f79c1c9632011":{"kind":"REWORK","_number":1,"created":"2023-04-10 08:51:43.000000000","uploader":{"_account_id":1001853,"name":"Weijie Gao","email":"hackpascal@gmail.com","username":"hackpascal"},"ref":"refs/changes/89/7589/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/89/7589/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/89/7589/1 \u0026\u0026 git checkout -b change-7589 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/89/7589/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/89/7589/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/89/7589/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/89/7589/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/89/7589/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1b3a9d61647274c9bcfdc5ede3605b31ee9d106b","subject":"jtag/drivers/ftdi: make mpsse-libusb optional in build"}],"author":{"name":"Weijie Gao","email":"hackpascal@gmail.com","date":"2023-04-10 07:13:01.000000000","tz":480},"committer":{"name":"Weijie Gao","email":"hackpascal@gmail.com","date":"2023-04-10 08:51:20.000000000","tz":480},"subject":"jtag/drivers/ftdi: add support for using FTDI D2XX driver on Windows","message":"jtag/drivers/ftdi: add support for using FTDI D2XX driver on Windows\n\nThis patch adds FTDI D2XX support on Windows platform.\n\nMany FTDI boards are shipped with blank EEPROM which will be likely\ninstalled with the FTDI official D2XX driver on Windows.\nAs many users don\u0027t know how to replace the D2XX driver with libusb one,\nit\u0027s necessary to support the FTDI D2XX driver.\n\nThis patch adds new subcommands for ftdi adapter driver:\n- ftdi backend (libusb|d2xx)\n  Selects the backend to be used for accessing device, libusb or d2xx.\n  libusb is default if not specified.\n  This makes sure the support for D2XX does not break the compatibility.\n- ftdi device_location \u003clocation-id\u003e\n  Specify the D2XX USB device location ID of the FTDI device.\n\nSince FT_OpenEx supports three methods of opening a device, this patch has\nalso added support for these methods:\n1. By serial number:\n   ftdi backend d2xx\n   adapter serial \u003cserial_string\u003e\n2. By description:\n   ftdi backend d2xx\n   ftdi device_desc \u003cd2xx-related-description\u003e\n3. By location\n   ftdi backend d2xx\n   ftdi device_location \u003cd2xx-location-id\u003e\n\nFor portability, the original ftd2xx.lib is not used. Instead, dynamically\nloading of ftd2xx.dll is used. This will make the executable not depend on\nftd2xx.dll, and this feature can be always enabled for Windows platform.\n\nSigned-off-by: Weijie Gao \u003chackpascal@gmail.com\u003e\nChange-Id: Iae42e28357da54061122fe56e4cd8e041df5255c\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"NOT_READY","labels":[{"label":"Verified","status":"REJECT","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"REJECT","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"UNSATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"]}},{"name":"Code-Review","status":"UNSATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"]}}]}
