)]}'
{"id":"openocd~master~I118554fffde41c94cea9e1201ea941ff3c1ee762","project":"openocd","branch":"master","hashtags":[],"change_id":"I118554fffde41c94cea9e1201ea941ff3c1ee762","subject":"flash: with pointers, use NULL instead of 0","status":"MERGED","created":"2023-04-10 17:35:31.000000000","updated":"2023-05-05 22:08:38.000000000","submitted":"2023-05-05 22:08:38.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7595","meta_rev_id":"c4aa9ee7ce1814390b937d25db4ea077eccce40f","_number":7595,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-05-05 22:08:38.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-05-05 22:08:38.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-04-10 21:20:51.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2023-04-11 17:36:54.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"b6b4d81014f777e4e4faeed6f14d850b38326078","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-04-10 17:35:31.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3de8305d9811ece02a02a7b00d2a3ef9d1930ab6","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-04-10 21:20:06.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"f5d5fa7b081451ab17a9fc441b66f301480a8c27","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-04-10 21:20:51.000000000","message":"Patch Set 1:\n\nNo Builds Executed","accounts_in_message":[],"_revision_number":1},{"id":"baa714510ddce5c8c2a76cc0788f11d4b4557820","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-04-11 17:36:54.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16828/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/17626/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"d12e505c9bc3de62d50b1c0731bf27a95343b1c5","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-05-05 22:08:35.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"c4aa9ee7ce1814390b937d25db4ea077eccce40f","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-05-05 22:08:38.000000000","message":"Change has been successfully cherry-picked as aa1214280d11c32f82961da44dee863098e1ac38","accounts_in_message":[],"_revision_number":3}],"current_revision":"aa1214280d11c32f82961da44dee863098e1ac38","revisions":{"aa1214280d11c32f82961da44dee863098e1ac38":{"kind":"REWORK","_number":3,"created":"2023-05-05 22:08:38.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/95/7595/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/95/7595/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/95/7595/3 \u0026\u0026 git checkout -b change-7595 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/95/7595/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/95/7595/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/95/7595/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/95/7595/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/95/7595/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d4fe63e36b662ad274783585ff7222befbf54268","subject":"flash: nor: add static to local symbols"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-04-08 22:00:37.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-05-05 22:08:38.000000000","tz":0},"subject":"flash: with pointers, use NULL instead of 0","message":"flash: with pointers, use NULL instead of 0\n\nDon\u0027t compare pointers with 0, use NULL when needed.\nDon\u0027t pass 0 ad pointer argument, pass NULL.\n\nDetected through \u0027sparse\u0027 tool.\n\nChange-Id: I118554fffde41c94cea9e1201ea941ff3c1ee762\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7595\nTested-by: jenkins\n"}},"b32f46d2302c7b73184125bf183217797ca41edf":{"kind":"REWORK","_number":2,"created":"2023-04-10 21:20:06.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/95/7595/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/95/7595/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/95/7595/2 \u0026\u0026 git checkout -b change-7595 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/95/7595/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/95/7595/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/95/7595/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/95/7595/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/95/7595/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c3528c3ba0416bc5cd5b6be828df418428d73ad8","subject":"flash: nor: add static to local symbols"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-04-08 22:00:37.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-04-10 21:18:52.000000000","tz":120},"subject":"flash: with pointers, use NULL instead of 0","message":"flash: with pointers, use NULL instead of 0\n\nDon\u0027t compare pointers with 0, use NULL when needed.\nDon\u0027t pass 0 ad pointer argument, pass NULL.\n\nDetected through \u0027sparse\u0027 tool.\n\nChange-Id: I118554fffde41c94cea9e1201ea941ff3c1ee762\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"ba97438d93c827c85c3246c2c2f1e9f33176ff5e":{"kind":"REWORK","_number":1,"created":"2023-04-10 17:35:31.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/95/7595/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/95/7595/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/95/7595/1 \u0026\u0026 git checkout -b change-7595 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/95/7595/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/95/7595/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/95/7595/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/95/7595/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/95/7595/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c3528c3ba0416bc5cd5b6be828df418428d73ad8","subject":"flash: nor: add static to local symbols"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-04-08 22:00:37.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-04-10 17:22:08.000000000","tz":120},"subject":"flash: with pointers, use NULL instead of 0","message":"flash: with pointers, use NULL instead of 0\n\nDon\u0027t compare pointers with 0, use NULL when needed.\nDon\u0027t pass 0 ad pointer argument, pass NULL.\n\nDetected through \u0027sparse\u0027 tool.\n\nChange-Id: I118554fffde41c94cea9e1201ea941ff3c1ee762\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}