)]}'
{"id":"openocd~master~I27d18d26c2c797160a397daa32835c199014b70b","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2023-05-06 13:34:22.000000000","reason":"\u003cGERRIT_ACCOUNT_1000021\u003e replied on the change","reason_account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2023-05-06 13:34:32.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I27d18d26c2c797160a397daa32835c199014b70b","subject":"target: etm: fix check trace status","status":"MERGED","created":"2023-04-10 17:35:31.000000000","updated":"2023-05-06 13:34:32.000000000","submitted":"2023-05-06 13:34:32.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7599","meta_rev_id":"6dd938ad55d0c026e97756fe3f1caa944c4149ec","_number":7599,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-05-06 13:34:32.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-05-06 13:34:32.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-05-06 13:34:32.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-04-10 17:39:00.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"},{"updated":"2023-04-11 04:41:17.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"3813d2700748ff73e0bf75ed0c9a35644dea4cf2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-04-10 17:35:31.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"5215577c766ccc05e7c3e8cd3d7b4f8103658dd5","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-04-10 17:39:00.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"f0e7fe120a0b4103f48947afdd72ab1b3f931673","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-04-11 04:41:17.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16816/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/17613/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"ec95a3b2e6547dfc158a9bd16cbf318e79004574","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-05-05 22:09:34.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"738fbc5c243aa39be0502e3332f873c20ca9eafc","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-05-06 04:26:19.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"b96d4a86562886be1ae7b37c31b437b212f1c22b","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-05-06 13:34:22.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"6dd938ad55d0c026e97756fe3f1caa944c4149ec","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-05-06 13:34:32.000000000","message":"Change has been successfully cherry-picked as 329b10754aa2294d11717c461f356c174eba5094","accounts_in_message":[],"_revision_number":2}],"current_revision":"329b10754aa2294d11717c461f356c174eba5094","revisions":{"329b10754aa2294d11717c461f356c174eba5094":{"kind":"REWORK","_number":2,"created":"2023-05-06 13:34:32.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/99/7599/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/99/7599/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/99/7599/2 \u0026\u0026 git checkout -b change-7599 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/99/7599/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/99/7599/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/99/7599/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/99/7599/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/99/7599/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"92c1bee18c8268511de3478aabd226ce4f92322a","subject":"jtag: xds110: fix check on malloc() returned pointer"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-04-08 23:00:15.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-05-06 13:34:32.000000000","tz":0},"subject":"target: etm: fix check trace status","message":"target: etm: fix check trace status\n\nCurrent code tests a function pointer against a numeric value that\nis the same enum type as returned by the pointed function.\nClearly the author was willing to call the function and check its\nreturned value.\n\nFix the check by calling the function.\n\nDetected through \u0027sparse\u0027 tool.\n\nChange-Id: I27d18d26c2c797160a397daa32835c199014b70b\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nCheckpatch-ignore: GIT_COMMIT_ID\nFixes: 237e894805dd (\"reworked etm/etb into a generic etm part with trace capture\")\nReviewed-on: https://review.openocd.org/c/openocd/+/7599\nTested-by: jenkins\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"b48eac0d6be1b82550a665ad85f472a859394384":{"kind":"REWORK","_number":1,"created":"2023-04-10 17:35:31.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/99/7599/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/99/7599/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/99/7599/1 \u0026\u0026 git checkout -b change-7599 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/99/7599/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/99/7599/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/99/7599/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/99/7599/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/99/7599/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"00a8fea31fc527021da9613eb5b0b97bd67925ae","subject":"rtos: with pointers, use NULL instead of 0"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-04-08 23:00:15.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-04-10 17:22:08.000000000","tz":120},"subject":"target: etm: fix check trace status","message":"target: etm: fix check trace status\n\nCurrent code tests a function pointer against a numeric value that\nis the same enum type as returned by the pointed function.\nClearly the author was willing to call the function and check its\nreturned value.\n\nFix the check by calling the function.\n\nDetected through \u0027sparse\u0027 tool.\n\nChange-Id: I27d18d26c2c797160a397daa32835c199014b70b\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nCheckpatch-ignore: GIT_COMMIT_ID\nFixes: 237e894805dd (\"reworked etm/etb into a generic etm part with trace capture\")\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}