)]}'
{"id":"openocd~master~I205ca986968fef9a536f87492d1f6c80e41829f3","project":"openocd","branch":"master","hashtags":[],"change_id":"I205ca986968fef9a536f87492d1f6c80e41829f3","subject":"target: use \u0027ULL\u0027 suffix for long constants","status":"MERGED","created":"2023-04-10 17:35:31.000000000","updated":"2023-05-05 22:10:18.000000000","submitted":"2023-05-05 22:10:18.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7601","meta_rev_id":"087317adcb0cf453a2fca9450352ad6cd63a20d3","_number":7601,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-05-05 22:10:18.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-05-05 22:10:18.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-04-11 08:23:12.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"5896214faf7916f6b2d36b80cd96eadaabedf7aa","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-04-10 17:35:31.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a69e2e2b8c59a3eb5d7283cdd998fc77b7fadeea","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-04-11 08:23:12.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16819/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/17617/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"0a996c25f728abeb412442176da8846ccd68b7d3","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-05-05 22:10:13.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"087317adcb0cf453a2fca9450352ad6cd63a20d3","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-05-05 22:10:18.000000000","message":"Change has been successfully cherry-picked as ea62f8e22adb0c56509dd1999a2be9cf9798b8aa","accounts_in_message":[],"_revision_number":2}],"current_revision":"ea62f8e22adb0c56509dd1999a2be9cf9798b8aa","revisions":{"63589a38e9b1dfe870395e342f074b8cc30b1d46":{"kind":"REWORK","_number":1,"created":"2023-04-10 17:35:31.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/01/7601/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/01/7601/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/01/7601/1 \u0026\u0026 git checkout -b change-7601 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/01/7601/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/01/7601/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/01/7601/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/01/7601/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/01/7601/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"446c8eb6fcf040b05d745ab6bde43402487629b4","subject":"target: riscv: use \u0027ULL\u0027 suffix for long constants"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-04-08 23:36:04.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-04-10 17:22:08.000000000","tz":120},"subject":"target: use \u0027ULL\u0027 suffix for long constants","message":"target: use \u0027ULL\u0027 suffix for long constants\n\nOn 32 bit hosts, gcc should consider constants without suffix as\n32 bits values.\n\nUse the suffix \u0027ULL\u0027 to guarantee it is a 64 bit.\n\nDetected through \u0027sparse\u0027 tool.\n\nChange-Id: I205ca986968fef9a536f87492d1f6c80e41829f3\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"ea62f8e22adb0c56509dd1999a2be9cf9798b8aa":{"kind":"REWORK","_number":2,"created":"2023-05-05 22:10:18.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/01/7601/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/01/7601/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/01/7601/2 \u0026\u0026 git checkout -b change-7601 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/01/7601/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/01/7601/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/01/7601/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/01/7601/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/01/7601/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"314f4c665f746ebec3be69a8e26f0a671cfdcb46","subject":"rtos: with pointers, use NULL instead of 0"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-04-08 23:36:04.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-05-05 22:10:18.000000000","tz":0},"subject":"target: use \u0027ULL\u0027 suffix for long constants","message":"target: use \u0027ULL\u0027 suffix for long constants\n\nOn 32 bit hosts, gcc should consider constants without suffix as\n32 bits values.\n\nUse the suffix \u0027ULL\u0027 to guarantee it is a 64 bit.\n\nDetected through \u0027sparse\u0027 tool.\n\nChange-Id: I205ca986968fef9a536f87492d1f6c80e41829f3\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7601\nTested-by: jenkins\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}