)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b3d71029d1f80e19443116d0f1e3441b501f7495","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9dd1a1b1_d953ba96","updated":"2023-05-14 10:50:03.000000000","message":"My main concern is about respecting SEGGER copyright and license.\nPlease properly check it","commit_id":"01426cb0b433b30e95d0ecc17186286dee44c97d"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"87c86ea5f6f76865b9609a057f9b55fbb1d635d3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"49998df3_fb939411","updated":"2023-05-14 20:55:20.000000000","message":"Thanks.\nI just make a quick check. Too late, tonight. Maybe I will review it deeply at next round.","commit_id":"10fd14f01dae2f355bd079a52377797dc8feaa14"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"da050e931283acb72199ce8a174d65f119cc3111","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1e2041b5_ce792e4c","updated":"2023-05-15 18:34:36.000000000","message":"@Antonio, Thanks for the first round. This is ready for the next.","commit_id":"c8dd17a6427373f12f7bf836cdedbe1effa19559"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"31ddeb3781e296730e5c012d3a545022ed43c6de","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1a13501d_0cb980b8","updated":"2023-05-16 21:38:17.000000000","message":"There are still very few things to fix, then I think could be ok.","commit_id":"c8dd17a6427373f12f7bf836cdedbe1effa19559"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"c60a8592ce661cbed94c0d13f9781768573b72c6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"de69c5dc_d2773d13","updated":"2023-05-17 17:48:00.000000000","message":"Thank you Antonio.","commit_id":"bc01e9ad0899b27a57492b3d55532435bac44c46"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"d7e89ec5df985a2fd0a2fa03c270759e869f37e2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"583ae186_25c8275d","updated":"2023-05-18 09:42:40.000000000","message":"Thanks!","commit_id":"bc01e9ad0899b27a57492b3d55532435bac44c46"}],"src/target/espressif/esp32_apptrace.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b3d71029d1f80e19443116d0f1e3441b501f7495","unresolved":true,"context_lines":[{"line_number":1259,"context_line":"\tuint8_t cmds[] \u003d { SEGGER_SYSVIEW_COMMAND_ID_START };"},{"line_number":1260,"context_line":"\tuint32_t fired_target_num \u003d 0;"},{"line_number":1261,"context_line":"\tstruct esp32_apptrace_target_state target_state[ESP32_APPTRACE_MAX_CORES_NUM];"},{"line_number":1262,"context_line":"\tstruct esp32_sysview_cmd_data *cmd_data \u003d (struct esp32_sysview_cmd_data *)ctx-\u003ecmd_priv;"},{"line_number":1263,"context_line":""},{"line_number":1264,"context_line":"\t/* get current block id */"},{"line_number":1265,"context_line":"\tint res \u003d esp32_apptrace_get_data_info(ctx, target_state, \u0026fired_target_num);"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"da86809c_dee0bdfc","line":1262,"updated":"2023-05-14 10:50:03.000000000","message":"no need for cast, since cmd_priv is defined as void*","commit_id":"01426cb0b433b30e95d0ecc17186286dee44c97d"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"2b7752c94f4f43cab85c730190f1554727247b65","unresolved":false,"context_lines":[{"line_number":1259,"context_line":"\tuint8_t cmds[] \u003d { SEGGER_SYSVIEW_COMMAND_ID_START };"},{"line_number":1260,"context_line":"\tuint32_t fired_target_num \u003d 0;"},{"line_number":1261,"context_line":"\tstruct esp32_apptrace_target_state target_state[ESP32_APPTRACE_MAX_CORES_NUM];"},{"line_number":1262,"context_line":"\tstruct esp32_sysview_cmd_data *cmd_data \u003d (struct esp32_sysview_cmd_data *)ctx-\u003ecmd_priv;"},{"line_number":1263,"context_line":""},{"line_number":1264,"context_line":"\t/* get current block id */"},{"line_number":1265,"context_line":"\tint res \u003d esp32_apptrace_get_data_info(ctx, target_state, \u0026fired_target_num);"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"7404796e_710bedda","line":1262,"in_reply_to":"da86809c_dee0bdfc","updated":"2023-05-14 13:11:20.000000000","message":"Done","commit_id":"01426cb0b433b30e95d0ecc17186286dee44c97d"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b3d71029d1f80e19443116d0f1e3441b501f7495","unresolved":true,"context_lines":[{"line_number":1273,"context_line":"\t\tfired_target_num \u003d 0;"},{"line_number":1274,"context_line":"\t}"},{"line_number":1275,"context_line":"\t/* start tracing */"},{"line_number":1276,"context_line":"\tres \u003d"},{"line_number":1277,"context_line":"\t\tesp_apptrace_usr_block_write(ctx-\u003ehw,"},{"line_number":1278,"context_line":"\t\tctx-\u003ecpus[fired_target_num],"},{"line_number":1279,"context_line":"\t\ttarget_state[fired_target_num].block_id,"},{"line_number":1280,"context_line":"\t\tcmds,"},{"line_number":1281,"context_line":"\t\tsizeof(cmds));"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"a5855360_729c7e2f","line":1278,"range":{"start_line":1276,"start_character":1,"end_line":1278,"end_character":30},"updated":"2023-05-14 10:50:03.000000000","message":"very strange and unreadable indentation.\nPlease don\u0027t put the function parameters aligned with the function name","commit_id":"01426cb0b433b30e95d0ecc17186286dee44c97d"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"2b7752c94f4f43cab85c730190f1554727247b65","unresolved":false,"context_lines":[{"line_number":1273,"context_line":"\t\tfired_target_num \u003d 0;"},{"line_number":1274,"context_line":"\t}"},{"line_number":1275,"context_line":"\t/* start tracing */"},{"line_number":1276,"context_line":"\tres \u003d"},{"line_number":1277,"context_line":"\t\tesp_apptrace_usr_block_write(ctx-\u003ehw,"},{"line_number":1278,"context_line":"\t\tctx-\u003ecpus[fired_target_num],"},{"line_number":1279,"context_line":"\t\ttarget_state[fired_target_num].block_id,"},{"line_number":1280,"context_line":"\t\tcmds,"},{"line_number":1281,"context_line":"\t\tsizeof(cmds));"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"920b847c_c33778e4","line":1278,"range":{"start_line":1276,"start_character":1,"end_line":1278,"end_character":30},"in_reply_to":"a5855360_729c7e2f","updated":"2023-05-14 13:11:20.000000000","message":"Done","commit_id":"01426cb0b433b30e95d0ecc17186286dee44c97d"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b3d71029d1f80e19443116d0f1e3441b501f7495","unresolved":true,"context_lines":[{"line_number":1291,"context_line":"{"},{"line_number":1292,"context_line":"\tuint32_t old_block_id, fired_target_num \u003d 0, empty_target_num \u003d 0;"},{"line_number":1293,"context_line":"\tstruct esp32_apptrace_target_state target_state[ESP32_APPTRACE_MAX_CORES_NUM];"},{"line_number":1294,"context_line":"\tstruct esp32_sysview_cmd_data *cmd_data \u003d (struct esp32_sysview_cmd_data *)ctx-\u003ecmd_priv;"},{"line_number":1295,"context_line":"\tuint8_t cmds[] \u003d { SEGGER_SYSVIEW_COMMAND_ID_STOP };"},{"line_number":1296,"context_line":"\tstruct duration wait_time;"},{"line_number":1297,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":2,"id":"14abf531_1c96d24b","line":1294,"updated":"2023-05-14 10:50:03.000000000","message":"no cast","commit_id":"01426cb0b433b30e95d0ecc17186286dee44c97d"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"2b7752c94f4f43cab85c730190f1554727247b65","unresolved":false,"context_lines":[{"line_number":1291,"context_line":"{"},{"line_number":1292,"context_line":"\tuint32_t old_block_id, fired_target_num \u003d 0, empty_target_num \u003d 0;"},{"line_number":1293,"context_line":"\tstruct esp32_apptrace_target_state target_state[ESP32_APPTRACE_MAX_CORES_NUM];"},{"line_number":1294,"context_line":"\tstruct esp32_sysview_cmd_data *cmd_data \u003d (struct esp32_sysview_cmd_data *)ctx-\u003ecmd_priv;"},{"line_number":1295,"context_line":"\tuint8_t cmds[] \u003d { SEGGER_SYSVIEW_COMMAND_ID_STOP };"},{"line_number":1296,"context_line":"\tstruct duration wait_time;"},{"line_number":1297,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":2,"id":"c30274a8_b675f510","line":1294,"in_reply_to":"14abf531_1c96d24b","updated":"2023-05-14 13:11:20.000000000","message":"Done","commit_id":"01426cb0b433b30e95d0ecc17186286dee44c97d"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b3d71029d1f80e19443116d0f1e3441b501f7495","unresolved":true,"context_lines":[{"line_number":1320,"context_line":"\t\t/* read pending data without ack, they will be acked when stop command is queued */"},{"line_number":1321,"context_line":"\t\tres \u003d"},{"line_number":1322,"context_line":"\t\t\tctx-\u003ehw-\u003edata_read(ctx-\u003ecpus[fired_target_num],"},{"line_number":1323,"context_line":"\t\t\ttarget_state[fired_target_num].data_len,"},{"line_number":1324,"context_line":"\t\t\tblock-\u003edata,"},{"line_number":1325,"context_line":"\t\t\ttarget_state[fired_target_num].block_id,"},{"line_number":1326,"context_line":"\t\t\t0 /*no ack target data*/);"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"b7b7b30e_4bc5a062","line":1323,"updated":"2023-05-14 10:50:03.000000000","message":"indentation","commit_id":"01426cb0b433b30e95d0ecc17186286dee44c97d"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"2b7752c94f4f43cab85c730190f1554727247b65","unresolved":false,"context_lines":[{"line_number":1320,"context_line":"\t\t/* read pending data without ack, they will be acked when stop command is queued */"},{"line_number":1321,"context_line":"\t\tres \u003d"},{"line_number":1322,"context_line":"\t\t\tctx-\u003ehw-\u003edata_read(ctx-\u003ecpus[fired_target_num],"},{"line_number":1323,"context_line":"\t\t\ttarget_state[fired_target_num].data_len,"},{"line_number":1324,"context_line":"\t\t\tblock-\u003edata,"},{"line_number":1325,"context_line":"\t\t\ttarget_state[fired_target_num].block_id,"},{"line_number":1326,"context_line":"\t\t\t0 /*no ack target data*/);"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"69f8a416_c3d57d6f","line":1323,"in_reply_to":"b7b7b30e_4bc5a062","updated":"2023-05-14 13:11:20.000000000","message":"Done","commit_id":"01426cb0b433b30e95d0ecc17186286dee44c97d"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b3d71029d1f80e19443116d0f1e3441b501f7495","unresolved":true,"context_lines":[{"line_number":1323,"context_line":"\t\t\ttarget_state[fired_target_num].data_len,"},{"line_number":1324,"context_line":"\t\t\tblock-\u003edata,"},{"line_number":1325,"context_line":"\t\t\ttarget_state[fired_target_num].block_id,"},{"line_number":1326,"context_line":"\t\t\t0 /*no ack target data*/);"},{"line_number":1327,"context_line":"\t\tif (res !\u003d ERROR_OK) {"},{"line_number":1328,"context_line":"\t\t\tLOG_ERROR(\"SEGGER: Failed to read data on (%s)!\", target_name(ctx-\u003ecpus[fired_target_num]));"},{"line_number":1329,"context_line":"\t\t\treturn res;"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"1a549781_82cdfde3","line":1326,"updated":"2023-05-14 10:50:03.000000000","message":"this is a bool! use true/false, not a numeric value","commit_id":"01426cb0b433b30e95d0ecc17186286dee44c97d"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"2b7752c94f4f43cab85c730190f1554727247b65","unresolved":false,"context_lines":[{"line_number":1323,"context_line":"\t\t\ttarget_state[fired_target_num].data_len,"},{"line_number":1324,"context_line":"\t\t\tblock-\u003edata,"},{"line_number":1325,"context_line":"\t\t\ttarget_state[fired_target_num].block_id,"},{"line_number":1326,"context_line":"\t\t\t0 /*no ack target data*/);"},{"line_number":1327,"context_line":"\t\tif (res !\u003d ERROR_OK) {"},{"line_number":1328,"context_line":"\t\t\tLOG_ERROR(\"SEGGER: Failed to read data on (%s)!\", target_name(ctx-\u003ecpus[fired_target_num]));"},{"line_number":1329,"context_line":"\t\t\treturn res;"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"35e7bc5e_81980630","line":1326,"in_reply_to":"1a549781_82cdfde3","updated":"2023-05-14 13:11:20.000000000","message":"Done","commit_id":"01426cb0b433b30e95d0ecc17186286dee44c97d"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b3d71029d1f80e19443116d0f1e3441b501f7495","unresolved":true,"context_lines":[{"line_number":1339,"context_line":"\t/* stop tracing and ack target data */"},{"line_number":1340,"context_line":"\tres \u003d"},{"line_number":1341,"context_line":"\t\tesp_apptrace_usr_block_write(ctx-\u003ehw,"},{"line_number":1342,"context_line":"\t\tctx-\u003ecpus[fired_target_num],"},{"line_number":1343,"context_line":"\t\ttarget_state[fired_target_num].block_id,"},{"line_number":1344,"context_line":"\t\tcmds,"},{"line_number":1345,"context_line":"\t\tsizeof(cmds));"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"9a8bcf9b_27ea6458","line":1342,"updated":"2023-05-14 10:50:03.000000000","message":"indentation","commit_id":"01426cb0b433b30e95d0ecc17186286dee44c97d"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"2b7752c94f4f43cab85c730190f1554727247b65","unresolved":false,"context_lines":[{"line_number":1339,"context_line":"\t/* stop tracing and ack target data */"},{"line_number":1340,"context_line":"\tres \u003d"},{"line_number":1341,"context_line":"\t\tesp_apptrace_usr_block_write(ctx-\u003ehw,"},{"line_number":1342,"context_line":"\t\tctx-\u003ecpus[fired_target_num],"},{"line_number":1343,"context_line":"\t\ttarget_state[fired_target_num].block_id,"},{"line_number":1344,"context_line":"\t\tcmds,"},{"line_number":1345,"context_line":"\t\tsizeof(cmds));"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"1d2f33e6_2a7a9290","line":1342,"in_reply_to":"9a8bcf9b_27ea6458","updated":"2023-05-14 13:11:20.000000000","message":"Done","commit_id":"01426cb0b433b30e95d0ecc17186286dee44c97d"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b3d71029d1f80e19443116d0f1e3441b501f7495","unresolved":true,"context_lines":[{"line_number":1352,"context_line":"\t\t/* ack target data on another CPU */"},{"line_number":1353,"context_line":"\t\tres \u003d"},{"line_number":1354,"context_line":"\t\t\tctx-\u003ehw-\u003ectrl_reg_write(ctx-\u003ecpus[empty_target_num],"},{"line_number":1355,"context_line":"\t\t\ttarget_state[fired_target_num].block_id,"},{"line_number":1356,"context_line":"\t\t\t0 /*target data ack*/,"},{"line_number":1357,"context_line":"\t\t\ttrue /*host connected*/,"},{"line_number":1358,"context_line":"\t\t\tfalse /*no host data*/);"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"ee664bb3_af6daf38","line":1355,"updated":"2023-05-14 10:50:03.000000000","message":"indentation","commit_id":"01426cb0b433b30e95d0ecc17186286dee44c97d"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"2b7752c94f4f43cab85c730190f1554727247b65","unresolved":false,"context_lines":[{"line_number":1352,"context_line":"\t\t/* ack target data on another CPU */"},{"line_number":1353,"context_line":"\t\tres \u003d"},{"line_number":1354,"context_line":"\t\t\tctx-\u003ehw-\u003ectrl_reg_write(ctx-\u003ecpus[empty_target_num],"},{"line_number":1355,"context_line":"\t\t\ttarget_state[fired_target_num].block_id,"},{"line_number":1356,"context_line":"\t\t\t0 /*target data ack*/,"},{"line_number":1357,"context_line":"\t\t\ttrue /*host connected*/,"},{"line_number":1358,"context_line":"\t\t\tfalse /*no host data*/);"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"7a8b95ba_f8bdfefb","line":1355,"in_reply_to":"ee664bb3_af6daf38","updated":"2023-05-14 13:11:20.000000000","message":"Done","commit_id":"01426cb0b433b30e95d0ecc17186286dee44c97d"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b3d71029d1f80e19443116d0f1e3441b501f7495","unresolved":true,"context_lines":[{"line_number":1406,"context_line":"\t\t\t\t\ttarget_state[fired_target_num].data_len,"},{"line_number":1407,"context_line":"\t\t\t\t\tblock-\u003edata,"},{"line_number":1408,"context_line":"\t\t\t\t\ttarget_state[fired_target_num].block_id,"},{"line_number":1409,"context_line":"\t\t\t\t\t1 /*ack target data*/);"},{"line_number":1410,"context_line":"\t\t\t\tif (res !\u003d ERROR_OK) {"},{"line_number":1411,"context_line":"\t\t\t\t\tLOG_ERROR(\"SEGGER: Failed to read last data on (%s)!\","},{"line_number":1412,"context_line":"\t\t\t\t\t\ttarget_name(ctx-\u003ecpus[fired_target_num]));"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"a3174252_205da534","line":1409,"updated":"2023-05-14 10:50:03.000000000","message":"bool","commit_id":"01426cb0b433b30e95d0ecc17186286dee44c97d"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"2b7752c94f4f43cab85c730190f1554727247b65","unresolved":false,"context_lines":[{"line_number":1406,"context_line":"\t\t\t\t\ttarget_state[fired_target_num].data_len,"},{"line_number":1407,"context_line":"\t\t\t\t\tblock-\u003edata,"},{"line_number":1408,"context_line":"\t\t\t\t\ttarget_state[fired_target_num].block_id,"},{"line_number":1409,"context_line":"\t\t\t\t\t1 /*ack target data*/);"},{"line_number":1410,"context_line":"\t\t\t\tif (res !\u003d ERROR_OK) {"},{"line_number":1411,"context_line":"\t\t\t\t\tLOG_ERROR(\"SEGGER: Failed to read last data on (%s)!\","},{"line_number":1412,"context_line":"\t\t\t\t\t\ttarget_name(ctx-\u003ecpus[fired_target_num]));"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"8b753639_1629457a","line":1409,"in_reply_to":"a3174252_205da534","updated":"2023-05-14 13:11:20.000000000","message":"Done","commit_id":"01426cb0b433b30e95d0ecc17186286dee44c97d"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b3d71029d1f80e19443116d0f1e3441b501f7495","unresolved":true,"context_lines":[{"line_number":1531,"context_line":"\t\t\t\tesp32_apptrace_connect_targets(\u0026s_at_cmd_ctx, false, old_state \u003d\u003d TARGET_RUNNING);"},{"line_number":1532,"context_line":"\t\t\t\ts_at_cmd_ctx.running \u003d 0;"},{"line_number":1533,"context_line":"\t\t\t\tesp32_apptrace_cmd_cleanup(\u0026s_at_cmd_ctx);"},{"line_number":1534,"context_line":"\t\t\t\tcommand_print(cmd, \"SEGGER: Failed to start tracing!\");"},{"line_number":1535,"context_line":"\t\t\t\treturn res;"},{"line_number":1536,"context_line":"\t\t\t}"},{"line_number":1537,"context_line":"\t\t}"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"a5f3e2cb_9b204f4e","line":1534,"updated":"2023-05-14 10:50:03.000000000","message":"While reporting compatibility with Segger tool is OK in the documentation, here I would prefer a more neutral message, e.g. replacing \"SEGGER\" with \"sysview\"","commit_id":"01426cb0b433b30e95d0ecc17186286dee44c97d"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"2b7752c94f4f43cab85c730190f1554727247b65","unresolved":false,"context_lines":[{"line_number":1531,"context_line":"\t\t\t\tesp32_apptrace_connect_targets(\u0026s_at_cmd_ctx, false, old_state \u003d\u003d TARGET_RUNNING);"},{"line_number":1532,"context_line":"\t\t\t\ts_at_cmd_ctx.running \u003d 0;"},{"line_number":1533,"context_line":"\t\t\t\tesp32_apptrace_cmd_cleanup(\u0026s_at_cmd_ctx);"},{"line_number":1534,"context_line":"\t\t\t\tcommand_print(cmd, \"SEGGER: Failed to start tracing!\");"},{"line_number":1535,"context_line":"\t\t\t\treturn res;"},{"line_number":1536,"context_line":"\t\t\t}"},{"line_number":1537,"context_line":"\t\t}"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"b5e87ec6_41dc90db","line":1534,"in_reply_to":"a5f3e2cb_9b204f4e","updated":"2023-05-14 13:11:20.000000000","message":"Done","commit_id":"01426cb0b433b30e95d0ecc17186286dee44c97d"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"87c86ea5f6f76865b9609a057f9b55fbb1d635d3","unresolved":true,"context_lines":[{"line_number":1531,"context_line":"\t\t\t\tesp32_apptrace_connect_targets(\u0026s_at_cmd_ctx, false, old_state \u003d\u003d TARGET_RUNNING);"},{"line_number":1532,"context_line":"\t\t\t\ts_at_cmd_ctx.running \u003d 0;"},{"line_number":1533,"context_line":"\t\t\t\tesp32_apptrace_cmd_cleanup(\u0026s_at_cmd_ctx);"},{"line_number":1534,"context_line":"\t\t\t\tcommand_print(cmd, \"SEGGER: Failed to start tracing!\");"},{"line_number":1535,"context_line":"\t\t\t\treturn res;"},{"line_number":1536,"context_line":"\t\t\t}"},{"line_number":1537,"context_line":"\t\t}"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"edcb4279_fe26f174","line":1534,"in_reply_to":"b5e87ec6_41dc90db","updated":"2023-05-14 20:55:20.000000000","message":"My idea was to replace s/SEGGER/sysview/ in every LOG_XX in this file, not only here","commit_id":"01426cb0b433b30e95d0ecc17186286dee44c97d"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"da050e931283acb72199ce8a174d65f119cc3111","unresolved":false,"context_lines":[{"line_number":1531,"context_line":"\t\t\t\tesp32_apptrace_connect_targets(\u0026s_at_cmd_ctx, false, old_state \u003d\u003d TARGET_RUNNING);"},{"line_number":1532,"context_line":"\t\t\t\ts_at_cmd_ctx.running \u003d 0;"},{"line_number":1533,"context_line":"\t\t\t\tesp32_apptrace_cmd_cleanup(\u0026s_at_cmd_ctx);"},{"line_number":1534,"context_line":"\t\t\t\tcommand_print(cmd, \"SEGGER: Failed to start tracing!\");"},{"line_number":1535,"context_line":"\t\t\t\treturn res;"},{"line_number":1536,"context_line":"\t\t\t}"},{"line_number":1537,"context_line":"\t\t}"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"2e1b8382_565bb540","line":1534,"in_reply_to":"edcb4279_fe26f174","updated":"2023-05-15 18:34:36.000000000","message":"Now OK.","commit_id":"01426cb0b433b30e95d0ecc17186286dee44c97d"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b3d71029d1f80e19443116d0f1e3441b501f7495","unresolved":true,"context_lines":[{"line_number":1639,"context_line":"\t\t.help \u003d"},{"line_number":1640,"context_line":"\t\t\t\"App Tracing: SEGGER SystemView compatible trace control. Starts, stops or queries tracing process status.\","},{"line_number":1641,"context_line":"\t\t.usage \u003d"},{"line_number":1642,"context_line":"\t\t\t\"[start file://\u003coutfile1\u003e [file://\u003coutfile2\u003e] [poll_period [trace_size [stop_tmo [wait4halt [skip_size]]]]] | [stop] | [status]\","},{"line_number":1643,"context_line":"\t},"},{"line_number":1644,"context_line":"\t{"},{"line_number":1645,"context_line":"\t\t.name \u003d \"sysview_mcore\","}],"source_content_type":"text/x-csrc","patch_set":2,"id":"081e4936_88405ddf","line":1642,"updated":"2023-05-14 10:50:03.000000000","message":"the notation [stop] means that you can either put the argument \"stop\" or it can be omitted.\nBut the command cannot be run with NO arguments, so this notation is incorrect.\nShould it be\n.usage \u003d\n\"(start file://\u003coutfile1\u003e [file://\u003coutfile2\u003e] [poll_period [trace_size [stop_tmo [wait4halt [skip_size]]]]) | stop | status\",\n?","commit_id":"01426cb0b433b30e95d0ecc17186286dee44c97d"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"2b7752c94f4f43cab85c730190f1554727247b65","unresolved":false,"context_lines":[{"line_number":1639,"context_line":"\t\t.help \u003d"},{"line_number":1640,"context_line":"\t\t\t\"App Tracing: SEGGER SystemView compatible trace control. Starts, stops or queries tracing process status.\","},{"line_number":1641,"context_line":"\t\t.usage \u003d"},{"line_number":1642,"context_line":"\t\t\t\"[start file://\u003coutfile1\u003e [file://\u003coutfile2\u003e] [poll_period [trace_size [stop_tmo [wait4halt [skip_size]]]]] | [stop] | [status]\","},{"line_number":1643,"context_line":"\t},"},{"line_number":1644,"context_line":"\t{"},{"line_number":1645,"context_line":"\t\t.name \u003d \"sysview_mcore\","}],"source_content_type":"text/x-csrc","patch_set":2,"id":"f8564a62_79cfd544","line":1642,"in_reply_to":"081e4936_88405ddf","updated":"2023-05-14 13:11:20.000000000","message":"Done","commit_id":"01426cb0b433b30e95d0ecc17186286dee44c97d"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"da050e931283acb72199ce8a174d65f119cc3111","unresolved":false,"context_lines":[{"line_number":1639,"context_line":"\t\t.help \u003d"},{"line_number":1640,"context_line":"\t\t\t\"App Tracing: SEGGER SystemView compatible trace control. Starts, stops or queries tracing process status.\","},{"line_number":1641,"context_line":"\t\t.usage \u003d"},{"line_number":1642,"context_line":"\t\t\t\"[start file://\u003coutfile1\u003e [file://\u003coutfile2\u003e] [poll_period [trace_size [stop_tmo [wait4halt [skip_size]]]]] | [stop] | [status]\","},{"line_number":1643,"context_line":"\t},"},{"line_number":1644,"context_line":"\t{"},{"line_number":1645,"context_line":"\t\t.name \u003d \"sysview_mcore\","}],"source_content_type":"text/x-csrc","patch_set":2,"id":"90252575_e22d8306","line":1642,"in_reply_to":"68f5a83a_43033d13","updated":"2023-05-15 18:34:36.000000000","message":"Now OK.","commit_id":"01426cb0b433b30e95d0ecc17186286dee44c97d"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"87c86ea5f6f76865b9609a057f9b55fbb1d635d3","unresolved":true,"context_lines":[{"line_number":1639,"context_line":"\t\t.help \u003d"},{"line_number":1640,"context_line":"\t\t\t\"App Tracing: SEGGER SystemView compatible trace control. Starts, stops or queries tracing process status.\","},{"line_number":1641,"context_line":"\t\t.usage \u003d"},{"line_number":1642,"context_line":"\t\t\t\"[start file://\u003coutfile1\u003e [file://\u003coutfile2\u003e] [poll_period [trace_size [stop_tmo [wait4halt [skip_size]]]]] | [stop] | [status]\","},{"line_number":1643,"context_line":"\t},"},{"line_number":1644,"context_line":"\t{"},{"line_number":1645,"context_line":"\t\t.name \u003d \"sysview_mcore\","}],"source_content_type":"text/x-csrc","patch_set":2,"id":"68f5a83a_43033d13","line":1642,"in_reply_to":"f8564a62_79cfd544","updated":"2023-05-14 20:55:20.000000000","message":"no, the square brackets means optional. So\n([case1] | [case2] | [case3])\nis incorrect. It should be\n(case1 | case2 | case3)","commit_id":"01426cb0b433b30e95d0ecc17186286dee44c97d"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b3d71029d1f80e19443116d0f1e3441b501f7495","unresolved":true,"context_lines":[{"line_number":1648,"context_line":"\t\t.help \u003d"},{"line_number":1649,"context_line":"\t\t\t\"App Tracing: Espressif multi-core SystemView trace control. Starts, stops or queries tracing process status.\","},{"line_number":1650,"context_line":"\t\t.usage \u003d"},{"line_number":1651,"context_line":"\t\t\t\"[start file://\u003coutfile\u003e [poll_period [trace_size [stop_tmo [wait4halt [skip_size]]]]] | [stop] | [status]\","},{"line_number":1652,"context_line":"\t},"},{"line_number":1653,"context_line":"\tCOMMAND_REGISTRATION_DONE"},{"line_number":1654,"context_line":"};"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"34cc5074_0e17ab0c","line":1651,"updated":"2023-05-14 10:50:03.000000000","message":"same here","commit_id":"01426cb0b433b30e95d0ecc17186286dee44c97d"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"2b7752c94f4f43cab85c730190f1554727247b65","unresolved":false,"context_lines":[{"line_number":1648,"context_line":"\t\t.help \u003d"},{"line_number":1649,"context_line":"\t\t\t\"App Tracing: Espressif multi-core SystemView trace control. Starts, stops or queries tracing process status.\","},{"line_number":1650,"context_line":"\t\t.usage \u003d"},{"line_number":1651,"context_line":"\t\t\t\"[start file://\u003coutfile\u003e [poll_period [trace_size [stop_tmo [wait4halt [skip_size]]]]] | [stop] | [status]\","},{"line_number":1652,"context_line":"\t},"},{"line_number":1653,"context_line":"\tCOMMAND_REGISTRATION_DONE"},{"line_number":1654,"context_line":"};"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"4a018417_10a3b95f","line":1651,"in_reply_to":"34cc5074_0e17ab0c","updated":"2023-05-14 13:11:20.000000000","message":"Done","commit_id":"01426cb0b433b30e95d0ecc17186286dee44c97d"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"6e44c7548ba0f2107d3463e94838ece48651d058","unresolved":true,"context_lines":[{"line_number":1267,"context_line":"\t\tfired_target_num \u003d 0;"},{"line_number":1268,"context_line":"\t}"},{"line_number":1269,"context_line":"\t/* start tracing */"},{"line_number":1270,"context_line":"\tres \u003d esp_apptrace_usr_block_write(ctx-\u003ehw, ctx-\u003ecpus[fired_target_num], target_state[fired_target_num].block_id,"},{"line_number":1271,"context_line":"\t\tcmds, sizeof(cmds));"},{"line_number":1272,"context_line":"\tif (res !\u003d ERROR_OK) {"},{"line_number":1273,"context_line":"\t\tLOG_ERROR(\"sysview: Failed to start tracing!\");"}],"source_content_type":"text/x-csrc","patch_set":6,"id":"b014ad21_2289fba9","line":1270,"updated":"2023-05-27 08:42:54.000000000","message":"Erhan, clang reports a problem here\nhttps://build.openocd.org/job/openocd-clang/1159/clang/new/source.c2725009-0433-4710-bf16-0e510ec2d8c9/#1270\n3rd function call argument is an uninitialized value\nWould you mind having a check?","commit_id":"a0fecd6c41a6f2c965352efb0df70a149b7b260c"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"4ef72af8ce2a0bf0aa78745998c229efa36e6456","unresolved":false,"context_lines":[{"line_number":1267,"context_line":"\t\tfired_target_num \u003d 0;"},{"line_number":1268,"context_line":"\t}"},{"line_number":1269,"context_line":"\t/* start tracing */"},{"line_number":1270,"context_line":"\tres \u003d esp_apptrace_usr_block_write(ctx-\u003ehw, ctx-\u003ecpus[fired_target_num], target_state[fired_target_num].block_id,"},{"line_number":1271,"context_line":"\t\tcmds, sizeof(cmds));"},{"line_number":1272,"context_line":"\tif (res !\u003d ERROR_OK) {"},{"line_number":1273,"context_line":"\t\tLOG_ERROR(\"sysview: Failed to start tracing!\");"}],"source_content_type":"text/x-csrc","patch_set":6,"id":"bd2a4350_7851247f","line":1270,"in_reply_to":"29279969_8bc9c4a4","updated":"2023-05-28 12:08:35.000000000","message":"Created https://review.openocd.org/c/openocd/+/7719","commit_id":"a0fecd6c41a6f2c965352efb0df70a149b7b260c"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"6fecfa0ee91e8f7531a4cafc2ebf127dcbff17b6","unresolved":false,"context_lines":[{"line_number":1267,"context_line":"\t\tfired_target_num \u003d 0;"},{"line_number":1268,"context_line":"\t}"},{"line_number":1269,"context_line":"\t/* start tracing */"},{"line_number":1270,"context_line":"\tres \u003d esp_apptrace_usr_block_write(ctx-\u003ehw, ctx-\u003ecpus[fired_target_num], target_state[fired_target_num].block_id,"},{"line_number":1271,"context_line":"\t\tcmds, sizeof(cmds));"},{"line_number":1272,"context_line":"\tif (res !\u003d ERROR_OK) {"},{"line_number":1273,"context_line":"\t\tLOG_ERROR(\"sysview: Failed to start tracing!\");"}],"source_content_type":"text/x-csrc","patch_set":6,"id":"29279969_8bc9c4a4","line":1270,"in_reply_to":"b014ad21_2289fba9","updated":"2023-05-27 08:45:59.000000000","message":"Antonio, sure. I will check later today.","commit_id":"a0fecd6c41a6f2c965352efb0df70a149b7b260c"}],"src/target/espressif/esp32_sysview.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b3d71029d1f80e19443116d0f1e3441b501f7495","unresolved":true,"context_lines":[{"line_number":18,"context_line":"#define ESP32_SYSVIEW_USER_BLOCK_LEN(_v_)   (_v_)"},{"line_number":19,"context_line":"#define ESP32_SYSVIEW_USER_BLOCK_HDR_SZ     2"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"/* grabbed from SystemView target sources */"},{"line_number":22,"context_line":"#define   SYSVIEW_EVTID_NOP                 0\t/* Dummy packet. */"},{"line_number":23,"context_line":"#define   SYSVIEW_EVTID_OVERFLOW            1"},{"line_number":24,"context_line":"#define   SYSVIEW_EVTID_ISR_ENTER           2"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"242b77b2_716b0271","line":21,"updated":"2023-05-14 10:50:03.000000000","message":"what about the license of the original file you took these info from?\nIs it a file from Segger? Does it is available online, somewhere?\nGoogle found this\nhttps://github.com/espressif/esp-idf/blob/master/components/app_trace/sys_view/SEGGER/SEGGER_SYSVIEW.h\nIt means we need to report, here, that these macros are:\nCopyright: 1995-2021 SEGGER Microcontroller GmbH\nLicense: BSD-1-Clause\nMaybe it\u0027s safer to move these defines in a dedicated file.h with its own license and copyright","commit_id":"01426cb0b433b30e95d0ecc17186286dee44c97d"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"2b7752c94f4f43cab85c730190f1554727247b65","unresolved":true,"context_lines":[{"line_number":18,"context_line":"#define ESP32_SYSVIEW_USER_BLOCK_LEN(_v_)   (_v_)"},{"line_number":19,"context_line":"#define ESP32_SYSVIEW_USER_BLOCK_HDR_SZ     2"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"/* grabbed from SystemView target sources */"},{"line_number":22,"context_line":"#define   SYSVIEW_EVTID_NOP                 0\t/* Dummy packet. */"},{"line_number":23,"context_line":"#define   SYSVIEW_EVTID_OVERFLOW            1"},{"line_number":24,"context_line":"#define   SYSVIEW_EVTID_ISR_ENTER           2"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"c34190a8_1120f8e3","line":21,"in_reply_to":"242b77b2_716b0271","updated":"2023-05-14 13:11:20.000000000","message":"There is no license information in the original file.\nhttps://www.segger.com/downloads/systemview/systemview_target_src\n\nI moved these defines into the segger_sysview.h \nNot sure about the license information now.","commit_id":"01426cb0b433b30e95d0ecc17186286dee44c97d"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"da050e931283acb72199ce8a174d65f119cc3111","unresolved":false,"context_lines":[{"line_number":18,"context_line":"#define ESP32_SYSVIEW_USER_BLOCK_LEN(_v_)   (_v_)"},{"line_number":19,"context_line":"#define ESP32_SYSVIEW_USER_BLOCK_HDR_SZ     2"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"/* grabbed from SystemView target sources */"},{"line_number":22,"context_line":"#define   SYSVIEW_EVTID_NOP                 0\t/* Dummy packet. */"},{"line_number":23,"context_line":"#define   SYSVIEW_EVTID_OVERFLOW            1"},{"line_number":24,"context_line":"#define   SYSVIEW_EVTID_ISR_ENTER           2"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"4422500a_e4d5277a","line":21,"in_reply_to":"c34190a8_1120f8e3","updated":"2023-05-15 18:34:36.000000000","message":"Done","commit_id":"01426cb0b433b30e95d0ecc17186286dee44c97d"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b3d71029d1f80e19443116d0f1e3441b501f7495","unresolved":true,"context_lines":[{"line_number":90,"context_line":"\t}"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"\tcmd_data \u003d calloc(1, sizeof(*cmd_data));"},{"line_number":93,"context_line":"\tassert(cmd_data \u0026\u0026 \"No memory for command data!\");"},{"line_number":94,"context_line":"\tcmd_ctx-\u003ecmd_priv \u003d cmd_data;"},{"line_number":95,"context_line":"\tcmd_data-\u003emcore_format \u003d mcore_format;"},{"line_number":96,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":2,"id":"3bda4c96_ad341087","line":93,"updated":"2023-05-14 10:50:03.000000000","message":"no assert but return ERROR_FAIL","commit_id":"01426cb0b433b30e95d0ecc17186286dee44c97d"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"2b7752c94f4f43cab85c730190f1554727247b65","unresolved":false,"context_lines":[{"line_number":90,"context_line":"\t}"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"\tcmd_data \u003d calloc(1, sizeof(*cmd_data));"},{"line_number":93,"context_line":"\tassert(cmd_data \u0026\u0026 \"No memory for command data!\");"},{"line_number":94,"context_line":"\tcmd_ctx-\u003ecmd_priv \u003d cmd_data;"},{"line_number":95,"context_line":"\tcmd_data-\u003emcore_format \u003d mcore_format;"},{"line_number":96,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":2,"id":"dbfa409d_4ab0b1ff","line":93,"in_reply_to":"3bda4c96_ad341087","updated":"2023-05-14 13:11:20.000000000","message":"Done","commit_id":"01426cb0b433b30e95d0ecc17186286dee44c97d"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b3d71029d1f80e19443116d0f1e3441b501f7495","unresolved":true,"context_lines":[{"line_number":170,"context_line":""},{"line_number":171,"context_line":"\tif (!mcore_format) {"},{"line_number":172,"context_line":"\t\thdr_str \u003d \";\\n\""},{"line_number":173,"context_line":"\t\t\t\"; Version     SEGGER SystemViewer V2.42\\n\""},{"line_number":174,"context_line":"\t\t\t\"; Author      Espressif Inc\\n\""},{"line_number":175,"context_line":"\t\t\t\";\\n\";"},{"line_number":176,"context_line":"\t\tdests_num \u003d ctx-\u003ecores_num;"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"ec5b524d_f9af155c","line":173,"updated":"2023-05-14 10:50:03.000000000","message":"maybe this string \"SEGGER SystemViewer V2.42\" could be defined in the external file.h\nIs it mandatory? What would happen if it is replaced by something else?","commit_id":"01426cb0b433b30e95d0ecc17186286dee44c97d"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"da050e931283acb72199ce8a174d65f119cc3111","unresolved":false,"context_lines":[{"line_number":170,"context_line":""},{"line_number":171,"context_line":"\tif (!mcore_format) {"},{"line_number":172,"context_line":"\t\thdr_str \u003d \";\\n\""},{"line_number":173,"context_line":"\t\t\t\"; Version     SEGGER SystemViewer V2.42\\n\""},{"line_number":174,"context_line":"\t\t\t\"; Author      Espressif Inc\\n\""},{"line_number":175,"context_line":"\t\t\t\";\\n\";"},{"line_number":176,"context_line":"\t\tdests_num \u003d ctx-\u003ecores_num;"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"60c481e8_3e6744b5","line":173,"in_reply_to":"d9e9f422_5ce289f1","updated":"2023-05-15 18:34:36.000000000","message":"Looks like not mandatory but we would like to keep the version info in the data file. So, I defined it in the segger_sysview.h","commit_id":"01426cb0b433b30e95d0ecc17186286dee44c97d"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"2b7752c94f4f43cab85c730190f1554727247b65","unresolved":true,"context_lines":[{"line_number":170,"context_line":""},{"line_number":171,"context_line":"\tif (!mcore_format) {"},{"line_number":172,"context_line":"\t\thdr_str \u003d \";\\n\""},{"line_number":173,"context_line":"\t\t\t\"; Version     SEGGER SystemViewer V2.42\\n\""},{"line_number":174,"context_line":"\t\t\t\"; Author      Espressif Inc\\n\""},{"line_number":175,"context_line":"\t\t\t\";\\n\";"},{"line_number":176,"context_line":"\t\tdests_num \u003d ctx-\u003ecores_num;"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"d9e9f422_5ce289f1","line":173,"in_reply_to":"ec5b524d_f9af155c","updated":"2023-05-14 13:11:20.000000000","message":"I will check this.","commit_id":"01426cb0b433b30e95d0ecc17186286dee44c97d"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b3d71029d1f80e19443116d0f1e3441b501f7495","unresolved":true,"context_lines":[{"line_number":189,"context_line":"\t\t\t(uint8_t *)hdr_str,"},{"line_number":190,"context_line":"\t\t\thdr_len);"},{"line_number":191,"context_line":"\t\tif (res !\u003d ERROR_OK) {"},{"line_number":192,"context_line":"\t\t\tLOG_ERROR(\"SEGGER: Failed to write %u bytes to dest %d!\", hdr_len, i);"},{"line_number":193,"context_line":"\t\t\treturn ERROR_FAIL;"},{"line_number":194,"context_line":"\t\t}"},{"line_number":195,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"acf0525c_c3a10a04","line":192,"updated":"2023-05-14 10:50:03.000000000","message":"s/SEGGER/sysview/ ?","commit_id":"01426cb0b433b30e95d0ecc17186286dee44c97d"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"2b7752c94f4f43cab85c730190f1554727247b65","unresolved":false,"context_lines":[{"line_number":189,"context_line":"\t\t\t(uint8_t *)hdr_str,"},{"line_number":190,"context_line":"\t\t\thdr_len);"},{"line_number":191,"context_line":"\t\tif (res !\u003d ERROR_OK) {"},{"line_number":192,"context_line":"\t\t\tLOG_ERROR(\"SEGGER: Failed to write %u bytes to dest %d!\", hdr_len, i);"},{"line_number":193,"context_line":"\t\t\treturn ERROR_FAIL;"},{"line_number":194,"context_line":"\t\t}"},{"line_number":195,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"17774ac5_1fb98f21","line":192,"in_reply_to":"acf0525c_c3a10a04","updated":"2023-05-14 13:11:20.000000000","message":"Done","commit_id":"01426cb0b433b30e95d0ecc17186286dee44c97d"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b3d71029d1f80e19443116d0f1e3441b501f7495","unresolved":true,"context_lines":[{"line_number":298,"context_line":""},{"line_number":299,"context_line":"\t/*case SYSVIEW_EVTID_NOP: */"},{"line_number":300,"context_line":"\tdefault:"},{"line_number":301,"context_line":"\t\tLOG_ERROR(\"SEGGER: Unsupported predef event %d!\", id);"},{"line_number":302,"context_line":"\t\tlen \u003d 0;"},{"line_number":303,"context_line":"\t}"},{"line_number":304,"context_line":"\treturn len;"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"60fb7f32_f5ea58a3","line":301,"updated":"2023-05-14 10:50:03.000000000","message":"ditto","commit_id":"01426cb0b433b30e95d0ecc17186286dee44c97d"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"2b7752c94f4f43cab85c730190f1554727247b65","unresolved":false,"context_lines":[{"line_number":298,"context_line":""},{"line_number":299,"context_line":"\t/*case SYSVIEW_EVTID_NOP: */"},{"line_number":300,"context_line":"\tdefault:"},{"line_number":301,"context_line":"\t\tLOG_ERROR(\"SEGGER: Unsupported predef event %d!\", id);"},{"line_number":302,"context_line":"\t\tlen \u003d 0;"},{"line_number":303,"context_line":"\t}"},{"line_number":304,"context_line":"\treturn len;"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"474200d4_779a6596","line":301,"in_reply_to":"60fb7f32_f5ea58a3","updated":"2023-05-14 13:11:20.000000000","message":"Done","commit_id":"01426cb0b433b30e95d0ecc17186286dee44c97d"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b3d71029d1f80e19443116d0f1e3441b501f7495","unresolved":true,"context_lines":[{"line_number":347,"context_line":"\t*delta \u003d esp_sysview_decode_u32(\u0026pkt);"},{"line_number":348,"context_line":"\t*delta_len \u003d pkt - delta_start;"},{"line_number":349,"context_line":"\t*pkt_len \u003d pkt - pkt_buf;"},{"line_number":350,"context_line":"\tLOG_DEBUG(\"SEGGER: evt %d len %d plen %d dlen %d\","},{"line_number":351,"context_line":"\t\tevent_id,"},{"line_number":352,"context_line":"\t\t*pkt_len,"},{"line_number":353,"context_line":"\t\tpayload_len,"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"7804b8ea_f6b4b603","line":350,"updated":"2023-05-14 10:50:03.000000000","message":"ditto... continues below","commit_id":"01426cb0b433b30e95d0ecc17186286dee44c97d"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"2b7752c94f4f43cab85c730190f1554727247b65","unresolved":false,"context_lines":[{"line_number":347,"context_line":"\t*delta \u003d esp_sysview_decode_u32(\u0026pkt);"},{"line_number":348,"context_line":"\t*delta_len \u003d pkt - delta_start;"},{"line_number":349,"context_line":"\t*pkt_len \u003d pkt - pkt_buf;"},{"line_number":350,"context_line":"\tLOG_DEBUG(\"SEGGER: evt %d len %d plen %d dlen %d\","},{"line_number":351,"context_line":"\t\tevent_id,"},{"line_number":352,"context_line":"\t\t*pkt_len,"},{"line_number":353,"context_line":"\t\tpayload_len,"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"ff33d475_533c1350","line":350,"in_reply_to":"7804b8ea_f6b4b603","updated":"2023-05-14 13:11:20.000000000","message":"Done","commit_id":"01426cb0b433b30e95d0ecc17186286dee44c97d"}],"src/target/espressif/esp32_sysview.h":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"31ddeb3781e296730e5c012d3a545022ed43c6de","unresolved":true,"context_lines":[{"line_number":12,"context_line":"#include \"esp32_apptrace.h\""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"enum {"},{"line_number":15,"context_line":"\tSEGGER_SYSVIEW_COMMAND_ID_START \u003d 1,"},{"line_number":16,"context_line":"\tSEGGER_SYSVIEW_COMMAND_ID_STOP,"},{"line_number":17,"context_line":"\tSEGGER_SYSVIEW_COMMAND_ID_GET_SYSTIME,"},{"line_number":18,"context_line":"\tSEGGER_SYSVIEW_COMMAND_ID_GET_TASKLIST,"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"d5fe83ec_f25fd509","line":15,"updated":"2023-05-16 21:38:17.000000000","message":"also this enum comes from segger and is under BSD-1-Clause\nIt is in file SEGGER/SEGGER_SYSVIEW_Int.h\nTo avoid so many files, just mode this in the same file\nsrc/target/espressif/segger_sysview.h\nand update the comment there to report that the extraction is from two files","commit_id":"c8dd17a6427373f12f7bf836cdedbe1effa19559"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"c60a8592ce661cbed94c0d13f9781768573b72c6","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#include \"esp32_apptrace.h\""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"enum {"},{"line_number":15,"context_line":"\tSEGGER_SYSVIEW_COMMAND_ID_START \u003d 1,"},{"line_number":16,"context_line":"\tSEGGER_SYSVIEW_COMMAND_ID_STOP,"},{"line_number":17,"context_line":"\tSEGGER_SYSVIEW_COMMAND_ID_GET_SYSTIME,"},{"line_number":18,"context_line":"\tSEGGER_SYSVIEW_COMMAND_ID_GET_TASKLIST,"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"b6a765b5_6ea96076","line":15,"in_reply_to":"d5fe83ec_f25fd509","updated":"2023-05-17 17:48:00.000000000","message":"Done","commit_id":"c8dd17a6427373f12f7bf836cdedbe1effa19559"}],"src/target/espressif/segger_sysview.h":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"87c86ea5f6f76865b9609a057f9b55fbb1d635d3","unresolved":true,"context_lines":[{"line_number":1,"context_line":"/* SPDX-License-Identifier: BSD-1-Clause"},{"line_number":2,"context_line":" *"},{"line_number":3,"context_line":" * SPDX-FileCopyrightText: 1995-2021 SEGGER Microcontroller GmbH"},{"line_number":4,"context_line":" *"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"e9eb4aba_c23c9f58","line":1,"updated":"2023-05-14 20:55:20.000000000","message":"license is correct. You can compare it with\nhttps://spdx.org/licenses/BSD-1-Clause.html\nor in OpenOCD\nhttps://review.openocd.org/gitweb?p\u003dopenocd.git;a\u003dblob;f\u003dLICENSES/preferred/BSD-1-Clause\n\nBut the SPDX-FileCopyrightText doesn\u0027t fully match the specs\n\nNevertheless, I would like to do some cleanup in this file\nI propose to collapse all the header as:\n\n /\\* SPDX-License-Identifier: BSD-1-Clause \\*/\n /\\* SPDX-FileCopyrightText: (c) 1995-2021 SEGGER Microcontroller GmbH. All rights reserved. \\*/\n /\\* SPDX-FileContributor: 2023 Espressif Systems (Shanghai) CO LTD \\*/\n \n /\\*\n  \\* The contend below is extracted from file SEGGER_SYSVIEW.h in:\n  \\* https://www.segger.com/downloads/systemview/systemview_target_src\n  \\* SystemView version: 3.42\n  \\*/\n \n #ifndef OPENOCD_TARGET_SEGGER_SYSVIEW_H\n ...","commit_id":"10fd14f01dae2f355bd079a52377797dc8feaa14"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"da050e931283acb72199ce8a174d65f119cc3111","unresolved":false,"context_lines":[{"line_number":1,"context_line":"/* SPDX-License-Identifier: BSD-1-Clause"},{"line_number":2,"context_line":" *"},{"line_number":3,"context_line":" * SPDX-FileCopyrightText: 1995-2021 SEGGER Microcontroller GmbH"},{"line_number":4,"context_line":" *"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"c465db00_bd1ecb2f","line":1,"in_reply_to":"e9eb4aba_c23c9f58","updated":"2023-05-15 18:34:36.000000000","message":"Done","commit_id":"10fd14f01dae2f355bd079a52377797dc8feaa14"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"31ddeb3781e296730e5c012d3a545022ed43c6de","unresolved":true,"context_lines":[{"line_number":3,"context_line":"/* SPDX-FileContributor: 2023 Espressif Systems (Shanghai) CO LTD */"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"/*"},{"line_number":6,"context_line":"* The contend below is extracted from file SEGGER_SYSVIEW.h in:"},{"line_number":7,"context_line":"* https://www.segger.com/downloads/systemview/systemview_target_src"},{"line_number":8,"context_line":"* SystemView version: 3.42"},{"line_number":9,"context_line":"*/"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"50cba2c4_0c4d0020","line":6,"updated":"2023-05-16 21:38:17.000000000","message":"here should become:\n... from files SEGGER_SYSVIEW.h and SEGGER_SYSVIEW_Int.h in:","commit_id":"c8dd17a6427373f12f7bf836cdedbe1effa19559"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"c60a8592ce661cbed94c0d13f9781768573b72c6","unresolved":false,"context_lines":[{"line_number":3,"context_line":"/* SPDX-FileContributor: 2023 Espressif Systems (Shanghai) CO LTD */"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"/*"},{"line_number":6,"context_line":"* The contend below is extracted from file SEGGER_SYSVIEW.h in:"},{"line_number":7,"context_line":"* https://www.segger.com/downloads/systemview/systemview_target_src"},{"line_number":8,"context_line":"* SystemView version: 3.42"},{"line_number":9,"context_line":"*/"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"7f45c523_de535ce2","line":6,"in_reply_to":"50cba2c4_0c4d0020","updated":"2023-05-17 17:48:00.000000000","message":"Done","commit_id":"c8dd17a6427373f12f7bf836cdedbe1effa19559"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"31ddeb3781e296730e5c012d3a545022ed43c6de","unresolved":true,"context_lines":[{"line_number":11,"context_line":"#ifndef OPENOCD_TARGET_SEGGER_SYSVIEW_H"},{"line_number":12,"context_line":"#define OPENOCD_TARGET_SEGGER_SYSVIEW_H"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"#define   SYSVIEW_EVTID_NOP                 0\t/* Dummy packet. */"},{"line_number":15,"context_line":"#define   SYSVIEW_EVTID_OVERFLOW            1"},{"line_number":16,"context_line":"#define   SYSVIEW_EVTID_ISR_ENTER           2"},{"line_number":17,"context_line":"#define   SYSVIEW_EVTID_ISR_EXIT            3"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"a7af2712_17892a99","line":14,"updated":"2023-05-16 21:38:17.000000000","message":"can you use a single space after #define?","commit_id":"c8dd17a6427373f12f7bf836cdedbe1effa19559"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"c60a8592ce661cbed94c0d13f9781768573b72c6","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#ifndef OPENOCD_TARGET_SEGGER_SYSVIEW_H"},{"line_number":12,"context_line":"#define OPENOCD_TARGET_SEGGER_SYSVIEW_H"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"#define   SYSVIEW_EVTID_NOP                 0\t/* Dummy packet. */"},{"line_number":15,"context_line":"#define   SYSVIEW_EVTID_OVERFLOW            1"},{"line_number":16,"context_line":"#define   SYSVIEW_EVTID_ISR_ENTER           2"},{"line_number":17,"context_line":"#define   SYSVIEW_EVTID_ISR_EXIT            3"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"9073353d_277d04dc","line":14,"in_reply_to":"a7af2712_17892a99","updated":"2023-05-17 17:48:00.000000000","message":"Done","commit_id":"c8dd17a6427373f12f7bf836cdedbe1effa19559"}]}